DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] net/vmxnet3: disable RSS for single queue configuration for ESX8.0+ versions
@ 2025-10-22 12:58 Amiya Ranjan Mohakud
  2025-10-22 13:32 ` Amiya Ranjan Mohakud
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Amiya Ranjan Mohakud @ 2025-10-22 12:58 UTC (permalink / raw)
  To: dev; +Cc: amiyaranjan.mohakud, stable

This fixes the issue of v4 RSS configuration failure in vmxnet3_v4_rss_configure
while writing to BAR register. It's very specific to single queue conifuguration.

Ref: https://mails.dpdk.org/archives/users/2025-April/008236.html

Bugzilla ID:1789
Cc: stable@dpdk.org

Signed-off-by: Amiya Ranjan Mohakud <amiyaranjan.mohakud@gmail.com>
---
 drivers/net/vmxnet3/vmxnet3_ethdev.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index f4cdb1bb31..fee4c23091 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
@@ -534,6 +534,12 @@ vmxnet3_dev_configure(struct rte_eth_dev *dev)
 
 	PMD_INIT_FUNC_TRACE();
 
+    /* Disabling RSS for single queue pair */
+    if (dev->data->nb_rx_queues == 1) {
+        dev->data->dev_conf.rxmode.mq_mode = ETH_MQ_RX_NONE;
+        PMD_INIT_LOG(ERR, "WARN: Disabling RSS for single Rx queue");
+    }
+
 	if (dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_RSS_FLAG)
 		dev->data->dev_conf.rxmode.offloads |= RTE_ETH_RX_OFFLOAD_RSS_HASH;
 
-- 
2.39.5 (Apple Git-154)


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] net/vmxnet3: disable RSS for single queue configuration for ESX8.0+ versions
  2025-10-22 12:58 [PATCH] net/vmxnet3: disable RSS for single queue configuration for ESX8.0+ versions Amiya Ranjan Mohakud
@ 2025-10-22 13:32 ` Amiya Ranjan Mohakud
  2025-10-22 13:35 ` Amiya Ranjan Mohakud
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Amiya Ranjan Mohakud @ 2025-10-22 13:32 UTC (permalink / raw)
  To: dev; +Cc: amiyaranjan.mohakud, stable

It fixes the issue of v4 RSS configuration failure in
vmxnet3_v4_rss_configure() whilw writing to BAR register. It's very
specific to single queue configuration.

https://mails.dpdk.org/archives/users/2025-April/008236.html

Bugzilla ID:1789
Cc: stable@dpdk.org

Signed-off-by: Amiya Ranjan Mohakud <amiyaranjan.mohakud@gmail.com>
---
 drivers/net/vmxnet3/vmxnet3_ethdev.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index f4cdb1bb31..3c0ddba80c 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
@@ -534,6 +534,12 @@ vmxnet3_dev_configure(struct rte_eth_dev *dev)
 
 	PMD_INIT_FUNC_TRACE();
 
+	/* Disabling RSS for single queue pair */
+	if (dev->data->nb_rx_queues == 1) {
+		dev->data->dev_conf.rxmode.mq_mode = RTE_ETH_MQ_RX_NONE;
+		PMD_INIT_LOG(ERR, "WARN: Disabling RSS for single Rx queue");
+	}
+
 	if (dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_RSS_FLAG)
 		dev->data->dev_conf.rxmode.offloads |= RTE_ETH_RX_OFFLOAD_RSS_HASH;
 
-- 
2.39.5 (Apple Git-154)


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] net/vmxnet3: disable RSS for single queue configuration for ESX8.0+ versions
  2025-10-22 12:58 [PATCH] net/vmxnet3: disable RSS for single queue configuration for ESX8.0+ versions Amiya Ranjan Mohakud
  2025-10-22 13:32 ` Amiya Ranjan Mohakud
@ 2025-10-22 13:35 ` Amiya Ranjan Mohakud
  2025-10-22 15:56   ` [PATCH v2] " Amiya Ranjan Mohakud
  2025-10-22 16:28 ` [PATCH] " Stephen Hemminger
  2025-10-22 16:32 ` Ronak Doshi
  3 siblings, 1 reply; 6+ messages in thread
From: Amiya Ranjan Mohakud @ 2025-10-22 13:35 UTC (permalink / raw)
  To: dev; +Cc: amiyaranjan.mohakud, stable

It fixes the issue of v4 RSS configuration failure in
vmxnet3_v4_rss_configure() whilw writing to BAR register. It's very
specific to single queue configuration.

https://mails.dpdk.org/archives/users/2025-April/008236.html

Bugzilla ID:1789
Cc: stable@dpdk.org

Signed-off-by: Amiya Ranjan Mohakud <amiyaranjan.mohakud@gmail.com>
---
 drivers/net/vmxnet3/vmxnet3_ethdev.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index f4cdb1bb31..3c0ddba80c 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
@@ -534,6 +534,12 @@ vmxnet3_dev_configure(struct rte_eth_dev *dev)
 
 	PMD_INIT_FUNC_TRACE();
 
+	/* Disabling RSS for single queue pair */
+	if (dev->data->nb_rx_queues == 1) {
+		dev->data->dev_conf.rxmode.mq_mode = RTE_ETH_MQ_RX_NONE;
+		PMD_INIT_LOG(ERR, "WARN: Disabling RSS for single Rx queue");
+	}
+
 	if (dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_RSS_FLAG)
 		dev->data->dev_conf.rxmode.offloads |= RTE_ETH_RX_OFFLOAD_RSS_HASH;
 
-- 
2.39.5 (Apple Git-154)


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH v2] net/vmxnet3: disable RSS for single queue configuration for ESX8.0+ versions
  2025-10-22 13:35 ` Amiya Ranjan Mohakud
@ 2025-10-22 15:56   ` Amiya Ranjan Mohakud
  0 siblings, 0 replies; 6+ messages in thread
From: Amiya Ranjan Mohakud @ 2025-10-22 15:56 UTC (permalink / raw)
  To: dev; +Cc: amiyaranjan.mohakud, stable

It fixes the issue of v4 RSS configuration failure in
vmxnet3_v4_rss_configure() while writing to BAR register. It's very
specific to single queue configuration.

https://mails.dpdk.org/archives/users/2025-April/008236.html

Bugzilla ID:1789
Cc: stable@dpdk.org

v2:
 - Fixed typo in commit message

Signed-off-by: Amiya Ranjan Mohakud <amiyaranjan.mohakud@gmail.com>
---
 drivers/net/vmxnet3/vmxnet3_ethdev.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index f4cdb1bb31..3c0ddba80c 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
@@ -534,6 +534,12 @@ vmxnet3_dev_configure(struct rte_eth_dev *dev)

 	PMD_INIT_FUNC_TRACE();

+	/* Disabling RSS for single queue pair */
+	if (dev->data->nb_rx_queues == 1) {
+		dev->data->dev_conf.rxmode.mq_mode = RTE_ETH_MQ_RX_NONE;
+		PMD_INIT_LOG(ERR, "WARN: Disabling RSS for single Rx queue");
+	}
+
 	if (dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_RSS_FLAG)
 		dev->data->dev_conf.rxmode.offloads |= RTE_ETH_RX_OFFLOAD_RSS_HASH;

--
2.39.5 (Apple Git-154)


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] net/vmxnet3: disable RSS for single queue configuration for ESX8.0+ versions
  2025-10-22 12:58 [PATCH] net/vmxnet3: disable RSS for single queue configuration for ESX8.0+ versions Amiya Ranjan Mohakud
  2025-10-22 13:32 ` Amiya Ranjan Mohakud
  2025-10-22 13:35 ` Amiya Ranjan Mohakud
@ 2025-10-22 16:28 ` Stephen Hemminger
  2025-10-22 16:32 ` Ronak Doshi
  3 siblings, 0 replies; 6+ messages in thread
From: Stephen Hemminger @ 2025-10-22 16:28 UTC (permalink / raw)
  To: Amiya Ranjan Mohakud; +Cc: dev, stable

On Wed, 22 Oct 2025 18:28:44 +0530
Amiya Ranjan Mohakud <amiyaranjan.mohakud@gmail.com> wrote:

> This fixes the issue of v4 RSS configuration failure in vmxnet3_v4_rss_configure
> while writing to BAR register. It's very specific to single queue conifuguration.
> 
> Ref: https://mails.dpdk.org/archives/users/2025-April/008236.html
> 
> Bugzilla ID:1789
> Cc: stable@dpdk.org
> 
> Signed-off-by: Amiya Ranjan Mohakud <amiyaranjan.mohakud@gmail.com>
> ---

Queued to next-net with slightly modified commit message.
Could you identify a commit this fixes so that the LTS backport can know
which versions are impacted.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] net/vmxnet3: disable RSS for single queue configuration for ESX8.0+ versions
  2025-10-22 12:58 [PATCH] net/vmxnet3: disable RSS for single queue configuration for ESX8.0+ versions Amiya Ranjan Mohakud
                   ` (2 preceding siblings ...)
  2025-10-22 16:28 ` [PATCH] " Stephen Hemminger
@ 2025-10-22 16:32 ` Ronak Doshi
  3 siblings, 0 replies; 6+ messages in thread
From: Ronak Doshi @ 2025-10-22 16:32 UTC (permalink / raw)
  To: Amiya Ranjan Mohakud; +Cc: dev, stable

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

On Wed, Oct 22, 2025 at 5:59 AM Amiya Ranjan Mohakud
<amiyaranjan.mohakud@gmail.com> wrote:
>
> +    /* Disabling RSS for single queue pair */
> +    if (dev->data->nb_rx_queues == 1) {
> +        dev->data->dev_conf.rxmode.mq_mode = ETH_MQ_RX_NONE;
> +        PMD_INIT_LOG(ERR, "WARN: Disabling RSS for single Rx queue");
> +    }
> +

Can you check if mq_mode had RSS enabled? Otherwise, this will always
LOG as WARN for application using single rx queue.

Thanks,
Ronak

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5465 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-10-22 16:33 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-22 12:58 [PATCH] net/vmxnet3: disable RSS for single queue configuration for ESX8.0+ versions Amiya Ranjan Mohakud
2025-10-22 13:32 ` Amiya Ranjan Mohakud
2025-10-22 13:35 ` Amiya Ranjan Mohakud
2025-10-22 15:56   ` [PATCH v2] " Amiya Ranjan Mohakud
2025-10-22 16:28 ` [PATCH] " Stephen Hemminger
2025-10-22 16:32 ` Ronak Doshi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).