From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb0-f179.google.com (mail-yb0-f179.google.com [209.85.213.179]) by dpdk.org (Postfix) with ESMTP id 1E19C2B9E for ; Tue, 2 May 2017 09:59:32 +0200 (CEST) Received: by mail-yb0-f179.google.com with SMTP id p143so32866189yba.2 for ; Tue, 02 May 2017 00:59:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=UJXpqxx+222EnAqojzgN+zCFclQtyaYdDF0ufgyfmEw=; b=Os4nJADZRl6ZHqMTRitY/R2kIn2LrFsY5UBp6BAvJDr+4e8kAD7fRZZpvhJbtmCYla N9E57X4vxx/PQQcFDJSw0o8ZdO17pejIrfSMENjqzgfvqvBZ4KDYCWfzlvHCKE0yw380 pd2XCyo2Xw9pcSK0z3rRToATrsZZDrk9IJRQM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=UJXpqxx+222EnAqojzgN+zCFclQtyaYdDF0ufgyfmEw=; b=moprwBXO1O1+wf4A9rKw7m1Z+fq4CFWY9nFzg77CmvDAQhFWjw34GRFDURG6Hxmh1+ oQe4iRzaqCWumx0aCkj1G5/4888ApjDLeV2qz02MwEcPvMOjznn2XtMz9jZwEPa1iFEA c1YJr/QWJQZok1nwgHUErogbRcDpFQ501orzqJaN4B50dWpQOo1LxeGly1FytswzLlPH dDVuvfVJsTNqHRNB44m4mmn58RkYJ3+L0/YpxP5GWwYw6UTNaW0Y+fDmwzFdi1zzKMCm l7L/XnkBHx59F7G4r8R9bQAlYcCohdpXEsiSTnVl4NtTxbIetePo/zZPWop6mcsgq8AS noUw== X-Gm-Message-State: AN3rC/5IFRODcmsu34cQVYJhri6OHx5H5hvPopoj7E9VRvmOTqS38pGn eX+rfh8sTzvzNzzynCbancWCqd3QAWtk X-Received: by 10.37.97.13 with SMTP id v13mr23827227ybb.136.1493711971538; Tue, 02 May 2017 00:59:31 -0700 (PDT) MIME-Version: 1.0 Received: by 10.37.4.16 with HTTP; Tue, 2 May 2017 00:59:30 -0700 (PDT) In-Reply-To: <20170502064059.GA28685@jerin> References: <20170427114249.31863-1-ashwin.sekhar@caviumnetworks.com> <20170502055953.29222-1-ashwin.sekhar@caviumnetworks.com> <20170502064059.GA28685@jerin> From: Jianbo Liu Date: Tue, 2 May 2017 15:59:30 +0800 Message-ID: To: Jerin Jacob Cc: Ashwin Sekhar T K , byron.marohn@intel.com, pablo.de.lara.guarch@intel.com, dev@dpdk.org Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH v3] efd: support lookup using neon intrinsics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 May 2017 07:59:32 -0000 On 2 May 2017 at 14:41, Jerin Jacob wrote: > -----Original Message----- >> Date: Mon, 1 May 2017 22:59:53 -0700 >> From: Ashwin Sekhar T K >> To: byron.marohn@intel.com, pablo.de.lara.guarch@intel.com, >> jerin.jacob@caviumnetworks.com, jianbo.liu@linaro.org >> Cc: dev@dpdk.org, Ashwin Sekhar T K >> Subject: [dpdk-dev] [PATCH v3] efd: support lookup using neon intrinsics >> X-Mailer: git-send-email 2.13.0.rc1 >> >> * Added file lib/librte_efd/rte_efd_arm64.h to hold arm64 >> specific definitions >> * Verified the changes with efd_autotest unit test case >> >> Signed-off-by: Ashwin Sekhar T K >> --- >> v2: >> * Slightly modified the content of the commit message body >> * Added prefix [dpdk-dev] to the email subject line >> >> v3: >> * Moved enum 'EFD_LOOKUP_NEON' under '#if defined(RTE_ARCH_ARM64)' >> >> MAINTAINERS | 1 + >> lib/librte_efd/rte_efd.c | 24 +++++++++++++ >> lib/librte_efd/rte_efd_arm64.h | 76 ++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 101 insertions(+) >> create mode 100644 lib/librte_efd/rte_efd_arm64.h >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index b6495d2..7d708ae 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -147,6 +147,7 @@ F: lib/librte_eal/common/include/arch/arm/*_64.h >> F: lib/librte_acl/acl_run_neon.* >> F: lib/librte_lpm/rte_lpm_neon.h >> F: lib/librte_hash/rte*_arm64.h >> +F: lib/librte_efd/rte*_arm64.h >> F: drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c >> F: drivers/net/i40e/i40e_rxtx_vec_neon.c >> F: drivers/net/virtio/virtio_rxtx_simple_neon.c >> diff --git a/lib/librte_efd/rte_efd.c b/lib/librte_efd/rte_efd.c >> index f601d62..5cc6283 100644 >> --- a/lib/librte_efd/rte_efd.c >> +++ b/lib/librte_efd/rte_efd.c >> @@ -53,6 +53,8 @@ >> #include "rte_efd.h" >> #if defined(RTE_ARCH_X86) >> #include "rte_efd_x86.h" >> +#elif defined(RTE_ARCH_ARM64) >> +#include "rte_efd_arm64.h" >> #endif >> >> #define EFD_KEY(key_idx, table) (table->keys + ((key_idx) * table->key_len)) >> @@ -103,6 +105,9 @@ allocated memory >> enum efd_lookup_internal_function { >> EFD_LOOKUP_SCALAR = 0, >> EFD_LOOKUP_AVX2, >> +#if defined(RTE_ARCH_ARM64) >> + EFD_LOOKUP_NEON, >> +#endif > > I think, we can remove this ifdef to > - Make code looks clean > - In future, in some case a new enum value gets added then the value > will be different for each build. > But the enum items are same for each ARCH. Besides, the ifdef could be considered as explanation to that enum. If someone knows nothing about arm/neon, he can ignore it totally after see the ifdef. > Any valid point to keep under RTE_ARCH_ARM64? > >> EFD_LOOKUP_NUM >> };