From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jianbo.liu@linaro.org>
Received: from mail-yw0-f170.google.com (mail-yw0-f170.google.com
 [209.85.161.170]) by dpdk.org (Postfix) with ESMTP id 5E8822BE6
 for <dev@dpdk.org>; Wed,  3 Aug 2016 11:36:38 +0200 (CEST)
Received: by mail-yw0-f170.google.com with SMTP id z8so222549290ywa.1
 for <dev@dpdk.org>; Wed, 03 Aug 2016 02:36:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=JbOjpJEytaDgczWUzWm8S/s3iuh6W6uvu0w/iyndiy0=;
 b=hg7KlQ6Nf2x2J2wWGgAob11J4IxFUFspto+UI34vi5g5VC4le0xSCAgXLofzp2ZvtT
 4mtaccsH5PCFFBxF9ati5eiO/VImlTnQL0t9N5SG/gMBmYPlDRkDqAOGxW83IF6Yxm4J
 di6jA5N5+IDQz0AtAR4ccQXF3+X/Mn2t9D+Hk=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=JbOjpJEytaDgczWUzWm8S/s3iuh6W6uvu0w/iyndiy0=;
 b=jj9ghIsXNAMljaLFubZt31YL7HusyngFrsg/SRsCNxzT44Fn/0/07thNiRI7EVZI5w
 GPV28j0FKijdF4JM2f6pir9ZXjj+PIUfpM1em6HoVVVLCE+UM2tRkkFgljgRn5SbxY08
 OE4RsyRXYrZEkQqnFwXncqbi4blZ4zAOdDCJPaoa6m4NPeZsojaofulnAsvKwigkxWhr
 7guAbu27O1tVlZwipG+2iwZU7Go/pU/XwItgUkScF/g7ORJAJIHs8X/Kjrc0D1npXyvK
 cTK9eZgfD3DSA2sRoY3vdbR9ed1MGjwqsvu8mv1j78JHflP8X0vmvI4H5HojfSM/uGUq
 y41Q==
X-Gm-Message-State: AEkoousabn9+I66CaF2YWSuOgmzQpzkXcLCkojxEyhH7SJZOZI8qcpW2ax8ynO6X0tJumwUuaXM6C25KhDOKY7kO
X-Received: by 10.129.90.68 with SMTP id o65mr28226166ywb.316.1470216997835;
 Wed, 03 Aug 2016 02:36:37 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.37.3.132 with HTTP; Wed, 3 Aug 2016 02:36:37 -0700 (PDT)
In-Reply-To: <2601191342CEEE43887BDE71AB97725836B8D25C@irsmsx105.ger.corp.intel.com>
References: <1470121107-7622-1-git-send-email-jianbo.liu@linaro.org>
 <82F45D86ADE5454A95A89742C8D1410E0330A4B6@shsmsx102.ccr.corp.intel.com>
 <2DBBFF226F7CF64BAFCA79B681719D9502046341@shsmsx102.ccr.corp.intel.com>
 <CAP4Qi39C0vNSbkOaVapiSGBbt=em7kef9XLP-W3UjDjKMWoTCg@mail.gmail.com>
 <2601191342CEEE43887BDE71AB97725836B8D25C@irsmsx105.ger.corp.intel.com>
From: Jianbo Liu <jianbo.liu@linaro.org>
Date: Wed, 3 Aug 2016 17:36:37 +0800
Message-ID: <CAP4Qi3-5V-7hmd4EFdYardsFa8WVwBk_+DgtzzoH0s2RGPMJpw@mail.gmail.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: "Yao, Lei A" <lei.a.yao@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, 
 "Zhang, Helin" <helin.zhang@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [dpdk-dev] [PATCH] i40e: enable i40e pmd on ARM platform
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Aug 2016 09:36:38 -0000

On 3 August 2016 at 16:29, Ananyev, Konstantin
<konstantin.ananyev@intel.com> wrote:
>
> Hi Jianbo,
>
>> > Hi, Jianbo
>> >
>> > I have tested you patch on my X86 platform,  the single core performance for Non-vector PMD will have about 1Mpps drop
>> > Non-vector PMD single core performance with patch               :  ~33.9 Mpps
>> > Non-vector PMD single core performance without patch        :  ~35.1 Mpps
>> > Is there any way to avoid such performance drop on X86? Thanks.
>> >
>>
>> I think we can place a compiling condition before rte_rmb() to avoid performance decrease on x86.
>> For example:  #if defined(RTE_ARCH_ARM) || defined(RTE_ARCH_ARM64)
>
> I suppose you can use rte_smp_rmb() here?

Great. Thank Konstantin.
I'll send v2.

Jianbo