From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jianbo.liu@linaro.org>
Received: from mail-yw0-f177.google.com (mail-yw0-f177.google.com
 [209.85.161.177]) by dpdk.org (Postfix) with ESMTP id 25D20C168
 for <dev@dpdk.org>; Wed, 22 Jun 2016 10:10:05 +0200 (CEST)
Received: by mail-yw0-f177.google.com with SMTP id b72so36086114ywa.3
 for <dev@dpdk.org>; Wed, 22 Jun 2016 01:10:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=cZsQa8r0YpUtd47b+OcOR7MsDqxM40+WrMTnpNGiFaQ=;
 b=jsfLfbPsxKI6ov8/FU9OeO6S0AyrJQ7M6fmZyG6Idj8xC8SKAM6wK3ArnXtdnt5lk1
 sbR3Vowrqbj95M29Q0+jhQoliMNEMc0xsRIoKXOANfUcdlt22V/eEPGC1V5W5ilKmsDo
 Ll4C9GoyAnejWNHy1WWO276P2lDcNpREwRXkw=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=cZsQa8r0YpUtd47b+OcOR7MsDqxM40+WrMTnpNGiFaQ=;
 b=LhFzi9yF6uNmK5ZyOAHiw5GC3mzehWWROFv0ivYpkmNLn//ZYrVzugrKnE+zPqvCsc
 OKutD9MkzV7zSPPE5i2rzESHkCQZ1rMODs24p71HFutEKwuSs1Fbedxo8eZxoR4yBhLD
 cI5vQh68Ye24w/1EsmBg6jGBwm5FhSjxbXGwazv+bkTIGp+vmjbpdkXGmGXGiZE7CY/4
 Eq/EEG5QumwYf5wDWVSbFmBP7uSq0kaPCSF/yaC84qnaA9tN/I13VaUdLdINTV5+D4kJ
 ORbzR04wBy5C6ekyn8jz1BlvN7xVarAKHMweixPjaa1rp8yqpQeSxroc0FjH1KrDa80e
 hgew==
X-Gm-Message-State: ALyK8tIlP0r0qiPiv+9UbqnlWnc80YM9i14/dTddzYqHmqBLC30EGnwFAzhzcwexNjv1E7/LAhzHs5rjsbfirF9/
X-Received: by 10.129.112.19 with SMTP id l19mr14018782ywc.222.1466583004600; 
 Wed, 22 Jun 2016 01:10:04 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.37.218.135 with HTTP; Wed, 22 Jun 2016 01:10:04 -0700 (PDT)
In-Reply-To: <2989572.Qmv8XzlVsK@xps13>
References: <1462869064-9423-1-git-send-email-jianbo.liu@linaro.org>
 <CAP4Qi380CmSRkb5g4WLFX3HaoeuphDxpyy2vjf6dEBz5dFJZcQ@mail.gmail.com>
 <2611917.yjRp4jXU2P@xps13> <2989572.Qmv8XzlVsK@xps13>
From: Jianbo Liu <jianbo.liu@linaro.org>
Date: Wed, 22 Jun 2016 16:10:04 +0800
Message-ID: <CAP4Qi3-E+OuP68OH7T4kX1m7Cb-Gkq491nPe9wgnOiP4QYe=3A@mail.gmail.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org, Jerin Jacob <jerin.jacob@caviumnetworks.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [dpdk-dev] [PATCH] arm64: change rte_memcpy to inline function
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Jun 2016 08:10:05 -0000

On 17 June 2016 at 18:30, Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> 2016-05-19 17:56, Thomas Monjalon:
>> 2016-05-19 21:48, Jianbo Liu:
>> > On 13 May 2016 at 23:49, Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
>> > > 2016-05-10 14:01, Jianbo Liu:
>> > >> Other APP may call rte_memcpy by function pointer,
>> > >> so change it to an inline function.
>> > >
>> > > Any example in mind?
>> > >
>> > It's for ODP-DPDK.
>>
>> Given that ODP is open (dataplane), you should also consider ppc64 and tile.
>>
>> > >> --- a/lib/librte_eal/common/include/arch/arm/rte_memcpy_64.h
>> > >> +++ b/lib/librte_eal/common/include/arch/arm/rte_memcpy_64.h
>> > >> -#define rte_memcpy(d, s, n)  memcpy((d), (s), (n))
>> > >> +static inline void *
>> > >> +rte_memcpy(void *dst, const void *src, size_t n)
>> > >> +{
>> > >> +     return memcpy(dst, src, n);
>> > >> +}
>> > >
>> > > It has no sense if other archs (arm32, ppc64, tile) are not updated.
>> > >
>> > But it also an inline function on x86.
>>
>> In x86, it was implemented as a function because there is some code.
>> If you want to make sure it is always a function, even in the case
>> of just calling memcpy from libc, you should put a doxygen comment in
>> the generic part and adapt every archs.
>
> no news?
> a v2 would be welcome

Hi Thomas,
Please close it, since there is already a solution to this issue in odp-dpdk.

Thanks!
Jianbo