From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-f169.google.com (mail-yw0-f169.google.com [209.85.161.169]) by dpdk.org (Postfix) with ESMTP id A8EA77E6A for ; Fri, 13 May 2016 05:28:18 +0200 (CEST) Received: by mail-yw0-f169.google.com with SMTP id j74so91985576ywg.1 for ; Thu, 12 May 2016 20:28:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=SrXOYUxfba6HXypGuy9ys6N54arll2E7B428Upv5YVw=; b=GAs9yvu/hz8CJfq9+4gjhwYFcU/XBfcWTwvWZiR24RNh6hqgU15asBWWGlJChDBTpv VTlad9YWDs0ceNuxlODJ0PDlPSR4oTIyYz4bjEd25TlII5YBj3htyMyIOj9ESA8kD2Xz kT+PfrVk3QGcJDDsH8r9xn6jljfRVaIhw/gR4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=SrXOYUxfba6HXypGuy9ys6N54arll2E7B428Upv5YVw=; b=MmEmnVhfqFw41sR6PYSanZRccTGzUthqGTrBDZnjBdMu/4s24mE1wzcFiHqZGM9Jok vgE2saUhEq84VgwZGBQSQ9Km278KJEPqd3b2/iyeBlk2zMRgDhtjNGNMVNX5QkuXkBqM qK3sBpuRmep1tbO+xr/MQWp4595UY7eSQ7Gp10UhZYrWw4lb0gK5fce8VnuLKHTFC4qs 4mc2uV3aSU9WBe3LryzjV5eIIhnHRdipurPiKVrZ2zqmtIHNpvf5qGJSIWmwk5739Rxn JDEviZVpZa6VGt3lCtQcFeq/G9KIZMX6fwgFpqRXE7aJMguzQTI3YuGG1YV9sLgjlk5t WspQ== X-Gm-Message-State: AOPr4FX5QzGcIOA8ppKY6/AaiLUw/QCrBAW30jUCrg0D45BY9PGWn9q/W6G/fSWKsiAGiF5ORVlDKFaHC8kjCgzZ MIME-Version: 1.0 X-Received: by 10.13.233.130 with SMTP id s124mr2402846ywe.15.1463110098132; Thu, 12 May 2016 20:28:18 -0700 (PDT) Received: by 10.37.223.2 with HTTP; Thu, 12 May 2016 20:28:18 -0700 (PDT) In-Reply-To: <1462542490-15556-10-git-send-email-viktorin@rehivetech.com> References: <1451682326-5834-1-git-send-email-viktorin@rehivetech.com> <1462542490-15556-1-git-send-email-viktorin@rehivetech.com> <1462542490-15556-10-git-send-email-viktorin@rehivetech.com> Date: Fri, 13 May 2016 11:28:18 +0800 Message-ID: From: Jianbo Liu To: Jan Viktorin Cc: dev@dpdk.org, David Marchand , Thomas Monjalon , Bruce Richardson , Declan Doherty , Jerin Jacob , Keith Wiles , Stephen Hemminger Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH v1 09/28] eal: introduce --no-soc option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 May 2016 03:28:18 -0000 On 6 May 2016 at 21:47, Jan Viktorin wrote: > This option has the same meaning for the SoC infra as the --no-pci > for the PCI infra. > > Signed-off-by: Jan Viktorin > --- > lib/librte_eal/common/eal_common_options.c | 5 +++++ > lib/librte_eal/common/eal_internal_cfg.h | 1 + > lib/librte_eal/common/eal_options.h | 2 ++ > 3 files changed, 8 insertions(+) > > diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c > index 3efc90f..09d64f7 100644 > --- a/lib/librte_eal/common/eal_common_options.c > +++ b/lib/librte_eal/common/eal_common_options.c > @@ -85,6 +85,7 @@ eal_long_options[] = { > {OPT_NO_HPET, 0, NULL, OPT_NO_HPET_NUM }, > {OPT_NO_HUGE, 0, NULL, OPT_NO_HUGE_NUM }, > {OPT_NO_PCI, 0, NULL, OPT_NO_PCI_NUM }, > + {OPT_NO_SOC, 0, NULL, OPT_NO_SOC_NUM }, > {OPT_NO_SHCONF, 0, NULL, OPT_NO_SHCONF_NUM }, > {OPT_PCI_BLACKLIST, 1, NULL, OPT_PCI_BLACKLIST_NUM }, > {OPT_PCI_WHITELIST, 1, NULL, OPT_PCI_WHITELIST_NUM }, > @@ -841,6 +842,10 @@ eal_parse_common_option(int opt, const char *optarg, > conf->no_pci = 1; > break; > > + case OPT_NO_SOC_NUM: > + conf->no_soc = 1; Could it be better to rename to enable_soc, and disable soc by default? > + break; > + > case OPT_NO_HPET_NUM: > conf->no_hpet = 1; > break; > diff --git a/lib/librte_eal/common/eal_internal_cfg.h b/lib/librte_eal/common/eal_internal_cfg.h > index 5f1367e..3a98e94 100644 > --- a/lib/librte_eal/common/eal_internal_cfg.h > +++ b/lib/librte_eal/common/eal_internal_cfg.h > @@ -67,6 +67,7 @@ struct internal_config { > unsigned hugepage_unlink; /**< true to unlink backing files */ > volatile unsigned xen_dom0_support; /**< support app running on Xen Dom0*/ > volatile unsigned no_pci; /**< true to disable PCI */ > + volatile unsigned no_soc; /**< true to disable SoC */ > volatile unsigned no_hpet; /**< true to disable HPET */ > volatile unsigned vmware_tsc_map; /**< true to use VMware TSC mapping > * instead of native TSC */ > diff --git a/lib/librte_eal/common/eal_options.h b/lib/librte_eal/common/eal_options.h > index a881c62..ba1e704 100644 > --- a/lib/librte_eal/common/eal_options.h > +++ b/lib/librte_eal/common/eal_options.h > @@ -69,6 +69,8 @@ enum { > OPT_NO_HUGE_NUM, > #define OPT_NO_PCI "no-pci" > OPT_NO_PCI_NUM, > +#define OPT_NO_SOC "no-soc" > + OPT_NO_SOC_NUM, > #define OPT_NO_SHCONF "no-shconf" > OPT_NO_SHCONF_NUM, > #define OPT_SOCKET_MEM "socket-mem" > -- > 2.8.0 >