From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb0-f174.google.com (mail-yb0-f174.google.com [209.85.213.174]) by dpdk.org (Postfix) with ESMTP id 6F4DB5920 for ; Tue, 2 May 2017 03:56:46 +0200 (CEST) Received: by mail-yb0-f174.google.com with SMTP id 8so31565963ybw.1 for ; Mon, 01 May 2017 18:56:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=8mLEu81PDaNIUFS88w3Co4d15dkiUlrKkEismy2cnis=; b=FNHs4cUqmS4YA+f6jncSkdxOp5Gfvytenfbtq6hWTuS7asGbHtAVK+9nBgic0Qh6v7 gyfkgW8zt1A7olikUHsrEjmVNhpys0kbLtsNsF9GU2ZG34gLF0jllHnzGUgBp2zDwO45 jj9aQhxbbN7GwCXXr9s+VkQFsQ030qgVJFrco= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=8mLEu81PDaNIUFS88w3Co4d15dkiUlrKkEismy2cnis=; b=NRrG0DdOS2jp3VjPyzQi70ig6HXpnbvpRX3UozPOvgE7cZ2x7DGaTpbPUsJEGR30lq rT/YstBX4RvqOqSGqczM+4Gm5o2TvINbTp1rjOUsLZsIrpLYJ6htsrLqk0Zs8YeRw9Ep sqImpaXAmtYJ79rD0NmJF2x3Xm0k0SMzyJF3etzrIzDD9J3a/2QJtSSOLecJ1m8mA3OG Cu4ZiiqssGZsJBvNKdilwLGeEmpOEMAVZFgEGdK/dHnmT+SmEiDR5RoVB1x0IlPY12Gb sRZFkvpugXwJpaf99SVDUL5JY6P7ZS8mKq7WI2iiOIlfjSwu7b3F39vdptKwSW3gsbCZ iT4A== X-Gm-Message-State: AN3rC/5eBRJVVRb8JTgeJDj0GE3lQ26bxVDn4Kj+83fYWEcuNLOiEMzn 7QKBuUj6GAFV2dlqdUwZxcjZT0SHwIuZ X-Received: by 10.37.55.151 with SMTP id e145mr21958463yba.164.1493690205389; Mon, 01 May 2017 18:56:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.37.4.16 with HTTP; Mon, 1 May 2017 18:56:44 -0700 (PDT) In-Reply-To: References: <20170427114249.31863-1-ashwin.sekhar@caviumnetworks.com> <20170427124418.32857-1-ashwin.sekhar@caviumnetworks.com> From: Jianbo Liu Date: Tue, 2 May 2017 09:56:44 +0800 Message-ID: To: "Sekhar, Ashwin" Cc: "byron.marohn@intel.com" , "pablo.de.lara.guarch@intel.com" , "Jacob, Jerin" , "dev@dpdk.org" Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH v2] efd: support lookup using neon intrinsics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 May 2017 01:56:46 -0000 On 28 April 2017 at 18:38, Sekhar, Ashwin wrote: > On Friday 28 April 2017 03:36 PM, Jianbo Liu wrote: >> On 27 April 2017 at 20:44, Ashwin Sekhar T K >> wrote: >>> * Added file lib/librte_efd/rte_efd_arm64.h to hold arm64 >>> specific definitions >>> * Verified the changes with efd_autotest unit test case >>> >>> Signed-off-by: Ashwin Sekhar T K >>> --- >>> v2: >>> * Slightly modified the content of the commit message body >>> * Added prefix [dpdk-dev] to the email subject line >>> >>> MAINTAINERS | 1 + >>> lib/librte_efd/rte_efd.c | 22 ++++++++++++ >>> lib/librte_efd/rte_efd_arm64.h | 76 ++++++++++++++++++++++++++++++++++++++++++ >>> 3 files changed, 99 insertions(+) >>> create mode 100644 lib/librte_efd/rte_efd_arm64.h >>> >>> diff --git a/MAINTAINERS b/MAINTAINERS >>> index b6495d2..7d708ae 100644 >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -147,6 +147,7 @@ F: lib/librte_eal/common/include/arch/arm/*_64.h >>> F: lib/librte_acl/acl_run_neon.* >>> F: lib/librte_lpm/rte_lpm_neon.h >>> F: lib/librte_hash/rte*_arm64.h >>> +F: lib/librte_efd/rte*_arm64.h >>> F: drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c >>> F: drivers/net/i40e/i40e_rxtx_vec_neon.c >>> F: drivers/net/virtio/virtio_rxtx_simple_neon.c >>> diff --git a/lib/librte_efd/rte_efd.c b/lib/librte_efd/rte_efd.c >>> index f601d62..4d9a088 100644 >>> --- a/lib/librte_efd/rte_efd.c >>> +++ b/lib/librte_efd/rte_efd.c >>> @@ -53,6 +53,8 @@ >>> #include "rte_efd.h" >>> #if defined(RTE_ARCH_X86) >>> #include "rte_efd_x86.h" >>> +#elif defined(RTE_ARCH_ARM64) >>> +#include "rte_efd_arm64.h" >>> #endif >>> >>> #define EFD_KEY(key_idx, table) (table->keys + ((key_idx) * table->key_len)) >>> @@ -103,6 +105,7 @@ allocated memory >>> enum efd_lookup_internal_function { >>> EFD_LOOKUP_SCALAR = 0, >>> EFD_LOOKUP_AVX2, >>> + EFD_LOOKUP_NEON, >> >> Should it be included in "if defined(RTE_ARCH_ARM64)"? >> > The enum can be wrapped under "if defined(RTE_ARCH_ARM64)" with no > issues, as all its usages are also under "if defined(RTE_ARCH_ARM64)". > I followed EFD_LOOKUP_AVX2 and defined EFD_LOOKUP_NEON on the same lines. > Please advise on whether this change is to be made. Will follow your advice. Yes, please do that.