From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb0-f175.google.com (mail-yb0-f175.google.com [209.85.213.175]) by dpdk.org (Postfix) with ESMTP id 744E5FADF for ; Mon, 16 Jan 2017 06:57:39 +0100 (CET) Received: by mail-yb0-f175.google.com with SMTP id 123so31285548ybe.3 for ; Sun, 15 Jan 2017 21:57:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=DuG7nKkgrEqJ4G+NlORbS5f0HMI6W+kAiJHOpizMISo=; b=bIWBGDpxOBzYUGOw8DoiHZLOTbQn/fI4dF51Qtn9vnB5V8M+yPUZ3FysJt1d40heuR BZszdBm50NwedZKWoM/ZyQV2xTnfCUjAQRgn7eoQfz1sV2dM6OC4qh/dIr+eWdxaNY7k 7pw5Ee+DwXUxEzWoyKa3mP3SwutE2OnV7lINo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=DuG7nKkgrEqJ4G+NlORbS5f0HMI6W+kAiJHOpizMISo=; b=JXU0x26vIoo5bXzuKe/urLZ4TvnUeY7UzfKeWTaFg4hLZvdgLgLgxCWA61bjTXsop4 JVfI/KfH7+R02p3bKBffZbpvcH3EqtXXOy7jBEBm5aHOYiz9CfH4NgVhn8TlEsT5txvD s0mFbYn/c8PrRlVQ8iihggTLMAULxpTKHasg0PvP7BMnLcXIAiO/yJ8++ovPmLNpbg73 //a9lk8W9kCSEwbGf/74J3aNZwchh6hlJudxLbm88y5bd1qfA4dHtMk8DrOIi3h4KPG/ +l21XC9WdgbztniRfZbDoBZ7iJ0USuMxKVHUuQ1KR09VAxWPmpIkJ1qp6ZPAaeUrOTLB SNMA== X-Gm-Message-State: AIkVDXKnvMCNrRaXZHNvesIMD0bYqA0e/90tvqkHPJMmy+TuOrYmCJ7VoVoxsToNvJDu96DPxWGLBaPWR1zw/ATx X-Received: by 10.37.56.208 with SMTP id f199mr20153027yba.94.1484546258869; Sun, 15 Jan 2017 21:57:38 -0800 (PST) MIME-Version: 1.0 Received: by 10.37.221.6 with HTTP; Sun, 15 Jan 2017 21:57:38 -0800 (PST) In-Reply-To: <9c3e96af-7cac-10a4-736a-f6690e9caaff@nxp.com> References: <1481077985-4224-2-git-send-email-zbigniew.bodek@caviumnetworks.com> <1483551207-18236-1-git-send-email-zbigniew.bodek@caviumnetworks.com> <1483551207-18236-3-git-send-email-zbigniew.bodek@caviumnetworks.com> <9c3e96af-7cac-10a4-736a-f6690e9caaff@nxp.com> From: Jianbo Liu Date: Mon, 16 Jan 2017 13:57:38 +0800 Message-ID: To: Hemant Agrawal Cc: Zbigniew Bodek , dev@dpdk.org, pablo.de.lara.guarch@intel.com, Declan Doherty , Jerin Jacob Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH v3 2/8] lib: add cryptodev type for the upcoming ARMv8 PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jan 2017 05:57:39 -0000 On 13 January 2017 at 16:16, Hemant Agrawal wrote: > On 1/4/2017 11:03 PM, zbigniew.bodek@caviumnetworks.com wrote: >> >> From: Zbigniew Bodek >> >> Add type and name for ARMv8 crypto PMD >> >> Signed-off-by: Zbigniew Bodek >> --- >> lib/librte_cryptodev/rte_cryptodev.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/lib/librte_cryptodev/rte_cryptodev.h >> b/lib/librte_cryptodev/rte_cryptodev.h >> index 8f63e8f..6f34f22 100644 >> --- a/lib/librte_cryptodev/rte_cryptodev.h >> +++ b/lib/librte_cryptodev/rte_cryptodev.h >> @@ -66,6 +66,8 @@ >> /**< KASUMI PMD device name */ >> #define CRYPTODEV_NAME_ZUC_PMD crypto_zuc >> /**< KASUMI PMD device name */ >> +#define CRYPTODEV_NAME_ARMV8_PMD crypto_armv8 >> +/**< ARMv8 Crypto PMD device name */ >> > I will suggest the name as armv8ce or armv8_ce for this driver. > Do you agree? > I don't because it's a lib only optimized for chained crypto and hash. > >> /** Crypto device type */ >> enum rte_cryptodev_type { >> @@ -77,6 +79,7 @@ enum rte_cryptodev_type { >> RTE_CRYPTODEV_KASUMI_PMD, /**< KASUMI PMD */ >> RTE_CRYPTODEV_ZUC_PMD, /**< ZUC PMD */ >> RTE_CRYPTODEV_OPENSSL_PMD, /**< OpenSSL PMD */ >> + RTE_CRYPTODEV_ARMV8_PMD, /**< ARMv8 crypto PMD */ >> }; >> >> extern const char **rte_cyptodev_names; >> > >