From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-f173.google.com (mail-yw0-f173.google.com [209.85.161.173]) by dpdk.org (Postfix) with ESMTP id 91F9F2C48 for ; Mon, 21 Mar 2016 06:42:31 +0100 (CET) Received: by mail-yw0-f173.google.com with SMTP id g3so204127250ywa.3 for ; Sun, 20 Mar 2016 22:42:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=gvnyLaB/gJZlMChWja0FVK8DyL40pkIPXA2AJZHov0c=; b=R/RF6ZceP+2czwnjjA3fjhm3IQI6p30Gsw/1b82hNqEjkYsuvSvyq7spZxJzXNBUeH 1+FQoAh32TsrOhCgTOdhXgl39kD9XUjeAfWPM9H4Md5epzAkKBRLYRKA6SXjQqv9fk6O QW1Vw/YKCFs4CjwW0W9JcU97/abz6dWdnPIyM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=gvnyLaB/gJZlMChWja0FVK8DyL40pkIPXA2AJZHov0c=; b=fAB/tnsLIFna9q7+56MUdUEDfvM/vKQoZNOaTFLsC+JWVX8+FzgT1k8h/2gW6AC319 yxx/AoNPt3C8BjhhWE9OceCokO/OOkPxFrJupjqyXDrb2knU+VM9YnPDAZLVZoGYFIHe Xlw8rWl5+VkBG9TlwNYzJNQP8oROXsOsERHam2NLNZi2GDqr2+amUpKhQU1xj2TMhxPg K5Lwva80SslrRy+fK7e4lxwxpohYz/eKYIa2GCohPilJSx6ZmY2Q3ftgMRv+mK+w8zgP 6MoatonoPTH9Bi3+UzI+RQb82hqd6btRI4TycBlHSNzxZ0OYMv0bcotTLEDY6pZhv3v/ IScQ== X-Gm-Message-State: AD7BkJINlFsoPZPxZ/VgOabrffvIC05m+itWNQhjjijwB5l5oFPG3hy2D/t+PaMf8TRndD7p8P1I/9JYoJ2A5mdt MIME-Version: 1.0 X-Received: by 10.13.225.133 with SMTP id k127mr12609778ywe.20.1458538951118; Sun, 20 Mar 2016 22:42:31 -0700 (PDT) Received: by 10.37.209.212 with HTTP; Sun, 20 Mar 2016 22:42:31 -0700 (PDT) In-Reply-To: <1458417485-29436-5-git-send-email-viktorin@rehivetech.com> References: <1458379590-18618-1-git-send-email-viktorin@rehivetech.com> <1458417485-29436-1-git-send-email-viktorin@rehivetech.com> <1458417485-29436-5-git-send-email-viktorin@rehivetech.com> Date: Mon, 21 Mar 2016 13:42:31 +0800 Message-ID: From: Jianbo Liu To: Jan Viktorin Cc: dev@dpdk.org, Thomas Monjalon , Jerin Jacob , tomaszx.kulasek@intel.com Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH v3 4/4] eal/arm: introduce CONFIG_RTE_ARCH_ARM_NEON_MEMCPY X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2016 05:42:31 -0000 On 20 March 2016 at 03:58, Jan Viktorin wrote: > The flag is used to enable memcpy optimizations in EAL. As it is not always > the performance benefit, the flag allows to disable it. > > Signed-off-by: Jan Viktorin > --- > config/defconfig_arm-armv7a-linuxapp-gcc | 1 + > lib/librte_eal/common/include/arch/arm/rte_memcpy_32.h | 8 ++++++-- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/config/defconfig_arm-armv7a-linuxapp-gcc b/config/defconfig_arm-armv7a-linuxapp-gcc > index 96c3343..2c60c2c 100644 > --- a/config/defconfig_arm-armv7a-linuxapp-gcc > +++ b/config/defconfig_arm-armv7a-linuxapp-gcc > @@ -36,6 +36,7 @@ CONFIG_RTE_ARCH="arm" > CONFIG_RTE_ARCH_ARM=y > CONFIG_RTE_ARCH_ARMv7=y > CONFIG_RTE_ARCH_ARM_TUNE="cortex-a9" > +CONFIG_RTE_ARCH_ARM_NEON_MEMCPY=y > If it's not always benefit, why not disable here since it is common armv7a config, and enable in your or other user's own config file? Thanks! Jianbo