From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb0-f180.google.com (mail-yb0-f180.google.com [209.85.213.180]) by dpdk.org (Postfix) with ESMTP id B02F736E for ; Thu, 15 Dec 2016 09:13:34 +0100 (CET) Received: by mail-yb0-f180.google.com with SMTP id d128so27396166ybh.2 for ; Thu, 15 Dec 2016 00:13:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=KPp6wXEzjiCQZC1nzPrFKvvh9GU8kSz5bc2SWfmSfAI=; b=HVsoxEQhI+qQEGaNNRJbJzv284inTgj5Gg4W0hwwgWpzvHJX3zAYGIK1MsBVUrhNMk FPKVPw43Y0t9bSZjVaVwIQqa16jPWWc7SwyY0QdMayIqsX1HQ8OcsxrWEjAtoMuZkOwa zrdgagQH2iYemSwRXCs/NR/SpkERYiLI8UAqI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=KPp6wXEzjiCQZC1nzPrFKvvh9GU8kSz5bc2SWfmSfAI=; b=jyzlAGvAumkO+he7sb3lfJ/a/1YvJ2yXQ9oQaz1JF0hgbBalikllLOutMmzuk349Hm T/jUSr8II1F5noLzyWgyR7W2v7I5Ggk287YqgMl8z7s2aut2mwEMXCBpooJcgIrVna84 sj+/jWEe1kTCUiC+kL9vize0xgiONOcMNrVPw3F2b3zltgXDWpybzkBmhaRuTMrJlpx+ QWyKin9PsuccO77IUHKq/MadgWdGSuMai53HEKaXHUVSiwe1loqfBJLR9LUyUHRDqvrq QLQHb0KcvrnAlESg41WtTJDOrrWQZujrKyn8hsVMcH1XiPtR00OnduTuN38d64F83ym1 8Xrw== X-Gm-Message-State: AIkVDXLbR3nJnKeM68fxaaVZ+qzsJ8yiM11fvYz3q3r31YJQcy9MCflgX0k9j3kpd9hl7dmjvPDNdDDXhG5FcsIq X-Received: by 10.37.58.4 with SMTP id h4mr69521yba.82.1481789613877; Thu, 15 Dec 2016 00:13:33 -0800 (PST) MIME-Version: 1.0 Received: by 10.37.193.131 with HTTP; Thu, 15 Dec 2016 00:13:33 -0800 (PST) In-Reply-To: <1481680558-4003-9-git-send-email-jerin.jacob@caviumnetworks.com> References: <1481680558-4003-1-git-send-email-jerin.jacob@caviumnetworks.com> <1481680558-4003-9-git-send-email-jerin.jacob@caviumnetworks.com> From: Jianbo Liu Date: Thu, 15 Dec 2016 16:13:33 +0800 Message-ID: To: Jerin Jacob Cc: dev@dpdk.org, "Ananyev, Konstantin" , Thomas Monjalon , Bruce Richardson , Jan Viktorin Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH 08/28] eal/arm64: define smp barrier definition for arm64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Dec 2016 08:13:35 -0000 On 14 December 2016 at 09:55, Jerin Jacob wrote: > dmb instruction based barrier is used for smp version of memory barrier. > > Signed-off-by: Jerin Jacob > --- > lib/librte_eal/common/include/arch/arm/rte_atomic_64.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h > index bc7de64..78ebea2 100644 > --- a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h > +++ b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h > @@ -82,11 +82,11 @@ static inline void rte_rmb(void) > dsb(ld); > } > > -#define rte_smp_mb() rte_mb() > +#define rte_smp_mb() dmb(ish) > > -#define rte_smp_wmb() rte_wmb() > +#define rte_smp_wmb() dmb(ishst) > > -#define rte_smp_rmb() rte_rmb() > +#define rte_smp_rmb() dmb(ishld) > rte_*mb are inline functions, while rte_smp_*mb are macro. As they are all derived from dsb/dmb, can you keep them consistent? > #ifdef __cplusplus > } > -- > 2.5.5 >