From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-f180.google.com (mail-yw0-f180.google.com [209.85.161.180]) by dpdk.org (Postfix) with ESMTP id 5C0B52952 for ; Thu, 11 May 2017 08:11:57 +0200 (CEST) Received: by mail-yw0-f180.google.com with SMTP id 203so8030832ywe.0 for ; Wed, 10 May 2017 23:11:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ru2Pk6Dcg+5breQk+Xrx4Zk7dIQh1ROfXP+ntJi80EE=; b=HUnm73hMCx2SEO91Uljv1jKqQDD8d/CDOS7vBuZXD3Uvh4JfLwbHDvj6jgl6BZnCI8 dFOn9PWWnj/ud4OHQs41ZSPtMPB0RwxjtSmiECpNubREpVRQ+0uZCP+skbdGODJGJbKo o9jP8yLQhfChSPnHGfeYPRdgP+nNizQSzB1sI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ru2Pk6Dcg+5breQk+Xrx4Zk7dIQh1ROfXP+ntJi80EE=; b=Yassb+sMviYPC2f+P9k/RqmIe/XO8022QgyMJQEDsefNjH+yQPXOkR+u5v6QRghuu7 /b1ycNuGEc8JHN1RS6S08g4mFrTqUTkGbEDk4gAMttuJJ9xh77ATvpM09ShCoS8Yi3qX 8F4+ySBxMsa9W9kkikyM2BTgWmKpiewBbxoN+pRLJ41ZptEDiWZJvO2AxbZLo8pd8bBw i42pjk+jOtmBeK5TpXyJ4/394Y2aE7DCl1U1piGYVKNF/J5m1eYHzfkCPyWAxIVE9ZgL kNKrxm7gnKebSZCwcILEhY0HZpabSNzgGFYa4FrHhhWGQj1MnkR+nZxfaQomPB22tr5z Hkow== X-Gm-Message-State: AODbwcAIUZkK0flc/D2vqoaVxwI5oDLK/RjCEHUB40+vQ2pKz2cNnLcn UrmiThEChFG/KOWslY79IiWCwRQHK203 X-Received: by 10.129.78.73 with SMTP id c70mr7800494ywb.62.1494483116697; Wed, 10 May 2017 23:11:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.37.4.16 with HTTP; Wed, 10 May 2017 23:11:56 -0700 (PDT) In-Reply-To: <1494476828.4256.3.camel@caviumnetworks.com> References: <1493709255-8887-1-git-send-email-jianbo.liu@linaro.org> <1494383419-9677-1-git-send-email-jianbo.liu@linaro.org> <1494383419-9677-6-git-send-email-jianbo.liu@linaro.org> <1494428417.2713.55.camel@caviumnetworks.com> <1494476052.2563.10.camel@caviumnetworks.com> <1494476828.4256.3.camel@caviumnetworks.com> From: Jianbo Liu Date: Thu, 11 May 2017 14:11:56 +0800 Message-ID: To: "Sekhar, Ashwin" Cc: "Jacob, Jerin" , "tomasz.kantecki@intel.com" , "dev@dpdk.org" Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH v2 5/7] examples/l3fwd: add neon support for l3fwd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 May 2017 06:11:57 -0000 On 11 May 2017 at 12:27, Sekhar, Ashwin wrote: > > On Thu, 2017-05-11 at 04:14 +0000, Sekhar, Ashwin wrote: > ... >> > > Combining all the above comments, I made some changes on top of >> > > your >> > > patch. These changes are giving 3-4% improvement over your >> > > version. >> > > >> > > You may find the changes at >> > > https://gist.github.com/ashwinyes/34cbdd999784402c859c71613587faf >> > > c >> > > >> > Is the correct in Line 103/104, you only process one packets in the >> > last FWDSTEP packets? >> Its doing processx4_* there. So its processing 4 packets. >> >> > >> > Actually, I don't like your change in l3fwd_lpm_send_packets, >> > making >> > the simple logic complicated. And I don't think it can help to >> > improve >> > performance. :-) >> Its not making it complicated. The number of lines of code may be >> higher by may be 10 lines, but the conditions of the loops are >> simplified which reduces the number of branch instructions and helps >> the processor to go through them faster. I suspected not much improvement we can get. >> >> If possible, please try it out on your machine. OK, I'll test. If no performance regression, I'll adopt your suggestion in v3. > > Missed out one point. > Since 2 loops are form "for (i = 0; i < FWDSTEP; i++)" i.e. looping for > constant number of iterations, compiler will easily unroll them. > > Thanks > Ashwin >> > >> > >> > > >> > > >> > > Please check it out and let me know your comments. >> > > >> > > Thanks >> > > Ashwin