From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-f174.google.com (mail-yw0-f174.google.com [209.85.161.174]) by dpdk.org (Postfix) with ESMTP id 853FC1F5 for ; Thu, 18 May 2017 11:40:59 +0200 (CEST) Received: by mail-yw0-f174.google.com with SMTP id p73so7709900ywp.0 for ; Thu, 18 May 2017 02:40:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=KN+jkZ1GTIGMIfVf4itckb6v+yZHqtaOZVLwbxcv8G4=; b=YInJSktJCbR8kLaa/3dN/3DozTlJ/MV3p8fyWW/9/Rsa8nmRa/dnFDv+sOo+jivQYu 2dm92Mu4SeHHT3ADNM7vFzX6KwGD/5c1W4RaJ8IZZr1Esyw81OLe0zpgRUZexnMGHX3m Q82FAagovc5Ru0vAYnGzpTZX0NeQ1uDn88H+M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=KN+jkZ1GTIGMIfVf4itckb6v+yZHqtaOZVLwbxcv8G4=; b=nj59zmna4DX+GVGF/TvxknOu+pQ0q5d1dfcTlqs1xYjJ6+rVk/8GT5cAJXgbtrCmjv Z7x+25EZ7iBrkZrp310Od6y6IhjrBbEWBd4Gz1nLL0wGt20hMlZqLkxA6mr//dRSwms3 oZMBT4ei9L0wYy7MKfh90d3Z1N1oovU1vywOuSrcsNzGMB1N24OasJhjsBrLr/aIExJi fO8TdrwM6Q0P4fkxTBE7j52/gubhBGNrag7zjNHvdGCDQ48OK4mq9Uz/jRdEExLRkH4a Toj1NGO17YzT5Iier+p1D0lpNqhNEcAuRibTExTnF3sqBypzUnQc2Ut+ERReCZSu/ylF be+Q== X-Gm-Message-State: AODbwcDRT3TqVXjNkldTaYdMyEcrpeuyUyGqafGN/t2YdUlR9XJAe07d y6GJV5yg+NJ/rup0g1AM1oeuWzmLVQ+p X-Received: by 10.129.173.74 with SMTP id l10mr2493015ywk.114.1495100458967; Thu, 18 May 2017 02:40:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.37.4.16 with HTTP; Thu, 18 May 2017 02:40:58 -0700 (PDT) In-Reply-To: <20170511101046.26456-3-jerin.jacob@caviumnetworks.com> References: <20170511101046.26456-1-jerin.jacob@caviumnetworks.com> <20170511101046.26456-3-jerin.jacob@caviumnetworks.com> From: Jianbo Liu Date: Thu, 18 May 2017 17:40:58 +0800 Message-ID: To: Jerin Jacob Cc: dev@dpdk.org, thomas@monjalon.net, Jan Viktorin Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 3/6] eal/arm64: rte pause implementation for arm64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 May 2017 09:41:00 -0000 On 11 May 2017 at 18:10, Jerin Jacob wrote: > CC: Jianbo Liu > Signed-off-by: Jerin Jacob > --- > lib/librte_eal/common/include/arch/arm/rte_pause.h | 4 ++ > .../common/include/arch/arm/rte_pause_64.h | 55 ++++++++++++++++++++++ > 2 files changed, 59 insertions(+) > create mode 100644 lib/librte_eal/common/include/arch/arm/rte_pause_64.h > > diff --git a/lib/librte_eal/common/include/arch/arm/rte_pause.h b/lib/librte_eal/common/include/arch/arm/rte_pause.h > index 0fe88aba9..9b79405e6 100644 > --- a/lib/librte_eal/common/include/arch/arm/rte_pause.h > +++ b/lib/librte_eal/common/include/arch/arm/rte_pause.h > @@ -37,7 +37,11 @@ > extern "C" { > #endif > > +#ifdef RTE_ARCH_64 > +#include > +#else > #include > +#endif > > #ifdef __cplusplus > } > diff --git a/lib/librte_eal/common/include/arch/arm/rte_pause_64.h b/lib/librte_eal/common/include/arch/arm/rte_pause_64.h > new file mode 100644 > index 000000000..cae996de8 > --- /dev/null > +++ b/lib/librte_eal/common/include/arch/arm/rte_pause_64.h > @@ -0,0 +1,55 @@ > +/* > + * BSD LICENSE > + * > + * Copyright(c) 2017 Cavium. All rights reserved. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions > + * are met: > + * > + * * Redistributions of source code must retain the above copyright > + * notice, this list of conditions and the following disclaimer. > + * * Redistributions in binary form must reproduce the above copyright > + * notice, this list of conditions and the following disclaimer in > + * the documentation and/or other materials provided with the > + * distribution. > + * * Neither the name of Cavium nor the names of its > + * contributors may be used to endorse or promote products derived > + * from this software without specific prior written permission. > + * > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR > + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT > + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, > + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > + */ > + > +#ifndef _RTE_PAUSE_ARM64_H_ > +#define _RTE_PAUSE_ARM64_H_ > + > +#ifdef __cplusplus > +extern "C" { > +#endif > + > +#include > +#include "generic/rte_pause.h" > + > +static inline void rte_pause(void) > +{ > + /* YIELD hints the CPU to switch to another thread if possible > + * and executes as a NOP otherwise. I think you can remove the second line if you are trying to explain what YIELD instruction is. And I wonder if it can save power as rte_thread is bounded to certain core and always polling while YIELD is only a hint instruction. > + */ > + asm volatile("yield" ::: "memory"); > +} > + > +#ifdef __cplusplus > +} > +#endif > + > +#endif /* _RTE_PAUSE_ARM64_H_ */ > -- > 2.12.2 >