From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-f175.google.com (mail-yw0-f175.google.com [209.85.161.175]) by dpdk.org (Postfix) with ESMTP id 6B6262BF7 for ; Wed, 3 Aug 2016 08:02:06 +0200 (CEST) Received: by mail-yw0-f175.google.com with SMTP id u134so218994795ywg.3 for ; Tue, 02 Aug 2016 23:02:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=hYPwAQndpguRUSbxAmyzmeQRbjftczCgtpNFVEk8Wos=; b=R+PgnoEwoG2UX99XCgzca1HGVEuQ8ZurW4ZYeXUxCT2gY0pMAUkmiKWOA+fbVHZBCI PHxFCQe4+3DfdwXifFbMtPx4uHKlVgo5t+CnEz30Lv6xQE8FZhR8wHTWR4plGENNQWV8 ytXKOijHpmKL7CqNUm+6txzgGqZn1oQFyw1CQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=hYPwAQndpguRUSbxAmyzmeQRbjftczCgtpNFVEk8Wos=; b=XbXtujbFYKX0RUFA2fMgKUpYtek49FMV0VpoxGqeBrdehAodSOhAHpx3G0qVangkFD ZOmaYQTx/Ww0RPtnLwxXQ280ZSBx0h2YS+LifwXuFet+Js0jObmOJw4J9H2QRzEl5vBL LUhy4FhenmHXarbS8Ic7X8jgn3OPlMAqrddT7wbzjVm6Lo4SasQ3YKcKTFDFYB0qW5r5 n0k1XBuk+KybgoBSSqcpnX7O7ndN/UtDlrOzQfju5lA8b+AdMHZBE0nYmuHDg/sXmlSB 5My+I0E38IkzG+DdZBsvkXSxserhetqToe+SBJuFOUD9DvJsVXm5ilIqUlbZL15pIyfe bD1A== X-Gm-Message-State: AEkoouv4XLDGngd5NeXESd1lcP3lW4Xkct2jxMXrCVbWJlpWLBC6jMdFZYYSO7JtinUUrLJwbNghwY6BBV2umkGa X-Received: by 10.37.85.213 with SMTP id j204mr47622540ybb.149.1470204125797; Tue, 02 Aug 2016 23:02:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.37.3.132 with HTTP; Tue, 2 Aug 2016 23:02:05 -0700 (PDT) In-Reply-To: <2DBBFF226F7CF64BAFCA79B681719D9502046341@shsmsx102.ccr.corp.intel.com> References: <1470121107-7622-1-git-send-email-jianbo.liu@linaro.org> <82F45D86ADE5454A95A89742C8D1410E0330A4B6@shsmsx102.ccr.corp.intel.com> <2DBBFF226F7CF64BAFCA79B681719D9502046341@shsmsx102.ccr.corp.intel.com> From: Jianbo Liu Date: Wed, 3 Aug 2016 14:02:05 +0800 Message-ID: To: "Yao, Lei A" Cc: "dev@dpdk.org" , "Zhang, Helin" , "Wu, Jingjing" Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH] i40e: enable i40e pmd on ARM platform X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Aug 2016 06:02:06 -0000 On 3 August 2016 at 11:26, Yao, Lei A wrote: > Hi, Jianbo > > I have tested you patch on my X86 platform, the single core performance for Non-vector PMD will have about 1Mpps drop > Non-vector PMD single core performance with patch : ~33.9 Mpps > Non-vector PMD single core performance without patch : ~35.1 Mpps > Is there any way to avoid such performance drop on X86? Thanks. > I think we can place a compiling condition before rte_rmb() to avoid performance decrease on x86. For example: #if defined(RTE_ARCH_ARM) || defined(RTE_ARCH_ARM64) Thanks! Jianbo > BRs > Lei > > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jianbo Liu > Sent: Tuesday, August 2, 2016 2:58 PM > To: dev@dpdk.org; Zhang, Helin ; Wu, Jingjing > Cc: Jianbo Liu > Subject: [dpdk-dev] [PATCH] i40e: enable i40e pmd on ARM platform > > And add read memory barrier to avoid status inconsistency between two RX descriptors readings. > > Signed-off-by: Jianbo Liu > --- > config/defconfig_arm64-armv8a-linuxapp-gcc | 2 +- > doc/guides/nics/overview.rst | 2 +- > drivers/net/i40e/i40e_rxtx.c | 2 ++ > 3 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/config/defconfig_arm64-armv8a-linuxapp-gcc b/config/defconfig_arm64-armv8a-linuxapp-gcc > index 1a17126..08f282b 100644 > --- a/config/defconfig_arm64-armv8a-linuxapp-gcc > +++ b/config/defconfig_arm64-armv8a-linuxapp-gcc > @@ -46,6 +46,6 @@ CONFIG_RTE_EAL_IGB_UIO=n > > CONFIG_RTE_LIBRTE_IVSHMEM=n > CONFIG_RTE_LIBRTE_FM10K_PMD=n > -CONFIG_RTE_LIBRTE_I40E_PMD=n > +CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=n > > CONFIG_RTE_SCHED_VECTOR=n > diff --git a/doc/guides/nics/overview.rst b/doc/guides/nics/overview.rst index 6abbae6..5175591 100644 > --- a/doc/guides/nics/overview.rst > +++ b/doc/guides/nics/overview.rst > @@ -138,7 +138,7 @@ Most of these differences are summarized below. > Linux VFIO Y Y Y Y Y Y Y Y Y Y Y Y Y Y Y Y Y Y Y Y > Other kdrv Y Y Y > ARMv7 Y Y Y > - ARMv8 Y Y Y Y Y Y Y Y > + ARMv8 Y Y Y Y Y Y Y Y Y > Power8 Y Y Y > TILE-Gx Y > x86-32 Y Y Y Y Y Y Y Y Y Y Y Y Y Y Y Y Y Y Y Y Y Y Y Y > diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index 554d167..4004b8e 100644 > --- a/drivers/net/i40e/i40e_rxtx.c > +++ b/drivers/net/i40e/i40e_rxtx.c > @@ -994,6 +994,8 @@ i40e_rx_scan_hw_ring(struct i40e_rx_queue *rxq) > I40E_RXD_QW1_STATUS_SHIFT; > } > > + rte_rmb(); > + > /* Compute how many status bits were set */ > for (j = 0, nb_dd = 0; j < I40E_LOOK_AHEAD; j++) > nb_dd += s[j] & (1 << I40E_RX_DESC_STATUS_DD_SHIFT); > -- > 2.4.11 >