From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-f180.google.com (mail-yw0-f180.google.com [209.85.161.180]) by dpdk.org (Postfix) with ESMTP id 99EA92935 for ; Fri, 28 Apr 2017 07:37:33 +0200 (CEST) Received: by mail-yw0-f180.google.com with SMTP id 203so26004920ywe.0 for ; Thu, 27 Apr 2017 22:37:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=WYKx+bdfLFHGuC2U4lxoTs38RRIGtoCNnoeicBJ+Wn0=; b=Smq/9+OJoWak9RFR1Eu4ykHPh39vZm3bjqxMS1qW32r0UXbh7SWWD1Vy9qhejq0fWu ELFzP2aGtUWbgPEaK75j0NRcUhHyrQAZHzPeYGhZXJaQatzX8keRS7dUqYWqktQu2q06 YNCUDYYyfMm3KV7XE9yMCYahMMJ6ne0K+fCFw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=WYKx+bdfLFHGuC2U4lxoTs38RRIGtoCNnoeicBJ+Wn0=; b=Bthuh5EE9Q5sLyKbmqSl/51pVwC4cQ7IuMJr/bKcCKU5ert/GhT28fMvUBy1jvODBS ImN0CfV8ZqIrBde+i9rA3AKv0LZ9jQ8eZTGy7dQGVFaBDlncu5b1aSiW+0QV5TN/38WG k0EkA0ivNJapWzJc2+SeEIRipxXY9dMQ8cEDYdz1hnUOMgB1nolGrgKhcsjK2LI39Hp0 kdoZs//QmCDN5eJiSYB+1D+f28pqKIVIc7WcQtnGbJBvrszw5fk0jJuwYDnVLHo+SHSZ DPLNOWE3A0fKUiH65pzIG7dcDsK3wIVpoCgzVrmu8S/itH25ERpzu0I17dNMLEaQCSP0 tfIw== X-Gm-Message-State: AN3rC/7SZdIChN3WsgJq/Ns4Ywb8a4Jwyq6raBGqAbSnouJl61D5AK1g b3/cK10y56arPay3/kdlDH7gQPqCvJSI X-Received: by 10.129.33.87 with SMTP id h84mr7474615ywh.181.1493357853000; Thu, 27 Apr 2017 22:37:33 -0700 (PDT) MIME-Version: 1.0 Received: by 10.37.4.16 with HTTP; Thu, 27 Apr 2017 22:37:32 -0700 (PDT) In-Reply-To: References: <20170427130007.33210-1-ashwin.sekhar@caviumnetworks.com> From: Jianbo Liu Date: Fri, 28 Apr 2017 13:37:32 +0800 Message-ID: To: "Sekhar, Ashwin" Cc: "thomas@monjalon.net" , "cristian.dumitrescu@intel.com" , "Jacob, Jerin" , "dev@dpdk.org" Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH] sched: enable neon optimizations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Apr 2017 05:37:33 -0000 On 28 April 2017 at 13:27, Sekhar, Ashwin wrote: > On Friday 28 April 2017 09:20 AM, Jianbo Liu wrote: >> On 27 April 2017 at 21:00, Ashwin Sekhar T K >> wrote: >>> * Enabled CONFIG_RTE_SCHED_VECTOR for arm64 >>> * Verified the changes with sched_autotest unit test case >>> >>> Signed-off-by: Ashwin Sekhar T K >>> --- >>> config/defconfig_arm64-armv8a-linuxapp-gcc | 2 +- >>> lib/librte_sched/rte_sched.c | 22 ++++++++++++++++++++++ >>> 2 files changed, 23 insertions(+), 1 deletion(-) >>> >>> diff --git a/config/defconfig_arm64-armv8a-linuxapp-gcc b/config/defconfig_arm64-armv8a-linuxapp-gcc >>> index 65888ce..021044a 100644 >>> --- a/config/defconfig_arm64-armv8a-linuxapp-gcc >>> +++ b/config/defconfig_arm64-armv8a-linuxapp-gcc >>> @@ -48,4 +48,4 @@ CONFIG_RTE_LIBRTE_FM10K_PMD=n >>> CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n >>> CONFIG_RTE_LIBRTE_AVP_PMD=n >>> >>> -CONFIG_RTE_SCHED_VECTOR=n >>> +CONFIG_RTE_SCHED_VECTOR=y >> >> It's enough to remove this line only, I don't think you must enable it >> explicitly in the armv8a common config. >> > Tried removing this line from armv8a config. But in that case > RTE_SCHED_VECTOR doesn't get defined. > ./config/common_base has "CONFIG_RTE_SCHED_VECTOR=n" as the default > setting. So enabling explicitly is required. > I know it must be enabled to use your enhancement. But I meant to keep the same as common_base (or other default configs) if there is no other strange reason to enable it. Thanks! Jianbo