From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-f177.google.com (mail-yw0-f177.google.com [209.85.161.177]) by dpdk.org (Postfix) with ESMTP id AAEDA559C for ; Fri, 28 Apr 2017 10:50:39 +0200 (CEST) Received: by mail-yw0-f177.google.com with SMTP id l18so27678036ywh.3 for ; Fri, 28 Apr 2017 01:50:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=mvKmlll21BWHzWM6DVnttPALzgffjOnzkjHIGzSiXpI=; b=UbGzGQn6BzP1XsoAG6PEANWSWxU5boMoTi3MNahDQVHJ7x/m9wpHtSdI5fPH/uExsV PyPaxKnroCHsqSbxiE0LO9Da7sUzqrqsMs0YoCb04h8XD85hBZT1lm5EoVxdvrIzrgWf 06EUAOh1ClD19WYaAwgna07cAQQUDAArt3NyI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=mvKmlll21BWHzWM6DVnttPALzgffjOnzkjHIGzSiXpI=; b=moBT1bcQ8cWrToDR/Q2TmoMUFuxBsuKfxwQcgI2X1R41cxth4ES76ldsD4TDKwYprU dqStaorGbp94mIpFohs+7VTfhoJfUf9/Vdr1dIVk1XgYaSwYesVALQhyowL0WJDcO7G3 oQ7izAoR95hjbg35kWBcJSdotRyrxcBN0f8Iy0RHKHUlmEagPRo9jrbhVN8KW5DeRJC7 hduv3zoJlgp1EKtlBhb3T7oiywtO31Mpl9U7qRYrQGOSPymrexsp0ULmv8jR5hbCT6qp VX9aO7siTxdWNsPBgPdMMUFkV4xBoLyE22ayFpvNsssnlCr0gpDCM1B/Dk8mBXAqC+Xc XCNQ== X-Gm-Message-State: AN3rC/43i+C/dnXJFV9tkkBc/M+yHQKEuQxNzeUU1DVX974rRN9t1AQD AtZLOkesrCGd+BJ0Gbc2TBZTN6iFIInH X-Received: by 10.129.88.8 with SMTP id m8mr8023486ywb.62.1493369439066; Fri, 28 Apr 2017 01:50:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.37.4.16 with HTTP; Fri, 28 Apr 2017 01:50:38 -0700 (PDT) In-Reply-To: <20170428061548.44424-1-ashwin.sekhar@caviumnetworks.com> References: <20170427130007.33210-1-ashwin.sekhar@caviumnetworks.com> <20170428061548.44424-1-ashwin.sekhar@caviumnetworks.com> From: Jianbo Liu Date: Fri, 28 Apr 2017 16:50:38 +0800 Message-ID: To: Ashwin Sekhar T K Cc: thomas@monjalon.net, cristian.dumitrescu@intel.com, Jerin Jacob , dev@dpdk.org Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH v2] sched: add neon optimizations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Apr 2017 08:50:39 -0000 On 28 April 2017 at 14:15, Ashwin Sekhar T K wrote: > * Removed setting CONFIG_RTE_SCHED_VECTOR=n from armv8a config > so that the setting from common_base is taken as the default > setting for armv8a > * Verified the changes with sched_autotest unit test case > > Signed-off-by: Ashwin Sekhar T K > --- > v2: > * Removed line CONFIG_RTE_SCHED_VECTOR=n from config/defconfig_arm64-armv8a-linuxapp-gcc > * Modified the commit message and body to reflect the changes > > config/defconfig_arm64-armv8a-linuxapp-gcc | 2 -- > lib/librte_sched/rte_sched.c | 22 ++++++++++++++++++++++ > 2 files changed, 22 insertions(+), 2 deletions(-) > > diff --git a/config/defconfig_arm64-armv8a-linuxapp-gcc b/config/defconfig_arm64-armv8a-linuxapp-gcc > index 65888ce..6415f46 100644 > --- a/config/defconfig_arm64-armv8a-linuxapp-gcc > +++ b/config/defconfig_arm64-armv8a-linuxapp-gcc > @@ -47,5 +47,3 @@ CONFIG_RTE_EAL_IGB_UIO=n > CONFIG_RTE_LIBRTE_FM10K_PMD=n > CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n > CONFIG_RTE_LIBRTE_AVP_PMD=n > - > -CONFIG_RTE_SCHED_VECTOR=n > diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c > index 614705d..4ba476a 100644 > --- a/lib/librte_sched/rte_sched.c > +++ b/lib/librte_sched/rte_sched.c > @@ -58,6 +58,8 @@ > > #if defined(__SSE4__) > #define SCHED_VECTOR_SSE4 > +#elif defined(RTE_MACHINE_CPUFLAG_NEON) > +#define SCHED_VECTOR_NEON > #endif > > #endif > @@ -1732,6 +1734,26 @@ grinder_pipe_exists(struct rte_sched_port *port, uint32_t base_pipe) > return 1; > } > > +#elif defined(SCHED_VECTOR_NEON) > + > +static inline int > +grinder_pipe_exists(struct rte_sched_port *port, uint32_t base_pipe) > +{ > + uint32x4_t index, pipes; > + uint32_t *pos = (uint32_t *)port->grinder_base_bmp_pos; > + > + index = vmovq_n_u32(base_pipe); > + pipes = vld1q_u32(pos); > + if (!vminvq_u32(veorq_u32(pipes, index))) > + return 1; > + > + pipes = vld1q_u32(pos + 4); > + if (!vminvq_u32(veorq_u32(pipes, index))) > + return 1; > + > + return 0; > +} > + > #else > > static inline int > -- > 2.7.4 > Acked-by: Jianbo Liu