From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f48.google.com (mail-vk0-f48.google.com [209.85.213.48]) by dpdk.org (Postfix) with ESMTP id 314975952 for ; Tue, 8 Dec 2015 11:21:54 +0100 (CET) Received: by vkbs1 with SMTP id s1so9049445vkb.1 for ; Tue, 08 Dec 2015 02:21:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=i+JRzKa6jzXU5Qp863ScRmibtguTo46ovdPbmX74IDM=; b=ZFOpW3lZuMcCXsdQeUWZlsYxjXKD0ph5/4+kuTX+1cs4lLg388CmTGH7Lme8X8FAY3 2mhRmQRdsyDIKxCNt9cG9K38ln3yzXrBNpOeDKebvqAz3gF0FdGV1MyfzHYiDwK9V+Di ByUIp1SP5AQMrkG6T9GeN3W6wuR7NY+NKss1nsx3M9tGFMr6rw0H63UCcuM3EI3N9FgR GZqgr1Yu/ZIietzf7KotKYQr32ZrS97Ljn8HwHZl94zITNDft6sbl2PUqyIhXUdhURNs 1d4+3C6rvHSHUkuR0VvSHa5+sqe4CEqDtTZd+lxufSK0nmdpayiF/a3dEVnV/zrrXup2 S0Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=i+JRzKa6jzXU5Qp863ScRmibtguTo46ovdPbmX74IDM=; b=iD/FfA6X17zZ6SBHkdiPGW6Q/WdDRWLdLO+JVU9c69UCZYvXoOFbHHlyqiteWNdVYb pjz0qTinKDRmcev96ArLc9tkvq9VqnEZGvw4+Ym5wC/dgVZyMqjEU2cc98Wiodzql+fh fPfd670ybVS5a80M7LYFP09S3oTANSB/QOMujOZf1soC+UKyyiPDiRQd1N2t1IMjC4HD 3tNVmfMFU5FSj/eDBN928HROsPUYr7/s4+wKY8spNH3k+A7hkIgtWs0YG+hgm9e3oO4J 59Lo3bHTFUehkdzV0KRZespamTtHDPViuavjMRD31kx0/aJweqYIHIoHM26LqpfK9W+x a9Mg== X-Gm-Message-State: ALoCoQnHGmzB0XB9aZBMtS11LcwwITHArkcU6oymhRQCgFTuVio50utcy2/K1sg+89bhQN5E78Bj+yPPwJpdmCb7bmr2yH1bR0ua2pwRRNtAJ3UtNUYjRO0= MIME-Version: 1.0 X-Received: by 10.31.169.8 with SMTP id s8mr2404795vke.148.1449570113554; Tue, 08 Dec 2015 02:21:53 -0800 (PST) Received: by 10.31.95.215 with HTTP; Tue, 8 Dec 2015 02:21:53 -0800 (PST) In-Reply-To: <2562409.c2PxG9doT8@xps13> References: <1448995276-9599-1-git-send-email-jianbo.liu@linaro.org> <4116700.gN3RbU5N65@xps13> <2562409.c2PxG9doT8@xps13> Date: Tue, 8 Dec 2015 18:21:53 +0800 Message-ID: From: Jianbo Liu To: Thomas Monjalon Content-Type: text/plain; charset=UTF-8 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 2/3] eal/acl: enable acl for armv7-a X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Dec 2015 10:21:54 -0000 On 8 December 2015 at 18:03, Thomas Monjalon wrote: > 2015-12-08 15:56, Jianbo Liu: >> On 8 December 2015 at 10:23, Thomas Monjalon wrote: >> > 2015-12-08 09:50, Jianbo Liu: >> >> On 8 December 2015 at 09:18, Thomas Monjalon wrote: >> >> > 2015-12-03 23:02, Jianbo Liu: >> >> >> -ifeq ($(CONFIG_RTE_ARCH_ARM64),y) >> >> >> +ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM) $(CONFIG_RTE_ARCH_ARM64)),) >> >> > [...] >> >> >> +#ifdef RTE_ARCH_ARM >> >> >> +/* NEON intrinsic vqtbl1q_u8() is not supported in ARMv7-A(AArch32) */ >> >> > >> >> > I'm convinced there is a good reason why ARMv8 is also called ARCH_ARM64, >> >> > and ARMv7 may be called AArch32 or ARCH_ARM. But I don't know why? >> >> > >> >> https://lkml.org/lkml/2012/7/15/133 >> >> >> >> > Is ARCH_ARM32 or ARCH_ARMv7 too simple? >> >> > Is it possible to have a 32-bit ARMv8? >> >> Yes, ARMv8-R/M >> > >> > So what does mean CONFIG_RTE_ARCH_ARM? >> > ARMv7? ARM32? >> > Please consider a renaming. >> >> I'd rather not renaming becase it can be both ARMv7 and AARCH32, which >> are ISA compatibility. >> If further differentiation is needed, CONFIG_RTE_ARCH_ARMv7 is added >> in the config, just like Jan Viktorin did. > > I don't understand. > You say CONFIG_RTE_ARCH_ARM is for ARMv7 and AARCH32, right? > Both are 32-bit right? > Why not rename it to CONFIG_RTE_ARCH_ARM32? I understand that you want to make the naming more clear. But arm/arm64 are used in Linux kernel, I think it's better to stay the same.