DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jianbo Liu <jianbo.liu@linaro.org>
To: "Xu, Qian Q" <qian.q.xu@intel.com>
Cc: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	 "Richardson, Bruce" <bruce.richardson@intel.com>,
	"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
	 "Zhang, Helin" <helin.zhang@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ixgbe: avoid unnessary break when checking at the tail of rx hwring
Date: Mon, 28 Mar 2016 16:48:17 +0800	[thread overview]
Message-ID: <CAP4Qi3_POihX25PHyxyxqkOXGA8JZJYwQeBK7NeZU9GJjA25Ag@mail.gmail.com> (raw)
In-Reply-To: <82F45D86ADE5454A95A89742C8D1410E032143C2@shsmsx102.ccr.corp.intel.com>

Hi Qian,

On 28 March 2016 at 10:30, Xu, Qian Q <qian.q.xu@intel.com> wrote:
> Jianbo
> Could you tell me the case that can reproduce the issue? We can help evaluate the impact of performance on ixgbe, but I'm not sure how to check if your patch really fix a problem because I don’t know how to reproduce the problem! Could you first teach me on how to reproduce your issue? Or you may not reproduce it by yourself?
>
It is more an refactoring to original design than fixing an issue. So
I don't know how to reproduce either.
Can you use your usual performance testing cases first, and see if
there is any impact or improvement?

Thanks!
Jianbo

  reply	other threads:[~2016-03-28  8:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-14 14:25 Jianbo Liu
2016-03-16  6:06 ` Lu, Wenzhuo
2016-03-16  7:51   ` Jianbo Liu
2016-03-16 11:14     ` Bruce Richardson
2016-03-17  2:20       ` Jianbo Liu
2016-03-18 10:03         ` Bruce Richardson
2016-03-21  2:26           ` Jianbo Liu
2016-03-22 14:27             ` Ananyev, Konstantin
2016-03-25  8:53               ` Jianbo Liu
2016-03-28  2:30                 ` Xu, Qian Q
2016-03-28  8:48                   ` Jianbo Liu [this message]
2016-06-17 10:09                     ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAP4Qi3_POihX25PHyxyxqkOXGA8JZJYwQeBK7NeZU9GJjA25Ag@mail.gmail.com \
    --to=jianbo.liu@linaro.org \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=qian.q.xu@intel.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).