From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f45.google.com (mail-lf0-f45.google.com [209.85.215.45]) by dpdk.org (Postfix) with ESMTP id 3DB9B3238 for ; Thu, 13 Oct 2016 05:00:04 +0200 (CEST) Received: by mail-lf0-f45.google.com with SMTP id b81so109340097lfe.1 for ; Wed, 12 Oct 2016 20:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=lJcws+CuqCfxBnQiutw8vN1L40+D6Ryrsu/pvUsRqmQ=; b=RowKhrsw/Y1+06guUmLLBFVudqjrw/l1JaL1ZEY/SqrcR1gQKRs6Fs7967tuGun57n Ve1PviVrD5ij8LtSszeqGztVy0OjQ4VXvbyr3isOpHKnqXQ8NlQjRUOzhG3esEXkPzmp emVyhJ7myt5Lm88tQh38fPnhEV5sn7E2CtjsA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=lJcws+CuqCfxBnQiutw8vN1L40+D6Ryrsu/pvUsRqmQ=; b=F1lW7l+UXreVjE9n8s9de1zFzMdaHycPjx/nLESKEvnj0mK9lrjZCMzaIDi0exOxV0 9QY10oQ466AfaTTwBBcKN352XN24RdMlVvdKP6k0btyVNoF++bA/hosptCWhl9oVHQwx NlIwSKB1krhcFj1iI1WRmVnPmuYv7uORl+Vy72RgIgbdmN9Ar3DcqNSWIVF0Egq4l4xM lEA5r5yILUu0ohsXqBzh7+thBXeZttB2vTzkeAk1wjCUAZhR6pdooqbbEGHMdW2u1XtR Utlfin43myY3YcmEhmFf0uiDu+rnf7noPKjVmd8XNX6puBA/W9yw8BBFMgaAHhS0z7dQ 283Q== X-Gm-Message-State: AA6/9Rmrq9AhHVT1RHdHsMNUn8uOPMIGK3CZmFmBMhkv+iG8iAlkTtbhBm2PhXVeZ755YyX/9jjMPTwepPTpnOJz X-Received: by 10.194.125.144 with SMTP id mq16mr5201887wjb.35.1476327603773; Wed, 12 Oct 2016 20:00:03 -0700 (PDT) MIME-Version: 1.0 Received: by 10.80.172.121 with HTTP; Wed, 12 Oct 2016 20:00:03 -0700 (PDT) In-Reply-To: <039ED4275CED7440929022BC67E706115065A1BD@SHSMSX103.ccr.corp.intel.com> References: <1472032425-16136-1-git-send-email-jianbo.liu@linaro.org> <1472032425-16136-2-git-send-email-jianbo.liu@linaro.org> <039ED4275CED7440929022BC67E706115065A1BD@SHSMSX103.ccr.corp.intel.com> From: Jianbo Liu Date: Thu, 13 Oct 2016 11:00:03 +0800 Message-ID: To: "Zhang, Qi Z" Cc: "Zhang, Helin" , "Wu, Jingjing" , "jerin.jacob@caviumnetworks.com" , "dev@dpdk.org" Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH 1/5] i40e: extract non-x86 specific code from vector driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Oct 2016 03:00:04 -0000 On 12 October 2016 at 10:55, Zhang, Qi Z wrote: > Hi Jianbo > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jianbo Liu >> Sent: Wednesday, August 24, 2016 5:54 PM >> To: Zhang, Helin ; Wu, Jingjing >> ; jerin.jacob@caviumnetworks.com; dev@dpdk.org >> Cc: Jianbo Liu >> Subject: [dpdk-dev] [PATCH 1/5] i40e: extract non-x86 specific code from vector >> driver >> >> move scalar code which does not use x86 intrinsic functions to new file >> "i40e_rxtx_vec_common.h", while keeping x86 code in i40e_rxtx_vec.c. >> This allows the scalar code to to be shared among vector drivers for different >> platforms. >> >> Signed-off-by: Jianbo Liu >> --- ... > > Should we rename the function "_40e_rx_queue_release_mbufs_vec" to > "i40e_rx_queue_release_mbufs_vec_default", so functions be wrapped can follow a consistent rule? I think these two ways are different. For func/_func, _func implements what func needs to do, they are same. We needs _func inline, to be called in different ARCHs. But for func/func_default, func_default is the default behavior, but you can use or not-use it in func.