From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AFA0B42C6C; Fri, 9 Jun 2023 10:35:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3D82540EDB; Fri, 9 Jun 2023 10:35:59 +0200 (CEST) Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by mails.dpdk.org (Postfix) with ESMTP id E9ED540A84 for ; Fri, 9 Jun 2023 10:35:57 +0200 (CEST) Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-3f9ac889629so1618771cf.0 for ; Fri, 09 Jun 2023 01:35:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1686299757; x=1688891757; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JWhdJ55hRgKc+uDBpbClilzo36ET05kGl5DQacuT+CM=; b=hh7Y2UFO8BHlG2FTGGk4eJ34pmcMS0KETZ5GI3Vpznwwzn44xMDglR6ZNkgTj2wvZF g0Sq8HMGIF1QZb0xd1AyevX8c1dPbnMS2Ey6FGaqBiR9UIppHZaKOpEjJWYXALJklU1B zEFn7PcGraMelIyD+r+e27hLUA++cMic5oRDOgTkCEJucpw3HO0CK/Hrb0588QM7B/o0 KDOFLP9Yzpev0x+4zf2Q+SDlBD5tHd0BW0SmWDe2QS8uoXwYtOTNWi0oSWQovhfsDTGI ofcryZsmpIiD7Vs5PdES8QjD7mpkymMlTeV8dFHXxG82dzNxjeUiiTfcVMadx0B47Cjd IaRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686299757; x=1688891757; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JWhdJ55hRgKc+uDBpbClilzo36ET05kGl5DQacuT+CM=; b=LkMqMnP/3DTZAtIgxmo0Rx+HE/hxMc35VwNMFMEkHkLO8zSqmFetTEeFf/QM7J/QdL L5zB3pMG9XDnF4wrspK/SmFmnF/FxySeQRpBUvp9cHTNJgDCLdWA3oN0n/QdlLl8eBuM Em/zRf0olBuqahQP3ZQOj4HPCO2eTZpVzqZvpgHht0RLUzupywBPUAH9MkRa/Oopm+uf jhgU+kEKfx1V52UIS2QJczn3SUDMSB6IWvmDBRTjpXKmybK4koaG8l/IiTKGlYY82hlI HIfGTugRO1YYGN2s6YHMqidOZjmI9p2Zl3HutQOkWGX8Gah1wv0nW2CZ7TozvukIts3A iy1w== X-Gm-Message-State: AC+VfDzLkDkNobznN23I1qF0CykRutlhLIU66OUFpu6auh7EJiYDDYWT uD8RZ1ujN2UWviDcqfYziuf5OBP0HAdF1iy5rzjshA== X-Google-Smtp-Source: ACHHUZ7/gz4ITbHY1wZrudboeIAYgQvp11LPwis9PeUboTzXlsXbnLD37oBS64/FKXxwvYad4Zaf04uRDfGsYEjs+6U= X-Received: by 2002:a05:622a:1009:b0:3f8:46d:dacc with SMTP id d9-20020a05622a100900b003f8046ddaccmr1117322qte.2.1686299757273; Fri, 09 Jun 2023 01:35:57 -0700 (PDT) MIME-Version: 1.0 References: <20230529112130.11198-1-changfengnan@bytedance.com> In-Reply-To: From: Fengnan Chang Date: Fri, 9 Jun 2023 16:35:46 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v4] eal: fix eal init may failed when too much continuous memsegs under legacy mode To: David Marchand Cc: Lin Li , anatoly.burakov@intel.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org David Marchand =E4=BA=8E2023=E5=B9=B46=E6=9C=88= 8=E6=97=A5=E5=91=A8=E5=9B=9B 04:33=E5=86=99=E9=81=93=EF=BC=9A > > On Mon, May 29, 2023 at 1:23=E2=80=AFPM Fengnan Chang > wrote: > > > > Under legacy mode, if the number of continuous memsegs greater > > than RTE_MAX_MEMSEG_PER_LIST, eal init will failed even though > > another memseg list is empty, because only one memseg list used > > to check in remap_needed_hugepages. > > Fix this by make remap_segment return how many segments mapped, > > remap_segment try to map most contiguous segments it can, if > > exceed it's capbility, remap_needed_hugepages will continue to > > map other left pages. > > > > For example: > > hugepage configure: > > cat /sys/devices/system/node/node*/hugepages/hugepages-2048kB/nr_hugepa= ges > > 10241 > > 10239 > > > > startup log: > > EAL: Detected memory type: socket_id:0 hugepage_sz:2097152 > > EAL: Detected memory type: socket_id:1 hugepage_sz:2097152 > > EAL: Creating 4 segment lists: n_segs:8192 socket_id:0 hugepage_sz:2097= 152 > > EAL: Creating 4 segment lists: n_segs:8192 socket_id:1 hugepage_sz:2097= 152 > > EAL: Requesting 13370 pages of size 2MB from socket 0 > > EAL: Requesting 7110 pages of size 2MB from socket 1 > > EAL: Attempting to map 14220M on socket 1 > > EAL: Allocated 14220M on socket 1 > > EAL: Attempting to map 26740M on socket 0 > > EAL: Could not find space for memseg. Please increase 32768 and/or 6553= 6 in > > configuration. > > EAL: Couldn't remap hugepage files into memseg lists > > EAL: FATAL: Cannot init memory > > EAL: Cannot init memory > > We are missing a Fixes: tag and this is backport material, right? Yes, this patch need cc stable@dpdk.org > > > > > > Signed-off-by: Fengnan Chang > > Signed-off-by: Lin Li > > Can I update Lin Li existing entry in .mailmap? Or is this a different pe= rson? Please help update in .mailmap, same person, thanks. > > > > Signed-off-by: Burakov Anatoly > Anatoly Burakov* > > > Reviewed-by: Anatoly Burakov > > Strange to have both SoB and Review tag from Anatoly. Maybe just leave SoB ? cc @ Anatoly > > > > --- > > lib/eal/linux/eal_memory.c | 51 +++++++++++++++++++++++++++----------- > > Is this issue affecting only Linux? Yes=EF=BC=8CWindows and FreeBSD is fine. > > > > -- > David Marchand >