From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D56942CC2; Thu, 15 Jun 2023 08:44:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1760F40DDA; Thu, 15 Jun 2023 08:44:50 +0200 (CEST) Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by mails.dpdk.org (Postfix) with ESMTP id 8D60C40A84 for ; Thu, 15 Jun 2023 08:44:47 +0200 (CEST) Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-3f9d6655604so10710351cf.1 for ; Wed, 14 Jun 2023 23:44:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1686811487; x=1689403487; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0XX2S4UnZSrKHRCcStQaYbdfsuHPhFG9CAaynFywObg=; b=U0JrY0JeT5+VlNc7Qfy+juj8fOGekuemKwquj8tQO0jwoSXdB8pMMq5QJ5qLTzuNVa BBu2OB2cHA3djOO5G0WCIauvSO922fFEm2QTmsC+DVfVCRmIB5ZbFgn/dwg/og5/R6dx vBzzGTTSRCjFZQr8RO8+ZTBOO7IoZ5XWUqyhUStcvL3U33TFcFkurphJDzK1Jq2KMGdx uPd88DNh+BG5En4WwUOCz5YpT0P9JuE6dkn5hxkOldpNG200LoiV7gADANRD3QY567fG f4Y0/vFE/jiVWva8PbSwt+AQY7T3S3kWP6dn8nlyPSoHhqugmMUe8WumUUdOE7Lq9bUB 5B7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686811487; x=1689403487; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0XX2S4UnZSrKHRCcStQaYbdfsuHPhFG9CAaynFywObg=; b=ke8An+Lxdg7Uv5W6gcbInBjfBS6hvdtkEvBC8bCdLg7q69pUXmNSTRwttdlTfDgNVF aMy8he8jGNSop6IsiT5B8KmNXhw1hNoXaj1AyLeu207zK3KZrgtDGdzTjZuX3WL3rccn 8B1qKZy8ZOiMFMuAt+tUjuDmWTW1yaOjatM8vUHF3gDxBEp6s/WhjXAQ1pL2FRqt/Uxw 8AOCZ0ucWfofXAwCIH7bnRaNRNl10WLpRlovh5vRCo4Fm7Gdh756zu0yDuZE4//jqyYE ZCAN9u4rVTiS+qn1L0dbeIz3Na8CRABCYUpQ7vJbLXWI6HWr+/14iqp0H5q5KKh9zOM0 5Jfw== X-Gm-Message-State: AC+VfDxCB8oXnfeIjG7QiXEsbmregBtUVtK98wdzfe7cK9Cdfld3/GIb DrYByHzJC1HMfitbBODU6I8us9ROFXCu2sYR7kxOgA== X-Google-Smtp-Source: ACHHUZ5/Y0oPsRknVJPL0XDmxgymBWnTKN+LoDlGBGN/7uQAqYkp+/1tm/JSHU/VbHjAMlWPxvoDU7JTngCrMIC4W6c= X-Received: by 2002:ac8:5846:0:b0:3f6:b465:8ccc with SMTP id h6-20020ac85846000000b003f6b4658cccmr21330700qth.1.1686811486281; Wed, 14 Jun 2023 23:44:46 -0700 (PDT) MIME-Version: 1.0 References: <20230529112155.11247-1-changfengnan@bytedance.com> In-Reply-To: From: Fengnan Chang Date: Thu, 15 Jun 2023 14:44:35 +0800 Message-ID: Subject: Re: [External] Re: [PATCH] eal: fix prompt info when remap_segment failed To: David Marchand Cc: anatoly.burakov@intel.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org David Marchand =E4=BA=8E2023=E5=B9=B46=E6=9C=88= 12=E6=97=A5=E5=91=A8=E4=B8=80 21:09=E5=86=99=E9=81=93=EF=BC=9A > > On Mon, May 29, 2023 at 1:22=E2=80=AFPM Fengnan Chang > wrote: > > > > when there is enough space for memseg, we should pormpt which > > config to modify, not just print numbers. > > I think you want to explain the case when there is *not* enough > objects declared in the static configuration. > Could you rephrase and fix the typos? > Uhn, this is a careless mistake, I'll fix it. :) > > > > > Signed-off-by: Fengnan Chang > > --- > > lib/eal/linux/eal_memory.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/lib/eal/linux/eal_memory.c b/lib/eal/linux/eal_memory.c > > index 0876974631..974db901b7 100644 > > --- a/lib/eal/linux/eal_memory.c > > +++ b/lib/eal/linux/eal_memory.c > > @@ -716,9 +716,8 @@ remap_segment(struct hugepage_file *hugepages, int = seg_start, int seg_end) > > break; > > } > > if (msl_idx =3D=3D RTE_MAX_MEMSEG_LISTS) { > > - RTE_LOG(ERR, EAL, "Could not find space for memseg. Ple= ase increase %s and/or %s in configuration.\n", > > - RTE_STR(RTE_MAX_MEMSEG_PER_TYPE), > > - RTE_STR(RTE_MAX_MEM_MB_PER_TYPE)); > > + RTE_LOG(ERR, EAL, "Could not find space for memseg. Ple= ase increase RTE_MAX_MEMSEG_PER_LIST " > > + "RTE_MAX_MEMSEG_PER_TYPE and/or RTE_MAX= _MEM_MB_PER_TYPE in configuration.\n"); > > This same log is in FreeBSD, so I guess we want to update it too. > > > -- > David Marchand >