DPDK patches and discussions
 help / color / mirror / Atom feed
From: Fengnan Chang <changfengnan@bytedance.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "Morten Brørup" <mb@smartsharesystems.com>,
	"Thomas Monjalon" <thomas@monjalon.net>,
	anatoly.burakov@intel.com, dev@dpdk.org, rsanford@akamai.com,
	bruce.richardson@intel.com, maxime.coquelin@redhat.com,
	david.marchand@redhat.com, jerinj@marvell.com,
	honnappa.nagarahalli@arm.com,
	"Fidaullah Noonari" <fidaullah.noonari@emumba.com>
Subject: Re: [External] Re: [PATCH] malloc: fix malloc performance may becomes worse as the number of malloc increases
Date: Thu, 16 Feb 2023 10:54:35 +0800	[thread overview]
Message-ID: <CAPFOzZvzbgv6+KE_4rpDFbJLAJhEtcTsE9wAhO044EeQi+JyEw@mail.gmail.com> (raw)
In-Reply-To: <20230215091616.1217c509@hermes.local>

Stephen Hemminger <stephen@networkplumber.org> 于2023年2月16日周四 01:16写道：
>
> On Wed, 15 Feb 2023 12:10:23 +0100
> Morten Brørup <mb@smartsharesystems.com> wrote:
>
> > Looking isolated at the patch itself...
> >
> > I agree with the way the patch modifies the ranges of the free list, and the consequential removal of the "- 1" from the calculation of log2.
> >
> > Intuitively, the lists should cover ranges such as [0x100..0x3FF], which this patch does, not [0x101..0x400], how it was previously... The ranges with this patch make much more sense.
> >
> > So if the existing code is otherwise correct, i.e. handles the size with/without MALLOC_ELEM_HEADER_LEN correctly, my gut feeling says this patch is an improvement.
> >
> > Acked-by: Morten Brørup <mb@smartsharesystems.com>
>
> It would be good to have a malloc performance test.
> Possibly something reused from some other project.

I have done some performance tests in SPDK before，maybe available for
your reference:

https://bytedance.feishu.cn/wiki/wikcnKWXQmN4qhyxLcWJqP4vrOs

In one word, the performance of 4k malloc has improved, and other
cases almost the same.

  reply	other threads:[~2023-02-16  2:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-10  6:30 Fengnan Chang
2023-02-15 10:10 ` Thomas Monjalon
2023-02-15 11:10   ` Morten Brørup
2023-02-15 17:16     ` Stephen Hemminger
2023-02-16  2:54       ` Fengnan Chang [this message]
2023-02-16 14:02     ` Liang Ma
2023-02-17  2:14       ` [External] " Fengnan Chang
2023-02-16 10:40   ` Liang Ma
2023-02-20 10:59 ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPFOzZvzbgv6+KE_4rpDFbJLAJhEtcTsE9wAhO044EeQi+JyEw@mail.gmail.com \
    --to=changfengnan@bytedance.com \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=fidaullah.noonari@emumba.com \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=jerinj@marvell.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=mb@smartsharesystems.com \
    --cc=rsanford@akamai.com \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).