From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from compass.polito.it (compass.polito.it [130.192.55.110]) by dpdk.org (Postfix) with ESMTP id 412B82B8C for ; Fri, 15 Apr 2016 10:23:38 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by compass.polito.it (Postfix) with ESMTP id 1756D10025D for ; Fri, 15 Apr 2016 10:23:38 +0200 (CEST) Authentication-Results: compass.polito.it (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=studenti.polito.it DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= studenti.polito.it; h=content-type:content-type:cc:to:from:from :subject:subject:message-id:date:date:references:in-reply-to :received:mime-version:received:received:received; s=y2k10; t= 1460708617; bh=OMlAJ68Rpv7OOYVJz4gaktE4gpy+1zaR3ujegjN0B6I=; b=O kbtSpqYrY2oMYMCfnbxCszzDJh/QOZUo48RQs/fj5toOC9IUs2k2hut1j5TNqBzI +2Z1JVCG/9ZyeCwX70Eqmad/eAh50WG/NmTPPVoGHqtrc6oHPvUlUXkd4DPvunTH Lhnc0WviHtTxFR4Mk3OWwDo4DPAwCJcjoEFXxQig2g= X-Virus-Scanned: amavisd-new at studenti.polito.it X-Spam-Flag: NO X-Spam-Score: -5.861 X-Spam-Level: X-Spam-Status: No, score=-5.861 tagged_above=-100 required=3.5 tests=[ALL_TRUSTED=-5, AWL=0.638, BAYES_00=-1.5, HTML_MESSAGE=0.001] autolearn=ham Received: from compass.polito.it ([127.0.0.1]) by localhost (compass.polito.it [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 1ClOrt2XEgYa for ; Fri, 15 Apr 2016 10:23:37 +0200 (CEST) Received: from mail-lf0-f41.google.com (mail-lf0-f41.google.com [209.85.215.41]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: s203403@studenti.polito.it) by compass.polito.it (Postfix) with ESMTPSA id 0AEB5100286 for ; Fri, 15 Apr 2016 10:23:37 +0200 (CEST) Received: by mail-lf0-f41.google.com with SMTP id g184so136912990lfb.3 for ; Fri, 15 Apr 2016 01:23:36 -0700 (PDT) X-Gm-Message-State: AOPr4FVO9MZNu/wNj75JyfvvsH7VYgwRi0RnOdOpQWN1LfJys7oyvqwvKAk82EwGOAsovJJ7sPFVFqy14xJQNw== MIME-Version: 1.0 X-Received: by 10.112.26.145 with SMTP id l17mr8586470lbg.106.1460708616448; Fri, 15 Apr 2016 01:23:36 -0700 (PDT) Received: by 10.25.0.198 with HTTP; Fri, 15 Apr 2016 01:23:36 -0700 (PDT) In-Reply-To: <570FADC8.8020705@intel.com> References: <1460641719-15231-1-git-send-email-mauricio.vasquezbernal@studenti.polito.it> <570FADC8.8020705@intel.com> Date: Fri, 15 Apr 2016 10:23:36 +0200 X-Gmail-Original-Message-ID: Message-ID: From: =?UTF-8?Q?Mauricio_V=C3=A1squez?= To: Sergio Gonzalez Monroy Cc: dev@dpdk.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] mem: fix freeing of memzone used by ivshmem X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Apr 2016 08:23:38 -0000 This patch does not compile when ivshmem is disabled: compile error: CC malloc_heap.o /home/patchWorkOrg/compilation/lib/librte_eal/common/eal_common_memzone.c(353): error #177: label "error" was declared but never referenced error: ^ I'll send a v2 solving this issue On Thu, Apr 14, 2016 at 4:48 PM, Sergio Gonzalez Monroy < sergio.gonzalez.monroy@intel.com> wrote: > On 14/04/2016 14:48, Mauricio Vasquez B wrote: > >> although previous implementation returned an error when trying to release >> a >> memzone assigned to an ivshmem device, it stills freed it. >> >> Fixes: cd10c42eb5bc ("mem: fix ivshmem freeing") >> >> Signed-off-by: Mauricio Vasquez B < >> mauricio.vasquezbernal@studenti.polito.it> >> --- >> lib/librte_eal/common/eal_common_memzone.c | 12 ++++++++++-- >> 1 file changed, 10 insertions(+), 2 deletions(-) >> >> >> > Thanks for the fix (not sure what I was thinking at the time). > > Acked-by: Sergio Gonzalez Monroy > >