From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id D885C1B802 for ; Tue, 17 Oct 2017 14:50:58 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Oct 2017 05:50:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,390,1503385200"; d="scan'208";a="163568065" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga005.fm.intel.com with ESMTP; 17 Oct 2017 05:50:57 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.22]) by IRSMSX151.ger.corp.intel.com ([169.254.4.108]) with mapi id 14.03.0319.002; Tue, 17 Oct 2017 13:50:56 +0100 From: "Stokes, Ian" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" Thread-Topic: [PATCH v1 1/1] rte_crypto.h: Fix compilation issue with Ofast. Thread-Index: AQHTRze8yuU3JB7LfEmGkrXxeI3cIKLn3iOAgAAgXVA= Date: Tue, 17 Oct 2017 12:50:56 +0000 Message-ID: References: <1508238255-30383-1-git-send-email-ian.stokes@intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjM4ZjI0NjEtNTMxMC00MWY1LWJiMzAtODE2NmVlMTFiZDIwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IiszejZMNWZNUHl4TkNrYituemdVYUlQM1FlZytOcThXWWZxVG9YajVaZ1U9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 1/1] rte_crypto.h: Fix compilation issue with Ofast. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Oct 2017 12:50:59 -0000 . >=20 > Hi Ian, >=20 > > -----Original Message----- > > From: Stokes, Ian > > Sent: Tuesday, October 17, 2017 12:04 PM > > To: dev@dpdk.org > > Cc: De Lara Guarch, Pablo ; Stokes, > > Ian > > Subject: [PATCH v1 1/1] rte_crypto.h: Fix compilation issue with Ofast. > > > > When compiling with an application that includes rte_cryptodev.h with > > Ofast, an error is reported regarding enumeration > > RTE_CRYPTO_OP_TYPE_UNDEFINED not handled in switch case in function > > __rte_crypto_op_reset(). > > > > Fix this by adding case for RTE_OP_TYPE_UNDEFINED. > > > > Signed-off-by: Ian Stokes >=20 > Since this is a fix, you should add a fixes line with the commit id where > the issue was introduced. > This case: Fixes: c0f87eb5252b ("cryptodev: change burst API to be crypto > op oriented") >=20 > Also, the title should be: "cryptodev: fix build with Ofast" >=20 > Could you send a v2 with these changes? Thanks for the feedback Pablo, will send a v2. Thanks Ian >=20 > Thanks, > Pablo