[dpdk-dev] DEV_RX_OFFLOAD_SCATTER for ixgbe and igb devices

[dpdk-dev] DEV_RX_OFFLOAD_SCATTER for ixgbe and igb devices

[Stokes, Ian]

Hi all,

Currently it's the case that for some NICs (e.g. igb driver or ixgbe driver based), scatter_rx needs to be enabled explicitly in the case where it was not configured before.

A patch submitted for ovs-dpdk proposes to check that the DEV_RX_OFFLOAD_SCATTER flag is present in rte_ethdev_info.rx_offload_capa before setting scatter_rx.

https://mail.openvswitch.org/pipermail/ovs-dev/2018-April/345901.html

While testing igb and ixgbe devices I spotted the DEV_RX_OFFLOAD_SCATTER flag is not set in rx_offload_capa.

As these devices require scatter_rx, should the scatter_rx flag be set for them as part of the eth_igb_infos_get() for igb and ixgbe_dev_info_get for ixgbe?

Thanks
Ian 
 

Re: [dpdk-dev] DEV_RX_OFFLOAD_SCATTER for ixgbe and igb devices

[Ferruh Yigit]

On 4/13/2018 3:52 PM, Stokes, Ian wrote:
> Hi all,
> 
> Currently it's the case that for some NICs (e.g. igb driver or ixgbe driver based), scatter_rx needs to be enabled explicitly in the case where it was not configured before.
> 
> A patch submitted for ovs-dpdk proposes to check that the DEV_RX_OFFLOAD_SCATTER flag is present in rte_ethdev_info.rx_offload_capa before setting scatter_rx.
> 
> https://mail.openvswitch.org/pipermail/ovs-dev/2018-April/345901.html
> 
> While testing igb and ixgbe devices I spotted the DEV_RX_OFFLOAD_SCATTER flag is not set in rx_offload_capa.
> 
> As these devices require scatter_rx, should the scatter_rx flag be set for them as part of the eth_igb_infos_get() for igb and ixgbe_dev_info_get for ixgbe?

I agree, since that offload is supported by PMD, should be in capability flag.
Would you mind sending a patch for it, we can continue to discuss on it?

Thanks,
ferruh

Re: [dpdk-dev] DEV_RX_OFFLOAD_SCATTER for ixgbe and igb devices

[Stokes, Ian]

> On 4/13/2018 3:52 PM, Stokes, Ian wrote:
> > Hi all,
> >
> > Currently it's the case that for some NICs (e.g. igb driver or ixgbe
> driver based), scatter_rx needs to be enabled explicitly in the case where
> it was not configured before.
> >
> > A patch submitted for ovs-dpdk proposes to check that the
> DEV_RX_OFFLOAD_SCATTER flag is present in rte_ethdev_info.rx_offload_capa
> before setting scatter_rx.
> >
> > https://mail.openvswitch.org/pipermail/ovs-dev/2018-April/345901.html
> >
> > While testing igb and ixgbe devices I spotted the DEV_RX_OFFLOAD_SCATTER
> flag is not set in rx_offload_capa.
> >
> > As these devices require scatter_rx, should the scatter_rx flag be set
> for them as part of the eth_igb_infos_get() for igb and ixgbe_dev_info_get
> for ixgbe?
> 
> I agree, since that offload is supported by PMD, should be in capability
> flag.
> Would you mind sending a patch for it, we can continue to discuss on it?
> 
> Thanks,
> Ferruh

Thanks for the confirmation Ferruh, will send a patch.

Thanks
Ian