[dpdk-dev] [PATCH 1/2] test: replace license text with SPDX tag

[dpdk-dev] [PATCH 1/2] test: replace license text with SPDX tag

[Allain Legacy]

Replacing full license text with SPDX tag.

Signed-off-by: Allain Legacy <allain.legacy@windriver.com>
---
 app/test/test_cfgfile.c | 32 ++------------------------------
 1 file changed, 2 insertions(+), 30 deletions(-)

diff --git a/app/test/test_cfgfile.c b/app/test/test_cfgfile.c
index 37435b395..01905920e 100644
--- a/app/test/test_cfgfile.c
+++ b/app/test/test_cfgfile.c
@@ -1,33 +1,5 @@
-/*-
- *   BSD LICENSE
- *
- *   Copyright(c) 2017 Wind River Systems Inc. All rights reserved.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- *     * Redistributions of source code must retain the above copyright
- *       notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright
- *       notice, this list of conditions and the following disclaimer in
- *       the documentation and/or other materials provided with the
- *       distribution.
- *     * Neither the name of Intel Corporation nor the names of its
- *       contributors may be used to endorse or promote products derived
- *       from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2017 Wind River Systems Inc. All rights reserved.
  */
 
 #include <stdio.h>
-- 
2.12.1

[dpdk-dev] [PATCH 2/2] doc: replace license text with SPDX tag

[Allain Legacy]

Replace full license text with SPDX tag.

Signed-off-by: Allain Legacy <allain.legacy@windriver.com>
---
 doc/guides/nics/avp.rst | 29 +----------------------------
 1 file changed, 1 insertion(+), 28 deletions(-)

diff --git a/doc/guides/nics/avp.rst b/doc/guides/nics/avp.rst
index 1fcba66ce..b3dbc2816 100644
--- a/doc/guides/nics/avp.rst
+++ b/doc/guides/nics/avp.rst
@@ -1,32 +1,5 @@
-..  BSD LICENSE
+..  SPDX-License-Identifier: BSD-3-Clause
     Copyright(c) 2017 Wind River Systems, Inc. rights reserved.
-    All rights reserved.
-
-    Redistribution and use in source and binary forms, with or without
-    modification, are permitted provided that the following conditions
-    are met:
-
-    * Redistributions of source code must retain the above copyright
-    notice, this list of conditions and the following disclaimer.
-    * Redistributions in binary form must reproduce the above copyright
-    notice, this list of conditions and the following disclaimer in
-    the documentation and/or other materials provided with the
-    distribution.
-    * Neither the name of Intel Corporation nor the names of its
-    contributors may be used to endorse or promote products derived
-    from this software without specific prior written permission.
-
-    THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-    "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-    LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-    A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-    OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-    SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-    LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-    DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-    THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-    (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-    OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 AVP Poll Mode Driver
 =================================================================
-- 
2.12.1

Re: [dpdk-dev] [PATCH 1/2] test: replace license text with SPDX tag

[Hemant Agrawal]

Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Re: [dpdk-dev] [PATCH 2/2] doc: replace license text with SPDX tag

[Hemant Agrawal]

Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Re: [dpdk-dev] [PATCH 1/2] test: replace license text with SPDX tag

[Peters, Matt]

> -----Original Message-----
> From: Legacy, Allain
> Sent: Tuesday, August 13, 2019 8:20 AM
> To: hemant.agrawal@nxp.com
> Cc: dev@dpdk.org; john.mcnamara@intel.com; marko.kovacevic@intel.com;
> cristian.dumitrescu@intel.com; Peters, Matt
> Subject: [PATCH 1/2] test: replace license text with SPDX tag
> 
> Replacing full license text with SPDX tag.
> 
> Signed-off-by: Allain Legacy <allain.legacy@windriver.com>
> ---
Acked-by: Matt Peters <matt.peters@windriver.com>

Re: [dpdk-dev] [PATCH 2/2] doc: replace license text with SPDX tag

[Peters, Matt]

> -----Original Message-----
> From: Legacy, Allain
> Sent: Tuesday, August 13, 2019 8:20 AM
> To: hemant.agrawal@nxp.com
> Cc: dev@dpdk.org; john.mcnamara@intel.com; marko.kovacevic@intel.com;
> cristian.dumitrescu@intel.com; Peters, Matt
> Subject: [PATCH 2/2] doc: replace license text with SPDX tag
> 
> Replace full license text with SPDX tag.
> 
> Signed-off-by: Allain Legacy <allain.legacy@windriver.com>
Acked-by: Matt Peters <matt.peters@windriver.com>

Re: [dpdk-dev] [PATCH 1/2] test: replace license text with SPDX tag

[David Marchand]

On Tue, Aug 13, 2019 at 2:20 PM Allain Legacy
<allain.legacy@windriver.com> wrote:
>
> Replacing full license text with SPDX tag.
>
> Signed-off-by: Allain Legacy <allain.legacy@windriver.com>
> ---
>  app/test/test_cfgfile.c | 32 ++------------------------------
>  1 file changed, 2 insertions(+), 30 deletions(-)
>
> diff --git a/app/test/test_cfgfile.c b/app/test/test_cfgfile.c
> index 37435b395..01905920e 100644
> --- a/app/test/test_cfgfile.c
> +++ b/app/test/test_cfgfile.c
> @@ -1,33 +1,5 @@
> -/*-
> - *   BSD LICENSE
> - *
> - *   Copyright(c) 2017 Wind River Systems Inc. All rights reserved.
> - *
> - *   Redistribution and use in source and binary forms, with or without
> - *   modification, are permitted provided that the following conditions
> - *   are met:
> - *
> - *     * Redistributions of source code must retain the above copyright
> - *       notice, this list of conditions and the following disclaimer.
> - *     * Redistributions in binary form must reproduce the above copyright
> - *       notice, this list of conditions and the following disclaimer in
> - *       the documentation and/or other materials provided with the
> - *       distribution.
> - *     * Neither the name of Intel Corporation nor the names of its
> - *       contributors may be used to endorse or promote products derived
> - *       from this software without specific prior written permission.
> - *
> - *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> - *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> - *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
> - *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
> - *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> - *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> - *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> - *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> - *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> - *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> - *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2017 Wind River Systems Inc. All rights reserved.

Once applied the two patches of this series, we end up with 3 kind of
copyright lines:

$ git grep -h Copyright.*Wind.River app/
 * Copyright(c) 2017 Wind River Systems Inc. All rights reserved.

$ git grep -h Copyright.*Wind.River doc/
    Copyright(c) 2017 Wind River Systems, Inc. rights reserved.

$ git grep -h Copyright.*Wind.River drivers/
# Copyright(c) 2013-2017, Wind River Systems, Inc.
 * Copyright(c) 2013-2017 Wind River Systems, Inc.
 * Copyright(c) 2013-2017 Wind River Systems, Inc.
 * Copyright(c) 2014-2017 Wind River Systems, Inc.
 * Copyright(c) 2013-2017 Wind River Systems, Inc.

Should I still apply them as is? or do you want to send a v2?


Thanks.
-- 
David Marchand