From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33257A0548; Thu, 4 Nov 2021 09:29:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AEAF840E5A; Thu, 4 Nov 2021 09:29:27 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id A341A40DFD for ; Thu, 4 Nov 2021 09:29:26 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10157"; a="230384878" X-IronPort-AV: E=Sophos;i="5.87,208,1631602800"; d="scan'208";a="230384878" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2021 01:29:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,208,1631602800"; d="scan'208";a="729962123" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga005.fm.intel.com with ESMTP; 04 Nov 2021 01:29:25 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 4 Nov 2021 01:29:25 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 4 Nov 2021 01:29:24 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 4 Nov 2021 01:29:24 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 4 Nov 2021 01:29:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gYrl0lOGPhFUiaw4ZH0STOO7Ps1+913GRxs2klJK6/PISLTP3ML3u0f3cJZ7cbZSTRAOt7ukhetq0acLmSdzlx4Y8VwvlZxq8NQc9LAs4NOwKIFAaGj5rgjFiHhlEuHca1PbOjz97rs6J5YkeRUv368KPcOXXpxyVQCrgldUVlgD90GT1pmLtUAmibCuOY6QJe2WkXaOS9nLsKuWvkp4naCiOo37lYsJ+Fs6bWNucyaTiW0GAMUIrWGqe/XiRL/XIgAHFuTFRR/Lqp0QEnljj4yXdEMI40Tww/NPNeUqWPTc6HwM5jN4yLSkT+3QynJQ6eDxYGZk8nj5SmAfRNQC2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dliN0Ab80NCmWIlr4yqXWKarQDdpO3KV4EOS5une0Mc=; b=Rr6CGD94lBCNdSCgOp/75iCAuyoI0b5dFvtVs0MX/NpykYydfxu77Wb/4N2UfEZQHtLOUrO8aFiL+5ICKSWpmvOJHOBv7VKav1+LqYjsH9zN1CWamT/JZ+qCxzBLOSefi9FJnMcWzjo2Cps5yWZEN8USPhZPfAdjYYWJpTcTKZt7zpjHpbHDpDrQ8ceDDBqSi8zKbGcg+jIvdpP43I1itmlavGEEUibVdJ85/w9zbfUILHT8RsGPR3HyO6PyRem4EpYNZa52KWMIosKo9+9o3mO9PiuHk3GEvCwVQ0OuhfavVJO+BslnQ74vyZXkH6WJgTV3F86f6QMc3Pp/kkHeOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dliN0Ab80NCmWIlr4yqXWKarQDdpO3KV4EOS5une0Mc=; b=p0v20lZwtHn5LzdNMM0+ym7pF9Ou5bvzSiwoCOirjnoEmH+z9RtI48TOeZCmDPLlKlCIvEnEuvXN66uQ2TuLLdJaX28HrW/IOrN/X6coxq33JIp7DK/retaJlPJZYdKyLI+OH8YbhHUsfAwmTUhICtBxb1+OwwTbZ0f4QfofR1k= Received: from CH0PR11MB5363.namprd11.prod.outlook.com (2603:10b6:610:ba::12) by CH0PR11MB5738.namprd11.prod.outlook.com (2603:10b6:610:113::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10; Thu, 4 Nov 2021 08:29:21 +0000 Received: from CH0PR11MB5363.namprd11.prod.outlook.com ([fe80::90cf:5b59:eef2:1128]) by CH0PR11MB5363.namprd11.prod.outlook.com ([fe80::90cf:5b59:eef2:1128%8]) with mapi id 15.20.4669.011; Thu, 4 Nov 2021 08:29:21 +0000 From: "Liguzinski, WojciechX" To: Thomas Monjalon CC: "dev@dpdk.org" , "Singh, Jasvinder" , "Dumitrescu, Cristian" , "Ajmera, Megha" , "Mcnamara, John" Thread-Topic: [dpdk-dev] [PATCH v20 0/5] Add PIE support for HQoS library Thread-Index: AQHX0EV1OEPWoGCvjUqjVWM89Xv1QavyFrKAgAD0qtA= Date: Thu, 4 Nov 2021 08:29:21 +0000 Message-ID: References: <20211028101802.4127295-1-wojciechx.liguzinski@intel.com> <20211102235750.422908-1-wojciechx.liguzinski@intel.com> <2054730.RCNjnC0MAg@thomas> In-Reply-To: <2054730.RCNjnC0MAg@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e31ef213-3119-4e6c-1ec7-08d99f6d33ac x-ms-traffictypediagnostic: CH0PR11MB5738: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rfLFYB5bcW1jSJc7aLHfZSAvh5fvKPMhPpcEsGZAP+u2tCLLTgOnQ7mLTMh/3++UtMQM9rUq1Ho2XDEIR/Ey+DTz3auMwtBggjBp7Hb1FmujdzVq3CllEpq2wgP228op3fWltWkJlz7ZxBXinr7x0xhKJPT42sp+RObGJT71eIAV1nxcfvUlKl8zXvLhdYG1Eo7hmtP+gq5Uft82wnKSNrZIZhsjA4sqN3/71ILgUUThNJkayDV2cQRzk5PYCHLeN1aHmByYmNX8lBqu8hNCg/uyS96TQ+Ph7oG/DaOic+iS9c2oDcmdoSO1JZW0GUA1b2HFCmu/rkL3rSaJnf9uzNMo9sDc2JkZJHY/pJuf8/DqGd0siA+UKxmBAbowxx3L+5/ZqBtT+w2UQ5I5VSoFOunn3baQm8RLxlA6tw4Wyx0Dyzl/fyF2r7Y3XshH51ngtLffa33cAAEsnYH1pRvLqGYJ94MJG6gJ8dKy1YBAKiNgmCCqiLZsSA6z0mZzHM7qQG9pBod+2e39It5NyAdBbZ5f98UgTqNcXWR9n+aevZYY0lYGFf+mghCu/1vXHg1GSUFIXY3CvIogigcUXqyzfNO4+v6mY5dttJyIeFulRH4NshCwyiYv3K41v+QISdl7PCyjmXLxS0f+7VGBMh6sP3+38jrAlZ35Pz+rVdK9c87mw9R74KdtHB70Tox7HztppdjHyO87mU2dA8XiW/sWZoKRZVhNK5W7xY6cssQPArLya19TPNO4GQbNgdGc/liYxP4rVLcNfzPonGcquy0dUHE5czBzfDwgP6Wkh+1e2+s= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH0PR11MB5363.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(316002)(52536014)(107886003)(186003)(6916009)(508600001)(76116006)(38100700002)(6506007)(9686003)(8676002)(55016002)(8936002)(26005)(33656002)(66946007)(2906002)(122000001)(53546011)(5660300002)(86362001)(966005)(71200400001)(66556008)(64756008)(66446008)(83380400001)(7696005)(54906003)(38070700005)(4326008)(66476007)(82960400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wr2JrFYnabAM8y2wcixyeHAJi7Anl2Jozq0lSIm95jzr021paO2+RJyIz6TT?= =?us-ascii?Q?/HABwQbQVkQHkNTUIMK1z782VOHwwYeOiw5Cm9BMl8KPP9nsBtIaJVtT+jt2?= =?us-ascii?Q?P+kF/Gz7bKtSlGlHd2RogkzAWNchmTj65fB0q2Z606Du68DgEUHMWGLWWwqg?= =?us-ascii?Q?kWPu11QtwFn8ifm5cAwoPKluO/Eo/BszIEwkp8aUP3t51suZf5gSqfe9kfaZ?= =?us-ascii?Q?y1xNawomSvQSCKYDq71EL88ujz/Z3nqgcM/eMxr7U7/YFvpIR1IIASFUPAb4?= =?us-ascii?Q?pMH3uxfpoEXeiO9SXza7H/5MEgqASds4KXp08aVxRsKxlnmX030UrqtlFe4C?= =?us-ascii?Q?QE4k4RzqBt1e+ESeI4XRU/O+GNtXwQt0ywnYIPkNM7x/qU1X6fZe9MI1mZsR?= =?us-ascii?Q?TvWfr8kzyDCcq2q4q05NyZ7aBUA3ltDx2JLLIf/CdHIQ7XoY5qCPbbsZnqIu?= =?us-ascii?Q?2B1MF3XZdGil2Kn+JgcZ+W2bep1x/NTENAgHBOYltj0eyKhVLVzglS8fikde?= =?us-ascii?Q?vq1AUHSAxPWNfJ6+jft6boguIJ8W3CJtLG739q+sffhoFfcz0Pq/HaR2WXCL?= =?us-ascii?Q?pXGboCr8IuYgBaW8i5zep5YGNezVm/23+/QZnrrrk5O/qvgxjGusptiekxSd?= =?us-ascii?Q?r44te0Kvv+7STtLlUWAcOKSTLMdsNBCbcbj9R9tlvLMNVTYYubDsWFB3x+f6?= =?us-ascii?Q?T7LKJFo6IjB4/3Yn2zV7m3ne5C03TIgKmHgOzPHRvhzU0sOGtDhYhjKHFC15?= =?us-ascii?Q?EohIhVkZDzigCRbZABJa3nRP/JK2EeexaQ522TUXByAQbXDREPXGxlT8tfgt?= =?us-ascii?Q?HEkrikPqxfC5Hu9nKCU8FwkC2N2c/FHoBdb2ZJCJjtQ8ZpG6Gemjz/Lmp0ew?= =?us-ascii?Q?YIKrMFRzbSIGilhvY7CUdcszxSaeNTC6dw+Wcg5H2l9pxEGpypy9QWANv+Hd?= =?us-ascii?Q?vhr//2EwK8N6kNWnAQobos7Y/jW74K3dZpX1vhZzCFASU3IXm5K3i6ZzoY1U?= =?us-ascii?Q?fX0DM4xKqtxuojU0LS7Lh+Zv9LufoIY5J58D3OGdSICLisWXNKLhbCEeLDQv?= =?us-ascii?Q?gJ0Lx54oFCNa8sAsMY/0jHyN3nvc1/S9KDoE1CS2kNPqr22g3hpXkWKRh9ZG?= =?us-ascii?Q?/bmNV0M4ps8EbQRkMo6KbEYjEiqqZk5CDY1UMEt0zdA3n8ga7IFOuT+1TLHr?= =?us-ascii?Q?0sGjiAy3PxKzGI0vhhAN17KLjdRb8b5QFmtD3Ljcg+1R43UWb6ERaRWgshNr?= =?us-ascii?Q?iy3i0o2YPMUfNplFSI22KevI5zQXRPWGgGCkgeAaONQfvXkJ/hNywBRalY7P?= =?us-ascii?Q?Osiw6sK87mWKq2AeU3D5gucONay87CAB58cDToR78+5XGFN+RU9GkvyxEuSi?= =?us-ascii?Q?DbELXnI4NbVoBG7BVp5gUenDTrwLkGGxRY4JdzqIrMIpJ6dkAXoY6Ke2+O5G?= =?us-ascii?Q?5fdBnK2rNi+bbMNZUUAw8greYRaMNg6a84S3yK+0+N7q1Pt2LdaHny0wF7Yq?= =?us-ascii?Q?kGJVHMeL2G+Dv8R19cXK18zY3u/Pjg9g4ZkoL6CFz1NPDhHcdNM52r9ZxxTz?= =?us-ascii?Q?76V04U1x9XMYcQUIEf7ysTSPhNI4dtvQLlNEMuC9ZQ4J3XdV1dKNc6OifWq/?= =?us-ascii?Q?d/plgNlRCZ0oB4dWFJACv6NruPH/pcwa00WLLpwF0zk8d9jly9bGND+C83WJ?= =?us-ascii?Q?sxnQzg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH0PR11MB5363.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e31ef213-3119-4e6c-1ec7-08d99f6d33ac X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Nov 2021 08:29:21.5680 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xnhUazSANFKhSEbgovJWHvqxI2ttVuld7WOfqhrW7o7U95/XOa1Nph2888cIuY2LzSEbIsVDQ9RmkB4A3vN8+3RpDQmoCgZV2shmOxlU+IU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5738 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v20 0/5] Add PIE support for HQoS library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, Thanks, I will apply your suggestions asap. Wojtek -----Original Message----- From: Thomas Monjalon =20 Sent: Wednesday, November 3, 2021 6:53 PM To: Liguzinski, WojciechX Cc: dev@dpdk.org; Singh, Jasvinder ; Dumitrescu,= Cristian ; Ajmera, Megha ; Mcnamara, John Subject: Re: [dpdk-dev] [PATCH v20 0/5] Add PIE support for HQoS library 03/11/2021 00:57, Liguzinski, WojciechX: > From: Wojciech Liguzinski >=20 > DPDK sched library is equipped with mechanism that secures it from the=20 > bufferbloat problem which is a situation when excess buffers in the=20 > network cause high latency and latency variation. Currently, it=20 > supports RED for active queue management. However, more advanced queue=20 > management is required to address this problem and provide desirable qual= ity of service to users. >=20 > This solution (RFC) proposes usage of new algorithm called "PIE"=20 > (Proportional Integral controller Enhanced) that can effectively and=20 > directly control queuing latency to address the bufferbloat problem. >=20 > The implementation of mentioned functionality includes modification of=20 > existing and adding a new set of data structures to the library, adding P= IE related APIs. > This affects structures in public API/ABI. That is why deprecation=20 > notice is going to be prepared and sent. >=20 > Wojciech Liguzinski (5): > sched: add PIE based congestion management Did you see the checkpatch issues on this patch? http://mails.dpdk.org/archives/test-report/2021-November/238253.html > example/qos_sched: add PIE support The strict minimum is to explain why you add PIE and what the acronym means= , inside the commit log. > example/ip_pipeline: add PIE support Title should follow same convention as history. For examples, it start with "examples/" as the directory name. > doc/guides/prog_guide: added PIE doc should be squashed with code patches Is there any doc update related to= the examples? If not, it should be fully squashed with lib changes. > app/test: add tests for PIE If there is nothing special, it can be squashed with the lib patch.