From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA417432D3; Mon, 13 Nov 2023 12:12:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C4C12402D8; Mon, 13 Nov 2023 12:12:52 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 3638C4026C; Mon, 13 Nov 2023 12:12:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699873971; x=1731409971; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=4vG9NxgZXNkuZJh8ybes82SajwkUIWOP87eHHwbm7t4=; b=JyZ+7uFJDkV/ZriifW9yGpqv3C8kwrvBJIstWpRFSkd+dC8sDNdSynMd sb2tVSEPjylri2yNIxUNfwehTexmvD73d1vi8Ytu5/GmHAVOPlKtEtrfa GG+o9gRSolwonYswGqV8yfKcgI4hiXfgB57AX3bKQzYdiqCvdMebHvLNs Y+j4lDUni27ZdzdJ2i1AEtQAPNjKj9qKX6KhVhC5iITRWjjlQOpJTNCPg 4ifTn108geDLqH3vMs1c8YWj4rS99xhKWbRbik2cNFIec/6ZQN8KyDjsS kPSZztg7aobMnEjHu7eaCHuEd2wWvAofHogfI7IiuDUGjI6kec1rfUAfb A==; X-IronPort-AV: E=McAfee;i="6600,9927,10892"; a="393280497" X-IronPort-AV: E=Sophos;i="6.03,299,1694761200"; d="scan'208";a="393280497" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2023 03:12:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10892"; a="793414813" X-IronPort-AV: E=Sophos;i="6.03,299,1694761200"; d="scan'208";a="793414813" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 13 Nov 2023 03:12:49 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 13 Nov 2023 03:12:49 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Mon, 13 Nov 2023 03:12:49 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Mon, 13 Nov 2023 03:12:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EJ0QVsdBEG0bULlN+EXRT08qdvMTcWVyHnP6IM2QlL+1l/LP7+xBqtsQdnknODfBXXJDPajbCfM3nbg266j55GGaTTqsl1GYZZTxF+sE1Z8twfV11RG0eqawTHs+SZL+yndO6nJ2dI+OZkqpPg0eLC/FTNczZrZ30ixdzvLnOMEV+T5nq2wQFVnys+eFg9teqmr7D/a96Qf4mhhdtOrlNch+osx7rfbtEkTsTW90uXyjjeQQ5nJLZSST39MY2D4nYtmD2HBkcJMeljq+hXHHRyMf6NFeGR9FCO4x2W2TIrGzbp8srxKH+S3RHPHfB9TLQMbiGFbf0qvvvwcbCoTs5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4vG9NxgZXNkuZJh8ybes82SajwkUIWOP87eHHwbm7t4=; b=Cl6cOLV4NMmEQSFi5k+V4v9fNsO1L/qCtTbZPysP3mhbSpxvdzWe0ZLKLKiJYb9vt0RgGehNSVH2lWV+P2+okd5prfBzQ/TPjksM62hoMeowdiei1w6nCyGqD9vkue9YtR0+ad1CzQ6MBL7Se+cGQqViM5AMFtumAxQZViOJydyml1k90qmfEPYHNK6b90EfoRkqV9OxeqJ0+9wfi/yHTMfELiUlUvOTWAYWgrocvOu688D6ec4Q1pw6jm0VzE4JW8kB4VKASF0FByJmdZ9j5WSRRUOmOZYN3NHMtGWfw0Ts/uDtiNCIT9UbVbSdISPU33AzjBNyXQntYmj0r4hyaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CH0PR11MB5492.namprd11.prod.outlook.com (2603:10b6:610:d7::21) by CY8PR11MB7033.namprd11.prod.outlook.com (2603:10b6:930:53::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.29; Mon, 13 Nov 2023 11:12:47 +0000 Received: from CH0PR11MB5492.namprd11.prod.outlook.com ([fe80::1c80:b235:13c4:13be]) by CH0PR11MB5492.namprd11.prod.outlook.com ([fe80::1c80:b235:13c4:13be%5]) with mapi id 15.20.6977.029; Mon, 13 Nov 2023 11:12:47 +0000 From: "Cornu, Marcel D" To: "Karas, Krzysztof" , "Ji, Kai" , "De Lara Guarch, Pablo" , "Power, Ciara" CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH v2] crypto/ipsec_mb: do not dequeue ops after flush Thread-Topic: [PATCH v2] crypto/ipsec_mb: do not dequeue ops after flush Thread-Index: AQHaFggLmbF+R1Uy80K8eRBPc0z/+rB4GEPw Date: Mon, 13 Nov 2023 11:12:46 +0000 Message-ID: References: <20231113080158.3872440-1-krzysztof.karas@intel.com> In-Reply-To: <20231113080158.3872440-1-krzysztof.karas@intel.com> Accept-Language: en-US, en-GB Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH0PR11MB5492:EE_|CY8PR11MB7033:EE_ x-ms-office365-filtering-correlation-id: 44839133-7a7f-46ca-0588-08dbe4397745 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: I+u5ocJaaKtDWLRXTMNGKnlW9nKjfH4Y5d320YYxTEzldKe7INX5dERXyANwKn6LrPfSK0POzBP8o4fispYcKYc03x8Yo9cXI7d8Cx/pAmBSNRAeesHwNMCa7YisskklfUzkFKNNdLHizm17l8zwy+PPK4G9JaISSqnfsPVPhVqEX18SLgNcQkhcBrF4MRz/yvxBY0Ol6CMBooL4424yC4NWqMrJEfWlpRetR7ILThL5sIca8z7nhJgwZ9N6GB8sQZ9SiWvwzStLeMiq4m+FxuW+TxMhZKY8FU/v+q1ruY46/RkXRANdwfcZ7dLh3RllEYktIfyt+4AwiI5eyUrEa7Wi47dsR6v4T1R4EZ2NcYX6/lePk8YhGcatVTcJCHKYxTwFxOoHsfFfwRNpiYK5DQM8O1K+pkkTaSVbaB0PtO3Tvs3uJyJrKMdHvhAi/Vg3sLOuzQwyVXvcy+OPxpjkZsOwSLj4NTXRnHl56TUiu2HLaPaQMkJLsg+15XvtBTuKsMs2la13I6KToTk0+jdKcn86uYWvmq2qe4KRUDlgvRm/EeLVHDkMTKXl5AMbocwvdkS2ujtbagQ0Y+I0FgqQcueOppHpQwPFGgfA3IdEenI= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH0PR11MB5492.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(366004)(346002)(39860400002)(376002)(136003)(230922051799003)(451199024)(186009)(64100799003)(1800799009)(6636002)(26005)(6506007)(7696005)(53546011)(71200400001)(9686003)(83380400001)(5660300002)(4326008)(8936002)(8676002)(52536014)(4744005)(2906002)(41300700001)(450100002)(478600001)(316002)(110136005)(54906003)(64756008)(66446008)(66476007)(66556008)(66946007)(76116006)(122000001)(82960400001)(33656002)(86362001)(38100700002)(38070700009)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bEnOjD9eqaCORBa/nmnaLmHwEOunak5l4BKu4VEbjFN1VFL0qOeRtv0LddKV?= =?us-ascii?Q?DA5QY+9Cr59D96eNXmx9oLiPepb/D2asVhMuqwpDeduHDFYPUVh8KyZada+F?= =?us-ascii?Q?0F/Z7GhCo2Fq9pj3dlx06PoOhD3QUpx2/z9q1kjh1r7zXnRxjxjtpmgQROXx?= =?us-ascii?Q?vGUz5igFF20pn2eajh0bqac3uP7d8SsrQE2PoJDxI8MZKBMSlUrpq1+G/PH5?= =?us-ascii?Q?0LlabKRqIE5SC4DwFa80WNS3jclh0Lzalgq8WBsOOBjwga/7T+JodGJT3sPN?= =?us-ascii?Q?kBjYndsTYm/+6A1pVoNQzGUK5GZSF4PMzEzS6zI6WKzX6nQbwWXZuk3Fjqt8?= =?us-ascii?Q?g2jLt68Uc0LxiVfWZnU6AFzK649A6HzVaDzG3iij6AMMfff6DE5Tj/wvSqxJ?= =?us-ascii?Q?UyQNszGg9uatvRXx4rOmB0w5BpGl2hLDWgBFFBrBe7xHOibufGF5MkkEq/wj?= =?us-ascii?Q?cZF77UYbL4Sj1PmD+2j4r8y8YMqIhicLDNwLnKphiof5CFDyb2ipb5OS9uhR?= =?us-ascii?Q?eMXx5RyMRufXUi7grp8MIbWVki/7VpWjY1n8WNxzC9AGzAE3poiKl08BsMy4?= =?us-ascii?Q?h55IuO0w4fh64+oqThGtC5aIzmIM2uhvnz1/xviEtoQqaoVLrSOFjvQbfaSB?= =?us-ascii?Q?KapKixaQuDvHLoUYGZmZLQ8wzDy5SyqsGjJnlP1Hxugr/y30KBURQRA+H6BV?= =?us-ascii?Q?vzQl6SJZY/Jb4VcHfYzw5xK/l1MTry6qcsd4joGlKz10IlnS0qrsKRLonXF4?= =?us-ascii?Q?srlidBJmQSbPQoBhdgEOOjAUfk7czyBDRDHQ+zq8jL1lcT7WuqqwxTXKKYnY?= =?us-ascii?Q?Om09Ywr0yw7JWppMWL2k6biXvpM8rCYYoyxqeSJ7MHHbAIVSBMGpOy8hknBw?= =?us-ascii?Q?aVRU8fJ6sX9GzDKj++IcxQqX7F1XGCguTzyc5QKOt7ultmE+RUt0EQAnozeD?= =?us-ascii?Q?00hBi/wYPHCxW9nNADf/hd9bra5jLN3mQQDGwuCk5sGZn4s4BWc23NhsZzaO?= =?us-ascii?Q?8sJKbn34qnwM4qcBBZFS6Ppvkl/aTN1vImLziUnJriaA3S82KReN5Ql3jOYm?= =?us-ascii?Q?FSbeGHpbD9ww3U/27MRnnmrS4GLR+KgztO+6L6TvMGZzA1jrEYvZI5sFAxv6?= =?us-ascii?Q?uGInaftt5nbDpKsu+//Wrj1vtdD0tIJ69NXYVKbfdQYQ7RvZ9gS8cG1UO4ae?= =?us-ascii?Q?WOH+VAtCEUgxbb7Klc7bKcjVCq1athOwGyJFEncUHBBnxQrh3VTQW427LWl+?= =?us-ascii?Q?IC0Cic/vOVuIlsWNQtfTsfnX4ZGmG2j90b4R1D5xzw+1j7XA6ItHqLVE4F7G?= =?us-ascii?Q?2Gkqv6ILO7EEK1URYXKKBGqNJyapsOtmD1SleNovRsqqORNK78x64weQGDmE?= =?us-ascii?Q?iK8CaPQ+XQJ479678uh+khVerOd9oZyTOZPu7oyOTsJSWbiis6Q3w78WIhmb?= =?us-ascii?Q?FFi4tQ5A8Pj7cm6+yG9YfL8jGtJVgASod0rQ9l+bIg9pyGZ+hl3hx55BqlCH?= =?us-ascii?Q?s8igehnpZYNdlq6zeR+xbmcNIjXcNwjkIJe68aZ8CvB4AwSkEv4MDF0lGij3?= =?us-ascii?Q?kw2LanmBppvMnbbcgfwcd95Y8dMf+ol7LugiWaL9?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH0PR11MB5492.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 44839133-7a7f-46ca-0588-08dbe4397745 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2023 11:12:46.8134 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8B1ACND+tdMh/j+K8gsKJtTl6b7XtSAqH8Mx9W7qgWlcd2P2i65/vqluwkU1PH97uoum3dHdvufDkn4x0QpQl7GSH/+6OpOIVIYHnf/ZoFo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7033 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Karas, Krzysztof > Sent: Monday, November 13, 2023 8:02 AM > To: Ji, Kai ; De Lara Guarch, Pablo > ; Cornu, Marcel D > ; Power, Ciara > Cc: dev@dpdk.org; Karas, Krzysztof ; > stable@dpdk.org > Subject: [PATCH v2] crypto/ipsec_mb: do not dequeue ops after flush >=20 > Previously it was possible to increment `processed_jobs` to a value great= er than > requested `nb_ops`, because after flushing at most `nb_ops` jobs the whil= e loop > continued, so `processed_jobs` could still be incremented and it was poss= ible for > this variable to be greater than `nb_ops`. If `ops` provided to the funct= ion were > only `nb_ops` long, then the `aesni_mb_dequeue_burst()` would write to th= e > memory outside of `ops` array. >=20 > Fixes: b50b8b5b38f8 ("crypto/ipsec_mb: use burst API in AESNI") > Cc: stable@dpdk.org >=20 > Signed-off-by: Krzysztof Karas Acked-by: Marcel Cornu