From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4708A0548; Tue, 27 Apr 2021 13:19:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 58EF440142; Tue, 27 Apr 2021 13:19:26 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 64BC84003D for ; Tue, 27 Apr 2021 13:19:24 +0200 (CEST) IronPort-SDR: y/7jWn+2sBpzAE4bcNuUY/G1dJqBJzFs+Ns3QnktYPzq6kwNeDxODBL3stDMHQhBn7xfm1OR3m mljC0QaqpM8w== X-IronPort-AV: E=McAfee;i="6200,9189,9966"; a="281822170" X-IronPort-AV: E=Sophos;i="5.82,254,1613462400"; d="scan'208";a="281822170" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2021 04:19:23 -0700 IronPort-SDR: uc7JX9L2mN28e7jMykpP0YMmpv2htCcPWNN8zNFnnG8Wp+MHcwGzjNNk+DD8YpREVB/jyfWF36 7W2w7xURo/zg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,254,1613462400"; d="scan'208";a="423012873" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga008.fm.intel.com with ESMTP; 27 Apr 2021 04:19:15 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 27 Apr 2021 04:19:15 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 27 Apr 2021 04:19:14 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 27 Apr 2021 04:19:14 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.177) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 27 Apr 2021 04:19:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jkAKbIna0+nb55GZeQUPRO7sphHKHMi1vmXR3nWpx8UPe+BjQ18CbWVxKlaMDrnGNOFTK0Srapky9ATL+03JKzfxsN0Giyf6cw8bP8JgcsN4ZMI6AF7LcHJcFfwl7aIs9xZ3lw0BnhEMZqG7If++mo2ciESXlYwrX82TuMD9s0KoOlhkWJnFINW/079WoDoNU8s3sH0MC1m5VIehJH+MgmIK+cw3vEXBwqaMxWOWst/Uy+cc9sPGHL6BlTjaeGY7/7lC/Zsva0Q5G+8MBO5Y1KkORtTAj+A2u3QyBbvgnBVDW3ANg8bZHvGn4QLyig0C6XPXe3MWAtc/KFtR4czAFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CPN4aWyK9rRxTLynx6XQsORX8hR9LNeN6uxCtcpn0sc=; b=ToxGzWA3HCErAq+CHGLj+Leq2Y9K7zsJhHXbkxzn4Xx31zsuBY3nOwCf0O3+v5CqQw7skZjCU3Qy93kDQDRJfMIsUD7nGkIv0uttIjg3BzyuqxTz2jUqp49tQ0C7MgXo+ELYTZZivH4yHU11EkX2qxz/mQRP3142hK04Cwsx2QZmmIDqZFlfIeDiymYHHnHBsC/bvNdOiiU7nedG/AlYpGUcrzt2jspuQ16Lpnz1g66ski+cltJOP592BJUN+in31zSlXoDWCDCPDgGWZldGM1UPr4uE6KR1QIA4LSPa8IE+/LTeQKHbgALbZb46k9c0ZcDBQZgDtWSLngCljzqPwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CPN4aWyK9rRxTLynx6XQsORX8hR9LNeN6uxCtcpn0sc=; b=dMBzvH27BgUp4mlSxe99H+M//S7SYfYWGDMGqFAPvZgboJwx0YFiAUTrIbnfpeAawRLYiQy8FuBu2snoNptEh9K8N9XHVON3K3WpNyQ7Lv6+8Pi1dx3wIy3aHfZlanmG4Nl00kmOiGy5Lih70VgpMQMKlA2hrWskLcGzFzrLIxw= Received: from CH0PR11MB5523.namprd11.prod.outlook.com (2603:10b6:610:d6::15) by CH2PR11MB4200.namprd11.prod.outlook.com (2603:10b6:610:3d::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.25; Tue, 27 Apr 2021 11:19:11 +0000 Received: from CH0PR11MB5523.namprd11.prod.outlook.com ([fe80::b1fa:6c6b:1a23:5411]) by CH0PR11MB5523.namprd11.prod.outlook.com ([fe80::b1fa:6c6b:1a23:5411%4]) with mapi id 15.20.4065.027; Tue, 27 Apr 2021 11:19:11 +0000 From: "Li, Xiaoyun" To: Huisong Li , "dev@dpdk.org" CC: "Yigit, Ferruh" , "linuxarm@openeuler.org" Thread-Topic: [PATCH V3 3/7] app/testpmd: fix a segment fault when DCB test Thread-Index: AQHXNcPBaIIVqEzxeUOGzYKOOVVRlarIPu5Q Date: Tue, 27 Apr 2021 11:19:11 +0000 Message-ID: References: <1614939741-63927-1-git-send-email-oulijun@huawei.com> <1618909266-17584-1-git-send-email-lihuisong@huawei.com> <1618909266-17584-4-git-send-email-lihuisong@huawei.com> In-Reply-To: <1618909266-17584-4-git-send-email-lihuisong@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.54] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cdcf12cc-ca71-42b0-96bd-08d9096e4890 x-ms-traffictypediagnostic: CH2PR11MB4200: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4IX39t64pk0PXWthS2bOYTfTpDRL+EVWIW1Ff39k9dY2cDx7fDLCBMzZoKqHLV+ai8FDCXruAvtogL0tv3m1ZVNVcDLEwNLECodHp9l+VyniTU2u6KiwColi0kB3fF1Bt4p1R4fGH/DbqCZsG1Wz7z7s2T89Zc4YV7cyQNZmkwnvgrlnXyARGS0e0wYzhict7prdQEBpuDWDTk5utm4CtsszuGNU14c25K4mx1bVdfrjEQ3Mo4B03gIVS2Tn6OG2Mzaw2dy3SdsyQ/J/WWthQINcN+mFDr7/y6qdX/2sm8KQv6SKxXxZShA+vcuSNgdHkFSsihvDIow34fxRmjD21jkmggqZQNA5RBU4s1e9KbMjZV4stl+CUv9pLCl6dgmVt0dw0ZT4r2mujIHyZLUBS6R0/IdFM67TaQeiatyMl89jzSlOKvGWMJRMoepEhzXd2Esfk1YMu7m6KvZqqdwhMe88MUVIWrFVafRKpn0fK67AteF4OYYtLmZ/G5tHwddXvcY3qMkbSQ640m6oUq9oPc1jXAZ4tQ7rq8fwvmqoUk23UGuUv4W+3ZDhgUhg547Eg6jtJdTmaPKrl0N0dqNWLGWUn11tekkxGXIBGsy1Zhw= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH0PR11MB5523.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(136003)(376002)(39860400002)(396003)(346002)(66556008)(64756008)(66446008)(66476007)(66946007)(33656002)(76116006)(186003)(86362001)(26005)(316002)(52536014)(6506007)(71200400001)(9686003)(55016002)(83380400001)(5660300002)(2906002)(38100700002)(122000001)(7696005)(4326008)(8936002)(478600001)(110136005)(53546011)(54906003)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?bz8U75uPXJP318kG+Rvr+/V2RnqzscQs13R05pPuOzRAhk+kVM1tC1duMBMS?= =?us-ascii?Q?+U6povPj2r5ArdLQyzKi6eaRl7BX59BQ35xgXMs6/fRMM3Stl3L31Iw4yokY?= =?us-ascii?Q?gk1BchiFIJdEKwREZNXLdhsVAHyM/a3foIu56Ol2IRDlc1os8JychHlbornN?= =?us-ascii?Q?Q0X8+KiY6/ZmLirmaaU4Tif1n7BsWjWEFmoLoescDapzpNIfdq5HKwi/iU8f?= =?us-ascii?Q?GpvM35pjB8/uXQxQS8TAz4NfHDzbar71bv7LMu/ZmXcdjjU4ZvcTtsq0olNL?= =?us-ascii?Q?Ew9N+TFC6byiZ1or+2Z2urwOjvoB+/nJRCOnkm0TT7TdNvVdOeAsh+g7acP2?= =?us-ascii?Q?Yz0Xwr1B7+PddGWZ0lGnoHps5Or5F7pIfG8BxlZpBzPg96qH7rHMR3yTlvbN?= =?us-ascii?Q?FPvA7W5c7tNImDJiDqpPPh2UOzVHjdlsz7te3+F/hbs0vTdNdq1S/Qq2QFFK?= =?us-ascii?Q?ZreKYf7ditqNnSRAYXnoKx8QnSLCReDzq5B6Cl65JWC2mkY54mJ5vOmfo6Rw?= =?us-ascii?Q?hZ2JHdNBXOoT+Amj3jUbJzBog/GXmUF4ClM/qieLXI2wi/GsqzXK7VzqypWn?= =?us-ascii?Q?dfLtZkG+HqlAvf+D+4o6KngN0JCGuZCHJ/w79C2BPT42UdxYuvNG+drWVDfg?= =?us-ascii?Q?IK7x3M4O+D6DiosTcRhcXPzPKUY6JiTrbHCkDmNUpF4BuRGXRAY6tvxDGnUN?= =?us-ascii?Q?4zwAo+LOIF7oufHFaLFWWEkiKOf+p7V/FVEgDsUb7F3Jyag//rI/HAPGhwxA?= =?us-ascii?Q?eIJIdYzBFis6+GVW7zsLPK5X6mSaXw6VJTZoN6xdsnsNfytfIu10NFFIcX1Y?= =?us-ascii?Q?4H592rxCi/ohE3IljOikoA+TGaM4DeFpvp4w2X1CfOIKCoSoZNOTy/BmATMY?= =?us-ascii?Q?X++aAiqOoRZ3xvB+tWrNjfkhdEmCkXGcTLH4tj01UuVNbabsLpSRQiXJcEGl?= =?us-ascii?Q?dfyk27I6+1qAIayKS4NpkpaIJv0m8XoKIpgukcrzKkoT8AGoBExdA8ad6Qh4?= =?us-ascii?Q?chUGkQJ5+qZgI9PXqz+qLCJMigoIutqG/htkUuBFyFduBqKWhU+2INUMmm8g?= =?us-ascii?Q?AYSU3h+bwrVAKGMUEbRXZ7llZ4aMokrB/8Zp8m3MPvHrKyLu8jiY4fLmRV8k?= =?us-ascii?Q?FTDJ1PeN8XGDaDCtMAfrrf8upBeEEs9AEvGi32aRyEk8vVY3fuzGIDdaYZmb?= =?us-ascii?Q?Cub/bVxB6SJPBkSpy6eaEs2Pwz51PZ42gn6JIlnaW2uYDPT2UqOzCrtneo02?= =?us-ascii?Q?Hndn8d4tDGuxOVLhfe7GiexPtrt6kPlKi/oIP9tn2MLMrPxMhtVvpLPnmrjk?= =?us-ascii?Q?yn0=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH0PR11MB5523.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cdcf12cc-ca71-42b0-96bd-08d9096e4890 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2021 11:19:11.6690 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pqAAgHtUw3URt5hIx2vxy8eF3tfZ1n1H7ghLz8xhEJiX1kG1H3Gjcn5Fa0hR7HsSgR6e1S5AgdS1TghbjLnCdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR11MB4200 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH V3 3/7] app/testpmd: fix a segment fault when DCB test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Huisong Li > Sent: Tuesday, April 20, 2021 17:01 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Li, Xiaoyun ; > linuxarm@openeuler.org; lihuisong@huawei.com > Subject: [PATCH V3 3/7] app/testpmd: fix a segment fault when DCB test >=20 > After DCB mode is configured, if we decrease the number of RX and TX queu= es, > fwd_config_setup() will be called to setup the DCB forwarding configurati= on. > And forwarding streams are updated based on new queue numbers in > fwd_config_setup(), but the mapping between the TC and queues obtained by > rte_eth_dev_get_dcb_info() is still old queue numbers (old queue numbers = are > greater than new queue numbers). > In this case, the segment fault happens. So rte_eth_dev_configure() shoul= d be > called again to update the mapping between the TC and queues before > rte_eth_dev_get_dcb_info(). >=20 > Like: > set nbcore 4 > port stop all > port config 0 dcb vt off 4 pfc on > port start all > port stop all > port config all rxq 8 > port config all txq 8 >=20 > Fixes: 900550de04a7 ("app/testpmd: add dcb support") > Cc: stable@dpdk.org >=20 > Signed-off-by: Huisong Li > Signed-off-by: Lijun Ou > --- > app/test-pmd/config.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) >=20 > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index > 03ee40c..18b197b 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -2996,7 +2996,33 @@ dcb_fwd_config_setup(void) > uint16_t nb_rx_queue, nb_tx_queue; > uint16_t i, j, k, sm_id =3D 0; > uint16_t total_tc_num; > + struct rte_port *port; > uint8_t tc =3D 0; > + portid_t pid; > + int ret; > + > + /* > + * The fwd_config_setup() is called when the port is > RTE_PORT_STARTED When the port is RTE_PORT_STARTED or RTE_PORT_STARTED? Missing an 'or' here= . Maybe something like the following will be better? (just a reference, you c= an put it in a better way) /* * Re-configure ports to get updated mapping between tc and queue in case = the queue number of the port is changed. * Skip for started ports since configuring queue number needs to stop por= ts first. */ > + * RTE_PORT_STOPPED. When a port is RTE_PORT_STARTED, > dev_configure > + * cannot be called. > + * > + * re-configure the device after changing queue numbers of stopped > + * ports, so that the updated mapping between tc and queue can be > + * obtained. > + */ > + for (pid =3D 0; pid < nb_fwd_ports; pid++) { > + if (port_is_started(pid) =3D=3D 1) > + continue; > + > + port =3D &ports[pid]; > + ret =3D rte_eth_dev_configure(pid, nb_rxq, nb_txq, > + &port->dev_conf); > + if (ret < 0) { > + printf("Failed to re-configure port %d, ret =3D %d.\n", > + pid, ret); > + return; > + } > + } >=20 > cur_fwd_config.nb_fwd_lcores =3D (lcoreid_t) nb_fwd_lcores; > cur_fwd_config.nb_fwd_ports =3D nb_fwd_ports; > -- > 2.7.4