From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: "Ajmera, Megha" <megha.ajmera@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Singh, Jasvinder" <jasvinder.singh@intel.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH 3/3] sched: support for 100G+ rates in subport/pipe config
Date: Tue, 11 Oct 2022 13:09:14 +0000 [thread overview]
Message-ID: <CH0PR11MB572465FE3FE5A3447BAF23B9EB239@CH0PR11MB5724.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221006190038.431828-3-megha.ajmera@intel.com>
> -----Original Message-----
> From: Ajmera, Megha <megha.ajmera@intel.com>
> Sent: Thursday, October 6, 2022 8:01 PM
> To: dev@dpdk.org; Singh, Jasvinder <jasvinder.singh@intel.com>;
> Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: stable@dpdk.org
> Subject: [PATCH 3/3] sched: support for 100G+ rates in subport/pipe config
>
> Config load functions updated to support 100G rates
> for subport and pipes.
>
> Signed-off-by: Megha Ajmera <megha.ajmera@intel.com>
> ---
> examples/qos_sched/cfg_file.c | 64 +++++++++++++++++------------------
> 1 file changed, 32 insertions(+), 32 deletions(-)
>
> diff --git a/examples/qos_sched/cfg_file.c b/examples/qos_sched/cfg_file.c
> index ca871d3287..ca60d616a1 100644
> --- a/examples/qos_sched/cfg_file.c
> +++ b/examples/qos_sched/cfg_file.c
> @@ -64,67 +64,67 @@ cfg_load_pipe(struct rte_cfgfile *cfg, struct
> rte_sched_pipe_params *pipe_params
>
> entry = rte_cfgfile_get_entry(cfg, pipe_name, "tb rate");
> if (entry)
> - pipe_params[j].tb_rate = (uint64_t)atoi(entry);
> + pipe_params[j].tb_rate = atol(entry);
>
> entry = rte_cfgfile_get_entry(cfg, pipe_name, "tb size");
> if (entry)
> - pipe_params[j].tb_size = (uint64_t)atoi(entry);
> + pipe_params[j].tb_size = atol(entry);
>
> entry = rte_cfgfile_get_entry(cfg, pipe_name, "tc period");
> if (entry)
> - pipe_params[j].tc_period = (uint64_t)atoi(entry);
> + pipe_params[j].tc_period = atol(entry);
>
> entry = rte_cfgfile_get_entry(cfg, pipe_name, "tc 0 rate");
> if (entry)
> - pipe_params[j].tc_rate[0] = (uint64_t)atoi(entry);
> + pipe_params[j].tc_rate[0] = atol(entry);
>
> entry = rte_cfgfile_get_entry(cfg, pipe_name, "tc 1 rate");
> if (entry)
> - pipe_params[j].tc_rate[1] = (uint64_t)atoi(entry);
> + pipe_params[j].tc_rate[1] = atol(entry);
>
> entry = rte_cfgfile_get_entry(cfg, pipe_name, "tc 2 rate");
> if (entry)
> - pipe_params[j].tc_rate[2] = (uint64_t)atoi(entry);
> + pipe_params[j].tc_rate[2] = atol(entry);
>
> entry = rte_cfgfile_get_entry(cfg, pipe_name, "tc 3 rate");
> if (entry)
> - pipe_params[j].tc_rate[3] = (uint64_t)atoi(entry);
> + pipe_params[j].tc_rate[3] = atol(entry);
>
> entry = rte_cfgfile_get_entry(cfg, pipe_name, "tc 4 rate");
> if (entry)
> - pipe_params[j].tc_rate[4] = (uint64_t)atoi(entry);
> + pipe_params[j].tc_rate[4] = atol(entry);
>
> entry = rte_cfgfile_get_entry(cfg, pipe_name, "tc 5 rate");
> if (entry)
> - pipe_params[j].tc_rate[5] = (uint64_t)atoi(entry);
> + pipe_params[j].tc_rate[5] = atol(entry);
>
> entry = rte_cfgfile_get_entry(cfg, pipe_name, "tc 6 rate");
> if (entry)
> - pipe_params[j].tc_rate[6] = (uint64_t)atoi(entry);
> + pipe_params[j].tc_rate[6] = atol(entry);
>
> entry = rte_cfgfile_get_entry(cfg, pipe_name, "tc 7 rate");
> if (entry)
> - pipe_params[j].tc_rate[7] = (uint64_t)atoi(entry);
> + pipe_params[j].tc_rate[7] = atol(entry);
>
> entry = rte_cfgfile_get_entry(cfg, pipe_name, "tc 8 rate");
> if (entry)
> - pipe_params[j].tc_rate[8] = (uint64_t)atoi(entry);
> + pipe_params[j].tc_rate[8] = atol(entry);
>
> entry = rte_cfgfile_get_entry(cfg, pipe_name, "tc 9 rate");
> if (entry)
> - pipe_params[j].tc_rate[9] = (uint64_t)atoi(entry);
> + pipe_params[j].tc_rate[9] = atol(entry);
>
> entry = rte_cfgfile_get_entry(cfg, pipe_name, "tc 10 rate");
> if (entry)
> - pipe_params[j].tc_rate[10] = (uint64_t)atoi(entry);
> + pipe_params[j].tc_rate[10] = atol(entry);
>
> entry = rte_cfgfile_get_entry(cfg, pipe_name, "tc 11 rate");
> if (entry)
> - pipe_params[j].tc_rate[11] = (uint64_t)atoi(entry);
> + pipe_params[j].tc_rate[11] = atol(entry);
>
> entry = rte_cfgfile_get_entry(cfg, pipe_name, "tc 12 rate");
> if (entry)
> - pipe_params[j].tc_rate[12] = (uint64_t)atoi(entry);
> + pipe_params[j].tc_rate[12] = atol(entry);
>
> entry = rte_cfgfile_get_entry(cfg, pipe_name, "tc 12
> oversubscription weight");
> if (entry)
> @@ -165,67 +165,67 @@ cfg_load_subport_profile(struct rte_cfgfile *cfg,
>
> entry = rte_cfgfile_get_entry(cfg, sec_name, "tb rate");
> if (entry)
> - subport_profile[i].tb_rate = (uint64_t)atoi(entry);
> + subport_profile[i].tb_rate = atol(entry);
>
> entry = rte_cfgfile_get_entry(cfg, sec_name, "tb size");
> if (entry)
> - subport_profile[i].tb_size = (uint64_t)atoi(entry);
> + subport_profile[i].tb_size = atol(entry);
>
> entry = rte_cfgfile_get_entry(cfg, sec_name, "tc period");
> if (entry)
> - subport_profile[i].tc_period = (uint64_t)atoi(entry);
> + subport_profile[i].tc_period = atol(entry);
>
> entry = rte_cfgfile_get_entry(cfg, sec_name, "tc 0 rate");
> if (entry)
> - subport_profile[i].tc_rate[0] = (uint64_t)atoi(entry);
> + subport_profile[i].tc_rate[0] = atol(entry);
>
> entry = rte_cfgfile_get_entry(cfg, sec_name, "tc 1 rate");
> if (entry)
> - subport_profile[i].tc_rate[1] = (uint64_t)atoi(entry);
> + subport_profile[i].tc_rate[1] = atol(entry);
>
> entry = rte_cfgfile_get_entry(cfg, sec_name, "tc 2 rate");
> if (entry)
> - subport_profile[i].tc_rate[2] = (uint64_t)atoi(entry);
> + subport_profile[i].tc_rate[2] = atol(entry);
>
> entry = rte_cfgfile_get_entry(cfg, sec_name, "tc 3 rate");
> if (entry)
> - subport_profile[i].tc_rate[3] = (uint64_t)atoi(entry);
> + subport_profile[i].tc_rate[3] = atol(entry);
>
> entry = rte_cfgfile_get_entry(cfg, sec_name, "tc 4 rate");
> if (entry)
> - subport_profile[i].tc_rate[4] = (uint64_t)atoi(entry);
> + subport_profile[i].tc_rate[4] = atol(entry);
>
> entry = rte_cfgfile_get_entry(cfg, sec_name, "tc 5 rate");
> if (entry)
> - subport_profile[i].tc_rate[5] = (uint64_t)atoi(entry);
> + subport_profile[i].tc_rate[5] = atol(entry);
>
> entry = rte_cfgfile_get_entry(cfg, sec_name, "tc 6 rate");
> if (entry)
> - subport_profile[i].tc_rate[6] = (uint64_t)atoi(entry);
> + subport_profile[i].tc_rate[6] = atol(entry);
>
> entry = rte_cfgfile_get_entry(cfg, sec_name, "tc 7 rate");
> if (entry)
> - subport_profile[i].tc_rate[7] = (uint64_t)atoi(entry);
> + subport_profile[i].tc_rate[7] = atol(entry);
>
> entry = rte_cfgfile_get_entry(cfg, sec_name, "tc 8 rate");
> if (entry)
> - subport_profile[i].tc_rate[8] = (uint64_t)atoi(entry);
> + subport_profile[i].tc_rate[8] = atol(entry);
>
> entry = rte_cfgfile_get_entry(cfg, sec_name, "tc 9 rate");
> if (entry)
> - subport_profile[i].tc_rate[9] = (uint64_t)atoi(entry);
> + subport_profile[i].tc_rate[9] = atol(entry);
>
> entry = rte_cfgfile_get_entry(cfg, sec_name, "tc 10 rate");
> if (entry)
> - subport_profile[i].tc_rate[10] = (uint64_t)atoi(entry);
> + subport_profile[i].tc_rate[10] = atol(entry);
>
> entry = rte_cfgfile_get_entry(cfg, sec_name, "tc 11 rate");
> if (entry)
> - subport_profile[i].tc_rate[11] = (uint64_t)atoi(entry);
> + subport_profile[i].tc_rate[11] = atol(entry);
>
> entry = rte_cfgfile_get_entry(cfg, sec_name, "tc 12 rate");
> if (entry)
> - subport_profile[i].tc_rate[12] = (uint64_t)atoi(entry);
> + subport_profile[i].tc_rate[12] = atol(entry);
> }
>
> return 0;
> --
> 2.25.1
Hi Megha,
Maybe you can explain how removing this typecast can provide support for 100+G rates?
The atoi() function returns a 32-bit value, while the subport and pipe rates are 64-bit values; this typecast can at most remove a compiler warning ...
Regards,
Cristian
next prev parent reply other threads:[~2022-10-11 13:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 17:22 [PATCH v2] sched: Fix subport profile id not set correctly Megha Ajmera
2022-10-05 19:19 ` Dumitrescu, Cristian
2022-10-11 4:59 ` Ajmera, Megha
2022-10-06 19:00 ` [PATCH 1/3] sched: fix " Megha Ajmera
2022-10-06 19:00 ` [PATCH 2/3] sched: removed unused subport field in hqos profile Megha Ajmera
2022-10-11 14:26 ` Dumitrescu, Cristian
2022-10-06 19:00 ` [PATCH 3/3] sched: support for 100G+ rates in subport/pipe config Megha Ajmera
2022-10-11 13:09 ` Dumitrescu, Cristian [this message]
2022-10-18 5:40 ` Ajmera, Megha
2022-10-18 13:12 ` Dumitrescu, Cristian
2022-10-19 18:37 ` Stephen Hemminger
2022-10-20 9:47 ` [PATCH v4 1/3] sched: fix subport profile ID Megha Ajmera
2022-10-20 9:47 ` [PATCH v4 2/3] sched: fix number of subport profiles Megha Ajmera
2022-10-20 9:47 ` [PATCH v4 3/3] sched: support for 100G+ rates in subport/pipe config Megha Ajmera
2022-10-24 18:57 ` Dumitrescu, Cristian
2022-10-20 9:55 ` [PATCH " Ajmera, Megha
2022-10-11 14:22 ` [PATCH 1/3] sched: fix subport profile id not set correctly Dumitrescu, Cristian
2022-10-28 8:09 ` [PATCH v5 1/3] sched: fix subport profile ID Megha Ajmera
2022-10-28 8:09 ` [PATCH v5 2/3] sched: fix number of subport profiles Megha Ajmera
2022-10-28 8:09 ` [PATCH v5 3/3] sched: support for 100G+ rates in subport/pipe config Megha Ajmera
2022-10-28 9:55 ` [PATCH v6 1/3] sched: fix subport profile ID Megha Ajmera
2022-10-28 9:55 ` [PATCH v6 2/3] sched: fix number of subport profiles Megha Ajmera
2022-10-28 14:02 ` David Marchand
2022-10-28 9:55 ` [PATCH v6 3/3] sched: support for 100G+ rates in subport/pipe config Megha Ajmera
2022-10-28 10:57 ` Dumitrescu, Cristian
2022-10-28 14:04 ` David Marchand
2022-10-28 14:01 ` [PATCH v6 1/3] sched: fix subport profile ID David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CH0PR11MB572465FE3FE5A3447BAF23B9EB239@CH0PR11MB5724.namprd11.prod.outlook.com \
--to=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=megha.ajmera@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).