From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F9FE43269; Thu, 2 Nov 2023 07:45:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 009C74029E; Thu, 2 Nov 2023 07:45:11 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id BAFB040282 for ; Thu, 2 Nov 2023 07:45:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698907509; x=1730443509; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=E14WenCTPKeqiNefsJuNGWVMwUKS5NBrNjyzPIxtJrI=; b=Za+apAhvBXYvnINhvaT81bHZQNgLzqsZnnV8hhNB21S1WHB7g6dkdXTE NEqWqai7KuoIRNeuGB09ILvH13azZoELLc/zvBMPPA7tzBEa5sYDDp2V2 KJnjk19bhX/G4HKT1g6owhaGFh/mZBeNJrf0O82NeDOuupWGcmNEHPkoG Gu/yAJQd2kuyfnaTrbkC3rfdfuWc3Nq5V5m1H0T1r0hh6M5kWwk6QSANa /WmYkKBBJtgqHBOZTfA7MrjHojLelq17uRFk/eXEru4IYClHiNyNM06Ds +LsXFokoELknj5D1Ov9zfT3imYa2cO9c6+mUPB81XSlEpROBLlbhjPqL2 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10881"; a="373692860" X-IronPort-AV: E=Sophos;i="6.03,270,1694761200"; d="scan'208";a="373692860" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2023 23:45:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,270,1694761200"; d="scan'208";a="9273682" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 Nov 2023 23:45:05 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 1 Nov 2023 23:45:04 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Wed, 1 Nov 2023 23:45:04 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Wed, 1 Nov 2023 23:45:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HQ/zIysPouDUoD49phBxK5J1VE4juxLoArS83bmRGT0NDjgSOtQQEBjvfHy5qwVsu0cBH1pBsR/PGB4oc6NytS8X8UIigQ8yY1wm0jZakBOcoSm/aHbmTy6wCaBK5AiFUDYvsKBqQa8MotWtv6ZUVLKly8y308/u5air+ifbgsra2KrbROSdExnmsQCu5/1TfJADMGKgkEPaXNlJnulYwkrcZUWfcu+HvuLCSmc8H+M6VbnEmt3/3eiLxaTcw6ngEBbChDtGDnatr7OsxeqGaCDKJxfxpRR7pXUMB4A8ZeDj01ljgozNdzF8LoRQKJdDvUKlNtlreqkkOQ6E4Skcew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MW9luzJcMriVZGjpe3g/TuqiXbY8q9/Y2gwhjTqmvOE=; b=GULATSH20R5zCdyj1prZaEk+IfWio0TQz12rY6XpWFnojD9JN81Cudg8g85bwLWtR2AGiAm3jdvDi7DF5FsN+s53AV0DSV6FjJNmj1G2hntpMra1rjOxnvuKU2zjM6OGm56fmUCcrG1Sp7EfahUOlFgKvHw2y/J8C4N4wG+V2w06qvW3ztztHPuXAz5E81Y4MQviO/y+StKq70BP07BbLzsa+po4MWD+TDlYEcjg8p4gFCetkK2cFpB2mfJ0/xHgSzxOWxwrzvynTyrV0pTGr6MYIMt5JjwKBRvPuAVqOKTczAFzZegG85+UwxC3LXQlME1NS3WdbFlDv8H7LsZrSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CH0PR11MB8086.namprd11.prod.outlook.com (2603:10b6:610:190::8) by CY8PR11MB7083.namprd11.prod.outlook.com (2603:10b6:930:51::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.19; Thu, 2 Nov 2023 06:44:57 +0000 Received: from CH0PR11MB8086.namprd11.prod.outlook.com ([fe80::4aeb:f1:461:2f1f]) by CH0PR11MB8086.namprd11.prod.outlook.com ([fe80::4aeb:f1:461:2f1f%3]) with mapi id 15.20.6933.024; Thu, 2 Nov 2023 06:44:57 +0000 From: "Yang, Qiming" To: "Zhang, Qi Z" , "Xing, Beilei" CC: "dev@dpdk.org" , "Zhang, Qi Z" , "stable@dpdk.org" Subject: RE: [PATCH] net/iavf: fix Tx preparation Thread-Topic: [PATCH] net/iavf: fix Tx preparation Thread-Index: AQHaDT78iawX7ZeMkUKXfqBr6IjwxbBmlL+Q Date: Thu, 2 Nov 2023 06:44:57 +0000 Message-ID: References: <20231102120504.1468111-1-qi.z.zhang@intel.com> In-Reply-To: <20231102120504.1468111-1-qi.z.zhang@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH0PR11MB8086:EE_|CY8PR11MB7083:EE_ x-ms-office365-filtering-correlation-id: 1f17182e-3a49-4d6f-4523-08dbdb6f3a7d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Sp16qVdnNV/AiHp8DbnypIN/kKniI702uI42HMy5ZFue419fctONe4cWvwfdAUYR3qgHbBbyepM5t4rctgd1RdM/91KM2BJoR00YP0bnO+ZiZfU6WJOgcToV6VgH42w1HcWvp3Vq3aFnQuAsvtpPa+VVPtaWqh5gfabifTGpuCeaQCLTG60M2JgrHwQNEqSJ+hECLH7ylNtz5rgsWryvXU9X/AIUbEIIh95SXpD9I74IZk5EKfVl1rpDd6UqH24QpZy6A8W2Im0xjrgF+l5I5Adw0lRTxcMXDHUjq6wvrNOVYzj8fShbe9bfj+scqyCACbXckjcO1IYNlokJWUIDx9T7reuEPNFHkB34eWJtgbCWADt5hMYwEawnfMaf+9hQtLf19tkxzyxqAzvqssEDtnBGYnSQWO5M2nHPdD/wk4qSdT7yTNS8DnKLr4BhzlpDXbHetKK2jQCW9BvkNbCwMhm9yYVfZ7cgqIo+6V0FpZNXHHOLkdjU9b+Q6jKdaVoX+NoexoyjhiVsugWcJJyJrckNVPiN28HFHzoMVKjMl75b5iK5hyMwpgj4iQL/TORFiiR9TqZYIRAgLbqKJP9Qi7YtBA+aN8qiGC9fVGScamyPujCo6GzeAWMUVg7dv7uw x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH0PR11MB8086.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(39860400002)(346002)(376002)(396003)(366004)(230922051799003)(451199024)(186009)(64100799003)(1800799009)(2906002)(38100700002)(5660300002)(122000001)(86362001)(82960400001)(41300700001)(110136005)(55016003)(33656002)(9686003)(76116006)(66946007)(26005)(64756008)(6636002)(66446008)(316002)(66556008)(54906003)(66476007)(71200400001)(53546011)(7696005)(478600001)(6506007)(83380400001)(38070700009)(52536014)(8936002)(450100002)(8676002)(4326008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+bVhi4YrL6HtrzXDsjWGShPOCs+Vwd0ihcWld8fDBl6h6n2BDzdt4L+rFYu6?= =?us-ascii?Q?0rrrEKqJuE99coFfDOtzZuDCwLydEMFS8YkoVPAbg7nAMs/kKSFwfXe771l2?= =?us-ascii?Q?s8M3lNqth+ltsow7FtlFBEMGT8CaX3tRUF4fulybCll9Lh+9NfQ3CoXeXG1k?= =?us-ascii?Q?PtsWC5fCo/QLsEc8Y0YZjWiC0t0j/svnCUDfuRM/NKjMKaGZuno0+j8Ff1SF?= =?us-ascii?Q?yh3oljq+S50Mvr0sk33dn+tzimgNIr52s/pCo/pc3WvgUOOUwZOGsXzqFe5g?= =?us-ascii?Q?KANNg5or0VUb2dlElykTIYfa9pnoI77wgi9jr9xZlZlCcf5UOjaP0s765gjk?= =?us-ascii?Q?lgvClmT84Xf1LP+x3DkAWtxzQf1gLaoVaOyxWXMFTDZnPmaU9hcs7Bog+VuD?= =?us-ascii?Q?xEQwMpnHVZmmLTjaaC1zeXjBXKjWr32LOfpYdfJkNiIQBUktVwJ1/Nz8H4JN?= =?us-ascii?Q?4PZ/gYDw778S2NVMCr5xv58CR+fkKB9gzPQYD83eAvvsn43YmlgKSUgmB4IG?= =?us-ascii?Q?/QMj2LOkaqWFXGH1ktwAmB5hzjHkEswV1S2nJhRy0ygCTIsb6xWDCp7y1dMv?= =?us-ascii?Q?KbfhxreV6iRhFE2o2CN9HDqXOH7i2ESGVIQXo4Ua5KKOE4rishnkFlsfd96C?= =?us-ascii?Q?ChMIHWq5XCmheHNbz3UKkIIsVssj0LScm0esiFi4+TgXolGOAgsw7qHIGVJA?= =?us-ascii?Q?VPldO4XYN5Gkwah3tetjwQmB0uRY7Dkw7YMxoyue10SpxnVqWBoS7lAq1L5G?= =?us-ascii?Q?EI1us76WSPPi25V3k8C8ndj7AwxP4oa0jRh2/VytHTxGR64Z23QIyVpi8aHX?= =?us-ascii?Q?mh4qWvFk+sst0gTs3ECaWpvwTdMvbBVvM6oYVLqo0hlVeGa6ivsxHbbT/uEW?= =?us-ascii?Q?vsHFQe3pkoEjZJbIUcyfm7mdMkiHhOruN8iz/cWw2ey9I7yVolqLB5L7NFB2?= =?us-ascii?Q?jpEX2xilckx6nYdVCmx3eZZ2H9tnItS+5pI8fQyekgPfVITXJHsGq3/5+L0k?= =?us-ascii?Q?bzqnwu+9/1BgPp29E1Aq4dC1vlIxHggzm/g5PNyv5ia0mQ/Lv5OpS/DuA2pg?= =?us-ascii?Q?mDSRGWC4DMzAi0OYN1rOgYyJmYc8UtjfovPdpFB5KrphIyAmegpYiBb6B3hT?= =?us-ascii?Q?MvaVfcfRtTNvUz0pTMBM3Loi7h0sSFd79Ux+IGId/HaV9puzJQrOjPbnjHrW?= =?us-ascii?Q?mGuiPzwU7Q7Gs83CCUbMFvtOPXnVJKcHrgqBx1HOXrGRZQdvKatI/ur086ax?= =?us-ascii?Q?3zq3KX0g8anloTHBwnUyu4cs8u5GCOhRUdAciw5P3U86nuZ3ZtpgeOzx0Yix?= =?us-ascii?Q?J+Ju0Fhgt6XeHTueMKu8+8SVlKZ+ObstTXoDzdV8D9hmUgH5tJFGJTG/mg8P?= =?us-ascii?Q?4LpKGbxPhp485uyTNzkqIa4hTCAFcycd3yJKwrEOohHToSWpM7EO1Lz7VdT9?= =?us-ascii?Q?kUZaTg2uioiWFjWGBVgF8J8Wriy0ZfqK1WC8MhXvDsfqd2UFcfoQrIfGu6r8?= =?us-ascii?Q?+P7k2JPBspzWTeg8MeSCi+L4Wfkooqjb0EQpXGMAPrqb72wKwEUwxNZAT9zI?= =?us-ascii?Q?Lo1rCAU/LHDSJMB+zKyQdcI2pBlspqu5J21V7TCk?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH0PR11MB8086.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f17182e-3a49-4d6f-4523-08dbdb6f3a7d X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2023 06:44:57.1760 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vGQ+P78dhecBrf5KGYotXDYTCtVedfYpUNUDPGmiMmXBkbmgNyFlfn2SwBfSLVp3gFKoOF9qRco6h1bnAOs38Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7083 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi,=20 > -----Original Message----- > From: Qi Zhang > Sent: Thursday, November 2, 2023 8:05 PM > To: Xing, Beilei > Cc: dev@dpdk.org; Zhang, Qi Z ; stable@dpdk.org > Subject: [PATCH] net/iavf: fix Tx preparation >=20 > 1. check nb_segs > Tx ring size for TSO case. > 2. report nb_mtu_seg_max and nb_seg_max in dev_info. >=20 > Fixes: a2b29a7733ef ("net/avf: enable basic Rx Tx") > Cc: stable@dpdk.org >=20 > Signed-off-by: Qi Zhang > --- > drivers/net/iavf/iavf_ethdev.c | 2 ++ > drivers/net/iavf/iavf_rxtx.c | 3 ++- > 2 files changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethde= v.c > index 98cc5c8ea8..0c6ab4ac5a 100644 > --- a/drivers/net/iavf/iavf_ethdev.c > +++ b/drivers/net/iavf/iavf_ethdev.c > @@ -1207,6 +1207,8 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct > rte_eth_dev_info *dev_info) > .nb_max =3D IAVF_MAX_RING_DESC, > .nb_min =3D IAVF_MIN_RING_DESC, > .nb_align =3D IAVF_ALIGN_RING_DESC, > + .nb_mtu_seg_max =3D IAVF_TX_MAX_MTU_SEG, > + .nb_seg_max =3D IAVF_MAX_RING_DESC, > }; >=20 > dev_info->err_handle_mode =3D > RTE_ETH_ERROR_HANDLE_MODE_PASSIVE; > diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c = index > 610912f635..45f638c1d2 100644 > --- a/drivers/net/iavf/iavf_rxtx.c > +++ b/drivers/net/iavf/iavf_rxtx.c > @@ -3656,7 +3656,8 @@ iavf_prep_pkts(__rte_unused void *tx_queue, > struct rte_mbuf **tx_pkts, > return i; > } > } else if ((m->tso_segsz < IAVF_MIN_TSO_MSS) || > - (m->tso_segsz > IAVF_MAX_TSO_MSS)) { > + (m->tso_segsz > IAVF_MAX_TSO_MSS) || > + (m->nb_segs > txq->nb_tx_desc)) { > /* MSS outside the range are considered malicious */ > rte_errno =3D EINVAL; > return i; > -- > 2.31.1 Acked-by: Qiming Yang