From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2465FA0547; Sun, 17 Oct 2021 11:14:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A48C540041; Sun, 17 Oct 2021 11:14:41 +0200 (CEST) Received: from AZHDRRW-EX02.NVIDIA.COM (azhdrrw-ex02.nvidia.com [20.64.145.131]) by mails.dpdk.org (Postfix) with ESMTP id 59F5D4003C for ; Sun, 17 Oct 2021 11:14:40 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by mxs.oss.nvidia.com (10.13.234.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.858.15; Sun, 17 Oct 2021 02:14:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M1Yhv8PbmrOqJbuP4mDOyWQfhNT8nKdvCZdHf0Ik0em6zg3ELoOcVx8yh67Cjq0k5YwAwTKWBK0u702Unt4KVAh5LxMP9SnJrKOBrtVLkKRpLYQOzd2bYmG/gILSmKbJhWylutVeHcusZvnhgQpWyZL9Lz2rEvV0EUkhZTpIbf2csEW/rfIU2R0M9BbMb95O5g4RTseibXHuYB1GDRHxsjFcReoH9F3ZXPHW/hUmwu2WAHaPdV3TLfSH/IZIAaCZMi1fTRj+A50Jn2nio+sJ3KK1xVXCJ5ekxYAE82sfaQ4VPdyF+eFKtd40uictxWXlDadIDg0U2nZNHnjvBRiC0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Mq7Ul2rgsPTlYhjb8EK/B7CDm46VO7E0hi7SGg9+7/0=; b=dJ6ynakV1+z97E/c+l8bnTHR89dSd8oJOKcM/at3yei0DatOBdQ+XMwi/6FbDV67wbBR1LgaSdz5mxgqIMW4xfdCb+0Tb7pM34XyrCjkhVpWfiw7rVjy6pfri5CPV5lXhw64Mnfdi/C9+G/lk106x2ewFqR1MGY+2oxhsJfHeKXH6vhaYxXzg/zr9h1fdMt1g1D4kMwuZST9YLDYTZMeD+yJxW+qmnWUUFWB5N194zU6FzYh6QXk2z/h8/GJKG/zadSA10SLFx/KDob+XkPBe7kXwM/E8Gt3BlmYVekyadUgy45zpbopjx5d43uUbgIKkUl/GLw8ZZeZ6AI7uOR2rQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mq7Ul2rgsPTlYhjb8EK/B7CDm46VO7E0hi7SGg9+7/0=; b=fYvlhL3FDLH0nyp9faTkV0QprI5+FAKsGClKtL8jFb4BTDNzc2Q4F9eN8HzmuiIYCanv0G403dOr+4IJIhhwpGtySKX5skbaTom/pofFEGjnOSSqdzkKp7C7El/44xPkSD8VoiRreL4TrUkcQTbFRBRFVZ4gjjy+ReKQTi5jLKRsJSXq/mEY1/Fm/DPaZi8mnIXTGMuwOSuD1ao6eF6rEYzsAhuAm4SzTj+93T9I80TL2D0tCR/n7P+asJGz+cOlkSmP7P3ONOHXX7QifXHe5JjfmR4B806Wp3Eaw3niN35VnYw/ic2tmMb/b8IdQwNVNCPlUqvkVsN32dXWrC7iHA== Received: from CH0PR12MB5091.namprd12.prod.outlook.com (2603:10b6:610:be::10) by CH0PR12MB5298.namprd12.prod.outlook.com (2603:10b6:610:d5::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Sun, 17 Oct 2021 09:14:38 +0000 Received: from CH0PR12MB5091.namprd12.prod.outlook.com ([fe80::59bf:640f:7140:ab97]) by CH0PR12MB5091.namprd12.prod.outlook.com ([fe80::59bf:640f:7140:ab97%9]) with mapi id 15.20.4608.018; Sun, 17 Oct 2021 09:14:37 +0000 From: Dmitry Kozlyuk To: Ori Kam , "dev@dpdk.org" CC: NBU-Contact-Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko Thread-Topic: [PATCH v2 2/5] ethdev: add capability to keep shared objects on restart Thread-Index: AQHXwy5/qTXRKlwmLkGykti5THbWw6vW5iIQ Date: Sun, 17 Oct 2021 09:14:37 +0000 Message-ID: References: <20211005005216.2427489-1-dkozlyuk@nvidia.com> <20211015161822.3099818-1-dkozlyuk@nvidia.com> <20211015161822.3099818-3-dkozlyuk@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e54828ad-ca2d-4968-b887-08d9914e8b3f x-ms-traffictypediagnostic: CH0PR12MB5298: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KAMNog+lbGzIoSm+spUYgmYc66HRrgtDRnvMeLa9nCNKXDBYmQ+q2SdtBBuzjjVY7yNI8huEVRQV8/Zp++6QpkFtllw2OPk0KD//h5GGsHsbVKylg9DyKyfciRL5xoufUjFnQXrwNL7Nv5deI9xEz4SWAbfN28CpN0N5r0EnONnXSPEi7+NIN79AdNevSgg3dyFzDQfLdH5/9OqdYaOh4tkYtx+vTiKodQ7s3o2Ew9p7Gk0x5yWaPB8i2Rjr/tnZmWuMrdOgC+on6TLfPxW3Siakzj1a0rp7/pT3AtuVHfgxmv5Mu+rxIeLxW/OEk41kCMRqubYy1nHH8V8HablYVC4KZcUJKBF6EiUbudcKnx2bDgYRz0lHUJyT9JYBF2P0U9zuKinwzr6E5+SYUl+16KrJJDSXqME0465TW+H0S7VxDZCx3upnEokGTT4z9mxzntzPru34pkr9Jec/6keZEm3c+WQjQhTLtT7ZCm4piCTv+GcoI7tDND6bW17338BGxUVia9KFHM09xschJouswRSOJqz/e/0lEM9mE4Dl33xeXBbCDt+7BI4vuIuudhMsPOUjbNPQjFeQ989u6NCAkQUIIQe+4sBIEvZSd3KoCpq8H5xDEp7vDScp0b3F9zCnNQfdaGwGlAnSqeNYoClyFfyypmqYpUPqe66+iRHiyKgsPNQdenYSoBOKWGeG1tCCf/FguA0dvzwaGTSLccA8Yw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH0PR12MB5091.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(5660300002)(4326008)(71200400001)(52536014)(26005)(8936002)(66946007)(55016002)(33656002)(9686003)(6506007)(2906002)(7696005)(316002)(54906003)(107886003)(110136005)(186003)(122000001)(508600001)(66556008)(66476007)(66446008)(64756008)(8676002)(38100700002)(86362001)(76116006)(38070700005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NPxA2xleMHthQisFoeJEDeBgG8xnj14nAsFtRt5iLfWWaqL4054yERS9W3bO?= =?us-ascii?Q?LVLPsUJnK8Kfvjl6BxvCLtT2YPouyNNrkUXFb7q/QY2QufodGRV9ec9QVXfH?= =?us-ascii?Q?IDuO6FJ+rY88TryYW2dFGds71HSQnkoeFgYoBmn0jvWr6sqwRkq/PBJI1xTw?= =?us-ascii?Q?5a6RMYrolF5hIngC7BLFn6dXrqj0Oz0dAROoJtQe03hVjv1MPHUSSUDomTKL?= =?us-ascii?Q?rBlxyOZ57d0Udgabi/h0oQFdvmM58YMWuC5tiLSVHyPIOOI76/Az5KkTKR5Y?= =?us-ascii?Q?Hy49Jn5wxeZ+Ps9Zt0Qklr8af5Quqq+CCIht39ccXe3DvLDQie9oFgn3Vjuv?= =?us-ascii?Q?TJ38oKjcPVqxWekiXPAIUPY007Gs1jrKUHQhkEhu9/PEkSjtrgGFQd+JAJvb?= =?us-ascii?Q?26l0kfZAQl5NYCiPQ0/flo2HG7CkdWmi85yBiCks0zv2UKD+3Y/NWvtxS5Jl?= =?us-ascii?Q?f1qyQd7BsezuHzDLNk+oKKMKgBqTll1Z0FIRPjtndSRduLRHJZBsNsHrJIMS?= =?us-ascii?Q?xYm2iCoDlIci/ufp8Nb7G5Y6Hghc3Mx3TzIjfGYzzfNJOZNGk0rn6p0OEt+R?= =?us-ascii?Q?jgeqDBr3t0fw5AEUBJTkSf9OJeJ2+IJ5VciVVYdrod24B8l7UL5Ar5T8DOuK?= =?us-ascii?Q?fK5JrTaHrfJkTcgdzxBVHVvLJaJ58YuMQ1+hGwLGQRShIG9E4Jm6OBzzr1VO?= =?us-ascii?Q?UtzyeDGwsv17lwTeYE5YXXgFFihSRE4ADQela55Ue4ibX9xr1wIkZVwceidt?= =?us-ascii?Q?nEbCiT8R+KKoDo1z2dgqFulPMpO1rUfg2YvA3/R2mGXKP/j7rjPR6Swb7fYL?= =?us-ascii?Q?45xXfks19kBawEGKYB5lSBW2VCooVpxeGB0VyGt+9SBu15qY0jugI5DmdfbU?= =?us-ascii?Q?y8lJoU219Yr1GgH96Jlq+S1TB3cJUIMiKo+g0piJknyJPi479pnpkEE02ke0?= =?us-ascii?Q?t4XaahNEdtxHCFfDtBerQ+TP/XedgiNuP7FbxHe6K28osn0rEXP2NBV7on4b?= =?us-ascii?Q?CCB0VeGVjr4gg7WJr3J8cs5K/WHLIQ8PK0EBsC7UK2qC3tr45OJaQGjY8jAn?= =?us-ascii?Q?GbKzw6k3h5ZBBeM8EZREjJ5svq6WfVeYZgJ7fYn9E9XRfihyZhP431ykWYiX?= =?us-ascii?Q?5sQy7hh9VLvY6c1VB+ihXR736yJ8vPFYcN6/HVucMK11vYzN65dkK6tv2iRL?= =?us-ascii?Q?eTOen8wJkEeGERgnR1SV+TyUWtl9OcOA69kdYTDIWtKXLxPFZ8WIPlMq9f74?= =?us-ascii?Q?MJRZhb17NW4VwdZrzu0Lmlqj4QZjM4oSy33W5yKVmchtDSIJbQuK2JWLQQQP?= =?us-ascii?Q?/Uk=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH0PR12MB5091.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e54828ad-ca2d-4968-b887-08d9914e8b3f X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2021 09:14:37.8574 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8TbOQXwyMnYJeaV/d9TCuqOKJbQzzs1JLloxTL/qLfZzdu3vCILZN00SdUw8Y1nggaebradnp9SYK5H5uwz3/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5298 Subject: Re: [dpdk-dev] [PATCH v2 2/5] ethdev: add capability to keep shared objects on restart X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > [...] > > +By default it is unspecified if indirect actions persist after the > device stop. > > +If ``RTE_ETH_DEV_CAPA_FLOW_SHARED_OBJECT_KEEP`` is not advertised, the= n > > +indirect actions must be explicitly destroyed before stopping the > > +device if the application needs to ensure they are removed. >=20 > I don't understand the above line, if indirect actions must be explicitly > destroyed > what does it means "if the application needs to ensure?) > I think it should say just like now, application should destroy all share= d > objects before > stopping. If application doesn't call the destroy the state of the action > is undefined. I had in mind that some applications don't care, because they only stop the port before closing it. Would the following be more explicit? "If ``RTE_ETH_DEV_CAPA_FLOW_SHARED_OBJECT_KEEP`` is not advertised, the state of indirect actions after the device stop is undefined. Application must destroy all indirect actions before stopping the port if it intends to start it later, or unwanted indirect actions can remain."