From: Dmitry Kozlyuk <dkozlyuk@oss.nvidia.com>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Ferruh Yigit <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 3/6] net: advertise no support for keeping flow rules
Date: Wed, 20 Oct 2021 22:20:18 +0000 [thread overview]
Message-ID: <CH0PR12MB5091B29520AB02926A5A74D6B9BE9@CH0PR12MB5091.namprd12.prod.outlook.com> (raw)
In-Reply-To: <4c5ca636-cebe-3e4a-81db-456c15cf1a48@oktetlabs.ru>
> > diff --git a/drivers/net/bnxt/bnxt_ethdev.c
> b/drivers/net/bnxt/bnxt_ethdev.c
> > index aa7e7fdc85..1a6e0128ff 100644
> > --- a/drivers/net/bnxt/bnxt_ethdev.c
> > +++ b/drivers/net/bnxt/bnxt_ethdev.c
> > @@ -1009,6 +1009,7 @@ static int bnxt_dev_info_get_op(struct rte_eth_dev
> *eth_dev,
> > dev_info->speed_capa = bnxt_get_speed_capabilities(bp);
> > dev_info->dev_capa = RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP |
> > RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP;
> > + dev_info->dev_capa &= ~RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP;
>
> Sorry, but here and everywhere below I see no point to cleanup
> the bit explicitly when it is not actually set.
>
> [snip]
(removed maintainers from CC)
As Ferruh explained, this line serves as a TODO item for maintainers
to either remove the useless line or to support the capability and advertise it.
If deemed unnecessary in the end, this patch can be safely dropped.
http://inbox.dpdk.org/dev/6e148fd8-c7b9-dd90-d286-a54ff0faf713@intel.com/
next prev parent reply other threads:[~2021-10-20 22:20 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 0:52 [dpdk-dev] [PATCH 0/5] Flow entites behavior on port restart dkozlyuk
2021-10-05 0:52 ` [dpdk-dev] [PATCH 1/5] ethdev: add capability to keep flow rules on restart dkozlyuk
2021-10-06 6:15 ` Ori Kam
2021-10-06 6:55 ` Somnath Kotur
2021-10-06 17:15 ` Ajit Khaparde
2021-10-05 0:52 ` [dpdk-dev] [PATCH 2/5] ethdev: add capability to keep shared objects " dkozlyuk
2021-10-06 6:16 ` Ori Kam
2021-10-13 8:32 ` Dmitry Kozlyuk
2021-10-14 13:46 ` Ferruh Yigit
2021-10-14 21:45 ` Dmitry Kozlyuk
2021-10-14 21:48 ` Dmitry Kozlyuk
2021-10-15 11:46 ` Ferruh Yigit
2021-10-15 12:35 ` Dmitry Kozlyuk
2021-10-15 16:26 ` Ferruh Yigit
2021-10-16 20:32 ` Dmitry Kozlyuk
2021-10-18 8:42 ` Ferruh Yigit
2021-10-18 11:13 ` Dmitry Kozlyuk
2021-10-18 11:59 ` Ferruh Yigit
2021-10-14 14:14 ` Dmitry Kozlyuk
2021-10-15 8:26 ` Andrew Rybchenko
2021-10-15 9:04 ` Dmitry Kozlyuk
2021-10-15 9:36 ` Andrew Rybchenko
2021-10-05 0:52 ` [dpdk-dev] [PATCH 3/5] net/mlx5: discover max flow priority using DevX dkozlyuk
2021-10-05 0:52 ` [dpdk-dev] [PATCH 4/5] net/mlx5: create drop queue " dkozlyuk
2021-10-05 0:52 ` [dpdk-dev] [PATCH 5/5] net/mlx5: preserve indirect actions on restart dkozlyuk
2021-10-15 16:18 ` [dpdk-dev] [PATCH v2 0/5] Flow entites behavior on port restart Dmitry Kozlyuk
2021-10-15 16:18 ` [dpdk-dev] [PATCH v2 1/5] ethdev: add capability to keep flow rules on restart Dmitry Kozlyuk
2021-10-18 8:56 ` Andrew Rybchenko
2021-10-19 12:38 ` Dmitry Kozlyuk
2021-10-18 13:06 ` Zhang, Qi Z
2021-10-18 22:51 ` Dmitry Kozlyuk
2021-10-19 1:00 ` Zhang, Qi Z
2021-10-15 16:18 ` [dpdk-dev] [PATCH v2 2/5] ethdev: add capability to keep shared objects " Dmitry Kozlyuk
2021-10-17 8:10 ` Ori Kam
2021-10-17 9:14 ` Dmitry Kozlyuk
2021-10-17 9:45 ` Ori Kam
2021-10-15 16:18 ` [dpdk-dev] [PATCH v2 3/5] net/mlx5: discover max flow priority using DevX Dmitry Kozlyuk
2021-10-15 16:18 ` [dpdk-dev] [PATCH v2 4/5] net/mlx5: create drop queue " Dmitry Kozlyuk
2021-10-15 16:18 ` [dpdk-dev] [PATCH v2 5/5] net/mlx5: preserve indirect actions on restart Dmitry Kozlyuk
2021-10-19 12:37 ` [dpdk-dev] [PATCH v3 0/6] Flow entites behavior on port restart Dmitry Kozlyuk
2021-10-19 12:37 ` [dpdk-dev] [PATCH v3 1/6] ethdev: add capability to keep flow rules on restart Dmitry Kozlyuk
2021-10-19 15:22 ` Ori Kam
2021-10-19 16:38 ` Ferruh Yigit
2021-10-19 17:13 ` Dmitry Kozlyuk
2021-10-20 10:39 ` Andrew Rybchenko
2021-10-20 11:40 ` Dmitry Kozlyuk
2021-10-20 13:40 ` Ori Kam
2021-10-19 12:37 ` [dpdk-dev] [PATCH v3 2/6] ethdev: add capability to keep shared objects " Dmitry Kozlyuk
2021-10-19 15:22 ` Ori Kam
2021-10-19 12:37 ` [dpdk-dev] [PATCH v3 3/6] net: advertise no support for keeping flow rules Dmitry Kozlyuk
2021-10-20 10:08 ` Andrew Rybchenko
2021-10-20 22:20 ` Dmitry Kozlyuk [this message]
2021-10-19 12:37 ` [dpdk-dev] [PATCH v3 4/6] net/mlx5: discover max flow priority using DevX Dmitry Kozlyuk
2021-10-19 12:37 ` [dpdk-dev] [PATCH v3 5/6] net/mlx5: create drop queue " Dmitry Kozlyuk
2021-10-19 12:37 ` [dpdk-dev] [PATCH v3 6/6] net/mlx5: preserve indirect actions on restart Dmitry Kozlyuk
2021-10-20 10:12 ` [dpdk-dev] [PATCH v3 0/6] Flow entites behavior on port restart Andrew Rybchenko
2021-10-20 13:21 ` Dmitry Kozlyuk
2021-10-21 6:34 ` [dpdk-dev] [PATCH v4 " Dmitry Kozlyuk
2021-10-21 6:34 ` [dpdk-dev] [PATCH v4 1/6] ethdev: add capability to keep flow rules on restart Dmitry Kozlyuk
2021-10-21 7:36 ` Ori Kam
2021-10-28 18:33 ` Ajit Khaparde
2021-11-01 15:02 ` Andrew Rybchenko
2021-11-01 15:56 ` Dmitry Kozlyuk
2021-10-21 6:34 ` [dpdk-dev] [PATCH v4 2/6] ethdev: add capability to keep shared objects " Dmitry Kozlyuk
2021-10-21 7:37 ` Ori Kam
2021-10-21 18:28 ` Ajit Khaparde
2021-11-01 15:04 ` Andrew Rybchenko
2021-10-21 6:35 ` [dpdk-dev] [PATCH v4 3/6] net: advertise no support for keeping flow rules Dmitry Kozlyuk
2021-10-21 18:26 ` Ajit Khaparde
2021-10-22 1:38 ` Somnath Kotur
2021-10-27 7:11 ` Hyong Youb Kim (hyonkim)
2021-11-01 15:06 ` Andrew Rybchenko
2021-11-01 16:59 ` Ferruh Yigit
2021-10-21 6:35 ` [dpdk-dev] [PATCH v4 4/6] net/mlx5: discover max flow priority using DevX Dmitry Kozlyuk
2021-10-21 6:35 ` [dpdk-dev] [PATCH v4 5/6] net/mlx5: create drop queue " Dmitry Kozlyuk
2021-10-21 6:35 ` [dpdk-dev] [PATCH v4 6/6] net/mlx5: preserve indirect actions on restart Dmitry Kozlyuk
2021-10-26 11:46 ` [dpdk-dev] [PATCH v4 0/6] Flow entites behavior on port restart Ferruh Yigit
2021-11-01 13:43 ` Ferruh Yigit
2021-11-02 13:49 ` Ferruh Yigit
2021-11-02 13:54 ` [dpdk-dev] [PATCH v5 " Dmitry Kozlyuk
2021-11-02 13:54 ` [dpdk-dev] [PATCH v5 1/6] ethdev: add capability to keep flow rules on restart Dmitry Kozlyuk
2021-11-02 13:54 ` [dpdk-dev] [PATCH v5 2/6] ethdev: add capability to keep shared objects " Dmitry Kozlyuk
2021-11-02 13:54 ` [dpdk-dev] [PATCH v5 3/6] net: advertise no support for keeping flow rules Dmitry Kozlyuk
2021-11-02 13:54 ` [dpdk-dev] [PATCH v5 4/6] net/mlx5: discover max flow priority using DevX Dmitry Kozlyuk
2021-11-02 13:54 ` [dpdk-dev] [PATCH v5 5/6] net/mlx5: create drop queue " Dmitry Kozlyuk
2021-11-02 13:54 ` [dpdk-dev] [PATCH v5 6/6] net/mlx5: preserve indirect actions on restart Dmitry Kozlyuk
2021-11-02 14:23 ` [dpdk-dev] [PATCH v5 0/6] Flow entites behavior on port restart Ferruh Yigit
2021-11-02 17:02 ` Dmitry Kozlyuk
2021-11-02 17:01 ` [dpdk-dev] [PATCH v6 " Dmitry Kozlyuk
2021-11-02 17:01 ` [dpdk-dev] [PATCH v6 1/6] ethdev: add capability to keep flow rules on restart Dmitry Kozlyuk
2021-11-02 17:01 ` [dpdk-dev] [PATCH v6 2/6] ethdev: add capability to keep shared objects " Dmitry Kozlyuk
2021-11-02 17:01 ` [dpdk-dev] [PATCH v6 3/6] net: advertise no support for keeping flow rules Dmitry Kozlyuk
2021-11-02 17:01 ` [dpdk-dev] [PATCH v6 4/6] net/mlx5: discover max flow priority using DevX Dmitry Kozlyuk
2021-11-02 17:01 ` [dpdk-dev] [PATCH v6 5/6] net/mlx5: create drop queue " Dmitry Kozlyuk
2021-11-02 17:01 ` [dpdk-dev] [PATCH v6 6/6] net/mlx5: preserve indirect actions on restart Dmitry Kozlyuk
2021-11-02 18:02 ` [dpdk-dev] [PATCH v6 0/6] Flow entites behavior on port restart Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CH0PR12MB5091B29520AB02926A5A74D6B9BE9@CH0PR12MB5091.namprd12.prod.outlook.com \
--to=dkozlyuk@oss.nvidia.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).