From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7D8DA0C47; Tue, 12 Oct 2021 16:48:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8C9D841174; Tue, 12 Oct 2021 16:48:16 +0200 (CEST) Received: from AZHDRRW-EX02.NVIDIA.COM (azhdrrw-ex02.nvidia.com [20.64.145.131]) by mails.dpdk.org (Postfix) with ESMTP id 98C794111D for ; Tue, 12 Oct 2021 16:48:14 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by mxs.oss.nvidia.com (10.13.234.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.858.15; Tue, 12 Oct 2021 07:48:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fZKK6XHsWu5rV/2BE1AIUfzhTTLOork1g0WA52+9n8FgXx7gmOpnVzxcyoYSw4DNMK9a5EYOxgCx8i7dpUJ4/nIiVk7E43AdNzREFXNJ2N+L2MYucBrdZGvliFJ5SicQw44QJcEVp7c5Urae5ima/d92kqBo9eoS4NgKMGftW/OXDFe+rdQwFBWH9JMlP68TxMgxHvAsyQ9ue18varKAxM03/Gi7Be2LKuqTN0k4xyNN6kvDZqQvHxJcUGuSCL9m9aJnNqoLz0g4j1xADDw5QJDdXvgJpkLuun7MxkdL8H3F/tBB4Tg3xnal0rhNd2Vm/DsmPRXE9mW7/sVTqNkQ/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1nKYcGoFFxFBRFRNbfKmxxO0pnm8RNfkuFqzVAbfIYg=; b=AAXk9izTTUyf4xuClvCpsiFMz1xo5a+93lQxwo2NNtDLc2mL9yxEUtuJQsmHB/8bK4Tca4Vheuk9H3iKJVj9T84Nd/QFqaW/+dY8ksodfh5ymebXk3NyCUQOmetPWq2OjPt0sqsuRrfnUpWwk4ko7yZJneYlbPQHN5fDSIOkRlhcKdHRmku9mhqYwPK9J+vB8Z0YCXoGbysYWfC3wO543Qw3ONouGxPG4H3cGUeWCza1un9u8W5iO3Z+0FStsEXQreNiF3gz0Fd9fBPc/Rwv1LHl67EAgUKAWrg3iwpTFjD0lTkU2O7O6ih/hswFwICkS9QHd9skzSxU9oySLBk2XQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1nKYcGoFFxFBRFRNbfKmxxO0pnm8RNfkuFqzVAbfIYg=; b=OUm+a8yFm/6fqDH0i04xyqoFXK9s/uO6kddiqbWvLeKHxkFMtB31sODJ2GD2b4Ye2tJQWOJZXAiLlawd/XPMCbSSJlOOaV7FUNnH/Z4Yd60NWiav/gOUm6Zn4wIfwILaBvaIyrlHtXODY3z/TDIctrnmaxsqcBTZpvaOEq2L65oygMv3VtZ9WNodt7ykRmP0+9yayqqRdIS6toX/Y6SVTqPNtJdaGZo/4vt9I877ZfyT+8IzwpFMPoP/ySKRUAn1DRjlCmOfX1OBdh0oOEOcNXPykpcLq4TIkC0gCnwlgBct5Lft9ppF+dYT8eAziUbT9VvBcSK65VJuI65jW+vO1A== Received: from CH0PR12MB5091.namprd12.prod.outlook.com (2603:10b6:610:be::10) by CH0PR12MB5299.namprd12.prod.outlook.com (2603:10b6:610:d6::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Tue, 12 Oct 2021 14:48:11 +0000 Received: from CH0PR12MB5091.namprd12.prod.outlook.com ([fe80::59bf:640f:7140:ab97]) by CH0PR12MB5091.namprd12.prod.outlook.com ([fe80::59bf:640f:7140:ab97%9]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021 14:48:11 +0000 From: Dmitry Kozlyuk To: Aaron Conole CC: "dev@dpdk.org" , Slava Ovsiienko , Anatoly Burakov Thread-Topic: [dpdk-dev] [PATCH v6 3/3] app/test: add allocator performance autotest Thread-Index: AQHXvn4FoLvS7deeoEusH1W5HJFmcKvPZDBIgAAD0NA= Date: Tue, 12 Oct 2021 14:48:11 +0000 Message-ID: References: <20210921081632.858873-1-dkozlyuk@nvidia.com> <20211011085644.2716490-1-dkozlyuk@nvidia.com> <20211011085644.2716490-4-dkozlyuk@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3cace45c-4f81-485f-9841-08d98d8f504c x-ms-traffictypediagnostic: CH0PR12MB5299: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2276; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: D5llKcZ0/vGeorsj8rDpYR+jXSWErsDuBXf3HpmBtZ1IogErHZdLqHelVh5cFNrrXMxJ6siLzWa6vmaKKxVxM6QQTUmqWPzR2dg2CrpeUO/QKBOYOYiTMS3v5c88kaFLJwhHi10A04GstMaQLrLUkk7MHPF28NIXr6YqkkYF9FptJeNUX9HZgrAKVYUwqIwmLvLg22i0NJClxycV2kQxmgz7VbenU1bWkY4SNTeyckmW4QqF/QkfQVSSIqK0fpolONuCQgfkCQ8ot10PZJqi0HKGE0GbiN/3HBwtv9BuxrjfO3e+z0SZEykfmtvIGICqQvgY9GdOxITI6nob6ohiEd8W8bJvplSmeaNgCX1n09Zy8DNI2XN+NwimzZcry0htOALa+K4O/cZHa5jA/LjiC+Gz4114cZmOvyskmaZSeDQvNFXGHJh9BjIZj3aaZ7fFayEistzNm2/xSDx2FJtD1CoqlKQ693WQl39u4OBCLfp7FKKRL8YMAaGH6Pu2/9n6MPIag0NPIr/3aAPAjb/nAHZsgK3htWDJPupVXyEfgUoM1Y+8gXXwQNQgYLQhfU5j3pXfST+wPqT0lFGNLha2PX5QlNTphbTKMJ+Fb117Im5WlrgJ7K2UWouqFy17UtPxGxkEmYYcSTWXR7/FnGV0FswJ3ymKOsgfwv1hjEXGpHroCMEWnUgUWI+qkRXcQCWh4Yj58YIVVh4tNdY1tJf/mO1Y0QuqWPQuhPy4NG2tp/A= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH0PR12MB5091.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(52536014)(55016002)(38100700002)(54906003)(508600001)(5660300002)(122000001)(33656002)(7696005)(4326008)(26005)(38070700005)(6506007)(6862004)(86362001)(9686003)(316002)(2906002)(66476007)(66446008)(64756008)(8936002)(66946007)(8676002)(66556008)(71200400001)(107886003)(186003)(76116006)(21314003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EWBxcYQgMGLpGi7j03VjT5nPflGvuy9svkCHBw43PParS5+cnw6LjKLwdQ6+?= =?us-ascii?Q?i3FFKP4x6G00na/kmHLfXNQbKYhspzBgyNr0ejTicYN2OyBrye7C9squSjF9?= =?us-ascii?Q?DtdRN4L4LT/yEu2EU5Tvc5Jr6vYwhQAij0JfrmzwUKYVyqO3QlZSsM5S75bj?= =?us-ascii?Q?lZfxI5oz82kRma8AJNy9iFT7G3e88GoJkDNJwB9SUsrWTKWhE+EjrhuDpZQq?= =?us-ascii?Q?sxh7Cjrn5erUiyYLh5hW+WqwJ0Q+m+SZ+0uwYuy+Wz7PFBCqvtrmvknCo1lP?= =?us-ascii?Q?XDlXAxGQAUlD0V5HIyGhieqC7s4nMHJWRR3//am4VnW39NOHTO4ft5wZ1NtM?= =?us-ascii?Q?2utHCUIYLiy5hOuCCZ4PWxVe2Xp/SIlp59MvvumPAjElPApP68xexJR8kPu7?= =?us-ascii?Q?sdZCyWqKik1vLcP6TXU73vFQww1Nn17o7VH/KCaoKRL2JiT2BCKDQeNQoaA2?= =?us-ascii?Q?Wp37WpxcJ1f8zpw8sO5D/DjsLUoDNImYU5Ndl3F63cW5YfNpxkUsYI0vMdaZ?= =?us-ascii?Q?hhRn+f8GG9U5khPAz7BIdyxX4o7YQ50vWuIxhO7OyGCZRZDIA/cneXupokxz?= =?us-ascii?Q?7cmw8SCcIDAc8PL+EeWFg4xtUpHN6k6ye/T8Bn7YtQBDp9k1rDJm4vQbpUxS?= =?us-ascii?Q?8lh3sV6tNRYMVLeWkjqOb64tuI0rgjJ2wehv99ljG8X7AXoIlpJMu6NnAb3X?= =?us-ascii?Q?6/ROAdtsOZsX8DY5tVH6pDBdicbnRxnUosE68FijP45905Lzj86UaWX8V0W1?= =?us-ascii?Q?W2Kz9BV3pzFIjIa8grdbt5QYIRVXFP684RmkmiGt3NdBHQedpA4L5+3qcOJ4?= =?us-ascii?Q?MUFykvjBsulWUIgqEIsAdaW6EgCF79bG77mpNwlhOuVdMNQHo5yikyTBejwO?= =?us-ascii?Q?Te8H48r1BNtp1r45FtmSNr5K4W1fq70/vVubJ4OX50FtJDEdD2/eGHW7MsLb?= =?us-ascii?Q?6L0XRnkIL5ke5O0jih+4jpZPCu/nmtw6uD07446golR2e41b4kKVuj4JmMC+?= =?us-ascii?Q?lyXqyfX93rrE/N8qlUmD90a8cM/UjXz/+zWP9O4+iXBx+FEnZ367NKQlRIkk?= =?us-ascii?Q?dL4XG/8dzsamHe09jg+uLQZTXtZUSBLWbETj+FbSrLKYMAdHOununorkXgKL?= =?us-ascii?Q?EGjyQu3/sNRTSjL5TCyWEcFM1w8tA8tDdyyDWHT5ozvQs73S1n2tim/XQ1Aj?= =?us-ascii?Q?ATtUxRsuOH5Eq0788j47iWwPtoB22SqcPXI1m9Pid4sxrWiHBHc2J/IV3OvY?= =?us-ascii?Q?PRZdLcLKKFkh2MoOYnm/WPyz+P/DWjIdlLYxc21iWR2NhZdxC2nBXgFRbwY7?= =?us-ascii?Q?jUc=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH0PR12MB5091.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3cace45c-4f81-485f-9841-08d98d8f504c X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2021 14:48:11.5955 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: t7pqZC0/e14GCXObuJf88jfbyWLKC1EuvcBzKbBX3fXG3A4p8c24ZWExKKdCZzNiSUUx9gtJBMjCF8T9oK9KIQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5299 Subject: Re: [dpdk-dev] [PATCH v6 3/3] app/test: add allocator performance autotest X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > This isn't really a test, imho. There are no assert()s. How does a deve= loper who > tries to fix a bug in this area know what is acceptable? >=20 > Please switch the printf()s to RTE_LOG calls, and add some RTE_TEST_ASSER= T > calls to enforce some time range at the least. > Otherwise this test will not really be checking the performance - just gi= ving a > report somewhere. I just followed DPDK naming convention of test_xxx_perf.c / xxx_perf_autote= st. They all should really be called benchmarks. They help developers to see how the code changes affect performance. I don't understand how this "perf test" is not in line with existing ones and where it should properly reside. I'm not totally opposed to replacing printf() with RTE_LOG(), but all other= test use printf(). The drawback of the change is inconsistency, what is the benefit? > Also, I don't understand the way the memset test works here. You do one = large > memset at the very beginning and then extrapolate the time it would take.= Does > that hold any value or should we do a memset in each iteration and enforc= e a > scaled time? As explained above, we don't need to enforce anything, we want a report. I've never seen a case with one NUMA node where memset() time would not sca= le linearly, but benchmarks should be precise so I'll change it to memset()'ing the allo= cated area, thanks.=20