Re: [RFC PATCH 2/6] net/ipn3ke: drop unsupported per-queue xstats

["Xu, Rosen" <rosen.xu@altera.com>]

[-- Attachment #1: Type: text/plain, Size: 2435 bytes --]

Hi,

________________________________
From: Bruce Richardson <bruce.richardson@intel.com>
Sent: Tuesday, September 23, 2025 10:12 PM
To: dev@dpdk.org <dev@dpdk.org>
Cc: Bruce Richardson <bruce.richardson@intel.com>; Xu, Rosen <rosen.xu@altera.com>
Subject: [RFC PATCH 2/6] net/ipn3ke: drop unsupported per-queue xstats

The ipn3ke driver does not actually report per-queue stats, it always
sets the values to zero, so drop the flag causing auto-generation of
these meaningless xstats.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/net/intel/ipn3ke/ipn3ke_representor.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/drivers/net/intel/ipn3ke/ipn3ke_representor.c b/drivers/net/intel/ipn3ke/ipn3ke_representor.c
index feb57420c3..c5aca0ea8f 100644
--- a/drivers/net/intel/ipn3ke/ipn3ke_representor.c
+++ b/drivers/net/intel/ipn3ke/ipn3ke_representor.c
@@ -2124,7 +2124,6 @@ ipn3ke_rpst_stats_get
         uint16_t port_id = 0;
         char *ch;
         int cnt = 0;
-       int i = 0;
         struct rte_afu_device *afu_dev = NULL;
         struct ipn3ke_hw *hw = NULL;
         struct ipn3ke_rpst_hw_port_stats hw_stats;
@@ -2200,13 +2199,6 @@ ipn3ke_rpst_stats_get
                 stats->oerrors   = hw_stats.eth.tx_discards
                                         + hw_stats.eth.tx_errors;
                 stats->rx_nombuf = 0;
-               for (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS; i++) {
-                       stats->q_ipackets[i] = 0;
-                       stats->q_opackets[i] = 0;
-                       stats->q_ibytes[i] = 0;
-                       stats->q_obytes[i] = 0;
-                       stats->q_errors[i] = 0;
-               }
         } else {
                 ipn3ke_rpst_read_10g_lineside_stats_registers(hw,
                                                         port_id,
@@ -2931,8 +2923,7 @@ ipn3ke_rpst_init(struct rte_eth_dev *ethdev, void *init_params)
                 return -ENODEV;
         }

-       ethdev->data->dev_flags |= RTE_ETH_DEV_REPRESENTOR |
-                                       RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS;
+       ethdev->data->dev_flags |= RTE_ETH_DEV_REPRESENTOR;

         rte_spinlock_lock(&ipn3ke_link_notify_list_lk);
         TAILQ_INSERT_TAIL(&ipn3ke_rpst_list, rpst, next);
--
2.48.1

Reviewed-by: Rosen Xu <rosen.xu@altera.com>

[-- Attachment #2: Type: text/html, Size: 6163 bytes --]