From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBECCA057B; Wed, 1 Apr 2020 12:03:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2C7DB1BEAE; Wed, 1 Apr 2020 12:03:14 +0200 (CEST) Received: from rcdn-iport-6.cisco.com (rcdn-iport-6.cisco.com [173.37.86.77]) by dpdk.org (Postfix) with ESMTP id E81DD1BEAC for ; Wed, 1 Apr 2020 12:03:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=739; q=dns/txt; s=iport; t=1585735393; x=1586944993; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=2AoSrQlrRNyFaMSw0nRLHyvNe3qt6MbHVGvsBfUkK3s=; b=XlBUd/6lVfuQQ35wkvjrJxVUsRo9DdNbX0gIVEC3E4TvOtHuOSgQaMZQ la5GyuCN8aoW9QBCDNdRsBi4tUV4U9+APRvTL0VgJXRq2FrOTuDa0BI3K uxaOfhRDrOqaqbRCroyGIbD24RLBsXtwi3EDbkCxm8ImZgr0h38rCZUDD o=; IronPort-PHdr: =?us-ascii?q?9a23=3AONcOghOUJh0SFEj/P8wl6mtXPHoupqn0MwgJ65?= =?us-ascii?q?Eul7NJdOG58o//OFDEuKQ/l0fHCIPc7f8My/HbtaztQyQh2d6AqzhDFf4ETB?= =?us-ascii?q?oZkYMTlg0kDtSCDBjxI/fsaSESF8VZX1gj9Ha+YgBY?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AUCACTZYRe/4QNJK1mHQEBAQkBEQU?= =?us-ascii?q?FAYF7gVRQBWxYIAQLKgqHVQOKbYJfmB2CUgNUCgEBAQwBAScGAgQBAYREAoI?= =?us-ascii?q?2JDgTAgMBAQsBAQUBAQECAQUEbYVWDIVwAQEBAQIBEi4BATcBDwIBCEYyJQE?= =?us-ascii?q?BBAENBQgagwMCgksDDiABAwuifAKBOYhigieCfwEBBYEvAYNwGIIMCYE4jDE?= =?us-ascii?q?agUE/gRFHgU9+PoJnBIE5LINCgiyYDphjCoI9h2GPU4NOmCCPG4MghXiSbQI?= =?us-ascii?q?EAgQFAg4BAQWBaSINgUtwFYMnCUcYDY4dg3OFFIVBdAIBAQGBJIsygSIBgQ8?= =?us-ascii?q?BAQ?= X-IronPort-AV: E=Sophos;i="5.72,331,1580774400"; d="scan'208";a="749500955" Received: from alln-core-10.cisco.com ([173.36.13.132]) by rcdn-iport-6.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 01 Apr 2020 10:03:11 +0000 Received: from XCH-RCD-004.cisco.com (xch-rcd-004.cisco.com [173.37.102.14]) by alln-core-10.cisco.com (8.15.2/8.15.2) with ESMTPS id 031A3BtV030353 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 1 Apr 2020 10:03:11 GMT Received: from xhs-rtp-001.cisco.com (64.101.210.228) by XCH-RCD-004.cisco.com (173.37.102.14) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 1 Apr 2020 05:03:11 -0500 Received: from xhs-rtp-001.cisco.com (64.101.210.228) by xhs-rtp-001.cisco.com (64.101.210.228) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 1 Apr 2020 06:03:10 -0400 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (64.101.32.56) by xhs-rtp-001.cisco.com (64.101.210.228) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 1 Apr 2020 06:03:10 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G/k0zQ7fzyc0kdxhMqY591tNHU2hEL8muD/IVByEExkS+cSsN0bHrFwk3dTtv9w5BnXK1MvMIreSg1Dm8782QslvpTdXUol72iZgxynjPc0KWhDacvyA0vIGXibNLo7QITkoZd4km9t6agsbrn+vuQwQcEf2VhKoxVjLLxGgBOhbc+INFMgnE85kLMjadKpyXdhP5g1gJRMVmEHoGag/krY5CIFZg6PpivaGJ5GkAOzveS8aUq/GXf6bssIEe7Pq7b6CsCW53IHa5n5AStB58ZRadCC295eeeIYWeJroWEkCvVMEXiaXruaf1ZwKi+dKah2YcKrBKXtWGY5hkD2DWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A2S637NdSP44oSd/TZnxYHsE+CThGrpo7v1tISAXCxc=; b=YHHl/wKoxF6wVStJzIyunz4mn54zEIT5cXmMJSohJ1/VOmLGhWNFCTxTYwtaLQ3evpyfcQUNhHJXW1DIJo/PL4w/1sKs3i9tKaXkZcyYzaYUUzKfJng4oDpOH4zAnFN5ma+2l8FGcjeaCDNdLJJLQ4WboQAtmdeUnAM5hpGPah9RGqLb0YIga+3bEM6Dm4Zh+TNLhzm7Fkc6A0NcD2/8tSYh2R5APjbJ5ZdgJqKBMeW4zYmr4eDfKXeizY5cKFdPDhNfTIVJTVEDR3SQ5o0u+CxWj6LDMwqtP7HnZlFKFaSq2euGznqEqn0kfyYlRy/A4sb6Irj4hhniRf6Zi6mq8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A2S637NdSP44oSd/TZnxYHsE+CThGrpo7v1tISAXCxc=; b=iXqmtRr545FGJeEcq/mA4QfOFxCntrx7bwXRmRYmqza/HMlyYBps+Z931F1F08SLzW4HCCRCgpY5/k7K02UTZ9V70W0ZFEek1qEQiNPhNX9tYFNVxm1w7QOG2nB5HH3QgMhMve9ioEoZF6HNldVk94jc+P6YaNwFhBPNfv1Fy8o= Received: from CH2PR11MB4327.namprd11.prod.outlook.com (2603:10b6:610:43::30) by CH2PR11MB4280.namprd11.prod.outlook.com (2603:10b6:610:3f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19; Wed, 1 Apr 2020 10:03:08 +0000 Received: from CH2PR11MB4327.namprd11.prod.outlook.com ([fe80::2d84:413f:5702:c519]) by CH2PR11MB4327.namprd11.prod.outlook.com ([fe80::2d84:413f:5702:c519%5]) with mapi id 15.20.2856.019; Wed, 1 Apr 2020 10:03:08 +0000 From: "Benoit Ganne (bganne)" To: Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , =?iso-8859-1?Q?Morten_Br=F8rup?= CC: "dev@dpdk.org" , Matan Azrad Thread-Topic: [RFC] ethdev: use special speed for virtual Ethernet devices Thread-Index: AdYICKdJHmTupuPzSMalW7qyfRNRlAAAr+4AAAAX5yA= Date: Wed, 1 Apr 2020 10:03:08 +0000 Message-ID: References: <98CBD80474FA8B44BF855DF32C47DC35C60F2D@smartserver.smartshare.dk> <2254486.aKNjEaI27c@xps> In-Reply-To: <2254486.aKNjEaI27c@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=bganne@cisco.com; x-originating-ip: [92.154.90.183] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3c24c9ef-c3ac-44cf-6769-08d7d623e15a x-ms-traffictypediagnostic: CH2PR11MB4280: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 03607C04F0 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR11MB4327.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(136003)(366004)(39860400002)(396003)(346002)(376002)(66556008)(478600001)(33656002)(64756008)(9686003)(54906003)(55016002)(7696005)(4326008)(66446008)(316002)(52536014)(6506007)(81156014)(26005)(66476007)(4744005)(76116006)(71200400001)(966005)(110136005)(8676002)(8936002)(81166006)(45080400002)(5660300002)(2906002)(186003)(66946007)(86362001); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WRpPGd6XlSV5QWoqqgeS2dpCiHvYS2VRRMK8tDSgIC6yjPBO7+WIW0IXwF9eMyHfI99nUmumsK0ytM8wlivx10D1xw6Lyz+2/d/xU6fVanuGqv+/usgjiviX0JT9KKXn4hupd3AiHRwtGOX24T5V8zIpleq5C7RurC7he9lSKlh+OKVDFm7PrMbinpcZGzP899DSMkn6M4CzTx06QYuynby1fNwDGljXRG9ckCHD1eE3lhBKNC/m4r62vcuF0OxYGacnkN0fCXir0CwDZaPRCyqrWuQkC1q2D3JNIlaXqqh66ijvTMInzQGwzD2dWi/R1BRpJnvDQw+QVbGzOrnBSSxPIOSWJW3QJ4hBXTaZriC4RLcKbtxhIX3mYERdJwgxKEPvV65vkIZ57d9lpza3dmeV8MGUOHwAa1/qZr0XfnxE7YXdxm6/xsOqPL2ATukMqymv4FkYC/lSD6TuPUD2gIrBiX/I6iU8PKIH8EsOcjEWJ6gwcpQwjuIkLrgs/jz5BKDoqk2wXc0rAVjeF8ik9A== x-ms-exchange-antispam-messagedata: wAjnBpW5qq8LjV2800FwMX5Ux9gBm0nzNptwpfRRksS4Wk1wJg18nwzgHsj/TMRdKg+2D4t2aJr6fSoJBl9fZ21SiH1ETMqMuCD0UL8zvI5dJuBergmHP6/PUpxOz17xP7vUvIEnbL5ty0Ay/t9jGA== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 3c24c9ef-c3ac-44cf-6769-08d7d623e15a X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2020 10:03:08.7743 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1QYrFSd35tH0UOewpH+ySkoCEB9r+6MMqfNbzDxiXpk6gKkCZkYcd7ASPvw2lut+oaO6m59sSJoOaMbwEmiODw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR11MB4280 X-OriginatorOrg: cisco.com X-Outbound-SMTP-Client: 173.37.102.14, xch-rcd-004.cisco.com X-Outbound-Node: alln-core-10.cisco.com Subject: Re: [dpdk-dev] [RFC] ethdev: use special speed for virtual Ethernet devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi all, >> Alternatively, we could expand the meaning of ETH_SPEED_NUM_NONE: >> -#define ETH_SPEED_NUM_NONE 0 /**< Not defined */ >> +#define ETH_SPEED_NUM_NONE 0 /**< Not defined or unknown >> (virtual device) */ > Yes I agree with extending the comment for NONE. >> The special value could also be used in cases like this: >> >> http://inbox.dpdk.org/dev/AM0PR0502MB401907ADE7CEA27DC642DF35D2CB0@AM0PR= 0502MB4019.eurprd05.prod.outlook.com/T/#t > Yes, if speed is unknown, it should be reported as 0. Ok that should answer Matan concerns: it is perfectly fine for a PMD to ret= urn ETH_SPEED_NUM_NONE if it does not have better information. >From my app writer point of view it makes sense. Best ben