From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39F71A00C2; Wed, 2 Nov 2022 04:35:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 294C140693; Wed, 2 Nov 2022 04:35:56 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 21F6840223; Wed, 2 Nov 2022 04:35:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667360154; x=1698896154; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=V8ES+GXbfgNzRqk3w9+Di3swLYR/K9OQfRQ+T9n5AzY=; b=nbY5lyZ5sglDD9AhCXvuf5n1ubQ0/qlORbh/60VMGZsQebo1eW+GcZ5b VMQh5pwfw3SDxm7gliHLJSQcAXQsjG89cWrX42hbMVSs7GOJm973eYIIK 7RcasTnF7cE5Rvkdh7d79JHnflRSKDjX4MZvVL8rnskDPxdYiug8XJ2kV qpc+YE5Ejwju45gOcTLa44C7Epnzl1G413IGUOfCU5i766sgNLA833bfZ 1Tz/c8rvS+Fa3AruvdjMNSq/eflMr+juyHOB7Xf5dPS3ucdl2QS05KGcT qHoqiC5GLwsKoBvaIDABRg0vsF39Adq2bWz0Ma+ozwM3ZbYT4r4n7fpou g==; X-IronPort-AV: E=McAfee;i="6500,9779,10518"; a="289691913" X-IronPort-AV: E=Sophos;i="5.95,232,1661842800"; d="scan'208";a="289691913" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2022 20:35:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10518"; a="628803042" X-IronPort-AV: E=Sophos;i="5.95,232,1661842800"; d="scan'208";a="628803042" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga007.jf.intel.com with ESMTP; 01 Nov 2022 20:35:52 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 1 Nov 2022 20:35:52 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 1 Nov 2022 20:35:52 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 1 Nov 2022 20:35:52 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 1 Nov 2022 20:35:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UwjflN3P25SWRf9NStV6kYC2bf3SX6LEG4DsKJTlWOGDITse7my1bjict1bzL053PlB1VaagNoAQB7sIBsCWo1WMUSm5UxqER+HzvwmcdZB6DXqsGM2nwXY16JQzWuTSpRuwKgIXTdgCv031PZFS2isChKI6yY7VWovfGKdJO68s7imYzUVnfACsrc8w1C1t5C3O6omih/Gb2WemjMXBsk5EmjojU4o4pAIDc0IgNBzM4uUq4d/bM8vrwmhDnrkiiv11yHBn07k71a3z1uZeA2sj9g33LIzlKEJmiS4cdIJDVkxQyD2WMkbLa3j/dWREr9oY8aMiZUEoWYdMLt9xcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V8ES+GXbfgNzRqk3w9+Di3swLYR/K9OQfRQ+T9n5AzY=; b=mPbZ/PDdqR4SBELJWeAOtIq4qR+Gs09uCu+LV2e1byMTrhiZ2D5i2Ei2mTY8edbw8ClZ1gz8EuEV6oaq2MMFKVCGfoCLnQHSWJLJMmDUbxfr2AyF1C4UtLniAGiuq7rvH5XSPppD6n9ZF4ZcJJGV89a9fyp5TlEHs5EHeZoaPFqxy7jSnG+57G/6+jmzQ1/Jg8Yn/VsnVWRrS/HObtbRNCouTct9N5ZX9bstb8m4AviMzSD7T7/YrLAc0Wyunb8F5Z5TTW+NMCz+8hd/C8i63h6ISAnY4kHkUgTVr5Js1EHPUlDon4sWwf2X3uYJOzhYKAVXcMEpwLPw8vDxqgyWgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CH2PR11MB4487.namprd11.prod.outlook.com (2603:10b6:610:44::18) by DM4PR11MB5440.namprd11.prod.outlook.com (2603:10b6:5:39c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.21; Wed, 2 Nov 2022 03:35:50 +0000 Received: from CH2PR11MB4487.namprd11.prod.outlook.com ([fe80::d2d9:44ee:8c8f:2356]) by CH2PR11MB4487.namprd11.prod.outlook.com ([fe80::d2d9:44ee:8c8f:2356%5]) with mapi id 15.20.5769.019; Wed, 2 Nov 2022 03:35:50 +0000 From: "Yuan, DukaiX" To: Ivan Malov , "dev@dpdk.org" CC: "Jiang, YuX" , Chas Williams , "Min Hu (Connor)" , "Burakov, Anatoly" , "stable@dpdk.org" , "Andrew Rybchenko" Subject: RE: [PATCH] net/bonding: fix device configure reentrancy Thread-Topic: [PATCH] net/bonding: fix device configure reentrancy Thread-Index: AQHY7g4ZygjBHHgBv0amlADDBwCyC64q/B4g Date: Wed, 2 Nov 2022 03:35:50 +0000 Message-ID: References: <20221101161853.2702425-1-ivan.malov@oktetlabs.ru> In-Reply-To: <20221101161853.2702425-1-ivan.malov@oktetlabs.ru> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH2PR11MB4487:EE_|DM4PR11MB5440:EE_ x-ms-office365-filtering-correlation-id: 5febe3c6-23be-46c9-77e6-08dabc835699 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DoQBQdClPMSDKOth0KabIhdakYq8aYvfK2YeKOzAetL3nAd3SjPlD5QTHJPtKU58YNK0PM9rSODN+Y4o4XW5zaIpHiCu4FherO0WdPOL6UCX5z821AkIYbzrHTQRIFnnSi8MIc7jn5C328FjK8nooETdDocSfeV/1pWduRRymGMVQ2YIWptAQYJ5a7x1A+tsUHqhDLDPFyM31p5eBiO1En2q3RLksfS3leogNRKBdoB+CLbRO4QjOIIIA03gj5Mv0lbTaKPJjSXlw6QI7NAmQsuQt1o1cxKIfi98gqbcjfRhEQ7NUziCxBfqdnDzJB+2GnARqe7Muwl3j1AUiDm5IfxAMzut96nlMLfJLdpACZNtzqtERLBvBkzhsXIIsyM4H3Had7yPklf9P/tlXbi2+r6dEloLQpS/G2e2BHDfzFvkAlGhjnXhn4LGJjiyovG4eNtIXHYwKj1zVXhlt5NfvA76eSid0qEiVjrIrft1fcvinVs1ifiGt3/T6sEijG+xvYNCDVQ3W/g2vBw4WRRDWOCz2WzCBnidCanOaiLqOIMrx6oKdhGJZKrYtAl0S0x3HUNBcD9YOWYun9STSh+V9+pOk19ReOOEDNKrAx66dL0sr3Hz5ciQfKbCDDUfe0SoKtwpn+kbYX3ZvpD5ir+n+QeMSv/v9okrsmg9sDXAGOkFzbIGmheFegZHKM6ICTsOGRT02DkfSxCHLHh1g3lWGS7tz7+wCrNaq58HH8EQY0r8eS+cZc6TsrTafq7HmFd+tmoY3Nl55kyCUMrsNY675m492yI2adozyAiTSBQaXEU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR11MB4487.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(136003)(346002)(396003)(39860400002)(366004)(451199015)(8936002)(52536014)(66446008)(110136005)(54906003)(66476007)(64756008)(316002)(66556008)(76116006)(5660300002)(66946007)(41300700001)(4326008)(4744005)(8676002)(38070700005)(2906002)(478600001)(38100700002)(122000001)(71200400001)(26005)(53546011)(6506007)(9686003)(7696005)(966005)(82960400001)(83380400001)(33656002)(55016003)(86362001)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?OVZMQ1pGTkhGZWErZzhRK0k2czBvR01vSEhqelQwTE9Fa25LUk1HU2RS?= =?iso-2022-jp?B?a1BiSzdZNHFubmEzeE5yZzFyeHVEVVhPMHBvZDJFWTdHSng2c0Y2QUZy?= =?iso-2022-jp?B?S3NVWUdzUkZlbTdYaWd6MjlLSnpibnhUZ2M0RlhkSUF6M2F1USs3TlM3?= =?iso-2022-jp?B?djd1RWp1ZlBqQWtXcEFxM0RCSE5hSzQ3UUtYQXkwTzJsMDYxTEJGU2pX?= =?iso-2022-jp?B?VUx4SlY2UmNGNFhJdFVsR2pVcEE2enFTTzV3MzhaOUZlVDZMUnEyb3U0?= =?iso-2022-jp?B?OE5LRDZQTXBVSURva1FrbXBuTEZDU3JlT1BINDRYSmp5OVpjVk9NY0pJ?= =?iso-2022-jp?B?YTUrQjNqeFlEdkxxZnh2QWtFMzk2U0EwNmdNdXpOZ3NwWGwzQ1UzeTc2?= =?iso-2022-jp?B?TnhJSGdPWkNDNm1Vb0d4aTVIeGdwOGo2cElKa29IV3VBdjJDUlVrNndE?= =?iso-2022-jp?B?cEdGejVORGE4QTZVNTdtdEZ3c3ZLS2xOcjhPZU1QcTZYdENKTS9MY3dn?= =?iso-2022-jp?B?ZTBnUVpFYnIwajZUZnpuakRGVmVWUkhtNHFoS2M4UTdmSGlRYS9wM0Nw?= =?iso-2022-jp?B?OTZOUkMzc0txNzJQKzJhU0taN1RqUGxhb0gzbC8wYURKZVQ1ZENubzRC?= =?iso-2022-jp?B?TW1hS21uMi9mT2l4OTNpMGJIK0xPSUQwK2VacTNkdWlZWWNJU2ljVTZQ?= =?iso-2022-jp?B?WE5pK2lIZW5NTDV2b3NQaTF0eWNoTklIVFlkOTNyRUU2Y3JKZkJsVDJj?= =?iso-2022-jp?B?S2FveFBaK3V6Q1g3MjZnai9LR09vQ3Bad2hOeHNxSitQMVY4WXNBUDZz?= =?iso-2022-jp?B?WlhyaGIyL05uY005ampNTWszUmRiWktLZWh0dXdhekljbk8vc0xyRkNp?= =?iso-2022-jp?B?WnlPVWZHYXlONEUxL00rNmpJbllwZFVUWXo0Yys5RS93YWtMcGNWNDdL?= =?iso-2022-jp?B?OHNlRTBEbTZMaW9HVHJjK2VDODJ4Q0Y3RlhJQzNOVkFuL1N1MXVudTdB?= =?iso-2022-jp?B?LzlRNjRmdlRmVTVxdUxuaHRRN21ZTkEvTlNIcTBVLzZPR3o0TGlxTnJY?= =?iso-2022-jp?B?aEx2eUpyejJHRUpvSFhZUnR1N3NMaTBHSGtUcEs4YytNU0hnZlBVRmMv?= =?iso-2022-jp?B?N3poOVYvNnIvYmpCRTM1NUpSeTd0K2YvdUpZK2FLNXdWYS9JdDFTeXNs?= =?iso-2022-jp?B?SEZiYzd6SThsMnRSUU1ybVZPMS8wZUJTU1AyTXhVWFZPZmh2dzZtVEZo?= =?iso-2022-jp?B?TzgzTUZLc3ZrbHM2S0J4ZDgwWUYrWEpVM2o5c1Jta0dxRGRHUCs3Y3Bx?= =?iso-2022-jp?B?MkU3dk52OUUzSDFHbmxOMjg2RWQrZFFzRVYzWnZwZzJyQWJoM0piNkFF?= =?iso-2022-jp?B?QnRUK1Jjb09iKzBiRi9PSXpVYlZFNWFub1FkYzR4UWlHeHlDQVBxeitO?= =?iso-2022-jp?B?R0ptNmNlZDNSUkR4a3A4MGNoTmhpZ1lTNUQwdVd2bWJEeWUvNCtXenVQ?= =?iso-2022-jp?B?N085QndGVnhldEFPN294Tm9WZ3Y4bTV2enMyeXRndWU3L2lwaHBCTlpo?= =?iso-2022-jp?B?RzRJejRKNDRyWHlKdzZ0cFNIUG5uTG82ZnRmNDBJeFc3TGp3NDFhZjN5?= =?iso-2022-jp?B?ZnUxZnkvWW5WLzVKZVhLU3p5WllCMVhLRWJoZzFiTUMwVkV6dnFOcG1q?= =?iso-2022-jp?B?UXEvSzlVMmtCckxVRjB1enZtaXlYd3NXeks4T25WZjRrOG40M1BsV0g5?= =?iso-2022-jp?B?dHFUTEdpWFJibVBoRUgvMVRwR0xEZTR2dFJ1VmtxU2h1NE5rT2VvK21k?= =?iso-2022-jp?B?OWtGYnR4bnRTN2tVMTZDNFp4L1B0MjQxazZnUTJscy9ZQTNaMzMyWVFj?= =?iso-2022-jp?B?WXdVUnppV1RZem1FbDdNK1NBdnZDWi9CdWQ4UUlwaVlXVkxzNXhZNmZi?= =?iso-2022-jp?B?alN4dmZMUlN0SVB5ZW13WkQ1ZUt4RUIySkZabFRkelNEUFBYWHlhTDZy?= =?iso-2022-jp?B?Y2dLNTlPd0pzenRjWGJiV0IxeS9rR1RzVUgwSUh3N08zeEFOWWJnQUEx?= =?iso-2022-jp?B?SHM5Smx0dlg5aSs1cmlzZEx1SFNvOWF1cnpyQTQvTXpWZUxwTlQ5RnhX?= =?iso-2022-jp?B?TFEyVVNOZzFRRGZHcUs2VUZDVEtncW11eU5iZm9NWFEvTDZQTVNQZDZl?= =?iso-2022-jp?B?Sk9Oa1orcnpLMnZOcnlkYTM4UHEya2IwK1FkYmJYSFFZYSs5Y0psYXJ2?= =?iso-2022-jp?B?QmplY0JZQTdNMDFwVFNSV1E1a2M0TURiTlpXNU1YeWdNWE1ER1UzMlIv?= =?iso-2022-jp?B?SFRwRg==?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH2PR11MB4487.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5febe3c6-23be-46c9-77e6-08dabc835699 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2022 03:35:50.5513 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GWWr4CqWSDA7iCz2DzmTsiwfBu+Dvd8BMy9N1S4jlOiT92tRir4Zh4NTUgtUGPa+ctDbI5XlJ+HDr6q8e2ZqmQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5440 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org -----Original Message----- From: Ivan Malov =20 Sent: 2022=1B$BG/=1B(B11=1B$B7n=1B(B2=1B$BF|=1B(B 0:19 To: dev@dpdk.org Cc: Jiang, YuX ; Chas Williams ; Min Hu= (Connor) ; Burakov, Anatoly ; stable@dpdk.org; Andrew Rybchenko Subject: [PATCH] net/bonding: fix device configure reentrancy As per report [1], the previous patch for device configure code apparently = overlooks the corner case of manually adding back-end devices to the bond u= sing testpmd CLI. The problem is in removing back-end ports on re-configure= instead of just stopping them. Fix that. Fixes: 339f1ba51353 ("net/bonding: make configure method re-entrant") Cc: stable@dpdk.org [1] https://bugs.dpdk.org/show_bug.cgi?id=3D1119 Signed-off-by: Ivan Malov --- Tested-by: Dukai Yuan