From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E3F0A052E; Mon, 9 Mar 2020 07:06:48 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 98AD02BE6; Mon, 9 Mar 2020 07:06:47 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 2790E3B5 for ; Mon, 9 Mar 2020 07:06:46 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 02961Cop015358; Sun, 8 Mar 2020 23:06:45 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=HvuIXtuMDRi8TFmqs3NtkLVKnL7/rhrsU5X1WOjkK2Q=; b=MuxW0F21d22BcghYiIuaIwfwQwfADfyOB9axroLyRHWKmPw9gJfEwOa6JC1yzMghZgg5 mpwXan7k3YQdjUEuwZu0Jz/bNB5QZ5i+HSxe5VgGvdfBQcmrU4nmDTikBw2TXMNShHCn AXgsoRKzhzXJi74djzrCrPvhugnp4gWU/fTNT4HsyOilwM3nImWuOLNl3fc0wwvVSADY LDqZoXtntx98sg51nBkLImNC6yhiDvOYr7qSDHIaGQPg87tSwI7d1vo/Lk1Edr3BGlDz +RHwBZo4LoWqQDz64ITNYpr4mWTej4hIvFYPNJbvkBLAP6r4V8K62mSZ/Fh8aT3be5WJ cQ== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 2ymc0sndvh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Sun, 08 Mar 2020 23:06:45 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 8 Mar 2020 23:06:43 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.106) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Sun, 8 Mar 2020 23:06:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BQPGBBwBkUwV+J6UgqQB3lCBi9i3z0QU9VvNM0RPhmHO5I+8oZ0JY/OmfLm4b1Qre9b/gS6LK9Uh37b5aV/GzhheGzQs1I+kbLygL9fKfpoAcJ4PhMlQtnPTKBA2GI7ftK1EfqGlwUtlsPYS0LsHsBb861rf4cSsapr/ckR+jFB+ANfvnK/PqAq6qXqROZ1jkGvaoL8Iuc6aaPPPKtgJK7HoIQ5jS1foPny7eMV0i1/vjZyFR3RLC/8u0693TIuH/QwFcfIMYvBxzxzEd3JyAMVjyIiIhn2R+LoGrqMl7qXtie/3J0fh6qkUlqSnCu0yJfFFOTH/s1YEgroPz3V9jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HvuIXtuMDRi8TFmqs3NtkLVKnL7/rhrsU5X1WOjkK2Q=; b=LDhUwpmvAJzd/oKnFXJiKbAFzRKRY0qcJ9JF6mrUaWETPcrjJHvUMlmevj6W8NhgI3cXZKhm082zG+QLfodhN3/0hB1cF4YQE/fi9+4kYQmg+pKp2FqOgFMxsWYmplzl564hHGIzdPvk+di+DZyunSjAqob3OOxK+lIx8A4mC3huU7UumzOzELogmLyrHStsIzWuxr2q8M2Su7lENldNkDKKeE1ayzHfdV/+f8cI8bXFAHK3t1N9XUC52qNjdDghfp9gpdOJ+276rwc3JmwunR8UVtjZw6e/+GUjpw0d6zRS2rqg24MD0wlqP9q6I0zUofoJTdmdWAWbzIqhVPk8sQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HvuIXtuMDRi8TFmqs3NtkLVKnL7/rhrsU5X1WOjkK2Q=; b=VeQ0tdr6kCuXDMMAzSCUsJ42Joa+oo6TCSmTWR64icWgrANMCUamg4MphMhlBK1m7t3UblAHwOMM/NmbdGMMhkkzxqCWWPp7mrexJhEzyhSTJOCXjn5pPYrVOjQzmyVF9cPwzhazGQGguYz4LasVUy7xpopdvZOrIiYTySwgjBg= Received: from CH2PR18MB3270.namprd18.prod.outlook.com (52.132.247.204) by CH2PR18MB3320.namprd18.prod.outlook.com (52.132.246.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2793.16; Mon, 9 Mar 2020 06:06:41 +0000 Received: from CH2PR18MB3270.namprd18.prod.outlook.com ([fe80::3101:508:56c2:a18d]) by CH2PR18MB3270.namprd18.prod.outlook.com ([fe80::3101:508:56c2:a18d%4]) with mapi id 15.20.2793.013; Mon, 9 Mar 2020 06:06:41 +0000 From: Sunil Kumar Kori To: Stephen Hemminger , Jerin Jacob Kollanukkaran , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: restricted bus scanning to allowed devices Thread-Index: AQHV0DZKpw74+THH9UiObz8P25Cnrqf38ULAgDb+awCAESDzMA== Date: Mon, 9 Mar 2020 06:06:41 +0000 Message-ID: References: <20191216075501.15669-1-skori@marvell.com> <20191216081317.30f10c9d@hermes.lan> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5dc99b59-9cba-4be4-74aa-08d7c3f00976 x-ms-traffictypediagnostic: CH2PR18MB3320: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-forefront-prvs: 0337AFFE9A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39850400004)(396003)(136003)(346002)(376002)(366004)(189003)(199004)(26005)(86362001)(8676002)(55016002)(66446008)(64756008)(76116006)(66556008)(81156014)(33656002)(66476007)(316002)(66946007)(186003)(7696005)(81166006)(8936002)(71200400001)(9686003)(110136005)(2906002)(55236004)(478600001)(6506007)(5660300002)(52536014); DIR:OUT; SFP:1101; SCL:1; SRVR:CH2PR18MB3320; H:CH2PR18MB3270.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RIvisDmm7ne8269/dlEiyD/loxz8K260fayJgsSLBaPVtzNAuMBybr+EcnkmucWY7uGMWOIrUbKfNJv0AF2/bXV4Ml2b80Bcc+VWJcbG/KqtNvFwYw4psWZ2gwM2nAp0L4ZU9gPcDu2Ca4wUANOBga5Y9/cUhnZlJxgMcYNsMtjp2D55hxUzb+jeKbxcJTLocMaFQjJcQ0oQhe/4Gs+aC9/ekjPrZ507IhIJJtGChHcIokzDdsrkMtF3RQz/Y1HqX6moXMMKoKN8evB9wYMvYw1zqq7N96PIiJq6zelwCjAUzc5EW4vJ8N6rHqb6ujViZgLzuJi84ZQOfmP/Ol+giYtnSHPm1VaSlYz02sNmwqZpDaIRVM96htYyyXT4YKRqTyxiXCKxO7fhxg7pD1+J1hj+m9WZ8qnPwHp+Ub/AhQWUcJmV5xjbmu5i+rqjw1Ya x-ms-exchange-antispam-messagedata: 0AkDDVPLKNm9FBI9YWQB46p88Xk5WfM0V61vab4hXL2j9rBRTI5jyZbuthCO8oxfOYyO91E3vrggyrY6iU56ZT/xifUQC5m3aAMA/ziKljN2qCfdRN2qiZZUhHcWtYr+D9qX6zOdxB3vSf+WbuP+Kw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 5dc99b59-9cba-4be4-74aa-08d7c3f00976 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Mar 2020 06:06:41.2471 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Rh4BmvlePiYOWnYf8S/3uMW9GyDahkeVc4gWYNEnqwGMjm7ND/Him3mJSi61TO4y3z69Zpcsl7A8bmPRHq/6Vg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR18MB3320 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-03-09_01:2020-03-06, 2020-03-09 signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: restricted bus scanning to allowed devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Stephen, Please provide ack on below change if there is no concern so that it can be= accepted on 20.05. Regards Sunil Kumar Kori >-----Original Message----- >From: Sunil Kumar Kori >Sent: Thursday, February 27, 2020 2:00 PM >To: Stephen Hemminger ; Jerin Jacob >Kollanukkaran ; dev@dpdk.org >Subject: RE: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: restricted bus scanning= to >allowed devices > >Hello All, > >Is there any thought on this ? Otherwise it can be merged. > >Regards >Sunil Kumar Kori > >>-----Original Message----- >>From: Sunil Kumar Kori >>Sent: Thursday, January 23, 2020 2:13 PM >>To: Stephen Hemminger ; Jerin Jacob >>Kollanukkaran >>Subject: FW: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: restricted bus >>scanning to allowed devices >> >>Hello Stephen, >> >>Can you please look into this patch or provide your thought in this ? >>So that it can be merged within 20.02 release. >> >>Regards >>Sunil Kumar Kori >> >>-----Original Message----- >>From: Sunil Kumar Kori >>Sent: Tuesday, January 21, 2020 2:09 PM >>To: Sunil Kumar Kori ; Stephen Hemminger >> >>Cc: dev@dpdk.org >>Subject: RE: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: restricted bus >>scanning to allowed devices >> >>Hello Stephen, >>Any suggestions ? >> >>Regards >>Sunil Kumar Kori >> >>>-----Original Message----- >>>From: dev On Behalf Of Sunil Kumar Kori >>>Sent: Tuesday, December 17, 2019 4:30 PM >>>To: Stephen Hemminger >>>Cc: dev@dpdk.org >>>Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: restricted bus >>>scanning to allowed devices >>> >>> >>> >>>Regards >>>Sunil Kumar Kori >>> >>>>-----Original Message----- >>>>From: Stephen Hemminger >>>>Sent: Monday, December 16, 2019 9:43 PM >>>>To: Sunil Kumar Kori >>>>Cc: dev@dpdk.org >>>>Subject: [EXT] Re: [dpdk-dev] [PATCH] bus/pci: restricted bus >>>>scanning to allowed devices >>>> >>>>External Email >>>> >>>>--------------------------------------------------------------------- >>>>- >>>>> /* Create dummy pci device to get devargs */ >>>>> + dummy_dev.addr.domain =3D >>>>matches[i].pc_sel.pc_domain; >>>>> + dummy_dev.addr.bus =3D matches[i].pc_sel.pc_bus; >>>>> + dummy_dev.addr.devid =3D matches[i].pc_sel.pc_dev; >>>>> + dummy_dev.addr.function =3D >>>>matches[i].pc_sel.pc_func; >>>>> + dummy_dev.device.devargs =3D >>>>> + >>>> pci_devargs_lookup(&dummy_dev); >>>>> + >>>>> + /* Check that device should be ignored or not */ >>>>> + if (pci_ignore_device(&dummy_dev)) >>>>> + continue; >>>> >>>>It seems that you are creating dummy_dev as an alternative to passing >>>>just the PCI bus/device/function. Wouldn't be easier to just use BDF >>>>instead. Dummy arguments on the stack can lead to more corner cases >>>>in the future if device subsystem changes. >>>Agreed and initially I have implemented using BDF only instead of >>>using dummy device. >>>But using that approach, I was not able to use existing APIs to get >>>devargs and ignore device. >>>I had to write almost same functions to solve the purpose. So just to >>>avoid having replica of same code, I followed this approach. Please sugg= est. >>>> >>>>> +/** >>>>> + * Get the devargs of a PCI device. >>>>> + * >>>>> + * @param pci_dev >>>>> + * PCI device to be validated >>>>> + * @return >>>>> + * devargs on succes, NULL otherwise >>>>> + */ >>>>> +struct rte_devargs *pci_devargs_lookup(struct rte_pci_device >>>>> +*pci_dev); >>>> >>>>Must be marked experimental (or internal). >>>>The pci_device should be marked const. >>>Okay but If I go with BDF one then this change is not required anyway. >>>> >>>> >>>>> + >>>>> +/** >>>>> + * Validate whether a pci device should be ignored or not. >>>>> + * >>>>> + * @param pci_dev >>>>> + * PCI device to be validated >>>>> + * @return >>>>> + * 1 if device is to be ignored, 0 otherwise >>>>> + */ >>>>> +bool pci_ignore_device(const struct rte_pci_device *pci_dev); >>>> >>>>ditto >>>ditto