From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91D1FA052E; Tue, 21 Jan 2020 09:39:34 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EC7321515; Tue, 21 Jan 2020 09:39:33 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 87CB8F11 for ; Tue, 21 Jan 2020 09:39:31 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 00L8ZwGo013283; Tue, 21 Jan 2020 00:39:30 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=I+jz4jcnwBdITbaf7Eu8YHCQBgddTm8O8A+owCgdz7w=; b=ltETVl9OXXg+LUtRhV4MDrtEAR9fl62f/8y30VW/tlpMBvBHHdoxbuiQDx+xJuxLdJPT EtxeelY+Kxf33m+3nSUHwjo9toxA3zLIFexe2cArHERW/KTYRvfbDjXMcdnnrUhmx6Bj kQbNzjpVOti9OqbFYksvPxpGQapZyG+CwOcLD80lmr6ZstXI0C647PxtLicrgy2Tc/kX IX44TDYYNR89QnUw7QAjRlmR3/KTcrtRmWxzKTXWffYXZ2jZCzAHbgXBDVWEH0OrGKKu D5VGqk9GuRz4x435bKBwSDVAZcFFIzZkQIhHQroJc7slsT06HCyJYMd3fDax/PGFfjoP Eg== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 2xm08v9mss-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 21 Jan 2020 00:39:30 -0800 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 21 Jan 2020 00:39:29 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 21 Jan 2020 00:39:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n+oQoNUGb+7vCKeQazDg6+mKmI0QLow8cN78lwzz+UKBuuCDZ6Flj8Qe137AemWw5PyZDNg6t4w9gaWxdlPtq5eDZnnQJhk5uLE8qAVMcnvUcVrb+xeBWzOOtAWE+Nm08YFHZTu9qxr2lmxxgJpL/G87ZBi1IJ6JyMP209SATDWwp4gInxqmffoqmVAkrTnxFMgqk9EZwlEuCS53LJsKGgXi+o1fcRO3R1zOaE2k9JXamDF8xzeF+QfDuO0DOo/vuyG1SKPR11lMLDcADdLsVOdU0/aCGt8BrW6l4+NhyD1BzGVvaHYXlq/3EfohoIJ+pv6V6sNUw1Qx4MBPCPs2hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I+jz4jcnwBdITbaf7Eu8YHCQBgddTm8O8A+owCgdz7w=; b=EBrw++BimShvKOVv3K/NR9uXkmkWQPMdK6oxUbxGTnQLgUb3mrDez9RfIY2jw/IPD8qdE2AvM51eGVyvqmpJZyasr0Pp4z6uw5TakLjooMU2GFzgO4nxxYh04qi5IMaVEFsZ9d/njN+ZCve8R1bBNpPpoaGy1IrgroF6Y7kxfS5g+dM1flRJmLE0TlRFn9FDaWf+VsrBG0FdVoGKhjm6FhU3PFbRHsmewEseON8uSIL3WZtYvd5K5+WRZuaF6pQYxY1M66fqfPzZfNTUcuGt4S3DOf+oPzeH67sGoYYwXmOUuror8e5Z3ph18LFlEN2WqpUGgASJCy0741dQZK4LnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I+jz4jcnwBdITbaf7Eu8YHCQBgddTm8O8A+owCgdz7w=; b=TawfAJsYmlFwGzrgHM5+dsoQvh6jta9fzJWb2DuE4BnoIgK+5p5/ZqErntPYwiWYQ0nCA0v4P9wmGUsgB6gpSdoxDwUP/Qa0Ky3u+8uLYCvfBV08OASWirH7dAXM1Ea3gwg3NKRmaV3GXO6Ptpdk3fQoBin6yyWdclsXa+ObS/g= Received: from CH2PR18MB3270.namprd18.prod.outlook.com (52.132.247.204) by CH2PR18MB3430.namprd18.prod.outlook.com (52.132.246.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.25; Tue, 21 Jan 2020 08:39:27 +0000 Received: from CH2PR18MB3270.namprd18.prod.outlook.com ([fe80::919e:f1c5:c6ec:ae09]) by CH2PR18MB3270.namprd18.prod.outlook.com ([fe80::919e:f1c5:c6ec:ae09%3]) with mapi id 15.20.2644.027; Tue, 21 Jan 2020 08:39:27 +0000 From: Sunil Kumar Kori To: Sunil Kumar Kori , Stephen Hemminger CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: restricted bus scanning to allowed devices Thread-Index: AQHV0DZKpw74+THH9UiObz8P25Cnrg== Date: Tue, 21 Jan 2020 08:39:27 +0000 Message-ID: References: <20191216075501.15669-1-skori@marvell.com> <20191216081317.30f10c9d@hermes.lan> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2707519d-dbb7-40c0-3765-08d79e4d6d3b x-ms-traffictypediagnostic: CH2PR18MB3430: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-forefront-prvs: 0289B6431E x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(346002)(366004)(396003)(136003)(39860400002)(189003)(199004)(66946007)(76116006)(64756008)(66446008)(2906002)(66476007)(5660300002)(66556008)(110136005)(52536014)(4326008)(316002)(186003)(81156014)(81166006)(9686003)(8676002)(8936002)(55016002)(71200400001)(33656002)(478600001)(6506007)(86362001)(55236004)(26005)(7696005); DIR:OUT; SFP:1101; SCL:1; SRVR:CH2PR18MB3430; H:CH2PR18MB3270.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xSFPIneJRflwzESYjWKDvW6WmPTGLIePN9AaxBSXKDZgkpuhuT1HD8ZR/ySxSseNR0a9JHtDUukWKoV61sR5rKhzarf7vnNZSyxMx9HDulWC+oNWyv3DHl9R2mFE2Pv+hG0ib3Rorx1ZV7N9X1sINGqdfpB2U+QdUTt83txlXURcL8Zg0CQazPVphn2O1Z6pLFUR84UCOsSA0Iiq8lrdolnC520UxbgI1+9TvWIn8PljmKI3j3G2tWbyJqYgRujEdv/uEY9uP45gMSvaRHB+0kXZ3imnl+dBxT+J0GcIAQGRLCpF2h5LXN+Vp2f8ya1OmnUUwktXbS9G0JkNPgzoeVWJkf4n0in1IdpNZAANJ0UkGEZvGw9MmzaRWwszt7zIv9BxOAU1Yz74HmkN3qb8dQsudnRxGPp8jZVaAKxvUG6G3ttGISkRNvnFTe/MkemK Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 2707519d-dbb7-40c0-3765-08d79e4d6d3b X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jan 2020 08:39:27.6093 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iooXCfEPsjPO4icbfCoXBpsxvlhcmiNqGH/Yn+3yyLjzTaH9JWnkIZ8AcKry8pME02J3Lm3Owxho+mY/QjjrLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR18MB3430 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-01-21_02:2020-01-20, 2020-01-21 signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: restricted bus scanning to allowed devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Stephen, Any suggestions ?=20 Regards Sunil Kumar Kori >-----Original Message----- >From: dev On Behalf Of Sunil Kumar Kori >Sent: Tuesday, December 17, 2019 4:30 PM >To: Stephen Hemminger >Cc: dev@dpdk.org >Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: restricted bus scanning= to >allowed devices > > > >Regards >Sunil Kumar Kori > >>-----Original Message----- >>From: Stephen Hemminger >>Sent: Monday, December 16, 2019 9:43 PM >>To: Sunil Kumar Kori >>Cc: dev@dpdk.org >>Subject: [EXT] Re: [dpdk-dev] [PATCH] bus/pci: restricted bus scanning >>to allowed devices >> >>External Email >> >>---------------------------------------------------------------------- >>> /* Create dummy pci device to get devargs */ >>> + dummy_dev.addr.domain =3D >>matches[i].pc_sel.pc_domain; >>> + dummy_dev.addr.bus =3D matches[i].pc_sel.pc_bus; >>> + dummy_dev.addr.devid =3D matches[i].pc_sel.pc_dev; >>> + dummy_dev.addr.function =3D >>matches[i].pc_sel.pc_func; >>> + dummy_dev.device.devargs =3D >>> + >> pci_devargs_lookup(&dummy_dev); >>> + >>> + /* Check that device should be ignored or not */ >>> + if (pci_ignore_device(&dummy_dev)) >>> + continue; >> >>It seems that you are creating dummy_dev as an alternative to passing >>just the PCI bus/device/function. Wouldn't be easier to just use BDF >>instead. Dummy arguments on the stack can lead to more corner cases in >>the future if device subsystem changes. >Agreed and initially I have implemented using BDF only instead of using >dummy device. >But using that approach, I was not able to use existing APIs to get devarg= s and >ignore device. >I had to write almost same functions to solve the purpose. So just to avoi= d >having replica of same code, I followed this approach. Please suggest. >> >>> +/** >>> + * Get the devargs of a PCI device. >>> + * >>> + * @param pci_dev >>> + * PCI device to be validated >>> + * @return >>> + * devargs on succes, NULL otherwise >>> + */ >>> +struct rte_devargs *pci_devargs_lookup(struct rte_pci_device >>> +*pci_dev); >> >>Must be marked experimental (or internal). >>The pci_device should be marked const. >Okay but If I go with BDF one then this change is not required anyway. >> >> >>> + >>> +/** >>> + * Validate whether a pci device should be ignored or not. >>> + * >>> + * @param pci_dev >>> + * PCI device to be validated >>> + * @return >>> + * 1 if device is to be ignored, 0 otherwise >>> + */ >>> +bool pci_ignore_device(const struct rte_pci_device *pci_dev); >> >>ditto >ditto