From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15B5EA0487 for ; Thu, 4 Jul 2019 08:43:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3BC10374C; Thu, 4 Jul 2019 08:43:06 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id A08AA160 for ; Thu, 4 Jul 2019 08:43:04 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x646ZaG0029027; Wed, 3 Jul 2019 23:43:03 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=pfpt0818; bh=dXnQjiHCBy/8u7OjkxK65ipIknuYs99+0WvdWwGQx40=; b=BQSxw+TqKs8Jhf4/u0IkwrYg0g6klat3tWtDgCeqvcU9/M8ukarSbFwd5JfoynzGysHt meqHZAyLTWNm2M8l8MwJSdtBrIUrcSSjlV99XTCSzT7MTPnw8vViEWBst2rFGO4nNcxt i7TsCwr7a6aqS4N3nxtmugcRZhl2OgjxST+rxMW16qLc94omx2hiaoDPcJHx9tQxU5zP 2ftxUC7RLbbwDk/80jR0HglmzvI6pS0WCXM02dUgdR/As0tVl77YdILiWz2yQO+WLQ12 iv6WmF80qYjS3s6kG/tfHc9DAvf1UPjVSYNzYUrpDtpqHzZWDjCQHwF9gKxPWEmcyh7T RA== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 2tgtf7449s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 03 Jul 2019 23:43:02 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 3 Jul 2019 23:43:00 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.54) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 3 Jul 2019 23:42:59 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dXnQjiHCBy/8u7OjkxK65ipIknuYs99+0WvdWwGQx40=; b=G1esYi2NNhM/HM7KjluxqH4lqLSk6frjQXLHDbCzxCxhbZozGrMBteyYxTYo2Snz9+Z8rTzC96SU7J6k4StK+2RYn40EY0DumZBo5c2zbKhlxIqZi4ErXUE2pATJMfhHSPRtAz31Bo/vFjqrFY9VLstZ8+mZWz3ZWq5Q6qO7YNg= Received: from CH2PR18MB3381.namprd18.prod.outlook.com (52.132.246.204) by CH2PR18MB3432.namprd18.prod.outlook.com (52.132.247.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2052.18; Thu, 4 Jul 2019 06:42:57 +0000 Received: from CH2PR18MB3381.namprd18.prod.outlook.com ([fe80::189c:3889:b207:8922]) by CH2PR18MB3381.namprd18.prod.outlook.com ([fe80::189c:3889:b207:8922%5]) with mapi id 15.20.2032.019; Thu, 4 Jul 2019 06:42:57 +0000 From: Vamsi Krishna Attunuru To: "dev@dpdk.org" CC: "ferruh.yigit@intel.com" , "olivier.matz@6wind.com" , "arybchenko@solarflare.com" , "Jerin Jacob Kollanukkaran" , "Burakov, Anatoly" Thread-Topic: [dpdk-dev] [PATCH v6 0/4] add IOVA = VA support in KNI Thread-Index: AQHVLMuXusCcn4VbWE2ZRwEk1wJ3HKa1zmsCgAQ2JBs= Date: Thu, 4 Jul 2019 06:42:57 +0000 Message-ID: References: <20190422061533.17538-1-kirankumark@marvell.com> <20190625035700.2953-1-vattunuru@marvell.com> <51e1b2c8-4290-c9b5-701f-5be55e763425@intel.com> <4906aad7-47a2-6707-cf69-417043c46c8c@intel.com> <7bfd30cf-aec6-9fd3-00b0-ed8964849869@intel.com>, , In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [2409:4070:2487:420e:cc9e:7db9:948c:9d7] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 83408392-8177-4c9a-615c-08d7004ad9b2 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:CH2PR18MB3432; x-ms-traffictypediagnostic: CH2PR18MB3432: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0088C92887 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(346002)(376002)(396003)(366004)(136003)(53754006)(13464003)(199004)(189003)(102836004)(446003)(6506007)(52536014)(53546011)(66446008)(64756008)(7736002)(2906002)(76176011)(7696005)(55016002)(74316002)(11346002)(6916009)(6606003)(19627405001)(54896002)(54906003)(476003)(6246003)(99286004)(25786009)(2351001)(73956011)(76116006)(66556008)(66476007)(86362001)(66946007)(4326008)(2501003)(71200400001)(6116002)(71190400001)(478600001)(316002)(486006)(53936002)(186003)(46003)(5660300002)(229853002)(8936002)(9686003)(6436002)(5640700003)(33656002)(68736007)(81156014)(81166006)(1730700003)(8676002)(14454004)(256004); DIR:OUT; SFP:1101; SCL:1; SRVR:CH2PR18MB3432; H:CH2PR18MB3381.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Zg/4Uqnp0ITQisCebTE4/bNdF3wBVU+u+rUi1/VJPCI5j7hwNm0igN59f5nEWfREDTcstSpEKdGQsb4qUf2eJbiPQoLVRQrymM+bBKYpw38iYOu7oFo85qIs7pd5/aSjpjeP4StvRQHmpbsVCwCQYoQXEd4/VLowYeNXXzkR4MwGu6PefHS0KQCsxqoK4hVUqyGNKrTp3LwFZROB1bU1l+lsm2S/gPwW+15CypQMHsPVy9VfW0RKj8fLJxwOfLOfUpKKYvqf9coItcx/0AEkLc8bBqf7tSwW33lHhYX3iLQwWsO9pEwVleo0g1iQvOm+4CsdygzHjCJMsLD0spYWDea1YaTj2W+L7zl/ZMGkRQUZGVt2ccaQ8WSFjwmZJ1PL+aKLIhXqKGMU0VFroYLweOkEZEu5Ktsb5K1lvhy0A9Q= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 83408392-8177-4c9a-615c-08d7004ad9b2 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jul 2019 06:42:57.4501 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vattunuru@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR18MB3432 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-07-04_03:, , signatures=0 Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v6 0/4] add IOVA = VA support in KNI X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi All, Just to summarize, below items have arisen from the initial review. 1) Can the new mempool flag be made default to all the pools and will there= be case that new flag functionality would fail for some page sizes.? 2) Adding HW device info(pci dev info) to KNI device structure, will it bre= ak KNI on virtual devices in VA or PA mode.? Can someone suggest if any changes required to address above issues. ________________________________ From: dev on behalf of Vamsi Krishna Attunuru Sent: Monday, July 1, 2019 7:21:22 PM To: Jerin Jacob Kollanukkaran; Burakov, Anatoly; dev@dpdk.org Cc: ferruh.yigit@intel.com; olivier.matz@6wind.com; arybchenko@solarflare.c= om Subject: [EXT] Re: [dpdk-dev] [PATCH v6 0/4] add IOVA =3D VA support in KNI External Email ---------------------------------------------------------------------- ping.. ________________________________ From: Jerin Jacob Kollanukkaran Sent: Thursday, June 27, 2019 3:04:58 PM To: Burakov, Anatoly; Vamsi Krishna Attunuru; dev@dpdk.org Cc: ferruh.yigit@intel.com; olivier.matz@6wind.com; arybchenko@solarflare.c= om Subject: RE: [dpdk-dev] [PATCH v6 0/4] add IOVA =3D VA support in KNI > -----Original Message----- > From: Burakov, Anatoly > Sent: Tuesday, June 25, 2019 7:09 PM > To: Jerin Jacob Kollanukkaran ; Vamsi Krishna Attunur= u > ; dev@dpdk.org > Cc: ferruh.yigit@intel.com; olivier.matz@6wind.com; > arybchenko@solarflare.com > Subject: Re: [dpdk-dev] [PATCH v6 0/4] add IOVA =3D VA support in KNI > > On 25-Jun-19 12:30 PM, Burakov, Anatoly wrote: > > On 25-Jun-19 12:15 PM, Jerin Jacob Kollanukkaran wrote: > >>> -----Original Message----- > >>> From: dev On Behalf Of Burakov, Anatoly > >>> Sent: Tuesday, June 25, 2019 3:30 PM > >>> To: Vamsi Krishna Attunuru ; dev@dpdk.org > >>> Cc: ferruh.yigit@intel.com; olivier.matz@6wind.com; > >>> arybchenko@solarflare.com > >>> Subject: Re: [dpdk-dev] [PATCH v6 0/4] add IOVA =3D VA support in KNI > >>> > >>> On 25-Jun-19 4:56 AM, vattunuru@marvell.com wrote: > >>>> From: Vamsi Attunuru > >>>> > >>>> ---- > >>>> V6 Changes: > >>>> * Added new mempool flag to ensure mbuf memory is not scattered > >>>> across page boundaries. > >>>> * Added KNI kernel module required PCI device information. > >>>> * Modified KNI example application to create mempool with new > >>>> mempool flag. > >>>> > >>> Others can chime in, but my 2 cents: this reduces the usefulness of > >>> KNI because it limits the kinds of mempools one can use them with, > >>> and makes it so that the code that works with every other PMD > >>> requires changes to work with KNI. > >> > >> # One option to make this flag as default only for packet mempool(not > >> allow allocate on page boundary). > >> In real world the overhead will be very minimal considering Huge page > >> size is 1G or 512M # Enable this flag explicitly only IOVA =3D VA mode > >> in library. Not need to expose to application # I don=92t think, there > >> needs to be any PMD specific change to make KNI with IOVA =3D VA mode = # > >> No preference on flags to be passed by application vs in library. > >> But IMO this change would be > >> needed in mempool support KNI in IOVA =3D VA mode. > >> > > > > I would be OK to just make it default behavior to not cross page > > boundaries when allocating buffers. This would solve the problem for > > KNI and for any other use case that would rely on PA-contiguous > > buffers in face of IOVA as VA mode. > > > > We could also add a flag to explicitly allow page crossing without > > also making mbufs IOVA-non-contiguous, but i'm not sure if there are > > use cases that would benefit from this. > > On another thought, such a default would break 4K pages in case for packe= ts > bigger than page size (i.e. jumbo frames). Should we care? The hugepage size will not be 4K. Right? Olivier, As a maintainer any thoughts of exposing/not exposing the new mepool flag t= o Skip the page boundaries? All, Either option is fine, Asking for feedback to processed further?