From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF80842570; Mon, 11 Sep 2023 18:03:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AFB6B402E4; Mon, 11 Sep 2023 18:03:15 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 396D2402D6 for ; Mon, 11 Sep 2023 18:03:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694448193; x=1725984193; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=cPn6XUZGcFm1ah8zQQovWiHvhz7u7x0iSmKKGygJ7lI=; b=Vmomnuhnm8BT2RJdesSMQhJGrDL5nmX7kS1AnMwynxdOSFa3W9hSMdCy itvbW4+1rZlG26kfkqW8TfO3ffghL2+c/PkQd8n/dxEcZ6q/r6X561Gaa PKGeLUiX6uoH0igZr6UZZf/UFho8TAO5OIjjJXtmB2YazW3K25akvffEk Sj6S8izrchBeKpdFEnrUGhoNBr5r8B/rLerNCv0BU1Nx0pSnzdJgpDzaS t0WF+6BoNbrKNrlojzKjEdO1j5n0N12KC4LkktvYACSLJD+F2vmbn9V/6 Bs8JxY4EwrNe8vCv7s50vE26gVlkgYRhcyGMms9NlTxf5C1Oou2HMxCCX w==; X-IronPort-AV: E=McAfee;i="6600,9927,10830"; a="378038902" X-IronPort-AV: E=Sophos;i="6.02,244,1688454000"; d="scan'208";a="378038902" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2023 09:02:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10830"; a="1074192255" X-IronPort-AV: E=Sophos;i="6.02,244,1688454000"; d="scan'208";a="1074192255" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 11 Sep 2023 09:02:20 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Mon, 11 Sep 2023 09:02:20 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Mon, 11 Sep 2023 09:02:19 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Mon, 11 Sep 2023 09:02:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PHbmE096Gq2TztsQWIYSS3CRGPnwtApt7LjcdtHOSyi0cdY3Ma428UO05EMqMNsGyYXLiEEO3beBfwlyxH1p+U5t/YXMp8vwwzrvS7YtbwIFaOSxc1nUCnWak6NvO3jG7KsUzhUOq+jKaR3KAML6taLVopE+rsKkor3iOL71E5Tds3kZtnwS7WSNCqT+x/rl4HbRAkhItywHf1CB1+CPesGqILCH9mjT73tz6654MaM0zx1nV62Umb7ZUAGgY00c4/7yTOI3QzQXIS8Zoci1o5F9p/+gdSbQg1rhKaeLZHTDm8ouv/bu/UvM+9PGHfK3Cfj9TTwBBWLr52u2eV1VIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2Is49K+T18W7wvArrCkTXmLupTHiy2LPGRIleLziWjc=; b=EYXTVKo+M8bzEkkuuKNhHDpab2xQzm1VTX6eLAeiQ7afAmxoIfq2v7lt4cCnIdER2AXA6zPCe7Zhjvzq/ttF7IcCYLWdo9XSvqJiBG1QRyK7s/rnt0GOze2jXMNGo7ryeVvlmqcglNPFL2jd6nlyMVTkbNKhVElM/k1sV5x8PjLdm53ghuey0IXcPRUOawfypeYblPwuICiQg10frbBRYj4TeK+iY3XZso/w3o5aKwFOMRYtUx1Gk49GhyloXs/0lZuZ46+fwI0GZz6egBGf/RGPs1nPTBdI1KbN3cLPjLUrPUuvyvpyOIDT+pnAL6RFdxpAZ/YNZTwphRiJzTnfFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CH3PR11MB7252.namprd11.prod.outlook.com (2603:10b6:610:144::22) by SA1PR11MB8524.namprd11.prod.outlook.com (2603:10b6:806:3a9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.35; Mon, 11 Sep 2023 16:02:17 +0000 Received: from CH3PR11MB7252.namprd11.prod.outlook.com ([fe80::bd1a:89c3:cfaf:9f4c]) by CH3PR11MB7252.namprd11.prod.outlook.com ([fe80::bd1a:89c3:cfaf:9f4c%7]) with mapi id 15.20.6768.029; Mon, 11 Sep 2023 16:02:16 +0000 From: "Coyle, David" To: Anoob Joseph , "dev@dpdk.org" CC: "Ji, Kai" , "O'Sullivan, Kevin" , Jerin Jacob Kollanukkaran Subject: RE: [EXT] [PATCH v2 0/2] crypto/scheduler: add support for security protocols Thread-Topic: [EXT] [PATCH v2 0/2] crypto/scheduler: add support for security protocols Thread-Index: AQHZzD4AYgHDx1l2DkyukuCP4muDKa/k8AMAgDEE+QA= Date: Mon, 11 Sep 2023 16:02:16 +0000 Message-ID: References: <20230809101436.9942-1-david.coyle@intel.com> <20230811102401.12552-1-david.coyle@intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR11MB7252:EE_|SA1PR11MB8524:EE_ x-ms-office365-filtering-correlation-id: 3b7f0507-6b7a-4022-2836-08dbb2e0785d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: M8kiHQEEhGmpRtzA2mPOojPdD6h4LsiOeUHOYZblfVQMAavYYCo63w2Tq4ggYqi0fLfqb6fTSQpJy4kJcp9VPoQYGghwQRMVSSZdv/zdqMztw7+hLv3Hk8sIOnyMrHgD1kdQ/iUPEa74Rr0tgk+tcDGgfWnUMWmcJZS/pjGy9EmIiXgZd5H3r/SRfZW5BQ0RO57qqlxZ1H8nOIr39krlbul4EkG1pn0LTYWes+d5DJzegbqsyHJJfVkpHIFGo+2qjnpoUrG4CN3/yYZP0r5BlVjOMZn09xVqOIk6r7XCwKTievmXdOw5zaJ2GoCRY8g1wIaaUWu0z459GH+GuDXIBXlxonB1oU6IApMvRxgfMnh30SGEySNna1NTGNlntVxGlImTchFe7SASy09oRC7WebFh9jAVmfz4k12WNXbR8lrKe7adxhE+dIYYW3IoJZV0qimQ6g7xGyvgE2+uADS4LaA0OQRfIMY14+kRdm3CXSbjXPfb2vgTirGx0xqUgw52wWkDPWvtjjhU28jcu09iCI+u2oEiFMMsoAlYdg+yZwblkiMF/nFoERLShQC7K5Omw1zqcgT5AEP/Ysr2JN4Sy40mT91cIDBi9KxqTYXE75KwdAcwU9wKNhkPiiBr/ePQ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR11MB7252.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(346002)(366004)(376002)(396003)(39860400002)(1800799009)(186009)(451199024)(41300700001)(6506007)(7696005)(71200400001)(53546011)(9686003)(478600001)(83380400001)(2906002)(66446008)(64756008)(54906003)(66476007)(66556008)(66946007)(15650500001)(316002)(76116006)(52536014)(110136005)(5660300002)(4326008)(8936002)(8676002)(26005)(82960400001)(86362001)(55016003)(33656002)(38070700005)(38100700002)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eo1fpmxZeqyfW/4DALKFBmEYUZhNA8Oa9hdeQd2UpaSiudGE2Tie7Vbe05lU?= =?us-ascii?Q?vRITfsjiIP0dSdpZWgVQFfQK1DCX/BhVlW36vvImQIM6z+2ssYGyASD1XQX2?= =?us-ascii?Q?nJQpVQdvuGOq9Fc+U0rfyqlTDW9K7fi7c8F7MejXViLpeCmXqjIakJeL3fi0?= =?us-ascii?Q?XW7QsyLvvtbZ3UzHVT5LbkoYGOUB2Evt3i+yOwqpIwsUAciJaTjUNhkoV0ef?= =?us-ascii?Q?nc3mBETZEDsQbGjEQWU8JfQrlaXz0kP9KkklOhLPsACeH0l07hnvLvGJW2Ea?= =?us-ascii?Q?hpv6zJ2CkGjtww/Ng9ykq0Cc1ymtxg7nxMzFFcxslgpG7GPbxkqOP4UXKxXS?= =?us-ascii?Q?bFN7yhiNEdgOpMC5Bl2r/nIZsBVluq7rGUfdgEGjWQL6oTT3Id1icdPQr5HV?= =?us-ascii?Q?3qkY9AZ5GUSzzakaHq6zpnLW5Pdr0PtpXccUj94VxZtUnk8T2CCVdAHs2uyq?= =?us-ascii?Q?yVQ7i7upnmsz4ayDG46GaIt1QOeRxtzvQd4Wpyk/rBATe1LAktu00K2H/aNi?= =?us-ascii?Q?lRPw9tn172tMXvmXKN0lAboNZcXWdHHmVl0lR/EaPpAAeSHJz1Wc3GgHvoi7?= =?us-ascii?Q?ylDvN7IklOtkbdW6Y6NgpTdGOfSsEzQnZF8uptL1fdtM7PNQFxDjppbMHAaU?= =?us-ascii?Q?q9Jmv+mHQKenIZK38GAAvazz2sotcsc5rT/nh5XlptlU717PXDZVjUR3Jw1Q?= =?us-ascii?Q?pzPoN/Eot1D0AbmMG1te0ig6oNB2a/4cYccGwggVr3+4psJBgbcwWOgIEONp?= =?us-ascii?Q?NWBABB4BixZ6iMtqxeCN1Q4NXX0/B7NCsSNwRc6EkoVClEoWjsNc/9yNxRBq?= =?us-ascii?Q?IGJqi0YOd/JNmqfwWCqEWKWEEeISbCNLq4eNzcLcYEX3iRgtpABdcw8OqTkk?= =?us-ascii?Q?RUHyf3tNj3RmVMealv1TPHS0xnUAxk6ahy+YPr4ApVN1KJhmNw96CMHSn21b?= =?us-ascii?Q?K7drosFWIFdku4+YycxTEtmY1XjdkTKHdMcqSghUYkwDqtzA2xxj+lqgtAm6?= =?us-ascii?Q?5Eul+wI46ui5Hes4by7TloMIU/gnnUfJg8ODlq/bJEBPRbS60FPwREk/1zWx?= =?us-ascii?Q?R6l5gzNaTaIu3XQIcrqXS8UdRPC+baCvYbHf6EMVTDaiUxyhbxIjXMoy9lUo?= =?us-ascii?Q?DChnSxAZQWN241hQQoIZdvfPz/E5SYOC9kLyA6kCsXsRxzCPZAlIvgUx426e?= =?us-ascii?Q?IovpyhfeocAHq51/Gx74PCu6dzgPIQdLeFqqq1Zp+sVVXh9Rbj1yMcY1Ajzc?= =?us-ascii?Q?QhCtHYmxiEoMko1QRfL1E0PuyfFfWk4vBqZdvVvgfDTVopKNYuiwjUvZ4K+F?= =?us-ascii?Q?3kM0x6NeFMIqjO4mOrywGedgflQ4Gm+bIB5VutQL54WJ6qagjMd78q1TOgoP?= =?us-ascii?Q?tpghtww99cBk7ExPLEcz+mBb3MRLwd7o3kCX0XpZOYpnq8mNas/cDS7SKKUy?= =?us-ascii?Q?09+PZH022uBczsKoOw2W85TAk0QWjqIFcuJaYpJ8OkwmqDydZHZvKv4+PaBr?= =?us-ascii?Q?wKeJ//WnvGvqKHzN4YzRcSzl6SfR4CHjZhMFZp++GCF4nDRDs6JkfGppUwW+?= =?us-ascii?Q?j8+2CGxkNIv4yqfWAw1YAmQJTI/rD8afPh2sMS+L?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB7252.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3b7f0507-6b7a-4022-2836-08dbb2e0785d X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Sep 2023 16:02:16.4814 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2OqSW8XPOpY9g4gkVMU7U1UhqfalICG9d7zAxQUy2NtCdCG+VFuVVZgAtsrmcqnDbkvjCB9zcaHFNlJaRG8GZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8524 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Anoob, Thank you for that feedback - I was on extended leave so only just getting = back to it now. See replies below. Regards, David > -----Original Message----- > From: Anoob Joseph > Sent: Friday, August 11, 2023 12:09 PM > To: Coyle, David ; dev@dpdk.org > Cc: Ji, Kai ; O'Sullivan, Kevin ; > Jerin Jacob Kollanukkaran > Subject: RE: [EXT] [PATCH v2 0/2] crypto/scheduler: add support for secur= ity > protocols >=20 > Hi David, >=20 > While it is desirable to add security under crypto/scheduler, would it be > functionally possible if the PMDs perform stateful processing? For exampl= e, > with lookaside protocol mode of IPsec, fields such as seq no & AR defines= how > the crypto operation can be performed. Without two PMDs sharing this > (actively), how can the load balancing happen? [DC] So if some fields such as seq numbers are maintained within the PMDs f= or some protocols, then yes you are right - this would not work without som= e synchronization across PMD instances which I think we'd want to avoid at = this point. I tried to find some cases where a crypto PMD that supports IPSec, for exam= ple, maintains some global stateful parameters, but I could not find these = cases. I'm not at all familiar with these PMDs (cnxk, mvsam, dpaa_sec, dpaa2_sec) = though, so maybe you could guide me as to where they are maintained? >=20 > Said that, I agree utility of scheduler for stateless operations. My > understanding is, PDCP offload that is available today is not stateful an= d that > can leverage this. I'm not sure of DOCSIS and MACsec. [DC] I notice that the PDCP security xform struct has a seq number related = field, which would also suggest it could be stateful, but I could be wrong. >From a google search MACSec is stateless, but again I'm not an expert. The protocol I am familiar with is DOCSIS, and it is for this protocol that= we have added security support to the cryptodev scheduler. DOCSIS is 100% stateless, so will work no problem with the scheduler. >=20 > Should we make it such that only specific security sessions would be elig= ible for > scheduler operation? [DC] Do you think it would be acceptable to limit the scheduler to the DOCS= IS protocol only for now, and let the IPSec, MACSec and PDCP experts add th= ese later if applicable? If you think this would be ok, I can easily make that change. >=20 > Thanks, > Anoob >=20 > > -----Original Message----- > > From: David Coyle > > Sent: Friday, August 11, 2023 3:54 PM > > To: dev@dpdk.org > > Cc: kai.ji@intel.com; kevin.osullivan@intel.com; David Coyle > > > > Subject: [EXT] [PATCH v2 0/2] crypto/scheduler: add support for > > security protocols > > > > External Email > > > > ---------------------------------------------------------------------- > > This patchset adds support to the cryptodev scheduler PMD and unit > > tests for the existing security protocols in the security library, > > namely IPSec, MACSec, PDCP and DOCSIS. > > > > v2: > > * Improve inclusion of rte_security header files > > * Fix typo in commit message > > > > David Coyle (2): > > crypto/scheduler: support security protocols > > test/crypto: add security tests for cryptodev scheduler > > > > app/test/test_cryptodev.c | 14 +- > > doc/guides/rel_notes/release_23_11.rst | 3 + > > drivers/crypto/scheduler/meson.build | 2 +- > > .../scheduler/rte_cryptodev_scheduler.c | 229 ++++++++++- > > drivers/crypto/scheduler/scheduler_failover.c | 12 +- > > .../crypto/scheduler/scheduler_multicore.c | 10 +- > > .../scheduler/scheduler_pkt_size_distr.c | 54 +-- > > drivers/crypto/scheduler/scheduler_pmd.c | 33 ++ > > drivers/crypto/scheduler/scheduler_pmd_ops.c | 375 > > +++++++++++++----- .../crypto/scheduler/scheduler_pmd_private.h | 148 > ++++--- > > .../crypto/scheduler/scheduler_roundrobin.c | 6 +- > > 11 files changed, 656 insertions(+), 230 deletions(-) > > > > -- > > 2.25.1