From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1898B42536; Thu, 7 Sep 2023 15:33:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A74314029E; Thu, 7 Sep 2023 15:33:40 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 047D34026C for ; Thu, 7 Sep 2023 15:33:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694093619; x=1725629619; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=0TTS7eNBNaLRxGqmnTRz9YvoVnTRozewUO3kyCbnCAE=; b=Zw0HJTo5Rpcf5W/au3Pcx/hOlisiyjofvD2U8TbJnYWg5SLKZD9Yl616 9X7IopZ0O3Dcx0rOHa+9UqW+XtasQEj+4PEGCBj9J0dNJ4XnZyxTHNPW4 QYxC3jXimhwXbA5bdcoZHCxhMjJh57WyjpCgia2uRQJXBzVIBaci1bu2W rU9cwUvG1aJNr7umAFQCtMOJ8/f1R8ZozkbLuWbTso9TrzpGTrBpwwmhN Zu+HllOfKczYojaXfXfCe4Wv1pXoJCnMRpQO7wndhUHErLS4hCU7OGqSR ufkEyloQZm5y5PoaxPMvVaVoL7La7Y8XOXRDMHq1sLw+L2gGzpaIHLJ6r A==; X-IronPort-AV: E=McAfee;i="6600,9927,10826"; a="356829081" X-IronPort-AV: E=Sophos;i="6.02,235,1688454000"; d="scan'208";a="356829081" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2023 06:33:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10826"; a="1072892926" X-IronPort-AV: E=Sophos;i="6.02,235,1688454000"; d="scan'208";a="1072892926" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 07 Sep 2023 06:33:37 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Thu, 7 Sep 2023 06:33:37 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Thu, 7 Sep 2023 06:33:37 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Thu, 7 Sep 2023 06:33:37 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Thu, 7 Sep 2023 06:33:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dWaCqKzE91KLMLy/5LCoNEMsYCfnZd7fMX6RgkgKGPLojogX83BAQGfm/oxhhwJzMs2BxSl2FmziZ8G1fHtscnmNyV0KE+unEPfPjfgn9j8OE4/DtpYA+HrmtB4GWD78voW4wpPYpuKPrva5Yno9HX2CljdWYjH4HpJoei8PbAua4IDGBz9aDHZTEeeB5CAaVeRk1D9SWyAmfzX+wYt9K0d6lp/rQvKab0R/30j8O9ebiWy0b6FdkMq2reTpz+3FCgbHG+hbW6KgpSOpLWsDm8j6YPEbRwPNH7nzdbIqycf8ItP6K5xynMjmY0RAd4R+DihA/eqSgZ2TxVbGGWHtcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EpqHbu+7YNUIe3ob0ahmmtyC1FRaSrLvxpIvO70tim0=; b=MjU2fKXiNVorV/bvowr9lqguOxurwptma4XcePSNeco1Q4nT0BjzNUN3W8C08cTFIZmmohQSSuC6iNqvhoxkFEaJl5K0QQ+bB8N4mmPyBaWO8TbUVAq4apQ1VbSAIvlmaEc+1A0QAk+bwFzYeOcAxBAlppfdofWViaWYG86S7pfe6xjaBDul4OBU+Sp9Yjcnt7lgosUpZeHoPzp3rqV1ObdJlI4DRtEVfYCdJ9BgjmL8aHmD4hITSpoEwHmHvz4AOgIgEbh+CPCVrTiLz52PxRJse/LZhVAcD2CGOi0wzST+sjb+DKHbtJksxGNpZmlxdosepjmPc7ZAZOojUsPUeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CH3PR11MB8362.namprd11.prod.outlook.com (2603:10b6:610:175::6) by BN9PR11MB5340.namprd11.prod.outlook.com (2603:10b6:408:119::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.30; Thu, 7 Sep 2023 13:33:35 +0000 Received: from CH3PR11MB8362.namprd11.prod.outlook.com ([fe80::88c2:332c:5e8a:25e]) by CH3PR11MB8362.namprd11.prod.outlook.com ([fe80::88c2:332c:5e8a:25e%7]) with mapi id 15.20.6768.029; Thu, 7 Sep 2023 13:33:35 +0000 From: "Xia, Chenbo" To: David Marchand , "dev@dpdk.org" CC: "thomas@monjalon.net" , "ferruh.yigit@amd.com" , "nipun.gupta@amd.com" , "Richardson, Bruce" Subject: RE: [PATCH v2 15/15] devtools: forbid inclusion of Linux header for PCI Thread-Topic: [PATCH v2 15/15] devtools: forbid inclusion of Linux header for PCI Thread-Index: AQHZ1CPQiYpdKCWZrkWJoBobbDBBELAPd3eg Date: Thu, 7 Sep 2023 13:33:34 +0000 Message-ID: References: <20230803075038.307012-1-david.marchand@redhat.com> <20230821113549.3191921-1-david.marchand@redhat.com> <20230821113549.3191921-16-david.marchand@redhat.com> In-Reply-To: <20230821113549.3191921-16-david.marchand@redhat.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR11MB8362:EE_|BN9PR11MB5340:EE_ x-ms-office365-filtering-correlation-id: 178389e0-2056-4625-744b-08dbafa708af x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1p5AemGcgBBgiJTs/YGJdX0fKprL4J8clGEK7DDt+PmCzOTKvHv2wScTtluql4nHJqmwDPEm6YKE34shfoXwtsbDf/qK0Z86w4T/8sz+vsZWT1yQz7ZAaakxrIdaW0ixhYmJ2EG8HioUqKa27N3G5zoFaNP6de+v6yxJfH/eO9eVPQDkjcMB5RuV0P1yMmloPD5LHNzDLRvLWTYm7W9jZ7y2PwbCjYkIyvrHgMW2ZzKQwHwhp1048BnkQsUyPSysLj2u+J3tR82C1Rw/uv55SWxcyVzi/eMN5Tm4ZTAGBQLGe/qmhTWbBOSAvO7oRQuV1vDgqEe629vUTdxrmburr9SR8jXMvTkIdO9YGbwocDSeuZTZIjksOEMCZswj9fzyOT5NyB3UCmwShzQNubNLPYyQAnUOhcz1FtE5EFbiR9te3Gg/wi4kwBYMT6EwbdMg22mB+lW52yvlzJHpr/c6R7uygOZaLxNXwyiWkzJUWXVXt+XOz+7mJKSDGmlRK3YDWJsBBkAiaJpSAiRRpXBdU+ifhNxb63z/nNKyumxDarIQdleHJoY3j6I3jLgEHSEF7yC6tFjUyxXXeCLTmMYd42t4gjNBkfN8z5AnCWgugDwcc7WGAYmuw8qK/k6YfMPc x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR11MB8362.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(366004)(39860400002)(346002)(376002)(136003)(186009)(1800799009)(451199024)(122000001)(82960400001)(38070700005)(38100700002)(55016003)(86362001)(33656002)(2906002)(478600001)(110136005)(9686003)(53546011)(71200400001)(7696005)(6506007)(4326008)(8936002)(8676002)(5660300002)(52536014)(66946007)(316002)(54906003)(64756008)(76116006)(66556008)(66476007)(66446008)(41300700001)(83380400001)(26005)(107886003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0fo8puqLOjk/K2lSSYtQWBIgZMs9A54UND1SWgUrZ/llwiyzdgOMZCZ7Trc1?= =?us-ascii?Q?g69ayzHPrrL18yrinBK7M/ZDTk60vNwplXuUpgMNtCqIF+Q6tuGrkAM1vqCr?= =?us-ascii?Q?l+ZDnF76jUM+SvISE9kuDrNVB8NFhP8Ol0qL58G4uXsMVpE7M3fjjQOgAZFd?= =?us-ascii?Q?QHf0P4meYydJu0HqJlEs7ZI3o7kq8gOz5wtv2EQyHs24bt1p3NYZ8lFocjUJ?= =?us-ascii?Q?FznL5kSZZdg4ehZewHp2jr2yNjIXX4epxZQzL0ZmnUvBYCqGomVzwNK5oz+a?= =?us-ascii?Q?5lpADVruCmJG10U0hbF+C+7YTP7KTEUQhWFOSEnpOVNMMK/6tAA5Cp0o6kZr?= =?us-ascii?Q?bEVjaL/TNEaQIeiL9aJxFMbzETX1G13teLIYTtlpHP2IUIVc9UHnLejzflg1?= =?us-ascii?Q?xBSHZSui1QuIi1Mr+1kPHRLMsd0gMKsyfIjtN5fpckrHBF3MVQtYk2YFqxWF?= =?us-ascii?Q?yKgewfSXde0Zx3eii8NjFFpZL778Pbh3gbbfr34v5tuksrMQUkPx48miBiI8?= =?us-ascii?Q?NmPAsonxyR1z9omQf5ZHGBic6F4EtHDQH6rkZJCf12ry/4lP0lO1FxCnlQ20?= =?us-ascii?Q?I0MNDIEGVxGgr+OHX4y3Iu017DDaopFc49H962GsqaUZ5T49xuRhhn0hxtI1?= =?us-ascii?Q?4uGl62rTxpgeBHrsG4ufzJ5FHbLI4Ch8gvN9vqUoDPlSNHnFOMa2akQ0E8Fi?= =?us-ascii?Q?4GzppJZPo2h8JfrSBMwD2582FJZLugAuqm1Tghwlb3pweiOKuvLW+TFIT2iO?= =?us-ascii?Q?06YgS2ke3dPuEjXe9lumXwoFOczYfiC2qA5VTIAtr5sV6Apo3uf+VV8VFed3?= =?us-ascii?Q?x3x6qCBLkpSOEqMaSR29OP63BmQ4497g3O4h0mCZoK2FFDFgqW7kvtiQYPCy?= =?us-ascii?Q?e5fvB3DXx5LUuQsFhZdE/kIY3Q+ahM4/JyoiPDm1Nl1PvHiQ4rphx9djs2Jv?= =?us-ascii?Q?qlVCTWbq154IlKI5c5NDD6Ry3lUqse5fd1ogy3aWM8JLLe59uzskUcI5f1yj?= =?us-ascii?Q?cHqKpgMHDbLBmsj/klMpWY3mewJlrjkwb/TuMzXKNj6ND7vYuN9UyoJhjjjn?= =?us-ascii?Q?M/5zG3jOVa9cU53tzER+K50k43kXmL6FCDJlT7dEnQKEsl16S3OAxLvTW1tO?= =?us-ascii?Q?AnX35mWX0Qd13rYKHJqLrOOhH9/tKUBnp9nc36Dsr49ZZQzVmM7HoMKIeCT9?= =?us-ascii?Q?l4VNRdnu2M76KEBVzfjzZiwzsc5tRWjTnrNgNKZ/VjeB0hGZ4YlLj0wqMUh/?= =?us-ascii?Q?iIExfW2e3AQIcYELbfAgGlLD5bLhLHW4PWG9M/bFZlOTZRPAT38b6lvq4APA?= =?us-ascii?Q?mGA1PO1RGW2bYqCwC3bMOc/NZv9qB1F7yJUorQ1SuWx2BbOae509xZGhFHmB?= =?us-ascii?Q?m1n9TP8M+Q7AaQZErFbSUWknpkWTN/A4l5bQ0sEdAK/JXscft2HLQwkd+pMW?= =?us-ascii?Q?coOB0H9UpyAoPuvSnVId0MezXIyj3Icnup3AlikfyiAtIyKu6WLQnMnNjiAu?= =?us-ascii?Q?S66AO4ejh/JRyAm20a6POlEP/4cJ+bxio9Y+9JYidRpIXjjBnihTKCqJvtyV?= =?us-ascii?Q?0XKzuiYLJ3xcU1vYZjO3NxZUvxwpxRGEKZM6lg2R?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8362.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 178389e0-2056-4625-744b-08dbafa708af X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2023 13:33:34.3079 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RbZEmYm//u6asq44EnQFHYwSL4SrnM2Z8TYDeabGMUv6uyx2BMCHcj2Bw1JVI6+aqCawrw9zkp3U+Cw/XWSSZg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5340 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: David Marchand > Sent: Monday, August 21, 2023 7:36 PM > To: dev@dpdk.org > Cc: thomas@monjalon.net; ferruh.yigit@amd.com; Xia, Chenbo > ; nipun.gupta@amd.com; Richardson, Bruce > > Subject: [PATCH v2 15/15] devtools: forbid inclusion of Linux header for > PCI >=20 > Refrain from including Linux-only pci_regs.h header. > Instead, prefer our own definitions from the pci library. >=20 > Signed-off-by: David Marchand > Acked-by: Bruce Richardson > --- > devtools/checkpatches.sh | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh > index 43f5e36a18..5d3c5aaba5 100755 > --- a/devtools/checkpatches.sh > +++ b/devtools/checkpatches.sh > @@ -127,6 +127,14 @@ check_forbidden_additions() { # > -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ > "$1" || res=3D1 >=20 > + # forbid inclusion of Linux header for PCI constants > + awk -v FOLDERS=3D"lib drivers app examples" \ > + -v EXPRESSIONS=3D'include.*linux/pci_regs\\.h' \ > + -v RET_ON_FAIL=3D1 \ > + -v MESSAGE=3D'Using linux/pci_regs.h, prefer rte_pci.h' \ > + -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ > + "$1" || res=3D1 > + > # forbid use of experimental build flag except in examples > awk -v FOLDERS=3D'lib drivers app' \ > -v EXPRESSIONS=3D'-DALLOW_EXPERIMENTAL_API > allow_experimental_apis' \ > -- > 2.41.0 Reviewed-by: Chenbo Xia =20