From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD1454410E; Thu, 30 May 2024 10:22:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 15DE340A72; Thu, 30 May 2024 10:22:59 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2044.outbound.protection.outlook.com [40.107.220.44]) by mails.dpdk.org (Postfix) with ESMTP id 4663B40041; Thu, 30 May 2024 10:22:57 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TGGSmgeJJAbQreqZeSd4ml4+yBGMn5jiXYSec9+TKlJINkhFTXllURChAVr2aBlqYQqLLX23KQY7PJSrSzOpKeZ2RThWQ1h9vao2HzFBaDZD6Wz6kslUsYcOngG6pDEQKTNjKjti9v70CdThvSInC0CyXSsBtPr9R8IYmq1vhItAQPQVlJs9T5126b0748C0dxjxi6KAnPsSwBamkkfdoCLyognuVhXRHB4DrwTaQcofTbz8NtaXFhxjA6dO6hExgWWaZJPNnRzif35ICQByHMJqdvgYW+gJ+gd2xHAyCQqVllYc+p15YEQBGfOQM1tWMUOdN9/oGm7VX/sOojg5Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1YkcAUEyXS9XP+Q12i7/GFXZYN6mMrr9V8KEty9Mnfo=; b=i6z8kceBMbjfC2xRJb6C7HhfGGa7jrkvE0PPoyoC+rvOsLJLoecBspZsjzPWYV6pUEBhraCrpx8Wzy6PW5muZ3F7vmrld/VqdiwmjPLPludfZu7gWqgPC5iUHn7qwtB/6lxpbd5h5AWkHEY6oJaghIe/izaRU1wznuwrdz4VWcxZwMOpvHZoxyMFuaC0XMtLBr4fCNAMBHzvo2VhjSswSXGazqf3ncWMeBg7j3DfGQsCXR73BV+L34K+II0J6R/ozmvZu/MOSO5QXnzHW+haXZvLIXDEVBYVFOm+lKr623+PoHHSJiKxgg6A71x8hKF0FTAUjXYtGmaRNqwLggwgVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1YkcAUEyXS9XP+Q12i7/GFXZYN6mMrr9V8KEty9Mnfo=; b=aTJyjtIjvFbak6Y2P0dB3AXqG4o5gtYvLgvxQQAIFGeww49uUFpv+mGqQ7n7yFyGXtCNPvCYxnTnVFr0zMqT89VWUb5zjUMTDbFWS8fAZAsSEiH8QjKZ2TMFe1OdzjeClocrdPuH4NZJ1Cxqjby38Gvlfs+y5MV0E4dFJRtz05kY7Bo6OLFdxtrqqEZyzH95KOEB54oZQLa2eVMbttvRn7bxkz5VEnOTXlLYt+HtBjjEp2rm/UF/CTv5/1X+z1u0umuPkLQI8QnoR2wdBB3+O0pEusK55zYg4Knlbzip7xJqh2GHuY/sH7jrfPPYdfcJ5UI/owquodk0q4E9ArK9tQ== Received: from CH3PR12MB8209.namprd12.prod.outlook.com (2603:10b6:610:123::18) by IA1PR12MB7544.namprd12.prod.outlook.com (2603:10b6:208:42c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.30; Thu, 30 May 2024 08:22:54 +0000 Received: from CH3PR12MB8209.namprd12.prod.outlook.com ([fe80::9127:5857:7ba5:a7f2]) by CH3PR12MB8209.namprd12.prod.outlook.com ([fe80::9127:5857:7ba5:a7f2%4]) with mapi id 15.20.7611.016; Thu, 30 May 2024 08:22:53 +0000 From: rongwei liu To: "dev@dpdk.org" , Matan Azrad , Slava Ovsiienko , Ori Kam , Suanming Mou , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Dariusz Sosnowski CC: Michael Baum , "stable@dpdk.org" , Aman Singh , Yuying Zhang , Ferruh Yigit Subject: Re: [PATCH v2 1/4] app/testpmd: fix the testpmd field string sequence Thread-Topic: [PATCH v2 1/4] app/testpmd: fix the testpmd field string sequence Thread-Index: AQHar+BRYdLxSsf/VEScs6lIY4DYgrGvdUxZ Date: Thu, 30 May 2024 08:22:53 +0000 Message-ID: References: <20240527024720.1099161-1-rongweil@nvidia.com> <20240527024720.1099161-2-rongweil@nvidia.com> In-Reply-To: <20240527024720.1099161-2-rongweil@nvidia.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-Mentions: dsosnowski@nvidia.com X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR12MB8209:EE_|IA1PR12MB7544:EE_ x-ms-office365-filtering-correlation-id: fb1ebf2a-d391-4f91-c7f9-08dc8081b3f2 x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|376005|366007|1800799015|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?RJ7dtiDXTYOKc71jHRiHGdL8j0/FRzehYadVb0kzaefXPZ85WGKGl97GKOZv?= =?us-ascii?Q?Td0aTF4dp2luttF80LxexL8iiTsU+FjuWi8u1M3UaKk1JY1Cl8RCiI+ZS9UY?= =?us-ascii?Q?j+b92Yh1uw08Ts566v2913JYG9rrP5+AJm7uRTPR+JMkIpptiySgf1ubMBoy?= =?us-ascii?Q?zPCN98v2yn1ymYqGzhktm3ccO0Fi3l9dsGL3BlmLDR5S7qfDtXGC6a/Z2v/T?= =?us-ascii?Q?/N57KzxQ7KyvH6YrSUXurW5Uj7hd/N2r8eHDX4kUVTHR0+/rEWYCfCle2FFJ?= =?us-ascii?Q?PUxpyiC7InQIismx/XWplFQiKE0prniWpZ1voMTt0TNdlj2AQwRl0jzuZAUt?= =?us-ascii?Q?46BcOJ99vBX5IKi3r4Ktgk8H06gOiddw/h2QJQe/IcRCoQusxEsD07iTuCOw?= =?us-ascii?Q?InlAPJcsnlHa2l38kCwoDXwz9e+c3GLqKGyjYFRrLpkMpv7VOZMBebKkhhsF?= =?us-ascii?Q?C7vwFFeXDGaW6/vZRU4h8IC6lRH2Zb61owEzdBzwbT+U+y4Z+3KlsDLq0i2B?= =?us-ascii?Q?z5igSxTdMxTSAQ30tqnyQ3o6wlW7o7XgGU11kk4DIbOmX8lDVg2dH5/jBBBZ?= =?us-ascii?Q?7gAfPTeBvqSnPWWJGykk4iVBynOvFvY+Gdi15L1ADhNvUoIuieKNxzvwILCF?= =?us-ascii?Q?yiF3BgHfyZ+WfOaFzZEMnLbI4QnK0Xuj3AMp3vSFKEb1/74hstrR6pDBgN9/?= =?us-ascii?Q?a5OMBzr9CS6rdJ31k4GqOK7yt0cCq4qyyHd81/hvu90xqdRFZaZqORRI9mAH?= =?us-ascii?Q?kql2Un5uPDZdGUDQCtAgRqBZUDp3TAVv0jN9AxxfaT4e6vdmx/eiIk9Z+xF+?= =?us-ascii?Q?DfGDG976qpZFVElZsX5CL4kictzL+8vl9FYL9nXN4IC5Folgn/uOSva19WF0?= =?us-ascii?Q?FEvRnSc5LHSIfNfI8MfbBMfu46ZHDdn/+SQzQEqls2MBjl/HeFKYsHwI94ID?= =?us-ascii?Q?eqD8s6d/OwaKCA5bINEtnQDpeuc0klmFWtZsf2Nv+qaWUld1xD5JIc2xtX8x?= =?us-ascii?Q?xjVn6oCG4IFMXkMf0eBxwOIvuwxJ5DsTX+NzeVBBbqxUa2teEC+BFuwfRtoT?= =?us-ascii?Q?Gp80DRPfYXUtg0k1ZW/MAeUtzdhVY52QJ/XWcoaYraGpt7eBbjgXGYo9Aqaj?= =?us-ascii?Q?cySKXhQDV5IoZoSTZhCiqJh4fSvNTI6OwoxTjVQQ/yQBL1lA3E19XQyvvF5a?= =?us-ascii?Q?AYO3cyja+3twcCtzLH/hNkG1GC+cpwkbLrAHDyr3CdniN/GdZCMgAO9e2fKC?= =?us-ascii?Q?8Uk73h49dkO/0IMLyqJIeTpyXyCBYAjqq6DX8EsuaMt33szKOqauD2GWUtsT?= =?us-ascii?Q?3abjBvUH6xsElkSdyj7MkhQqVnTStNt8djup6JMDBXCRFQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB8209.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(366007)(1800799015)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7lkUSbsdqUW1eCCh9m9QGG6SdQ8F7WW0DgJGgrvFCy22xR2f2w9VRveZ2ByB?= =?us-ascii?Q?dxbvdXjhCk7NAa/7LHYy3MbM6wv3mLLYcsJyiYuBFlN8wZ+GzMd0XkAy8JdA?= =?us-ascii?Q?oDQPvGyIzzmZnlMKS3nCEHIJasflYV1olT9ehvFuOXdwtFE8pXGB8H7UzHs9?= =?us-ascii?Q?IL/ju/4y3+mZNlaGNpd1qlPcLjwVPJ9WvPpM26edIP/+3q6tAr4h03urIXBw?= =?us-ascii?Q?QED1xfdHhvB5/aKw4eTpl53HamIO1Etyt/FjaBIEDKXtldyjk5Cp/9vJUwmc?= =?us-ascii?Q?rM0F/v5FriEw5aIiUC3pOpPsBWr4vfWeCmnuMjNTtwN9rrIV9056gMTiXaRj?= =?us-ascii?Q?pUTJXxX7EoAaQZBo2tiXw4ZVrRYcFLbm5JtN4Kfyihn0n61UMse0MwMm83u5?= =?us-ascii?Q?nFXNXq/IqHI4Ei8rZQeObU/mnzS2NtMD6G8bzwXqtFGyWBPP7Vzwlau4G4V5?= =?us-ascii?Q?VujlqzKvIBBY8p/MxRRQgKoXEfKBJnG7Z9SPWdQkuKiZfZdJ7Y4gt1ynKt0p?= =?us-ascii?Q?S4LVk9q5pBFNLmWvjRdn1weI2oTcT+aeFDRvox/iQVX5X5ogKYefehNyrN+2?= =?us-ascii?Q?tgd8vO7lCgpyFBqbtGsXNMHAiG9xnwhxp8ZWLhdu47VSAP6yOmrmNxDjhybX?= =?us-ascii?Q?xA1KiTnurdgJalM4ud2cNWT5sm8IYwv+fizn6hGxnu50Nj99S70bDMQaqcAa?= =?us-ascii?Q?QmGHkhfmGk39i/Rwpzh2/nigG2MkDCYJ2vfBz7nV6XZ47t7bSFboSoO2uEsE?= =?us-ascii?Q?RkAmMToSHr9vJlSJcDdMbHqN5lADcv+JxY+aedoCg4uwld2oQQPrZ9MKE4hQ?= =?us-ascii?Q?nT93YGxlcGXdrMUPds0+ZKZTKqU96VKmx5jDnTb0mdDBYX7laFsn7/xne1wV?= =?us-ascii?Q?cw6k5NJ598NPpALjk+0ktr5GAoEBKg9GFbcVfFVCJnLOMhMV2OEQiqKBLA2D?= =?us-ascii?Q?VQ7bwUbAFRttS2GfM78tvny95qlho/MtSJyusMdx53YF1GjNyj2cFRZuOqqV?= =?us-ascii?Q?muW8l4FV/GQ1z3RF/6kN1YdJKMMr8OtB188xOqoHHBJDFEHiJTPFzX7OjH0i?= =?us-ascii?Q?XnZFPxNI8Y9Ca63SqplmMpEIDja9fWHDOTLoQobvbTtQpsCFiunTSOMztgno?= =?us-ascii?Q?mQJvmZN+gPaMDZvUuUPeevqkqARN0Z56PxoKddEoBV36pq+AYQONRvzaE9BG?= =?us-ascii?Q?wY25/3Z1ejovT/5j9mslXX/voDv1J4Cf8r8GY0Q/j4LES/FfJbBVvAoyXG9a?= =?us-ascii?Q?GEq2gOe6o6mQElDcj/IFJQWV6TKTnR5XhF2UM9vBPkiNgQjAfjc+ohCfu7a6?= =?us-ascii?Q?IOzDYm8lqZS0jIOsAoHVWkMi8TnVykgICeGQsbX8H3948mIdS9EHCFqeNb9/?= =?us-ascii?Q?VkLnQEr7kpB13kJWTdWlT6lxc83d5tNg/tm2srBdy0Dielzn6Z3K1HggLD5u?= =?us-ascii?Q?n9WntnilmdrI4qP19E3WO3WrmGDhL20Rv4oPXrN9D1FwZMyogWIxbOburm75?= =?us-ascii?Q?O/Sfnl+JDi8QzYd7ePiqU1Bh8ofpCqfvi892zLKY75LVB43jOFVRLRdncgVj?= =?us-ascii?Q?Tc11ClmPWd7YSbkC6WE=3D?= Content-Type: multipart/alternative; boundary="_000_CH3PR12MB8209547C3B14902544E5F276ABF32CH3PR12MB8209namp_" MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8209.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb1ebf2a-d391-4f91-c7f9-08dc8081b3f2 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2024 08:22:53.7832 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Q04yjov9ZsYpHLcMe8F4j/sv8qNAicsGNerb2JmcLvQ975z+Ykt1tCjWhH8Kglf+aVPRarEVqyi2tnArcZt9CQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7544 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_CH3PR12MB8209547C3B14902544E5F276ABF32CH3PR12MB8209namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi @Dariusz Sosnowski Can you comment on this pa= tch? Thanks. BR Rongwei ________________________________ From: Rongwei Liu Sent: Monday, May 27, 2024 10:47 To: dev@dpdk.org ; Matan Azrad ; Slava Ovsi= ienko ; Ori Kam ; Suanming Mou ; NBU-Contact-Thomas Monjalon (EXTERNAL) Cc: Michael Baum ; stable@dpdk.org ;= Aman Singh ; Yuying Zhang ; Ferruh Yigit ; Dariusz Sosnowski Subject: [PATCH v2 1/4] app/testpmd: fix the testpmd field string sequence External email: Use caution opening links or attachments The field string should be in the same order as the rte_flow_field_id enumration definitions Fixes: bfc007802 ("ethdev: allow modifying IPv6 FL and TC fields") Cc: michaelba@nvidia.com Cc: stable@dpdk.org Signed-off-by: Rongwei Liu --- app/test-pmd/cmdline_flow.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 60ee9337cf..775ce20fc4 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -1002,10 +1002,10 @@ static const char *const flow_field_ids[] =3D { "hash_result", "geneve_opt_type", "geneve_opt_class", "geneve_opt_data", "mpls", "tcp_data_off", "ipv4_ihl", "ipv4_total_len", "ipv6_payload_len", - "random", "ipv4_proto", - "esp_spi", "esp_seq_num", "esp_proto", "ipv6_flow_label", "ipv6_traffic_class", + "esp_spi", "esp_seq_num", "esp_proto", + "random", NULL }; -- 2.27.0 --_000_CH3PR12MB8209547C3B14902544E5F276ABF32CH3PR12MB8209namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Hi 
@Dariusz Sosnowski Can you comment on= this patch? Thanks.

BR

Rongwei

 

From: Rongwei Liu <rongw= eil@nvidia.com>
Sent: Monday, May 27, 2024 10:47
To: dev@dpdk.org <dev@dpdk.org>; Matan Azrad <matan@nvidia.= com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Ori Kam <orika@= nvidia.com>; Suanming Mou <suanmingm@nvidia.com>; NBU-Contact-Thom= as Monjalon (EXTERNAL) <thomas@monjalon.net>
Cc: Michael Baum <michaelba@nvidia.com>; stable@dpdk.org <s= table@dpdk.org>; Aman Singh <aman.deep.singh@intel.com>; Yuying Zh= ang <yuying.zhang@intel.com>; Ferruh Yigit <ferruh.yigit@amd.com&g= t;; Dariusz Sosnowski <dsosnowski@nvidia.com>
Subject: [PATCH v2 1/4] app/testpmd: fix the testpmd field string se= quence
 
External email: Use caution opening links or attac= hments


The field string should be in the same order as the rte_flow_field_id
enumration definitions

Fixes: bfc007802 ("ethdev: allow modifying IPv6 FL and TC fields"= )
Cc: michaelba@nvidia.com
Cc: stable@dpdk.org

Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
---
 app/test-pmd/cmdline_flow.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 60ee9337cf..775ce20fc4 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -1002,10 +1002,10 @@ static const char *const flow_field_ids[] =3D {
        "hash_result",
        "geneve_opt_type", &qu= ot;geneve_opt_class", "geneve_opt_data", "mpls",         "tcp_data_off", "= ipv4_ihl", "ipv4_total_len", "ipv6_payload_len", -       "random",
        "ipv4_proto",
-       "esp_spi", "esp_seq_nu= m", "esp_proto",
        "ipv6_flow_label", &qu= ot;ipv6_traffic_class",
+       "esp_spi", "esp_seq_nu= m", "esp_proto",
+       "random",
        NULL
 };

--
2.27.0

--_000_CH3PR12MB8209547C3B14902544E5F276ABF32CH3PR12MB8209namp_--