RE: [PATCH v6 2/4] net: add new union into VXLAN header

[rongwei liu <rongweil@nvidia.com>]

BR
Rongwei

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, June 5, 2024 18:42
> To: rongwei liu <rongweil@nvidia.com>
> Cc: dev@dpdk.org; Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; Suanming Mou
> <suanmingm@nvidia.com>
> Subject: Re: [PATCH v6 2/4] net: add new union into VXLAN header
> 
> External email: Use caution opening links or attachments
> 
> 
> 05/06/2024 12:21, Rongwei Liu:
> > Add "uint8_t last_rsvd" as union with origin rsvd1.
> 
> You should explain why: for matching what we have in testpmd.
> I think it should be squashed with the next patch.
Sure. Let' squash them, still with "ethdev" prefix?
The explanation should in the commit log not in the header file. What do you think?
> 
> > -                     uint8_t    rsvd1;    /**< Reserved. */
> > +                     union {
> > +                             uint8_t    rsvd1;        /**< Reserved. */
> > +                             uint8_t    last_rsvd;    /**< Reserved. */
> > +                     };
> 
>