From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1DF3A4415C; Wed, 5 Jun 2024 10:15:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1954C40A71; Wed, 5 Jun 2024 10:15:03 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2048.outbound.protection.outlook.com [40.107.100.48]) by mails.dpdk.org (Postfix) with ESMTP id EDBEF40A75 for ; Wed, 5 Jun 2024 10:15:01 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UHNVX0G4tFaNK47+omatzD1y5pUYgK4dBSgKIdp6qZe4BkXtEroColAOeGLvJZzkgJvXWDYqfNshiDA4mXWgJxJ5nYSXaXiBJV0sXoxj3c/nwV3MafrQYtbvZNrtpqn/PjJDC6kfkQc/QrFroFTYzH6vXpNfjULm5Ap4/i9pXIydqEDo1f1ot3xHcUNSegqH9G8lDkH4W82yPw9vWmrlu5PZtGfvvNKhmKlupLkH0PszmjpR1Na06aCh6sizeCTffG6wgrwr51juHZJaEWzaAyYaQ1iB4GgxZxDu26mQo3U6CRcP2vbjIfcsaJff0mmuido54NTPUdTCyQ046FAxrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qABX/LD5FFdXa5mPcmBEDWMZB4N5p7qQnY2TdlSmNcA=; b=Me+vijkeuZcU9QcCQCysCs5yrIU5+z4motAryISg+bs1kMprXsCX/zfbA+qHUZCv1Sxe8VmERo5XnXPqGJVUq85iDLIeA1n726L+D3c7Lm1HDsP0WVWjcsBUolN7HGrxvmbGRhq0KansK5QBqSv9jnOfDVbvi8zVreZgp/zRd5eqwHCuaS9wFm4HTv7mhcjqPn2T5DwWDpejOJQB3VUt9boHqqn+Keq9DSgjZO2SS12HoRgaGKwPu9p/yO4aorWZ5PI/9DmwbAKetUjN7WYJM9tcWufz1mDBGwCWGkub0HDil6zu0BiUUsheD7iyfx1BU2bZlOufbpPtRe5LWxv74A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qABX/LD5FFdXa5mPcmBEDWMZB4N5p7qQnY2TdlSmNcA=; b=IUKsd/bOc2k2Kp8oNpwfxZjvRkvduLY4Fw4bRXoFwQnzaa/GIuXZct9dBeADLW1hdRvnktxe/U022p6C1hkCfgKddQv3G+1uYHl/1xg9eV+idSOcSgKB2/JTq3YKCfHxbq9V2CEtSk2fzYN0ueXoNQSc4FJ7OZxUiXvjtdauGYY8db5g39X6yin/6+mDQ0MWsl6yYNDNcjKHRthtC0+LiKQA9OfidD9A4XdEc635HtW8E6QSb7UoaFUKiWoaYW9hS3pReZiKJ9fKJq9B0Q7m0dQy0ws72kcabgnR0qK/VggkGLAx7OIMmShW4fl//pk4s1IcJxPcVWBhu6sLBWCvpw== Received: from CH3PR12MB8209.namprd12.prod.outlook.com (2603:10b6:610:123::18) by CY5PR12MB6250.namprd12.prod.outlook.com (2603:10b6:930:22::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.24; Wed, 5 Jun 2024 08:14:59 +0000 Received: from CH3PR12MB8209.namprd12.prod.outlook.com ([fe80::9127:5857:7ba5:a7f2]) by CH3PR12MB8209.namprd12.prod.outlook.com ([fe80::9127:5857:7ba5:a7f2%4]) with mapi id 15.20.7633.021; Wed, 5 Jun 2024 08:14:58 +0000 From: rongwei liu To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Dariusz Sosnowski CC: "dev@dpdk.org" , Matan Azrad , Slava Ovsiienko , Ori Kam , Suanming Mou , Aman Singh , Yuying Zhang , Ferruh Yigit , Andrew Rybchenko Subject: Re: [PATCH v4 2/3] ethdev: add VXLAN last reserved field Thread-Topic: [PATCH v4 2/3] ethdev: add VXLAN last reserved field Thread-Index: AQHatnxK7usmfC8pJUuRgvKy0YbyIbG3s94AgAAWyJmAAARWgIAAIHCAgAButFqAAGS6gIAAEI/7 Date: Wed, 5 Jun 2024 08:14:58 +0000 Message-ID: References: <14937324.O6BkTfRZtg@thomas> <5068960.a9HWlOh95j@thomas> <6114865.NeCsiYhmir@thomas> In-Reply-To: <6114865.NeCsiYhmir@thomas> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR12MB8209:EE_|CY5PR12MB6250:EE_ x-ms-office365-filtering-correlation-id: 7bf3846c-8fd8-4b06-3c05-08dc8537975c x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|376005|366007|1800799015|38070700009; x-microsoft-antispam-message-info: =?iso-8859-1?Q?H9ybYh0xcQmY4djHHEyV/o84W6ffP5WT7DcXCulF+Yz9lQUv0xUbNwSq+y?= =?iso-8859-1?Q?KX/yYq6keNG5hrYNX2YULNa4Svbgu3bgxUdT80F9yhtXFzuMzJoIB2y05A?= =?iso-8859-1?Q?WhbfOJH4ljHJaWOSWN0wp7sgdpFQyhnJPstLZbp47NqGnpfDauLGrv6csP?= =?iso-8859-1?Q?+sLow8+1PGANtSeallT2y9RlLZ/GJLvm3InK/V6U9EjblEukyf9dx5r9iI?= =?iso-8859-1?Q?KxEx91RP7qlL/sOnFuJ/vT32NwEeq5E+XUtbfX+Yqg4BNLDV3DuNsY23IA?= =?iso-8859-1?Q?/s486iwGsgeSscnbOWWrpdtD2U+bt8G+RYJj47qFd+QGJrM2HY7KKJXeu0?= =?iso-8859-1?Q?S1s2YJbpXeoeuwiD434v9LBHgNGOJzdpYGedmRyj3ZDeY7E9PqYqwaqUUw?= =?iso-8859-1?Q?URpUZzahOmGAGYsnoEn3r2OUhgHq21lChk9XNSsSYKXqT6heBy7iHj/2vZ?= =?iso-8859-1?Q?oc+Uds9aeqyJAKEA7SRJp32VvomaUO2JF2g7WytMX5MxdNL4C5lftBF5ZC?= =?iso-8859-1?Q?/cUVtd6iEUpsRNq4tRbl0wSNjeG5CZRMJIUzW6fB+a6gXR910agwvwjYfh?= =?iso-8859-1?Q?YE6TMlqhimSP8DznAi52lCWNUSOekTCOYZ8JeBWMxQ/fKe77LQBCwJs4wP?= =?iso-8859-1?Q?mUHTlv7UEqZezIegFuzZOg48OvMLuJiK3RTLAKQLwfDWp/YoY1H2Rg9Kam?= =?iso-8859-1?Q?XZJmeAh4GsjQVfeSlEgwlrDI4ti+WHq9AKakjdlCaRCwAyy/Zo3hgQBCaU?= =?iso-8859-1?Q?k2z0VQgVfsXJZwRzz7HG6hl30MMzf0Yik8lNalsbZEHaby/3SmRkQYX/L3?= =?iso-8859-1?Q?7H4lSyEAYB4Bgi07hFORAcRIGWpDh+OyPrs80CUq+S0d6iJEDYH7znpsI7?= =?iso-8859-1?Q?1gHV+u8ZQGJBTIjfIsiia9GtIV8KLaB6qU2CVqq0O11ONCJRFhQmqNU9Ja?= =?iso-8859-1?Q?6JrzXNPwpGA46KC91/MJ5PHD6bPmTUTuiExd/r2DtfQilLeg8FLETCXxkq?= =?iso-8859-1?Q?SGu393OEz3BCeOIlarTXm4ZtKw3PZDz1YhkhNSFvWiHNX9H4x3p9SfphAL?= =?iso-8859-1?Q?bLetbzcMDjZ14Iju5lFDvaqXtsM00t3Ry2hJ/QmVoQZTT4H2c1jXZc649R?= =?iso-8859-1?Q?cbvZQSqziucGvlNCIZZ0EOgQ/Kj7XG2w3pm7Ab0QIpIQmQmBAMOkvSR0Ge?= =?iso-8859-1?Q?E0nUclZve4XpJnT16VuSte50DEuB7kxaAj9vBvZmyf2Q+88sIsPjoM3I3E?= =?iso-8859-1?Q?ynM/vGMjBHo7h3RmJaRhdffMSfKIXGnXjGghPyEPU+H3+CPO7pec27K8Ob?= =?iso-8859-1?Q?N0tVxcmWNmjs3NRErBkH9rFJtDiyU78qS1fqsNsSxa2I4Z2M1U7AEgScHg?= =?iso-8859-1?Q?sOh/YiVxSXScL0V73t1RakDbhe9e1r45BHLepuWhuuPuePQOpdN5s=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB8209.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(366007)(1800799015)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?mccCmM++kirbabeu7BX96Fb+23zTpt/SgvhS6FtWZucVyJL5a4h850RosM?= =?iso-8859-1?Q?RA7jLsJT8W/KRasDddXjIo3Ne4qoOs1SgWPNWTUp/hiXO8oks88HO7d+zb?= =?iso-8859-1?Q?Ja0GLzw8XyA0umiX4Ll+DIPVSbWDUQe1ciyToG2juw86h469DQ2b952hQN?= =?iso-8859-1?Q?6xmQ7UaEjGmSDO5JUS9c96wRKcxeJ5WXNk1rhZ9r/c45l/RyTQCzHAKskh?= =?iso-8859-1?Q?JwkicmEMvdp8EKAuUxxslz0fvbv1vpbf3+2neLl//CaldDFG2v3HMtc8WQ?= =?iso-8859-1?Q?rkl7Mm5fZd7lwnEBDCoONskTdDecTAJfVSvzh9wDNAYsxYFoOJx2yH1/p9?= =?iso-8859-1?Q?iGk27G+QBL7ezlNTZl0nH+KVjdOMHsQM1W1VAy9MappI6p+8LnTlkee3us?= =?iso-8859-1?Q?vasRszTkZH8BrAFXRc/CuIsQ9bDEz8t6x86h0yGMk9/lS9OT1kFKACC/9u?= =?iso-8859-1?Q?p4GAeXtQyYJQehAHLsC5u4lWoQ/eMVjmLucZ0sZLsn14gaMgL51JHJLJP2?= =?iso-8859-1?Q?3RbeKZxc9RJjmVVeSWdtS3h8cdwg7VokIyrN+zo/SMFtt7FF7ELlGs+KQx?= =?iso-8859-1?Q?RVTwJyABtIJnpDqfJlHL3iRidRpgT1MJnJ0Ww214mBrjngiAAyJ3BQxSov?= =?iso-8859-1?Q?I9cKTWrc5dFqQmIKxeq6/4PWhhrasbxE0xz940bC5M5kCcpANAZyTCuzqU?= =?iso-8859-1?Q?9MjpXNnN3lWZnHGu1WJRi63OZHZU5jon6hB+uQty+9MT/k3lON3HWgE5/I?= =?iso-8859-1?Q?Tgs8LS+wcFGBLXh3PLg/O0+xNw36RKpNqC/YqnJWTREWKMQqy3Qyw6sgBq?= =?iso-8859-1?Q?Fo4d6YzH6pIFRKAHvdjeKkFvASadHLrKQqcOUM3dCIIZELr7i/89xf4Jsq?= =?iso-8859-1?Q?ylXwjZswBQ+tW7/tvdxWmoTxVwBlYX9+BqaZc60PQLxIZeSQ9muxS0ch8x?= =?iso-8859-1?Q?4ivtdfoKmTrVTOnuOaJbhSLYvKFSkEOeLt/SDpu55HvAnz4eu7nc9u5/eU?= =?iso-8859-1?Q?lOwMCyojy3r+SZhy8vySEtqpFh20owy8shje8tobxLZdQmBrt3iUcoxQ8N?= =?iso-8859-1?Q?7gk9xgPBNMWD5w/GHzTPDmRPbcVCFgI+CbD/Xkqy1oemsdLdbhqAIx+nFa?= =?iso-8859-1?Q?foqOHAnHin8C8pNp/vRZks/J5EETJUDc9/0QOz3fAOGAm8m6HcZd6sQKLR?= =?iso-8859-1?Q?x1fmrnsg3++Cv5MokF5QUulDnZ5DOAVRiV6yYYoqdykxsNeJwSAH8aJ0QG?= =?iso-8859-1?Q?r4vf9u/Ituin/VM32zHul+beF4uTrxvlE/70INL/t7b4RCItvN1GxdnGdq?= =?iso-8859-1?Q?Eqj8I2FLPbxYLmFJ8aXAYztI899eEsQJsK7zin0TDtWpOzFjGUegT7hYVs?= =?iso-8859-1?Q?kqRoLi+pCqjkV8RE8i494gJW2lQtYHPn/0zfG3dikmq9KCmt1YMLAGbcBW?= =?iso-8859-1?Q?w0efOiQ1KjfzxO6qApKNTQNEZ1g/SxgaKYZck321u1d7VYaygwgvXXv7e9?= =?iso-8859-1?Q?dAuaN3nO/Gx6MICAe5KWxCikJ5lIAumpXj0QCOpuB6KId6UXMWDsV55TYL?= =?iso-8859-1?Q?0pKQF3mE4+aqGCSJDA3qLRbO+VEa7BPYRTEkNdqGnZbma7geu7BHRAiGbx?= =?iso-8859-1?Q?Quf8oyw7UtthVl1Tl93kwTTe8EoiHDw9I+?= Content-Type: multipart/alternative; boundary="_000_CH3PR12MB82096875D6E7CC189F84F77BABF92CH3PR12MB8209namp_" MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8209.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7bf3846c-8fd8-4b06-3c05-08dc8537975c X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jun 2024 08:14:58.8534 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EJeCLjmVNtMoocE2MDKX8RoWG7LV5e7+lCe989iJhKsl9Gfsf5mOlpTIeavDX52kDCT1pUM5c+qDCYU4CqCWdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6250 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_CH3PR12MB82096875D6E7CC189F84F77BABF92CH3PR12MB8209namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable BR Rongwei ________________________________ From: Thomas Monjalon Sent: Wednesday, June 5, 2024 15:13 To: Dariusz Sosnowski ; rongwei liu Cc: dev@dpdk.org ; Matan Azrad ; Slava Ovsi= ienko ; Ori Kam ; Suanming Mou ; Aman Singh ; Yuying Zhang = ; Ferruh Yigit ; Andrew Rybch= enko Subject: Re: [PATCH v4 2/3] ethdev: add VXLAN last reserved field External email: Use caution opening links or attachments 05/06/2024 03:16, rongwei liu: > From: Thomas Monjalon > > 04/06/2024 18:40, Dariusz Sosnowski: > > > > > 04/06/2024 14:38, Rongwei Liu: > > > > > > --- a/app/test-pmd/cmdline_flow.c > > > > > > +++ b/app/test-pmd/cmdline_flow.c > > > > > > @@ -1006,6 +1006,7 @@ static const char *const flow_field_ids[]= =3D > > > > > > { > > > > > > > > > > > > "ipv6_flow_label", "ipv6_traffic_class", > > > > > > "esp_spi", "esp_seq_num", "esp_proto", > > > > > > "random", > > > > > > > > > > > > + "vxlan_last_rsvd", > > > > > > > > > > > > NULL > > > > > > > > > > > > }; > > > > > > > > > > How vxlan_last_rsvd is linked to RTE_FLOW_FIELD_VXLAN_RSVD1 in > > > > > testpmd? > > > > > Just because it is the same order? > > > > > > Yes, it's because of the order. > > > We should refactor this to use array designators. > > > > > > > > > --- a/lib/ethdev/rte_flow.h > > > > > > +++ b/lib/ethdev/rte_flow.h > > > > > > @@ -2428,6 +2428,7 @@ enum rte_flow_field_id { > > > > > > > > > > > > RTE_FLOW_FIELD_ESP_SEQ_NUM, /**< ESP Sequence Number.= */ > > > > > > RTE_FLOW_FIELD_ESP_PROTO, /**< ESP next protocol > > > > > > value. */ > > > > > > RTE_FLOW_FIELD_RANDOM, /**< Random value. */ > > > > > > > > > > > > + RTE_FLOW_FIELD_VXLAN_RSVD1, /**< VXLAN last reserved > > > > > > byte. */ > > > > > > > > > > > > }; > > > > > > > > > > I think we should use the same naming as in testpmd. > > > > > What about RTE_FLOW_FIELD_VXLAN_LAST_RSVD? > > > > > > > > To be honest, no strong objection per my personal thought. > > > > Considering the API "vxlan_hdr" names this field as "uint8_t rsvd1"= , > > > > maybe RTE_FLOW_FIELD_VXLAN_RSVD1 will be clearer for user as 1 vs 1 > > > > mapping?> > > > > > +1 on using RSVD1 so it matches rte_vxlan_hdr definition. > > > > > > In this patch, "vxlan_last_rsvd" is used in testpmd, so it matches > > > existing "last_rsvd" field in VXLAN item. If we choose to use "rsvd1"= , > > > we should probably rename all other instances of "last_rsvd" to match= .> > > > I prefer "vxlan_last_rsvd" for 2 reasons: > > - it is more meaningful > > - we are adding first, second and third reserved fields to matc= h > > the 3 bytes of rsvd0 (patch to come) > > Sound clear and reasonable. I would like to propose the alignment between= rte_flow_field_id and rte_vxlan_hdr: > > 1. > RTE_FLOW_FIELD_VXLAN_RSVD1 ---> RTE_FLOW_FIELD_VXLAN_LAST_RSVD > 2. > "uint8_t rsvd1" ----> "uint8_t last_rsvd" We don't change rte_vxlan_hdr, because we avoid breaking compatibility. How about to add a new union: union { uint8_t rsvd1; uint8_t last_rsvd; } RTE_FLOW_FIELD_VXLAN_LAST_RSVD will perfectly match the rte_vxlan_hdr defi= nition. --_000_CH3PR12MB82096875D6E7CC189F84F77BABF92CH3PR12MB8209namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable


BR

Rongwei

 


From: Thomas= Monjalon <thomas@monjalon.net>
Sent: Wednesday, June 5, 2024 15:13
To: Dariusz Sosnowski <dsosnowski@nvidia.com>; rongwei li= u <rongweil@nvidia.com>
Cc: dev@dpdk.org <dev@dpdk.org>; Matan Azrad <matan@nv= idia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Ori Kam <o= rika@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>; Aman Singh = <aman.deep.singh@intel.com>; Yuying Zhang <yuying.zhang@intel.com&= gt;; Ferruh Yigit <ferruh.yigit@amd.com>; Andrew Rybchenko <andrew.ryb= chenko@oktetlabs.ru>
Subject: Re: [PATCH v4 2/3] ethdev: add VXLAN last reserved fie= ld
 
External email: Us= e caution opening links or attachments


05/06/2024 03:16, rongwei liu:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 04/06/2024 18:40, Dariusz Sosnowski:
> > > > > 04/06/2024 14:38, Rongwei Liu:
> > > > > > --- a/app/test-pmd/cmdline_flow.c
> > > > > > +++ b/app/test-pmd/cmdline_flow.c
> > > > > > @@ -1006,6 +1006,7 @@ static const char *cons= t flow_field_ids[] =3D
> > > > > > {
> > > > > >
> > > > > >       "ipv= 6_flow_label", "ipv6_traffic_class",
> > > > > >       "esp= _spi", "esp_seq_num", "esp_proto",
> > > > > >       "ran= dom",
> > > > > >
> > > > > > +     "vxlan_last_rs= vd",
> > > > > >
> > > > > >       NULL
> > > > > >
> > > > > >  };
> > > > >
> > > > > How vxlan_last_rsvd is linked to RTE_FLOW_FIELD_VX= LAN_RSVD1 in
> > > > > testpmd?
> > > > > Just because it is the same order?
> > >
> > > Yes, it's because of the order.
> > > We should refactor this to use array designators.
> > >
> > > > > > --- a/lib/ethdev/rte_flow.h
> > > > > > +++ b/lib/ethdev/rte_flow.h
> > > > > > @@ -2428,6 +2428,7 @@ enum rte_flow_field_id = {
> > > > > >
> > > > > >       RTE_FLOW_= FIELD_ESP_SEQ_NUM,     /**< ESP Sequence Number. */<= br> > > > > > >       RTE_FLOW_= FIELD_ESP_PROTO,       /**< ESP next proto= col
> > > > > >       value. */=
> > > > > >       RTE_FLOW_= FIELD_RANDOM,          /**<= Random value. */
> > > > > >
> > > > > > +     RTE_FLOW_FIELD_VXLA= N_RSVD1,     /**< VXLAN last reserved
> > > > > > byte. */
> > > > > >
> > > > > >  };
> > > > >
> > > > > I think we should use the same naming as in testpm= d.
> > > > > What about RTE_FLOW_FIELD_VXLAN_LAST_RSVD?
> > > >
> > > > To be honest, no strong objection per my personal thoug= ht.
> > > > Considering the API "vxlan_hdr" names this fi= eld as "uint8_t rsvd1",
> > > > maybe RTE_FLOW_FIELD_VXLAN_RSVD1 will be clearer for us= er as 1 vs 1
> > > > mapping?> > >
> > > +1 on using RSVD1 so it matches rte_vxlan_hdr definition. > > >
> > > In this patch, "vxlan_last_rsvd" is used in testpm= d, so it matches
> > > existing "last_rsvd" field in VXLAN item. If we ch= oose to use "rsvd1",
> > > we should probably rename all other instances of "last_= rsvd" to match.> >
> > I prefer "vxlan_last_rsvd" for 2 reasons:
> >         - it is more mean= ingful
> >         - we are adding f= irst, second and third reserved fields to match
> >         the 3 bytes of rs= vd0 (patch to come)
>
> Sound clear and reasonable. I would like to propose the alignment betw= een rte_flow_field_id and rte_vxlan_hdr:
>
>   1.
> RTE_FLOW_FIELD_VXLAN_RSVD1  ---> RTE_FLOW_FIELD_VXLAN_LAST_RSV= D
>   2.
> "uint8_t rsvd1"  ---->  "uint8_t last_rsvd= "

We don't change rte_vxlan_hdr, because we avoid breaking compatibility.

How about to add a new union:

union {
    uint8_t rsvd1;
    uint8_t last_rsvd;
}
 RTE_FLOW_FIELD_VXLAN_LAST_RSVD will perfectly match the rte_vxlan_= hdr definition.
--_000_CH3PR12MB82096875D6E7CC189F84F77BABF92CH3PR12MB8209namp_--