BR

Rongwei



________________________________
From: Thomas Monjalon <thomas@monjalon.net>
Sent: Tuesday, June 4, 2024 20:19
To: rongwei liu <rongweil@nvidia.com>
Cc: dev@dpdk.org <dev@dpdk.org>; Matan Azrad <matan@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>; Dariusz Sosnowski <dsosnowski@nvidia.com>
Subject: Re: [PATCH v2 4/4] net/mlx5: implement VXLAN last reserved modification

External email: Use caution opening links or attachments


27/05/2024 04:47, Rongwei Liu:
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
> @@ -685,6 +685,11 @@ Limitations
>      - Second tunnel fields are not supported.
>
>    - Encapsulation levels greater than ``2`` are not supported.
> +  - Modification of the VXLAN header is supported with below limitations:
> +
> +    - Only in HW steering (``dv_flow_en=2``).
> +    - Support VNI and rsvd1 modifications for traffic with default VXLAN/VXLAN-GPE/VXLAN-GBP
> +      UDP destination port.

Don't add at the end of bullet lists without trying to order.
It is limitation for a specific protocol, it should go above with other protocols,
between "Modification of VXLAN network" and GENEVE limitations.

"rsvd1" should be replaced with "last reserved byte".
Ok.

What do you mean with "default VXLAN/VXLAN-GPE/VXLAN-GBP UDP destination port"?
Is it port 4789 for VXLAN and VXLAN-GBP, and port 4790 for VXLAN-GPE?
We need to be more specific probably.

Will change to the exact number.