From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7CEA744153; Tue, 4 Jun 2024 14:25:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6DB3F40E25; Tue, 4 Jun 2024 14:25:02 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2079.outbound.protection.outlook.com [40.107.243.79]) by mails.dpdk.org (Postfix) with ESMTP id 2448D402E3 for ; Tue, 4 Jun 2024 14:25:01 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EApGKwg1/ohmL/w4rqA3EC/FCf2Kkee+3B45pC6EdscswoUoO/nLF7GmxrgibjMFPmSa2SoS+pexahlSXreT0IcATm4W6/In+Ol/45fhM3i8WdH6Gv9DQDdtcHFIXXT1AFWMoqa4c+PlsTD7bqg5kHWgxgZbAiGwSVLOqy3KihetKpwLMaUvwZrgqVf0higILNLUMzLkFsQC+dhwUgKjCGhCLlnw0REwEVLIAPOxr2iZ9cCYViSdIfzGeZ201ifu69wOw/+dBX/yZY9ZgKy+kvUzjyIdM1fDnsrzDXbAbqETD8aLsEVjWNZnalgt7DWJPMP00VmXDXZZ0zfKhAlVSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W5L3FUd2qj+wp1GIdEWxC4zYI2HxxyeYg+Sn/yfonuI=; b=PPv5T1csgFYXUW3kSwLzO+0C+bJYhOKSXgew6Tmno7pJ+BpQ0TF57cER600O/P44UukplwMMdPxYtilG9oplNhWNp5cqLa5j7ukjQ+tLKwFhJHaoYPdRlb+PPjebPNLs9AwuDrsrdNCbJuYa420BwszDqoz+YKIyO5JwiW3f/lAsotvvozaUUpo3yIHDn7si4izqboWe5qVBueEYvDZEih4a9okv6QI5kgEI3KZfrSd6SfVVrJIKCalhPwAmTDQYay0skohV7ifG02mxDgrezwVCPUWunzrs4hOU58IS2wpUFjFh9lBs+GrE9H3toBhxcbhlz4+nbgOANZNoU4Vx5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W5L3FUd2qj+wp1GIdEWxC4zYI2HxxyeYg+Sn/yfonuI=; b=e4MJTDA+n1u5HQnmWvAFLCnzRz4BCK9BGXy28LxguDbekbfO2vcAKvLNVs4r7+Q5AJs9xhdqypCK2TJiAWHIAGS0xu1qGqT9GsOKO9u7mtUwcEMKvg7PSzohYGVo+L6+sG28tmJ3whA0VbXlSEsNurXorjKnZAxnbn7rfbZeTDKcPVrU2UIie4hthzG0lvnyMtjZMXCSwbNG2dvvMwj5zxWhHkY/yT9WsaXrvFNLbRpA8kE5sk6OSta2CYlyeIy9gOFeUSdBsCGIAqIKPhXxjvUhpu4m4twWPW1psF5EFZKsipYqMUIMbpA4k3zN7TmIq1i8dei/qZZk2PpPNeTT3g== Received: from CH3PR12MB8209.namprd12.prod.outlook.com (2603:10b6:610:123::18) by SJ2PR12MB7867.namprd12.prod.outlook.com (2603:10b6:a03:4cd::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.27; Tue, 4 Jun 2024 12:24:58 +0000 Received: from CH3PR12MB8209.namprd12.prod.outlook.com ([fe80::9127:5857:7ba5:a7f2]) by CH3PR12MB8209.namprd12.prod.outlook.com ([fe80::9127:5857:7ba5:a7f2%4]) with mapi id 15.20.7633.021; Tue, 4 Jun 2024 12:24:58 +0000 From: rongwei liu To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" CC: "dev@dpdk.org" , Matan Azrad , Slava Ovsiienko , Ori Kam , Suanming Mou , Dariusz Sosnowski Subject: Re: [PATCH v2 4/4] net/mlx5: implement VXLAN last reserved modification Thread-Topic: [PATCH v2 4/4] net/mlx5: implement VXLAN last reserved modification Thread-Index: AQHar+BdLm7TQbtQkEexvJL74Qq7UrG3kyMAgAABLSI= Date: Tue, 4 Jun 2024 12:24:58 +0000 Message-ID: References: <20240527024720.1099161-1-rongweil@nvidia.com> <20240527024720.1099161-5-rongweil@nvidia.com> <14937324.O6BkTfRZtg@thomas> In-Reply-To: <14937324.O6BkTfRZtg@thomas> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR12MB8209:EE_|SJ2PR12MB7867:EE_ x-ms-office365-filtering-correlation-id: d9a26f41-ec12-4138-c664-08dc84915929 x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|366007|376005|1800799015|38070700009; x-microsoft-antispam-message-info: =?iso-8859-1?Q?KQYol0FUW8Cdvn6Mm73BESnT5xD2nmhRE0ouaOVH7pQBE/1rB3xCrnB6ow?= =?iso-8859-1?Q?hJId39g4gjwSrczz9E0FdYjf0uf2wZb+fvI0cKArA3GDfxnLxRnFNA/aRx?= =?iso-8859-1?Q?9pZL0Ry4xX6IH8xnsLIo7D5QHdNR/QcdH7jMzlLlQDZALslyPQ+FjLzmdz?= =?iso-8859-1?Q?hzhUYYQC82VmD9/Oii2W0ALQRhiEHNstfrG1xH8fhCsFiVyaIDQv/Slt0T?= =?iso-8859-1?Q?yM8JToAmQ7tBB7UZQXi0qUG35I+ClWynmEYrkqoyEMbdbkLI+XYZSzuERw?= =?iso-8859-1?Q?hT6dgl5Mj7N/c8+pgX8lpy81GTh5SGyWeRLs8uQ8teRTdO4NTiq3Rb/CJv?= =?iso-8859-1?Q?Nz2vlheVRJ6DePkcGGTvSuI1qa8WodfAS3qdOyfQgn7p+thr2ISuavNMVl?= =?iso-8859-1?Q?wlJaTf2HfstSpQzt83ec8z1pBtS/L5AomciG9HvGiCAjqRzNnKpaEi39DZ?= =?iso-8859-1?Q?YWJppn/qIYC53UpH3A6vTTjAkYjknYnECJ9Y2AhDnMWFrM9vptTHIlHDHC?= =?iso-8859-1?Q?6KJCQubZmK8HcWQXRg5jak/fCXSw68/X0NRs7mDNytJbuPORgiuFifCSLa?= =?iso-8859-1?Q?aL2TtkvTLmk10rTHWcwacT0O0d+wQMzGdwOXmg36Mwuf4M13RNMFBHWvFc?= =?iso-8859-1?Q?lsTvaB+ekxF8zrO3MGB+Kkg2s7fQTb7m7UO14VRpC4ZjYlejj5TsgFivuq?= =?iso-8859-1?Q?8PMI70F7BDKVbAV8pRakq//nOwT3dj3WZiBU95l/QF4DX0u1/BNqb8QBNB?= =?iso-8859-1?Q?wQqt+fy9LFbpq7pWgpJzKVnQUg6q+HSaOOr3oWcL7WhjtlGUEQs5rTh4kK?= =?iso-8859-1?Q?4TKrJ3yctppbf5RivUCr14WAo6gGPaNi8nWn2vElVjQ58WgfqEfpF0x+S2?= =?iso-8859-1?Q?4fztLAZwXBCKZ5ZkODPSXI0rAkQfyAFpl00siWEWK9igqb492Qj58XX1MX?= =?iso-8859-1?Q?MD3H+R7j0+XkptKn/0DZ3g1Cyby93W1cmqHb4XCcNtIMrvWGX9RqNQo9Gu?= =?iso-8859-1?Q?BEMyvIbPM8evLZUYJtec5Y9RxvUwgopFbNrmhRUHxIGpSdQj8CVm6JX8FO?= =?iso-8859-1?Q?52uqUtjSw+/9sqj61ThtGTqRH3fHSYb4x5XRl5VecrER38WxI4ri7orcKz?= =?iso-8859-1?Q?8IT1NOY524lfB0TqdJ3FcfZaaDoKFF9evNc7NU9Hzuv9d8f1233EoDCf10?= =?iso-8859-1?Q?QKEtFtWIw9oZii3zRDyR50wF0Qrc5WYYEYrjbKUZOy+tXtLR89XkLW4EbX?= =?iso-8859-1?Q?EASgQ7qj7Ci129QrMtr6Fakta/nRPK5WdXV2/9O/0hCkNriWqbPLGEKMD4?= =?iso-8859-1?Q?vsUUhjP7dmjehub7iwlqGpsVAfZSYpCviuAf6+w+tdNj9ajahxwMTt3Pke?= =?iso-8859-1?Q?7GpH9H5I6LFm/OoCIZDPAjqvEvsv79kg=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB8209.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(376005)(1800799015)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?vm7hDFXFX+oHr44+I9rtzDIkibBrVH6Am0KEpqWfXVD7nRER0lpEUL+xHm?= =?iso-8859-1?Q?UwZqKqBuwrFcdGlK8v5T3RPlXERiwheMfymjII7Lv6OJGZqKQCHc8L8UtM?= =?iso-8859-1?Q?5M3PLHw1og+DUVViYLj94qePEZsBGH0oP03LuLrzLAFWCLE078UGDBoZLi?= =?iso-8859-1?Q?v1B7lUsLP5c0m+huSmVWeduijtYDSHwxY39138ztH+iVI7qh89IXCIab+i?= =?iso-8859-1?Q?RCfwat72LrK9GA61lfDo+C74dJGqY+0NU9Ed9vHOCOzCWmZA3gZRLa+2Qi?= =?iso-8859-1?Q?WWFA6gGnD38cTlF95yEi13qyVa1aMJKVe0m5nKnP7Ik0N0iL4DujyC3GUd?= =?iso-8859-1?Q?gOl1IXNQ8MPqe7Utb7ZLUmrWoLluOEMZokYX2n0xqGUyiG8FGMRVjUFtAC?= =?iso-8859-1?Q?N9zcviwzkehXuRVjtawGVTPjVpKt0gGIHeH0PWm+cKnjmtWtGmeXisK6cl?= =?iso-8859-1?Q?VRtdWxRFFzb5Walixnwnq/8Tv567Q761+Fadh55IEOq5BDtTcTUAyldWX5?= =?iso-8859-1?Q?V0bF+IdX+X3z6hSuU6JmbjtVWJ3sglrUbFnnTwMgiWtzDPOwm2siWVPJ65?= =?iso-8859-1?Q?MM5mPT4KUKHMniOVE3YbUl866W+OoV+rkXf7SJ++fb3WtmMSXhUJ/l9Aq0?= =?iso-8859-1?Q?UeDZdnNBaljzep4K8l8nDii0dhY3Nd4OPoaTMParq9qm4nPxwbVkrF6Gry?= =?iso-8859-1?Q?w/hF0TozOrzde7GZIhurpueIKbfFIjMBkgplJ99Y9TpObLJqVOF2wZ45RJ?= =?iso-8859-1?Q?LnxR5lOwknBDUjNkmDhNPQP5kqOboFloY7bN3ie5esmmrqZuWhOgCG6B61?= =?iso-8859-1?Q?P3a9oWM/gXyIJ3ecHe+HyQ5WRXhdVZfnDbdrF9jWWB170b08IsW8Yz4qZQ?= =?iso-8859-1?Q?ZWnsDHz8RwLoqn2rhVkBDyUg3q8LUtkWDvA/lnMOWgxnN/BtiWvsmIAxFP?= =?iso-8859-1?Q?d7KZ5BishU7z+WuhlUZnYJhQwSbI+NgB4w2uxtMdmYleBXkCyqQVDQMDWR?= =?iso-8859-1?Q?0iCG5DFgW9Ep6ZOw/0H4mXH2fwhVjRnhjPTN7TMkJgHa+fBdX8wIZuiaca?= =?iso-8859-1?Q?a757XBUwCLJtO1bfovZvGaoWWIK6SHQMDcdAvNHdX7GYNjm0uZnaiy3Ham?= =?iso-8859-1?Q?cCQX84wSQhCLQwQ0ksvqCInLXI4JJTpfgReLVi97jgrQATPyXTI8qvn0O9?= =?iso-8859-1?Q?ZYdKCA05HEtpmW6yoWcszNu/YCTCU21PPPyFLrjvun875o40UE3gzn0aaf?= =?iso-8859-1?Q?2HA3Hqfw8xRUBLlt105FGi8JTIbBdnSbkNxU/AdHdE5GvLYCqidhXJ+csd?= =?iso-8859-1?Q?zhPcCDny/dIwWWKpWxDTd4buk77fw+DkliwOnFlmQTG9Fpe+UHz0pi4t/u?= =?iso-8859-1?Q?aJKTBfJvdiCb6m4x8mWzVAwJoxyElXhEM8TQHD4NQwLqP6OWdp5V3NO+T2?= =?iso-8859-1?Q?ih7Z8vk4iymmplFKfcXnLZlJ44LZKMWlHFlu7dGSqgBMNNIJmwTFu2W0l6?= =?iso-8859-1?Q?yMZF3xsGlB3SyEv/0r+nEVHtGiIjS7kDduCzhR5QFbU2nJiaPayFvZZQx0?= =?iso-8859-1?Q?bsZBp3XtGp4JwaIDZx0R+a6RN2K9eqK95LsSL7Q3ASpl09ZDiWNlLfnxnZ?= =?iso-8859-1?Q?kZEX79+Gefjf5h1hV7YM4wFLX9s8Nolzfa?= Content-Type: multipart/alternative; boundary="_000_CH3PR12MB820993373E5ABF5A6279BDF9ABF82CH3PR12MB8209namp_" MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8209.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9a26f41-ec12-4138-c664-08dc84915929 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jun 2024 12:24:58.0747 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9Yf4loDkMowgFNTeDUFvyFHqkd97PR/WM3GQVgTVl9JuXPiaD1y/KUUyvoOwX5uMHzcrsGxeUoOGD/N9+C3uoQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB7867 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_CH3PR12MB820993373E5ABF5A6279BDF9ABF82CH3PR12MB8209namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable BR Rongwei ________________________________ From: Thomas Monjalon Sent: Tuesday, June 4, 2024 20:19 To: rongwei liu Cc: dev@dpdk.org ; Matan Azrad ; Slava Ovsi= ienko ; Ori Kam ; Suanming Mou ; Dariusz Sosnowski Subject: Re: [PATCH v2 4/4] net/mlx5: implement VXLAN last reserved modific= ation External email: Use caution opening links or attachments 27/05/2024 04:47, Rongwei Liu: > --- a/doc/guides/nics/mlx5.rst > +++ b/doc/guides/nics/mlx5.rst > @@ -685,6 +685,11 @@ Limitations > - Second tunnel fields are not supported. > > - Encapsulation levels greater than ``2`` are not supported. > + - Modification of the VXLAN header is supported with below limitations= : > + > + - Only in HW steering (``dv_flow_en=3D2``). > + - Support VNI and rsvd1 modifications for traffic with default VXLAN= /VXLAN-GPE/VXLAN-GBP > + UDP destination port. Don't add at the end of bullet lists without trying to order. It is limitation for a specific protocol, it should go above with other pro= tocols, between "Modification of VXLAN network" and GENEVE limitations. "rsvd1" should be replaced with "last reserved byte". Ok. What do you mean with "default VXLAN/VXLAN-GPE/VXLAN-GBP UDP destination po= rt"? Is it port 4789 for VXLAN and VXLAN-GBP, and port 4790 for VXLAN-GPE? We need to be more specific probably. Will change to the exact number. --_000_CH3PR12MB820993373E5ABF5A6279BDF9ABF82CH3PR12MB8209namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable


BR

Rongwei

 


From: Thomas= Monjalon <thomas@monjalon.net>
Sent: Tuesday, June 4, 2024 20:19
To: rongwei liu <rongweil@nvidia.com>
Cc: dev@dpdk.org <dev@dpdk.org>; Matan Azrad <matan@nv= idia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Ori Kam <o= rika@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>; Dariusz Sos= nowski <dsosnowski@nvidia.com>
Subject: Re: [PATCH v2 4/4] net/mlx5: implement VXLAN last rese= rved modification
 
External email: Us= e caution opening links or attachments


27/05/2024 04:47, Rongwei Liu:
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
> @@ -685,6 +685,11 @@ Limitations
>      - Second tunnel fields are not supported= .
>
>    - Encapsulation levels greater than ``2`` are not su= pported.
> +  - Modification of the VXLAN header is supported with below lim= itations:
> +
> +    - Only in HW steering (``dv_flow_en=3D2``).
> +    - Support VNI and rsvd1 modifications for traffic = with default VXLAN/VXLAN-GPE/VXLAN-GBP
> +      UDP destination port.

Don't add at the end of bullet lists without trying to order.
It is limitation for a specific protocol, it should go above with other pro= tocols,
between "Modification of VXLAN network" and GENEVE limitations.
"rsvd1" should be replaced with "last reserved byte".
Ok.

What do you mean with "default VXLAN/VXLAN-GPE/VXLAN-GBP UDP destinati= on port"?
Is it port 4789 for VXLAN and VXLAN-GBP, and port 4790 for VXLAN-GPE?
We need to be more specific probably.

Will change to the exact number.



--_000_CH3PR12MB820993373E5ABF5A6279BDF9ABF82CH3PR12MB8209namp_--