From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06E5944153; Tue, 4 Jun 2024 14:06:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E85D0402EB; Tue, 4 Jun 2024 14:06:11 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2042.outbound.protection.outlook.com [40.107.93.42]) by mails.dpdk.org (Postfix) with ESMTP id 3D01F402CD for ; Tue, 4 Jun 2024 14:06:10 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LtIabeyaLEFYIa9aUZ0B7+E7BS5PFP8GgBxUdK5TWlCvsjJK2aNYekvTxKSeJJ5B2ykM0k0wXJ+TRVtiuRLWcWsE1KNn61IhvdnHYirNlMkoBgMNR38X1yzqzajTBqM8yDClJKH1Hj7xtQSXXR5HCuTyENwOQlQDEiRTBbcttWDAYq/lenRLqYZtNJ6DlPKRB6WND9MK1ISxysjYHcGJJZCdjDXX+e6sUG1KHnQBGhbSgzCpX2lejacXnxxSWcEZmd0S4VjhNkq4VXxvsEPcFWElXjP/MswIdUeD3QfYph+SczMLMNMNTqcAJrJeDM8BpION5IRFDSMkfLekaEvrvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1WYdN11Vd+T6LHzK5CqyTJRpgENKOuje/LI7/uKmNEo=; b=VHs1nBXIPleuA76S8TuwIKt/P/gp50U/VQ1Y5w/PjRieVIiZo27awpLx9YCHDikfyEXxY5esatI9ACjYiZrZptYDBuDh87YzZm/ISGeQAq7E0jC8NY8vfWa+vekqowYbC2zaz38Tyl3rXn5YcyaTctgvz2AP9DcoCS1fx+73rjVZR5KU2QyZjvQw1o3KshmWo9NolBROFE+6COX3rh0EW6ixpSdDyakNDsYW+CBUJylgx/H10DlvVCMkUIHlJCDkjn0K55ArNS4v4eZ59M83hb5eZHhYDhji3w6bdFHG/l9sYXpc5PrFeqpWfGn94XxxRkT/rNSPfrNldzQWKpIYPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1WYdN11Vd+T6LHzK5CqyTJRpgENKOuje/LI7/uKmNEo=; b=E1qp3XWfwIOjqvoTtXJeVmHPPYWKdRkUL6j9HHaB2+xgeIfIBrL7MZ29Ad8F2PrFnSDV+McR9H+rHw6Vofev/nmcZcenP74I0deFqZ/PGvudcJ06IESzG3z6LqjZR6c/Kyi+lZ6Zbv/N2SX2RJLuzG+E5ui3hM1FnRiPpEfA7+GtVcMNyQNeZ4pgNzSTt/bQERjNUDp9WqEWTwWazSTRcwIDerDQyUFyaj7KCZQJZovlko1+PESIrDNSXpY9h17TJ481RCRJVUC5W22tL7vyeiJQaj5tZtnCAfEcfzEz3fosj7oAkuyeWTKe42WeVWChOQMfoqG6f5cx3wZXvLNRLg== Received: from CH3PR12MB8209.namprd12.prod.outlook.com (2603:10b6:610:123::18) by CH2PR12MB4215.namprd12.prod.outlook.com (2603:10b6:610:ab::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.31; Tue, 4 Jun 2024 12:06:07 +0000 Received: from CH3PR12MB8209.namprd12.prod.outlook.com ([fe80::9127:5857:7ba5:a7f2]) by CH3PR12MB8209.namprd12.prod.outlook.com ([fe80::9127:5857:7ba5:a7f2%4]) with mapi id 15.20.7633.021; Tue, 4 Jun 2024 12:06:07 +0000 From: rongwei liu To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" CC: "dev@dpdk.org" , Matan Azrad , Slava Ovsiienko , Ori Kam , Suanming Mou , Dariusz Sosnowski , Ferruh Yigit , Andrew Rybchenko Subject: Re: [PATCH v2 2/4] ethdev: add VXLAN last reserved field Thread-Topic: [PATCH v2 2/4] ethdev: add VXLAN last reserved field Thread-Index: AQHar+BZOHaNKwGs20GsHNJtpRkALrG3jWyAgAABoA0= Date: Tue, 4 Jun 2024 12:06:07 +0000 Message-ID: References: <20240527024720.1099161-1-rongweil@nvidia.com> <20240527024720.1099161-3-rongweil@nvidia.com> <2585221.otXNkdZ6W1@thomas> In-Reply-To: <2585221.otXNkdZ6W1@thomas> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR12MB8209:EE_|CH2PR12MB4215:EE_ x-ms-office365-filtering-correlation-id: beb78754-3299-4ba4-3f90-08dc848eb710 x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|376005|366007|1800799015|38070700009; x-microsoft-antispam-message-info: =?iso-8859-1?Q?2GeGH+sOx5zUUsmBImDDPYm1cnZYHmTH+P4VatEniPiqSEqmYm2gh949l0?= =?iso-8859-1?Q?BUTKTezO2e8WLgBNRfufbLBkFMBlLU5rlHj7nu3yk/pYdoctMfPNtRjmw7?= =?iso-8859-1?Q?e5xOVpehnONkqKHRmj5jIbsnId27i4MPcUwf4AtoITv9fJVFfxn2BTMGwo?= =?iso-8859-1?Q?/GUevXVuf9kR5eEAFwvqG0yI0vXwvr7K2IYjKI5EXlDrJ1IWzcwE7+VQF3?= =?iso-8859-1?Q?y7E8V1ubUT4oc+ep5Svcz9hdw+tXBFyAelZNFxQbfH5COxzmGlxEDBay8h?= =?iso-8859-1?Q?UH2kC3n5JJdtlP8X/KHXCrCkuD5CvXW24CqDuROh+pq6t37sZbEwbtSkmH?= =?iso-8859-1?Q?nkAmRVKnNE712yl5l1/ziC6Kg6LGrNY2+g6YP3+9iPPLMxTmi7MfUFwEzv?= =?iso-8859-1?Q?TQy36Q+H/uAfXD149G/sieMu9zLbHCTa2ADlEZ+SUew/ey43Kfqy0pLnEp?= =?iso-8859-1?Q?hku7ZGbhZpE+nf2r2N70YASkpff+nF8D/tYraRrHZCE3OiGMFusfNa1o9F?= =?iso-8859-1?Q?ATZ1CvwEsqMHllwTKJN5UZLofsu/LhUYRA7WuuZj8SXsG/9wU91j1KzrIj?= =?iso-8859-1?Q?xqECK84J65ay+V0iGIRm73/m3ADUahmSvCjW4ZTmVL5yk8ilPJamaXs/eV?= =?iso-8859-1?Q?cRmcKbURXcOOPJjcZ35kTKauAikS8ajWNvYIQufkS+MrzyFFIc6vgVEG0b?= =?iso-8859-1?Q?OogDPs6Mya/nE+P2DMqLf+FBPL7i67+g0UwviFJcz8/XXlbCsj09aRNsFB?= =?iso-8859-1?Q?gWq87+9byvLApJtahrIPgOvOoNy4ZDlH+l8CKfiYuiaJUkCpVf1wwIs+4w?= =?iso-8859-1?Q?DQS3osuMc831B1O2POBas9Xpqdj9kJA9LPfefgmhIB6wLotqfEPcZ0yyIQ?= =?iso-8859-1?Q?IcWcqgPkyVXV+4RELdpA9mUTdvNMY8uby3p6JrStPJSyp56oiVVpcVr6d7?= =?iso-8859-1?Q?6s4xtoshW8qRXk12zT/3g56FSoFNNBUaHXoe75LgjfrOdbhd1wESgdfU8s?= =?iso-8859-1?Q?xhzgsj4/Bcbs90L3Q+ssb6tLqFsm1Fp+R2IffvWFMy/TgT/gsi/AApjI7n?= =?iso-8859-1?Q?01PguJIpUJi8Scu3p0RcGcoAwobpF17vs5arlHtpbB9Ew5VvwAPgLqfwNk?= =?iso-8859-1?Q?VWpTuNGlk+oOwWb5mY9kaey+xvtkQ74d3QkSHT8P6kgh3xWpBLnTfhpnQh?= =?iso-8859-1?Q?xO6NeqmNrGrVlcUuODW6ny7jc6a50aBZnTHrbfRpHipthUnK2HjXDbGika?= =?iso-8859-1?Q?a5t+pGmqFmkwETVPpOPm0vNkJ59IUwKwDJcPzKV4yEkhsYW0qg/eYOQXxF?= =?iso-8859-1?Q?C3j+yOdZjx5nK1KP4yNojmJOzkOFFin77NQkhTbrXMx8NPqAPIyiDkK/rM?= =?iso-8859-1?Q?SGBreIX0dx3VAn5dPpoLIXgaJywy3aGoVW+ALO0PPUCljHabtP/b8=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB8209.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(366007)(1800799015)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?t+z3nHEI3p7Jr8iy+khrpTkzsf4HxwwO9l2K3MwHO0BuFHJ2yACwCRmYng?= =?iso-8859-1?Q?qCtkuxXfehuf0mOBNpqGJapeZZkOpACDVNxKetINAXLoOxc/CPXibj+kPp?= =?iso-8859-1?Q?ZsRevAefFNyYrVKwKtpyu8R1DsdQEAMz69M4hqNBR5+YiLZ7lviypg0Wxv?= =?iso-8859-1?Q?9TeOBDwJQWTVsqbDApA5nlkJ5X6aMLZS+817UpkhCi11y2YPRLDfewf3Zm?= =?iso-8859-1?Q?c5e7Op2WfhgVWWtQizSGj7jEutj44zmmie0A3/TUd63SGXiDiluOPxIZJG?= =?iso-8859-1?Q?FC5vTDfRDY0B8MeLpeZ0B/VK4InR1HWzOzu/fNZL6D7wry4OS+/V08Tj+p?= =?iso-8859-1?Q?Lj/hVPfImc8MovghZc+91bDq/7dab/p+mMLTQOL4Y3LDdx4JMRoRKD4ok1?= =?iso-8859-1?Q?pOiMRfX/YPv5sVRTwOY/7H+nruKCi2D98RsTKhzPB3EN4YXjJ6c3uabMnN?= =?iso-8859-1?Q?iKU7v3wB5vXzuesOSOmAkzgj6XL8LAd6sHhekESZTCSmhLhkHeBwaM1lEW?= =?iso-8859-1?Q?iXwh5W9VewZZs1DPsH9JOKwbJyUbCXfk2OcSxf72KDUfUtlLLE1+9XBf3g?= =?iso-8859-1?Q?UB485cXBKFsdDyXJnygVTW+h0IpQzUm0PWgoJ6RHsuQzNAc7eYjh3z+zWS?= =?iso-8859-1?Q?YjJIZtuEItqR/RFoVHhMoprXpCpjMmPs4J+DbeXrNg+qu96LoRv3wp5ZtE?= =?iso-8859-1?Q?URDlekD7sOx0+FiZQh8bF7b+TWWVPneOevDmigDu9qVz9oFx2IAcpGUAQT?= =?iso-8859-1?Q?+6vpVQ9aaQLsGa8zXiIBZmqS2tq9csZB+oxDGG6Sp03m/syTnYQbakp2ab?= =?iso-8859-1?Q?Ocr/DG1jKNCSJwKeJxcsQxGDVD09AvRotMIgguv/gRB4tNeki62Gd24cnh?= =?iso-8859-1?Q?CMQtctzuX/V9SUDMAULdWUrAcSqB/XglM8ZQRM4kIiaQYtd+kRIUWSxnzu?= =?iso-8859-1?Q?AdmXo5apyG5lEjFW9ORc1tVAuvimtAeYMhJY+MXpQOGD298AzB6BkmfMX/?= =?iso-8859-1?Q?pcKu+PCCSjaD4T6bJbna4HSH/20foNhFnsjL84uwKy3c5y0XEBAfpCGDzS?= =?iso-8859-1?Q?EAhC6wyKtAYDkYshpNa2itSqzvFfT6sWztlc3EDTpbAkJq2VrgF3/wLV7e?= =?iso-8859-1?Q?+EQ2P48YpcybJ0pvfTeOavQfvK2Vi2zAItwh2daZWKRTrdSE4yPGrm5KG/?= =?iso-8859-1?Q?LWA4d9xv2VoyFkb/bSgONSFu5TfW0MVhaOR6aUR2Vc+NM03GsbPDw8DEkA?= =?iso-8859-1?Q?+dzEqHmA89sdbGgLPLQ/nFyobfzXfIM+ZP9AqwQ8u4zsNfFLEHt/HdppCv?= =?iso-8859-1?Q?Rgvk9X91uPY6RsoWyxlYJl9oIpHPsGGxB33L/eSFplsVM9ujRslnj6HLvS?= =?iso-8859-1?Q?QEMJ+EwCD4aU4Jkf/DddbONVzQFQPNdqeCQVqUWQpw50gDlyme6lJ49zES?= =?iso-8859-1?Q?sau2fdPzmEKlqnEj0t8xG3+HZrMGMRFZAOerZsHgirC71DcZ9TxCHWN4R1?= =?iso-8859-1?Q?ysiqlmJEPgt3TCfJu7j/1PXmcvhgdrXy+Gh3vKuUHdj72BMGmeDWvt7ZkP?= =?iso-8859-1?Q?zK0SSbe+6vavZNmihNJUcfgr57uaP1ZtqQHK36KEsO3JKYgU0yMqbjWdnX?= =?iso-8859-1?Q?PU0J7kLUgwT/Gb4XOqmNvudy5vab/5nH1q?= Content-Type: multipart/alternative; boundary="_000_CH3PR12MB8209DD3B97740A88D2B1342BABF82CH3PR12MB8209namp_" MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8209.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: beb78754-3299-4ba4-3f90-08dc848eb710 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jun 2024 12:06:07.1262 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9E6No3spyWdIeJZVQjChQPnx120gOOG7w9GV3sk5PCcvfMAZTdhqUe9SL+D/iGGYRw9jPSsMJhxb5GLTFHjrCA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4215 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_CH3PR12MB8209DD3B97740A88D2B1342BABF82CH3PR12MB8209namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable BR Rongwei ________________________________ From: Thomas Monjalon Sent: Tuesday, June 4, 2024 19:59 To: rongwei liu Cc: dev@dpdk.org ; Matan Azrad ; Slava Ovsi= ienko ; Ori Kam ; Suanming Mou ; Dariusz Sosnowski ; Ferruh Yig= it ; Andrew Rybchenko Subject: Re: [PATCH v2 2/4] ethdev: add VXLAN last reserved field External email: Use caution opening links or attachments 27/05/2024 04:47, Rongwei Liu: > Add VXLAN last reserved byte in rte flow packet field. You should squash addition in testpmd in the same patch. Adding a field in rte_flow.h should be atomic with testpmd update. Sure. Squash into one commit. > @@ -2428,6 +2428,7 @@ enum rte_flow_field_id { > RTE_FLOW_FIELD_ESP_SEQ_NUM, /**< ESP Sequence Number. */ > RTE_FLOW_FIELD_ESP_PROTO, /**< ESP next protocol value. */ > RTE_FLOW_FIELD_RANDOM, /**< Random value. */ > + RTE_FLOW_FIELD_VXLAN_RSVD1, /**< VXLAN reserved1. */ It isn't clear what reserved1 is. You should say it is the last byte of the VXLAN header. ACK. --_000_CH3PR12MB8209DD3B97740A88D2B1342BABF82CH3PR12MB8209namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable


BR

Rongwei

 


From: Thomas= Monjalon <thomas@monjalon.net>
Sent: Tuesday, June 4, 2024 19:59
To: rongwei liu <rongweil@nvidia.com>
Cc: dev@dpdk.org <dev@dpdk.org>; Matan Azrad <matan@nv= idia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Ori Kam <o= rika@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>; Dariusz Sos= nowski <dsosnowski@nvidia.com>; Ferruh Yigit <ferruh.yigit@amd.com= >; Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [PATCH v2 2/4] ethdev: add VXLAN last reserved fie= ld
 
External email: Us= e caution opening links or attachments


27/05/2024 04:47, Rongwei Liu:
> Add VXLAN last reserved byte in rte flow packet field.

You should squash addition in testpmd in the same patch.
Adding a field in rte_flow.h should be atomic with testpmd update.

Sure. Squash into = one commit.

> @@ -2428,6 +2428,7 @@ enum rte_flow_field_id {
>       RTE_FLOW_FIELD_ESP_SEQ_NUM, &= nbsp;   /**< ESP Sequence Number. */
>       RTE_FLOW_FIELD_ESP_PROTO, &nb= sp;     /**< ESP next protocol value. */
>       RTE_FLOW_FIELD_RANDOM,  =         /**< Random value. */
> +     RTE_FLOW_FIELD_VXLAN_RSVD1,   = ;  /**< VXLAN reserved1. */

It isn't clear what reserved1 is.
You should say it is the last byte of the VXLAN header.

ACK.


--_000_CH3PR12MB8209DD3B97740A88D2B1342BABF82CH3PR12MB8209namp_--