From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C171E4415C; Wed, 5 Jun 2024 11:41:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A923F402DC; Wed, 5 Jun 2024 11:41:31 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2081.outbound.protection.outlook.com [40.107.223.81]) by mails.dpdk.org (Postfix) with ESMTP id 8560040289 for ; Wed, 5 Jun 2024 11:41:29 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KbpFtakLouhIhx4DSgbm/Q+NxwrS2bWqtTmqFcN2TZo6wpy6xkfxAXb+Qjv/CIn1xVEtBPUkPBW0Kb7oWeJMZ8QC4eZvL9gSmphQReQqiGvDF2oxij/GexOnfGYq9XKTLNQnufYuH0tTXwyfAxcifR0c9VeYExePXmaN8npJpqT1W0NHMldkQ4luch81rpP1Pjw4YvfSV4LWRVV9aNfCiFQaFmHB/wDfq3/totRXAG3ceYtJXmCJzIF4eNtJDxwwM9HdCiHOPpvqehKU1xjy+ZfI7xIG4Gacn2MUvrnO4U6NysD4NPa5clpCe0IfBfJDWBGNx3LHtLxmYjDtd6N/qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pPosvdLccgN/xgOxu5qiF/AwCX1geztAsYGglBxGjBE=; b=la//xbTICxZtyOMUUC66yG6c3fv29sEW7hJy5nq2MoPtNgRBO7uwZtB/9uPa7NCq6Ti8pr/ylZlJL6IYzcyV7Ua4EsmUGTSD3HbVt312RA6A4DuvJOuv8cbpBRbvKXbeOmcBPCzOih4Cl5gJuWTE5rtOAgr022tBFwQbScPjMX6sazlxoNudA7bQBr962BJtcJozPMfdMaUo9+weD2+onHBmtWB8OQX09lLL4W2YZfeVhxu+vR8cIzLxZ3GqH0G03vc47vz3VL/CwmJsJmcQhU/1wYROet0FqzAXaT78eQJpDFy3tiU0RyUl+lu/EMEw2yww6zy0rFxThai1u33/aw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pPosvdLccgN/xgOxu5qiF/AwCX1geztAsYGglBxGjBE=; b=bPa6oUtCsOzR8LI1JG0L0vaasBPJu1zuW7TvJY6kWO9rsqD4txo8d7biww3YR1q4KBwBneZ+tzmmlJVvmnJ0BMZtHERiANAnxbQWkacCH1Gp1GQa37x+eqTGc86HEwvgbhHFCz/rZdRAY5bsxN/8vEpdl6IsUTgHdO/FiSikomhXNq8Ch/vnRck0ZiSOZt3EAA4PFzGnneSF6W3bkSJGAXXwpeNjEKuiUqbg5pZg+PwZbEA7SCS5JcOhsasP8k9Ldc1ncfhMumM02qAs/1z+yKB4UwrYMK9y9dywcftTIHsSC7B99Zxpbn+ELZxM1P4YVM6v9plvo33ahOn5OZSDKQ== Received: from CH3PR12MB8209.namprd12.prod.outlook.com (2603:10b6:610:123::18) by DM6PR12MB4436.namprd12.prod.outlook.com (2603:10b6:5:2a3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.31; Wed, 5 Jun 2024 09:41:24 +0000 Received: from CH3PR12MB8209.namprd12.prod.outlook.com ([fe80::9127:5857:7ba5:a7f2]) by CH3PR12MB8209.namprd12.prod.outlook.com ([fe80::9127:5857:7ba5:a7f2%4]) with mapi id 15.20.7633.021; Wed, 5 Jun 2024 09:41:24 +0000 From: rongwei liu To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" CC: Dariusz Sosnowski , "dev@dpdk.org" , Matan Azrad , Slava Ovsiienko , Ori Kam , Suanming Mou , Aman Singh , Yuying Zhang , Ferruh Yigit , Andrew Rybchenko Subject: Re: [PATCH v4 2/3] ethdev: add VXLAN last reserved field Thread-Topic: [PATCH v4 2/3] ethdev: add VXLAN last reserved field Thread-Index: AQHatnxK7usmfC8pJUuRgvKy0YbyIbG3s94AgAAWyJmAAARWgIAAIHCAgAButFqAAGS6gIAAEI/7gAAXCQCAAAFaaQ== Date: Wed, 5 Jun 2024 09:41:24 +0000 Message-ID: References: <14937324.O6BkTfRZtg@thomas> <6114865.NeCsiYhmir@thomas> <2286527.o7ts2hSHzF@thomas> In-Reply-To: <2286527.o7ts2hSHzF@thomas> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR12MB8209:EE_|DM6PR12MB4436:EE_ x-ms-office365-filtering-correlation-id: 698c1251-03b7-45e0-7a46-08dc8543aa00 x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|1800799015|376005|366007|38070700009; x-microsoft-antispam-message-info: =?iso-8859-1?Q?pSKuRt6AYMSqKe3loRYx7mPduZhCNUtLfd4SNri/fQL3Xgj4nC5zlAjEPg?= =?iso-8859-1?Q?X9rht1PknsVsJXY6bV2E31zd68V6DbO1cw+gu4TeHkAPDm3LqSA9bdEaOB?= =?iso-8859-1?Q?i1qnHRNXk741BWKHipvtV8lnjffhc5hlwJB043ZPKZj5qoUhISDk0u8/NB?= =?iso-8859-1?Q?K5QtIxsWSSFe03rtmEyBHgP+77CTX6HyCogk4Zqyb6WYbXBvNvcAmm/c2k?= =?iso-8859-1?Q?Xz2mnkKJIU+6nxBFBvPA1GTN8n8PUiEE5+uMFMTx8xep1ZwmDL3TdkCFOf?= =?iso-8859-1?Q?0aHA1dDIXU6EO20u2QfNonoyaO+E4X1+zXBK8/OHWjciM/Zxl7bcw6s6Jz?= =?iso-8859-1?Q?qut65+I3kf4mgDp9K31kh9jBEu5VAmiQj6+hNRETl40ZQPlnkdynNq3RjR?= =?iso-8859-1?Q?YvDnaSmUH/4243GMMJFEuc+KJm1899OusCVwDEK9KJuHR+PihM31d4CXj4?= =?iso-8859-1?Q?iMDZqbEok50HZ2Nv0CsT162r/lRwuQCK3pjww60pvy8lfmkK9W6JX8JfU/?= =?iso-8859-1?Q?u+IdyYFtkRlK+6buYjuSceoI1j1hN1szIM5z3VUwM5JJH2kGanLiRH3/aK?= =?iso-8859-1?Q?M0CKhpIv4L2HCt8aVEvAK8yK0OoM87Gg4TysvQaRFMHwGLQxTxbOAI3VNY?= =?iso-8859-1?Q?MztJdF0lC5TuVbYeB+27e/BTgXBnp7lGkKknmSRr4GlLZlSVF3HDk6QU+R?= =?iso-8859-1?Q?4ocddzOpp9VFmuOdY2cgQoCYYHGr9FMeKqIwib9sirBrIv1o8F3RB+GhXU?= =?iso-8859-1?Q?0vMpRJG2lPZvqDNPGwjep5pI0M/cgdVwvIZc96IJsoDoH9dyb1+qp3YFYV?= =?iso-8859-1?Q?G2WJMT+4hwR3Wj5uCemMoWSSiB/alj5waAhJO7lt+XrVoa6sB/J9/BOqwG?= =?iso-8859-1?Q?5dVrP9CMggxtkxDKhdisOoSpRO5zz6Ng+Scd57aXHJwODZ0mdcQ4Q4BRC0?= =?iso-8859-1?Q?v4CGuI5UTAW+eh4UzcLX4uwLW7dT9h7NZpFmFhGv6ZPxaARjR3aHNM6jlX?= =?iso-8859-1?Q?LwWl+3IxcuCY6yIbfiNlslgDNyUZVNVZNObFUP5qDZ09aJZnv3ujkNpsZB?= =?iso-8859-1?Q?Hf2wPFIijlGU7tq6nq35SheSVc1aOXA13GDqifE4h6ECA7XuW7MKS2gWRX?= =?iso-8859-1?Q?aMbRm6/GTVTFIyHJwZ3cYwGc3E5bavLqdDaN/5Uoth9RTdPYV5UmWRfLWt?= =?iso-8859-1?Q?Cs1WPU8e5C80ZJYZMP/7tm3VJKQjbAY6sI9hQgc4f0/OTLP4BWi3chJ3sw?= =?iso-8859-1?Q?EJW6FbILAOPh/TQcGntHPNf2ZU6vJtK9ewkcPQUyd+X05cTE6oSg3rwdLh?= =?iso-8859-1?Q?LjF0+UDfAkq+XwPI5edjbnBOIy5lgDt6qq36YS0TzO9ngrMMpJ+sz2sScg?= =?iso-8859-1?Q?z53K9td5ho29npwpn9W1PYbYQaP0VnOA=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB8209.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005)(366007)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?4RrqNHiY5YmJCt3mZDUWAh05OOpBBgnUS5hjPF0gNgFTeVorTYFBGGUEwr?= =?iso-8859-1?Q?LBiJj5PAshfR+wl5FEHjAkugs8WkA4kOPKryKW40YR5GN4Mc7Q/IwTresz?= =?iso-8859-1?Q?RzF6Mu7ie2gyhqHDuOZSBfZDQeChLhHxAEUSmK7DqHOs+qRoUAk/6Rn2DT?= =?iso-8859-1?Q?pwFp/WrdU8wgbwavQhZSF6yvaWl/pZzKrxkEoH/yd0TGC1zXakf3Fe3nlN?= =?iso-8859-1?Q?CVYdnWJP3DdFRsa3n9kIT3N82clZeiSgrTtBxZ0xT+uqs9oyy68a7yYwNG?= =?iso-8859-1?Q?HQpIlBbetghH94FKRyPOE57e1PYxIoXTgkdRinSjUBRMk6f7HwClEd9jpJ?= =?iso-8859-1?Q?k0bMFEOcjRlHUWripD7tzOrU3oGQ6NOR/DgMUw5dAvH4hdr8k9O9cvdkJ8?= =?iso-8859-1?Q?An6XWaEg5y27BpfK6y7QrUFhzAQu3EjJlxQHA9/6ISJiljqSf44Cqy0le0?= =?iso-8859-1?Q?1uzoDiLOZk+vG7ta0ZjTdKyJfBfykZ62iDiIjNogl+jJbSmzH9yGzP3Kak?= =?iso-8859-1?Q?gi/yEpSQDjJKBgktz7BcbNEWkPS5rNuNx3aOfNAIMMeh4smvTIHwlI/D2T?= =?iso-8859-1?Q?WeEasEpQZwugmqRBmQDvxD/g7WQWJnHWlygrfsYh84CsgF0xMSIRZTPL6Z?= =?iso-8859-1?Q?chkR1IMLmL09AB/f8h4HbQtkVd1z8oY3Fym2dgG4jVAfNxhilAbcqt7wvb?= =?iso-8859-1?Q?oO73WZ3KxE2f7fyOCGxDGjwJJFsmsXha4t9P51E0wwq40ignJHvtexmUU/?= =?iso-8859-1?Q?cVElnq2IiML188Dxcp/pG/U+yWZ2LMQat8vjcJ7tKIVU0fk0VDJKoLGZJs?= =?iso-8859-1?Q?EEUR4mcTOznPhbfi8i0yxO3L8jZWwcxS6u9oDSRwfy79BT9oqw+1e9wXa/?= =?iso-8859-1?Q?Twxy5yIyFTg7YzAWedP4RPADHP1+3hWnXywTPxRLKEeWpK8T0apiWR96W+?= =?iso-8859-1?Q?C9+0rvRYTaMLd1xQVh0gEdpZ4p/l4PSGHXi0CUltxDXEyoKptQyf/IwDJl?= =?iso-8859-1?Q?VXNnaQRbw8k2tR1ujJegK0hUBUecoEzoTBkUOIR7qp/yD8an3jGZLkAduJ?= =?iso-8859-1?Q?HP6wgTtzkzqoHjaJLdf013ChXLnc9gB4r0wynQSFdtpFlw9G9/jo3J8Wgn?= =?iso-8859-1?Q?LleGw4b9A/oeRIIRLxHyYdbabaPItUYarpwOB9N30yJVB1Vx/72zwTXmC2?= =?iso-8859-1?Q?XOZGR09Ngtnws7i1r+mEnIwS10QOrSNJkwn3Uxl3NYrhW+mPSz/vpz37zT?= =?iso-8859-1?Q?CG1purSRE+pGhFd7pQVqWRUPBm58GYqdn6tN+WYjvGXnC6YZQ1sByQTsVd?= =?iso-8859-1?Q?pScl7qGhmgTNPG/cVNVb+S0/4o42WdTNPyHyFmLxZKc4OHTIxSGlGzD6kP?= =?iso-8859-1?Q?rVwldt7a5fNW5arkUS8NAp6fwg4JWmEhM919Nh6Msb+HEO2YENrjWaIL7F?= =?iso-8859-1?Q?niB0I/63RTlbJeiLv5MG6gAtEt61GyNTf9YTy9UTWTzkHHjYKDwM26Oa0B?= =?iso-8859-1?Q?fGYnGF15U9tm18fudHKocSoFbCAUFRdoNJ0Ihop7+FboOkMeTp/vBuLFWF?= =?iso-8859-1?Q?cwO/dIdnpMTKnnoNfVufuEm6ZKDGuyz7ogyjP9BDYdGqMTgF1yDDhDIgaG?= =?iso-8859-1?Q?NL7ra0DnGlPA0=3D?= Content-Type: multipart/alternative; boundary="_000_CH3PR12MB8209E4C31534A18C88DAE88CABF92CH3PR12MB8209namp_" MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8209.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 698c1251-03b7-45e0-7a46-08dc8543aa00 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jun 2024 09:41:24.0982 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FwdhUPW7zUjXMImONnDoW9PUtRe2Ps2/SqVnZHw6IFD2G31bbya19kSa+KrHkv/geoSH3wiBqXrZ6JaFESUIMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4436 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_CH3PR12MB8209E4C31534A18C88DAE88CABF92CH3PR12MB8209namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable BR Rongwei ________________________________ From: Thomas Monjalon Sent: Wednesday, June 5, 2024 17:35 To: rongwei liu Cc: Dariusz Sosnowski ; dev@dpdk.org ;= Matan Azrad ; Slava Ovsiienko ; = Ori Kam ; Suanming Mou ; Aman Singh= ; Yuying Zhang ; Ferruh= Yigit ; Andrew Rybchenko Subject: Re: [PATCH v4 2/3] ethdev: add VXLAN last reserved field External email: Use caution opening links or attachments 05/06/2024 10:14, rongwei liu: > > > > > In this patch, "vxlan_last_rsvd" is used in testpmd, so it matche= s > > > > > existing "last_rsvd" field in VXLAN item. If we choose to use > > > > > "rsvd1", > > > > > we should probably rename all other instances of "last_rsvd" to > > > > > match.> > > > > > > > > > I prefer "vxlan_last_rsvd" for 2 reasons: > > > > - it is more meaningful > > > > - we are adding first, second and third reserved fields to > > > > match > > > > the 3 bytes of rsvd0 (patch to come) > > > > > > Sound clear and reasonable. I would like to propose the alignment bet= ween rte_flow_field_id and rte_vxlan_hdr: > > > 1. > > > > > > RTE_FLOW_FIELD_VXLAN_RSVD1 ---> RTE_FLOW_FIELD_VXLAN_LAST_RSVD > > > > > > 2. > > > > > > "uint8_t rsvd1" ----> "uint8_t last_rsvd" > > > > We don't change rte_vxlan_hdr, because we avoid breaking compatibility. > > How about to add a new union: > > union { > uint8_t rsvd1; > uint8_t last_rsvd; > } > RTE_FLOW_FIELD_VXLAN_LAST_RSVD will perfectly match the rte_vxlan_hdr de= finition. It could be a solution, yes, but I don't see it in your v5. Should I add this change in my serial or expect it in the upcoming new VXLA= N header definitions? --_000_CH3PR12MB8209E4C31534A18C88DAE88CABF92CH3PR12MB8209namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable


BR

Rongwei

 


From: Thomas= Monjalon <thomas@monjalon.net>
Sent: Wednesday, June 5, 2024 17:35
To: rongwei liu <rongweil@nvidia.com>
Cc: Dariusz Sosnowski <dsosnowski@nvidia.com>; dev@dpdk.o= rg <dev@dpdk.org>; Matan Azrad <matan@nvidia.com>; Slava Ovsiie= nko <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; Suanm= ing Mou <suanmingm@nvidia.com>; Aman Singh <aman.deep.singh@intel.= com>; Yuying Zhang <yuying.zhang@intel.com>; Ferruh Yigit <ferruh.yigit= @amd.com>; Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [PATCH v4 2/3] ethdev: add VXLAN last reserved fie= ld
 
External email: Us= e caution opening links or attachments


05/06/2024 10:14, rongwei liu:
> > > > > In this patch, "vxlan_last_rsvd" is used= in testpmd, so it matches
> > > > > existing "last_rsvd" field in VXLAN item= . If we choose to use
> > > > > "rsvd1",
> > > > > we should probably rename all other instances of &= quot;last_rsvd" to
> > > > > match.> >
> > > >
> > > > I prefer "vxlan_last_rsvd" for 2 reasons:
> > > >         - it is= more meaningful
> > > >         - we ar= e adding first, second and third reserved fields to
> > > >         match > > > >         the 3 b= ytes of rsvd0 (patch to come)
> > >
> > > Sound clear and reasonable. I would like to propose the alig= nment between rte_flow_field_id and rte_vxlan_hdr:
> > >   1.
> > >
> > > RTE_FLOW_FIELD_VXLAN_RSVD1  ---> RTE_FLOW_FIELD_VXLA= N_LAST_RSVD
> > >
> > >   2.
> > >
> > > "uint8_t rsvd1"  ---->  "uint8_t= last_rsvd"
> >
> > We don't change rte_vxlan_hdr, because we avoid breaking compatib= ility.
>
> How about to add a new union:
>
> union {
>     uint8_t rsvd1;
>     uint8_t last_rsvd;
> }
>  RTE_FLOW_FIELD_VXLAN_LAST_RSVD will perfectly match the rte_vxla= n_hdr definition.

It could be a solution, yes,
but I don't see it in your v5.

Should I add this change in my serial or expect it in the upcoming new VXLA= N header definitions? 




--_000_CH3PR12MB8209E4C31534A18C88DAE88CABF92CH3PR12MB8209namp_--