From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8CA0244156; Tue, 4 Jun 2024 18:29:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 77BB440A6D; Tue, 4 Jun 2024 18:29:48 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2063.outbound.protection.outlook.com [40.107.236.63]) by mails.dpdk.org (Postfix) with ESMTP id C1E7C4026E for ; Tue, 4 Jun 2024 18:29:46 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Iw8Dwn7YI+v7SMCZ7demCiGGQZApsJkykPjQtvY53o2rYScJ360yPNTSKVZTWBbF1GA9WQmp8CjBdfFQ2ckmA0TrDLOphJClX/2PQJFztt9yKP0Kkv1f/7woCAnkz62KWJYyYX+SSqsN4agZkkzXYB7IncbVBm2qW1ltSi9UFMtxffk4EqDPU6fPg6C/2OMlPn7S+bj17qyjRhaQs+B7eSFsppCHDM6ZRAFRb7/cCBNBMwIxodNJ76BP8d2Zy5C57U+nvVSqbj31wSOW7If4W6BUJJQQRzY6OOr1DEBIKjhTulKu2MPXYL2PgqVH0QrczDg0pP0Y6JMh9UrchU/vFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cr1o5AdCpS7QlQmMuuGEB6IU980l2gvM8OktQpl+z7c=; b=glWvNZozOnhdCCe757onalb0muY8kBfiYmUG72nkiupM2z/P6s2LjDXcmRfV6m81r/dBTmF3I4ytsiNhRbFijHlVxBECBXAyYiy6MmMqJTxXbXwl8bgc8uHw11ji2I2dTeDZZR9JJBQNXEgg0MnwmYmEL2NDkpVIWyDDr+NKpTm1KxjdAxWoZurDWfld29Ulw34qmQl7vjVnou3BuEVOHRUoImkNetqMAA0pIN9gPhVbICZOQHq1hpU2HdCVg2jPF4+5IFANhJ9gVGjXwqP6lWEsNTbqexUTu4Mmujx+zp8Ukx9q1/T77xhdhqzm23AlUpdeK53iAsxEUBEYmhhy1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cr1o5AdCpS7QlQmMuuGEB6IU980l2gvM8OktQpl+z7c=; b=curokBg9nTFf1l8IdCOoUwcQ9+0Wn5J+NOWeumicZO+/aGMt4/yNIi8lD2ED/YLyabcHP+mRHmJ1+chlqSOeshVURQQMaZxxFTgrDZ1qs/ifnyfA8rqGedRFWBK7PI1XG7gpoJf83auULcUy63pGvUBxhN9mZFHqQ1XGLH0BGtJhOAQlv2ZtCmDHai6tnsS9C5gEsjE1Uf4Gphd17hQiCtljkDZFeQY5D1IJ/SCwZFj4cWreehfoIHmvgzy835eKTGqb+6CkF2+KUWadJ+BEaCWwdFNOMOqJXAJvSKIA2s45XuSUqSZtsGCtah7e9RkoU97XaAm3k3NLu/UFPv1sTw== Received: from CH3PR12MB8209.namprd12.prod.outlook.com (2603:10b6:610:123::18) by IA1PR12MB6529.namprd12.prod.outlook.com (2603:10b6:208:3a6::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.30; Tue, 4 Jun 2024 16:29:39 +0000 Received: from CH3PR12MB8209.namprd12.prod.outlook.com ([fe80::9127:5857:7ba5:a7f2]) by CH3PR12MB8209.namprd12.prod.outlook.com ([fe80::9127:5857:7ba5:a7f2%4]) with mapi id 15.20.7633.021; Tue, 4 Jun 2024 16:29:39 +0000 From: rongwei liu To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" CC: "dev@dpdk.org" , Matan Azrad , Slava Ovsiienko , Ori Kam , Suanming Mou , Dariusz Sosnowski , Aman Singh , Yuying Zhang , Ferruh Yigit , Andrew Rybchenko Subject: Re: [PATCH v4 2/3] ethdev: add VXLAN last reserved field Thread-Topic: [PATCH v4 2/3] ethdev: add VXLAN last reserved field Thread-Index: AQHatnxK7usmfC8pJUuRgvKy0YbyIbG3s94AgAAWyJk= Date: Tue, 4 Jun 2024 16:29:39 +0000 Message-ID: References: <14937324.O6BkTfRZtg@thomas> <20240604123840.432044-1-rongweil@nvidia.com> <20240604123840.432044-3-rongweil@nvidia.com> <6180616.2l3rmUXbR5@thomas> In-Reply-To: <6180616.2l3rmUXbR5@thomas> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR12MB8209:EE_|IA1PR12MB6529:EE_ x-ms-office365-filtering-correlation-id: b4af1f9c-fdcf-463c-22ea-08dc84b38808 x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|376005|1800799015|366007|38070700009; x-microsoft-antispam-message-info: =?iso-8859-1?Q?F4cbkcymup7sVJqLlhmLAc6QEzBv4YwfN0iFKAWzkAq3LX4JqBsFQO2Kdo?= =?iso-8859-1?Q?1WptwcKqgt5PKDj9+z1h7a6W0ZI+kcgq2b5/ttCuy72E7Jj7YaiWdQ1PMu?= =?iso-8859-1?Q?arUTpIKZbBjI81YHtpr/Gq9BOBvufbKkr82knJi5srfFQ+WB9bPl2FkiWa?= =?iso-8859-1?Q?1z7zVCJ872AtKcMUN/lGdPG+q2+E2+XhChu+MnkYn49SzLOUYRUmV6Y4D9?= =?iso-8859-1?Q?DEH8nkIvIR+v1z4xVpwWEUA3sdYxnK2SJ5zF6ayZ2/AgW1NF8VFrRYwxMC?= =?iso-8859-1?Q?L4whItOlu4jlWU+yar07uQAoUtaFdGR+YCvCCDEvKQSorhQvP56cf+QjeH?= =?iso-8859-1?Q?yV8wsRvlykt8tOiUQzL8+f4cgvcQuChLokR1/a6JjC0NaA1R2dFBz20YTh?= =?iso-8859-1?Q?8//UzsNVZF9kS5DC5PsrZeJOzE1KmFe7qmgSVdoZvMt4TjXp2LfpNcAm6w?= =?iso-8859-1?Q?++/T4+MAw7NoWmISEU/rvWmBcDI/S12f8xj/NPjpEg5bXKyeOnmg0JTXV3?= =?iso-8859-1?Q?Rj/b4tDxLdkmc7tSawvee8CukfBpJXV+EBu+IUVTvu6/wLLhUXbDDhwB1N?= =?iso-8859-1?Q?3P33jY0C2J1Qy6beYn+UDwYbGgqZxGuiqyc16NaRruOmiyWj8ZwUCvAGdA?= =?iso-8859-1?Q?nzYYk1c/tb36/44D7Yn6SpcFi/ISluWMT4zfA8fjs+0U0rd/iuujh7ltkZ?= =?iso-8859-1?Q?IwlIgPXVGV2PWE9bFSWOgRb7xMHqS5rjoS7tN6pcW8tocMUn8vaF8mdmmV?= =?iso-8859-1?Q?7zg85oncsNyuWTb9p/SS1SeeFwMClizor2YifurwvkPgCDIYtp9fvar64W?= =?iso-8859-1?Q?LXGuIFVWvXv1SQ96ph7H0QMEL63xobOcpplj4h5gnrQMvYgFOhw1C2FEse?= =?iso-8859-1?Q?IH7TQB5CyFnKG1rglItW8oW9u6jhzopqfzQFC0FBx21zuuu9qBLNM2pkhZ?= =?iso-8859-1?Q?j9vOO+dbICt6EEb3GqyR7AhMEpTpN+o2j1pwRyj6Sn1exAvso09vKdV00+?= =?iso-8859-1?Q?Ec1VckG2Eg7ezTjbMXqQfVsVy4fDrgmB2C25awKHU3JbZExyfQvYcQqEk8?= =?iso-8859-1?Q?tGy96aeG1TVIueV4+5avoMlXEEKjf9V+yZNW4pP2q8s2AqGJSWSiNkFslH?= =?iso-8859-1?Q?8h/htFEmWiUJnL3pjpkNdrtCmbWQ4jKuBxeNkA+ZpImDdPRmev8JSV3+nU?= =?iso-8859-1?Q?9tvui7AAi0TNT4goREOd2nuyzk0Onj/4lnF1deITWgVkbTCOuZ91/qVKE/?= =?iso-8859-1?Q?K+HU6EBim/QzkLlW4058rIwB3wmK988yAcSD+UrmgPuoeflxGxD64pIw4u?= =?iso-8859-1?Q?bA/VTP9KQSgBuPMs9UX0xsYa3bDBJf2W6kN/e259qzkEDmJw+3xApvcgBN?= =?iso-8859-1?Q?uM1k69K6cyDAtDOw3WugkM6j03B6rnpw=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB8209.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015)(366007)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?sQmL+nH6X3vhAWfkENGHAHcBa1HQkV1nwCS4CBGUJhxhASv2D3RpQuxpsa?= =?iso-8859-1?Q?9TiWd4CMpFFIdrXGlGDAjDf3Otslehyg3WD2GA1IuMXvKQ1bp0nbCx+o2g?= =?iso-8859-1?Q?kn+I/2DOVyaMI0+qkpqwfza4KpDkwGLn1Yxe0rrX0JJ05EWWPfsijWbOHD?= =?iso-8859-1?Q?ptHr8lvtmkqU3d/fAPa7ABMech0tt/Lr9A6T+CJeLLqX9p3Vrbm/jywEHD?= =?iso-8859-1?Q?3vvXb5nbs649rQg+IMR2EfJClaNCJEIBT83ENUbzpcxqJvzbFET+83kOte?= =?iso-8859-1?Q?4v2fyUYjyINpOMUMHJTCUDHibGmGaKJOHq8L15bosD4R7fL5dvx3O7WdY8?= =?iso-8859-1?Q?u2R1HE8i6yM6aRR8Lyk3zayEU++2ZImywfURatFrLXyV2+Qoy+uDdmf1Qk?= =?iso-8859-1?Q?As3zIJp+ov4lIUdxTp+cHZIWw1rz2uIJARtpEqHIMHH0e4099KDgOeaBnn?= =?iso-8859-1?Q?wvMIhtHm0LSEQ982mk0tD6Vz8VgaQgnnpIwC+lrEY/msSARbj1l1M+n3LE?= =?iso-8859-1?Q?dUPiTVkCjI/upw2+ftOFk/pgRhPa15yHXY81a+PkG0j3G/u4CG25eog59J?= =?iso-8859-1?Q?mSSgN7hYYiNwGEJ/DwRer5Pq4/iv2jPkz/BPjYzG/5dvwRyConoJs6Keb5?= =?iso-8859-1?Q?vCqZfL6vskmWidJ+Lhee/ShzEViQE5Hr4KWegliRxZJWQ4oDetsttICD03?= =?iso-8859-1?Q?wVzZDujJkT0HP0TwYnqqVwaDXcanoFW1Q5T3BG7efc0il7H5RfdoiUylKA?= =?iso-8859-1?Q?3JtqRphDmkrs5pC5CBPXFBne5gdkbuWoZgg/O9JllgAV4N+3ho7YaOQWFs?= =?iso-8859-1?Q?7elmgvhXK/ggpIHEChE03H57JB9QXngAmuQlLTTw1SvkIf48vnZ2q3teiS?= =?iso-8859-1?Q?lh+TOVh3cq+uT4z/5qODNO2fGF0yMVk6p8Gnnw2OGdtYlpVZQDRpX4JDRL?= =?iso-8859-1?Q?n1ax7BsjYRVAen0Ml9NxRUxHNlLVp4kWAniwxSkB7XWpzMu5EMhSeNelRQ?= =?iso-8859-1?Q?U5wpGNzF626lqwtv6Zu6pEanKp9qJg18w2EzUMvSaBwTnRYqckBMsBuOFI?= =?iso-8859-1?Q?rpuuG0l9Gt246ujDAO6faq41H//WL6Idq+RNjrTZaDBuWBKC+TtEOQn7Nz?= =?iso-8859-1?Q?oxjIwbFeF0ovUaqY6TR99BGVOtPLUHi9n15nJi/eydT+Ub0lNV21GLxtqL?= =?iso-8859-1?Q?9IyDgeaeu+9/oq7zCXrsUKTcSWsKM+zFRYFegrgeN1Y1oXQHo/+hnpy8sU?= =?iso-8859-1?Q?vj9ZKoeeBeapTniWSl8YI9JgvmD2/9psyByFmijajYhuuRx9QUH0ICK7ji?= =?iso-8859-1?Q?8kxSNL+JaAEfPBMT9we3a45joqh3u9n4vMcFG+O0bgiOsSdBHAqfsl8Vug?= =?iso-8859-1?Q?ZPP6I3IX44DDHG7d5/zAJNFeSQURQqoqQ1u84jAxxeVHUpaPwjRqzk1H34?= =?iso-8859-1?Q?jiEzoNrCXKz4BKX6BGgNe8cmj2b5Ea9WEWWk9Xd4z0OJi9hispRw9ObioY?= =?iso-8859-1?Q?UFbxt3LkGJcBmer5h7M9Es5romPu394YJtmASkkeeXqsW6ntNu/LygR4j5?= =?iso-8859-1?Q?9GSgIYg6JSkJ4gdLjWRzP3j7rj1OqtGmDFSvLdDMz5FJ3A+hXtCH6GGvyX?= =?iso-8859-1?Q?LMv9XHStKKGC1bC/sf3/zgK94S/FJqFhxa?= Content-Type: multipart/alternative; boundary="_000_CH3PR12MB8209FC4C9706B0CBAD894C8DABF82CH3PR12MB8209namp_" MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8209.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4af1f9c-fdcf-463c-22ea-08dc84b38808 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jun 2024 16:29:39.5391 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IDrZPERELoFo9vg9M8ACfhcPay7liCWjLaAGOAb2sw7ZFow2G6YUNXy0gocVz0JIBC7gil4+/+2e+gfKDRyQNg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6529 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_CH3PR12MB8209FC4C9706B0CBAD894C8DABF82CH3PR12MB8209namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable BR Rongwei ________________________________ From: Thomas Monjalon Sent: Tuesday, June 4, 2024 23:03 To: rongwei liu Cc: dev@dpdk.org ; Matan Azrad ; Slava Ovsi= ienko ; Ori Kam ; Suanming Mou ; Dariusz Sosnowski ; Aman Singh= ; Yuying Zhang ; Ferruh= Yigit ; Andrew Rybchenko Subject: Re: [PATCH v4 2/3] ethdev: add VXLAN last reserved field External email: Use caution opening links or attachments 04/06/2024 14:38, Rongwei Liu: > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -1006,6 +1006,7 @@ static const char *const flow_field_ids[] =3D { > "ipv6_flow_label", "ipv6_traffic_class", > "esp_spi", "esp_seq_num", "esp_proto", > "random", > + "vxlan_last_rsvd", > NULL > }; How vxlan_last_rsvd is linked to RTE_FLOW_FIELD_VXLAN_RSVD1 in testpmd? Just because it is the same order? Consider the on-the-way VxLAN extension changes, the last reserved byte was= naming as "uint8_t rsvd1". > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > @@ -2428,6 +2428,7 @@ enum rte_flow_field_id { > RTE_FLOW_FIELD_ESP_SEQ_NUM, /**< ESP Sequence Number. */ > RTE_FLOW_FIELD_ESP_PROTO, /**< ESP next protocol value. */ > RTE_FLOW_FIELD_RANDOM, /**< Random value. */ > + RTE_FLOW_FIELD_VXLAN_RSVD1, /**< VXLAN last reserved byte. */ > }; I think we should use the same naming as in testpmd. What about RTE_FLOW_FIELD_VXLAN_LAST_RSVD? To be honest, no strong objection per my personal thought. Considering the= API "vxlan_hdr" names this field as "uint8_t rsvd1", maybe RTE_FLOW_FIELD_= VXLAN_RSVD1 will be clearer for user as 1 vs 1 mapping? --_000_CH3PR12MB8209FC4C9706B0CBAD894C8DABF82CH3PR12MB8209namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable


BR

Rongwei

 


From: Thomas= Monjalon <thomas@monjalon.net>
Sent: Tuesday, June 4, 2024 23:03
To: rongwei liu <rongweil@nvidia.com>
Cc: dev@dpdk.org <dev@dpdk.org>; Matan Azrad <matan@nv= idia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Ori Kam <o= rika@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>; Dariusz Sos= nowski <dsosnowski@nvidia.com>; Aman Singh <aman.deep.singh@intel.= com>; Yuying Zhang <yuying.zhang@intel.com>; Ferruh Yigit <ferruh.yigit= @amd.com>; Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [PATCH v4 2/3] ethdev: add VXLAN last reserved fie= ld
 
External email: Us= e caution opening links or attachments


04/06/2024 14:38, Rongwei Liu:
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -1006,6 +1006,7 @@ static const char *const flow_field_ids[] =3D {<= br> >       "ipv6_flow_label", "= ;ipv6_traffic_class",
>       "esp_spi", "esp_seq= _num", "esp_proto",
>       "random",
> +     "vxlan_last_rsvd",
>       NULL
>  };

How vxlan_last_rsvd is linked to RTE_FLOW_FIELD_VXLAN_RSVD1 in testpmd?
Just because it is the same order?

Consider the on-the-way VxLAN extension changes, the last reserved byte was= naming as "uint8_t rsvd1".

> --- a/lib/ethdev/rte_flow.h
> +++ b/lib/ethdev/rte_flow.h
> @@ -2428,6 +2428,7 @@ enum rte_flow_field_id {
>       RTE_FLOW_FIELD_ESP_SEQ_NUM, &= nbsp;   /**< ESP Sequence Number. */
>       RTE_FLOW_FIELD_ESP_PROTO, &nb= sp;     /**< ESP next protocol value. */
>       RTE_FLOW_FIELD_RANDOM,  =         /**< Random value. */
> +     RTE_FLOW_FIELD_VXLAN_RSVD1,   = ;  /**< VXLAN last reserved byte. */
>  };

I think we should use the same naming as in testpmd.
What about RTE_FLOW_FIELD_VXLAN_LAST_RSVD?

To be honest, no s= trong objection per my personal thought.  Considering the API "vx= lan_hdr" names this field as "uint8_t rsvd1", maybe RTE_FLOW_FIELD_VXLAN_RSVD1 will be clearer for user as 1 vs 1 mapping?


--_000_CH3PR12MB8209FC4C9706B0CBAD894C8DABF82CH3PR12MB8209namp_--