[AMD Official Use Only - AMD Internal Distribution Only]
Hi Stephen,
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Wednesday, July 24, 2024 8:10 PM
> To: Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com>
> Cc: david.hunt@intel.com; anatoly.burakov@intel.com;
> thomas@monjalon.net; Yigit, Ferruh <Ferruh.Yigit@amd.com>;
> david.marchand@redhat.com; dev@dpdk.org
> Subject: Re: [RFC PATCH 1/2] power: fix power library with --lcores
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> On Wed, 24 Jul 2024 13:03:35 +0000
> Sivaprasad Tummala <sivaprasad.tummala@amd.com> wrote:
>
> > + lcore_cpus = rte_lcore_cpuset(lcore_id);
> > + if (CPU_COUNT(&lcore_cpus) != 1) {
> > + POWER_LOG(ERR, "Power library doesn't support lcore %u mapping
> "
> > + "to %u cpus", lcore_id, CPU_COUNT(&lcore_cpus));
> > + return -1;
> > + }
> > + for (cpu = 0; cpu < CPU_SETSIZE; cpu++) {
> > + if (CPU_ISSET(cpu, &lcore_cpus))
> > + break;
> > + }
>
> You are copy and pasting the same code into multiple places which indicates it
> should be an API function.
ACK! Will fix this in next version.