From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7FC8A4586C; Mon, 26 Aug 2024 15:43:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1C3B440612; Mon, 26 Aug 2024 15:43:12 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2079.outbound.protection.outlook.com [40.107.92.79]) by mails.dpdk.org (Postfix) with ESMTP id CDA3F4060C for ; Mon, 26 Aug 2024 15:43:09 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aGU7F2i+Sz3xeFIkF6Zo/PxlvOvHBo4xg0hj6WTkBbErdKXmAbxwkYONmIOO4OzmXeiLguZ8SxiSRP5OtipwM/qn/U8kKEi1JtO0qNX0fAUmpSFEdO/sFmK9ijL6vOA9eGs7cVLldBh88oOEepJ1KAuWTn4DyV7vAyu6mDDrQf/j/kgmk9moN4PAIplyVSoNyfAYPwlSvgPbyop2xYNZMg4JsxEnVSKFw0oDrDPAmW88Nn9VDTQ9K44rQn9kkwr87Wiy8rfm9/k0dM6UoMhUvfJinf75T6YdBuqHaMNMpEORSVUHwGOigOm0RLjS4ID3wPg2fDiaml6xNHMB6/CZlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M4Fej8DAzPa2UHE4VfGcVlgK9zONgqCyVrFyack6xx4=; b=kZTfV8U1NMnVevHT5QA5hYpsoccZh5ECYfS58+39mzAQ6GCzUdIUe9YBZlzhyCMjhBKWtPVb5zUgjUSIddXeu9eSOVOSkE8kityALuRSp2nvc0Kstf5Qi8qZnq73011qYP8pSjgzXOko3mZs1Zob7aZH/fgS05nz/lzS9rPSTuzkAGebbI7qom4KGDyl/Jtd7kbQMR6hRC7GHnOP2B6DyEhetvoQ/fYvkET8lny9pEXGrztH5SIRQyqQgv/DMVHsQgst66xRzqagt9f8n6mmKXIvcYYu8rM84pZ93IypQL2dEnLkdQR7AXzeEfAQPqQ3hxX65og9EV4ZVEfmoXhqcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M4Fej8DAzPa2UHE4VfGcVlgK9zONgqCyVrFyack6xx4=; b=o1X/bdYwS2c1El3onTYFnQH3Myx3ogq35RZqGiEs9GRzI6iAdXVsVLwMLabFXO7PGplupXQnNYKi70xQBPwIiXAVanldPiaMWD3vBtS6AtTnMNexlvHXw/hR6DLXabzgHeJDUPvSEsIEEeBYW/eTn9y+it0vQDkxrskjzgjznvo= Received: from CH3PR12MB8233.namprd12.prod.outlook.com (2603:10b6:610:129::15) by SJ0PR12MB6759.namprd12.prod.outlook.com (2603:10b6:a03:44b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.19; Mon, 26 Aug 2024 13:43:04 +0000 Received: from CH3PR12MB8233.namprd12.prod.outlook.com ([fe80::278f:5cc5:549c:3515]) by CH3PR12MB8233.namprd12.prod.outlook.com ([fe80::278f:5cc5:549c:3515%5]) with mapi id 15.20.7897.021; Mon, 26 Aug 2024 13:43:04 +0000 From: "Tummala, Sivaprasad" To: Stephen Hemminger CC: "david.hunt@intel.com" , "anatoly.burakov@intel.com" , "thomas@monjalon.net" , "Yigit, Ferruh" , "david.marchand@redhat.com" , "dev@dpdk.org" Subject: RE: [RFC PATCH 1/2] power: fix power library with --lcores Thread-Topic: [RFC PATCH 1/2] power: fix power library with --lcores Thread-Index: AQHa3cn3B4Odu9aOGk+SBVIuLJeOHLIF8wMAgDPMySA= Date: Mon, 26 Aug 2024 13:43:04 +0000 Message-ID: References: <20240724130336.1076462-1-sivaprasad.tummala@amd.com> <20240724073932.5395f8aa@hermes.local> In-Reply-To: <20240724073932.5395f8aa@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ActionId=f63c98ba-4dbc-4d6c-b4e2-856036d8e478; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ContentBits=0; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Enabled=true; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Method=Standard; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Name=AMD Internal Distribution Only; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SetDate=2024-08-26T13:41:44Z; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR12MB8233:EE_|SJ0PR12MB6759:EE_ x-ms-office365-filtering-correlation-id: 82128439-8f98-47ff-874c-08dcc5d502ab x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?ZyrzAkZeXU7P12r44qdQX+tdOUcFIep+tSzrz283PFeOPsOxhdiU7Mg2W0/k?= =?us-ascii?Q?NSpCR/ax6Hkk0dQoIcvofgLroR0o/cZuZwrW3k1fhApeaheq9EAs4LZOdOHj?= =?us-ascii?Q?ASgTMpa/83WMnMsaBr6IW7aoDaJZvG7Ybxutj9gzsBME5ILtPKQqRywQUIV8?= =?us-ascii?Q?RgE8263soPmRL/m27BheB01sh7s9rF0g+LMSEsxTQLJxecZve673qJGD2tom?= =?us-ascii?Q?iDBVisVTNmkwfmIVKCAX3LIJtCRooqM1+Pe3FBxomB6OuX7qmFEA653BueKZ?= =?us-ascii?Q?h40OeXXgTJEFCzKUypzDmoLOFz3hm9yxqJgDxHgnz24U/EKNaDVja2qExi9k?= =?us-ascii?Q?FPxuouZEmx2tx3se7azYgckFmNZj90Kl9ceqwUReGwvaCSeWabqA5hG3fFJn?= =?us-ascii?Q?FltO01tqRMo/irOJomLrmdSNx6AlfQbbtx5dqxJLiBlddpzbgStROJ7kT2qZ?= =?us-ascii?Q?N+kkSK308NtlmHrTAgAwjAbWLGfD+dYpfrBlSV5++RoXXBf96wVhamJoe5j7?= =?us-ascii?Q?5wmBVBOHm7D3lrBjhoxKFq6RAOSuUp7uN/092JpSq21KAnAQNAhba0sQRWmA?= =?us-ascii?Q?dom7K1JXR2Vjg63rjOLTTvTjq8L/J8ebcpMZzsQUllekpJ8PD/XS0hltbIJS?= =?us-ascii?Q?9DuiBZmiIUJh41usNoth3zXajKLWb5e3eONdS9A+YdkdoKiHtCvnxMQValXx?= =?us-ascii?Q?kq5WH2N5bOI8I7bBXo1thIu80Li+PF1ELdWsx5vKy3HFNBmnk/0j3mSWj0Ro?= =?us-ascii?Q?nbiGOsVdJ1hK/udLvUjh10uFHdmAffSZG6S7vExrs2oZcbeKif2LIHz7O6e2?= =?us-ascii?Q?22Oky77QOKcqbQkHULaP7FDJ0pjiqrZYpz0UiNXH/ehA8CtOdcBnKBqmGmzG?= =?us-ascii?Q?hh+99VbZao3ukxwtBC7EfYdVIqYPA3ADf5iVQGZHvuCyxBacT4xc5zvcx9op?= =?us-ascii?Q?hNl5eGiRQkfezVC9TiEaKndELCjrZ27iLyc3YDycrBxWY9+x+Gb6mBEeyn1C?= =?us-ascii?Q?aPVatX0aHNUUNJsFup6uPmX8L6Hx01zwS/qbnxeOW7hw8GlOBjW7QNcz21Uk?= =?us-ascii?Q?83jrIlhBJDaAiS7lcCcvhOcbd6Ab8w+bNcqHBPh8Srk6f6KLOHN+YZyWCxCx?= =?us-ascii?Q?U130tkvw/oc3381Iect+nkZbuaNROAcA7p4RAShHJSJdYQ336iVuyGLS2rUe?= =?us-ascii?Q?meut1MjnVWEjyj6ubO2m0rJoc8bkZa2Eai9Q6JHtpFRP1R9x0ltKa6kjj9mb?= =?us-ascii?Q?vjrm04UMZgh7QNbU6uywShqQwnoCZXf8zgT2J6B8sc9b3eX0Sy3mx6WtA7L1?= =?us-ascii?Q?bILPYhD/At1g6Ab97ijNSq5TUGan4yy0KT6lokqKYGpIPgOTYIyVKGy7oAhq?= =?us-ascii?Q?uqy5IYxmJlL3jQB5P+gvSeVlIifrDpaMUHBhARjGPdl6//MeUA=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB8233.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?o0Mbxne57Hh6OzfOoKTi1+G/MMBJQVHMzjMxipvoUghLRySKC87oWMo1p16X?= =?us-ascii?Q?w/dRSqzTaABwIYANXhSaHlGUeqL4pt+T3P3nNsU0gTLXcehYsylnYoK0kYQ1?= =?us-ascii?Q?U93msUMGzpLR6Jj6wGc23wX34V2vrmjh+9wus8oCWRlqDoGrx9n4E+nwesoy?= =?us-ascii?Q?5sFg4tzafeTiGWyy7lruP84pZLnrnN1qNhq2NOr23OiUNzCdeM8y0mC5ShGi?= =?us-ascii?Q?8DFA1uV1sZo+TQj0jbWSh2ugjhVmE5pha2nYOlVZsTzSN/OTYfP1ysWsiaOD?= =?us-ascii?Q?WTq2qA1s+XUO3BDemh6MHkUVGXK5B/NVZHVXXDlAoKKzCNvob4lffspdoCZU?= =?us-ascii?Q?ROLC4SV7J9bG+MKKdheuIhbmcSQpS+mzcDYDhmDP6ALOULEa0waX2YtD4qC0?= =?us-ascii?Q?IV9bo996QrKpe8In1owUnbO5LKg74ryei7AQtoAPn7elsPKUHE6NoqDgWfPi?= =?us-ascii?Q?YNEQs/6gjfrl7yZAidRqXNdey+IXGjxwDjhag9TjxE5eqVupR2MNhHzssHsW?= =?us-ascii?Q?9LqEAKrdLIK4B6r2IZGnm2L+8jyAah1Nx4uETnQfbWxPmT82AEBdwh3mb+pJ?= =?us-ascii?Q?+/NbdU/aQ2WqkDnW9n30aSOU9Fn6AFmMjK6qQ0CgRJhKmjIJnWS0xW0FJyJU?= =?us-ascii?Q?b34EoChRgyDUB1itlJmmqlTqrPZD8rJ/+Mju9cwH6y26XhF1ktsR9UZRZzPh?= =?us-ascii?Q?b6Jok95aYqHpouY/+ddRRp/UE0Q58H+WZfUjpd4yXmoV7CKkrhts/6qHjo+z?= =?us-ascii?Q?fxPNkFsEkc456CnJ8SPLWEmaT2FaqGUslXoMMzQfGCP6bUglvmPD960q4Ok3?= =?us-ascii?Q?11SirthDQU9JxqDKUUJk6iKlgKgG42iu5cSE9Kz+2maYWFPhV0HseOVD9PSG?= =?us-ascii?Q?cWh8bAJJ/dg0XwvgRYtg6bxe4Gj4+XZqp9Z1kIYk1yKFxW21G7X3h8c8WrJl?= =?us-ascii?Q?oo0X+dGivdoslftdbMcOkmEzMF4m0mwJP04B18kC7Zn5h4sj6BRjIilTkyMW?= =?us-ascii?Q?ON5s9sBSz4hwPKIuAnTHJ9NIAa0ky0Oi1VC6D0LuACT0PM8WS2mMsopbsgiR?= =?us-ascii?Q?CRVMhFvGD4MwTz/gZ8cQyw5VxMga1RWMOdJYKEG0sAzhRPXSq6vilf6O8KC1?= =?us-ascii?Q?C37zLKixYbGqOJEO98r3FyTKs/uKTqksnATmm3VfET1UR6x7wNV6pU1K0l+R?= =?us-ascii?Q?k9hOjnXtGMG9AYDwr+YwIiRoCx6/FWB9voDvooIvLgi6aaei3KXlfFzt/XQC?= =?us-ascii?Q?umpuCpPoxmj0eh7ETeTgz2TJa1tZe7CrSCd9jGzzxqYDjcfZBgWjUJ0JzFGI?= =?us-ascii?Q?Ss6r4hQ8oiND56CbNZC2LSZoD8GuuJ094wCVZ2Ll+mn2Qw1eKym1XXr2qbg8?= =?us-ascii?Q?EQW1SEmzHnZSXtjL3wn1jPRf8yZQVDakpam+yIlFdIN5V0TR81ThcRvyGH4M?= =?us-ascii?Q?Da0QykE6pNiSZv35Y+SiSd22SQf6ODqxbNSMlaYJ+Vq0pOGHuwVeDuouXnDP?= =?us-ascii?Q?5bqlo8WEQWj6M3aDTkKSUvQlo2EkHwTqlPRD3X78I0kNSV6pRXI4jd5CHgM7?= =?us-ascii?Q?oJsXCjvvC0fz/AnX4EM=3D?= Content-Type: multipart/alternative; boundary="_000_CH3PR12MB82337A99C9EC093E9F9BA9FA868B2CH3PR12MB8233namp_" MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8233.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82128439-8f98-47ff-874c-08dcc5d502ab X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Aug 2024 13:43:04.2679 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OMREJhtAzCxy/XfrZlmf9bcRaJdRCHHap8YzQENWagSC6by9xwvvrn6VNTrehkpRae0s3sRg7n4vVOnwkH7scg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6759 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_CH3PR12MB82337A99C9EC093E9F9BA9FA868B2CH3PR12MB8233namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - AMD Internal Distribution Only] Hi Stephen, > -----Original Message----- > From: Stephen Hemminger > Sent: Wednesday, July 24, 2024 8:10 PM > To: Tummala, Sivaprasad > Cc: david.hunt@intel.com; anatoly.burakov@intel.com; > thomas@monjalon.net; Yigit, Ferruh ; > david.marchand@redhat.com; dev@dpdk.org > Subject: Re: [RFC PATCH 1/2] power: fix power library with --lcores > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > On Wed, 24 Jul 2024 13:03:35 +0000 > Sivaprasad Tummala > wrote: > > > + lcore_cpus =3D rte_lcore_cpuset(lcore_id); > > + if (CPU_COUNT(&lcore_cpus) !=3D 1) { > > + POWER_LOG(ERR, "Power library doesn't support lcore %u ma= pping > " > > + "to %u cpus", lcore_id, CPU_COUNT(&lcore_= cpus)); > > + return -1; > > + } > > + for (cpu =3D 0; cpu < CPU_SETSIZE; cpu++) { > > + if (CPU_ISSET(cpu, &lcore_cpus)) > > + break; > > + } > > You are copy and pasting the same code into multiple places which indicat= es it > should be an API function. ACK! Will fix this in next version. --_000_CH3PR12MB82337A99C9EC093E9F9BA9FA868B2CH3PR12MB8233namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

[AMD Official Use Only - AMD Internal Distribution Only]


Hi Stephen,

 

> -----Original Message-----

> From: Stephen Hemminger <stephen@networkp= lumber.org>

> Sent: Wednesday, July 24, 2024 8:10 PM

> To: Tummala, Sivaprasad <Sivaprasad.Tumma= la@amd.com>

> Cc: david.hunt@intel.com; anatoly.burakov@in= tel.com;

> thomas@monjalon.net; Yigit, Ferruh <Ferru= h.Yigit@amd.com>;

> david.marchand@redhat.com; dev@dpdk.org

> Subject: Re: [RFC PATCH 1/2] power: fix powe= r library with --lcores

>

> Caution: This message originated from an Ext= ernal Source. Use proper caution

> when opening attachments, clicking links, or= responding.

>

>

> On Wed, 24 Jul 2024 13:03:35 +0000

> Sivaprasad Tummala <sivaprasad.tummala@amd.com> wrote:

>

> > +     lcore_cpus = =3D rte_lcore_cpuset(lcore_id);

> > +     if (CPU_COUNT= (&lcore_cpus) !=3D 1) {

> > +      &n= bsp;      POWER_LOG(ERR, "Power library doesn= 't support lcore %u mapping

> "

> > +      &n= bsp;            = ;          "to %u cpus&qu= ot;, lcore_id, CPU_COUNT(&lcore_cpus));

> > +      &n= bsp;      return -1;

> > +     }

> > +     for (cpu =3D = 0; cpu < CPU_SETSIZE; cpu++) {

> > +      &n= bsp;      if (CPU_ISSET(cpu, &lcore_cpus))

> > +      &n= bsp;            = ;  break;

> > +     }

>

> You are copy and pasting the same code into = multiple places which indicates it

> should be an API function.

ACK! Will fix this in= next version.

--_000_CH3PR12MB82337A99C9EC093E9F9BA9FA868B2CH3PR12MB8233namp_--